)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e850d1e328348e67a779d8f58d82888f5df9a86c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            if router.get(\u0027ha\u0027):"},{"line_number":139,"context_line":"                new_owner \u003d const.DEVICE_OWNER_HA_REPLICATED_INT"},{"line_number":140,"context_line":"            else:"},{"line_number":141,"context_line":"                new_owner \u003d const.DEVICE_OWNER_ROUTER_INTF"},{"line_number":142,"context_line":"            self.l3plugin._migrate_router_ports("},{"line_number":143,"context_line":"                context, router_db,"},{"line_number":144,"context_line":"                old_owner\u003dconst.DEVICE_OWNER_DVR_INTERFACE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_c57d151d","line":141,"updated":"2017-09-06 04:12:28.000000000","message":"It doesn\u0027t look like either of these cases are unit tested.","commit_id":"cf8eb318f056453ee6d2b10385d76f7df0e3aba5"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"7ad89cf1eaef137bb5b4c3e43dc3860da7449f45","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        if migrating_to_distributed:"},{"line_number":127,"context_line":"            self.l3plugin._migrate_router_ports("},{"line_number":128,"context_line":"                context, router_db,"},{"line_number":129,"context_line":"                old_owner\u003dconst.DEVICE_OWNER_HA_REPLICATED_INT,"},{"line_number":130,"context_line":"                new_owner\u003dconst.DEVICE_OWNER_DVR_INTERFACE)"},{"line_number":131,"context_line":"            self.l3plugin._migrate_router_ports("},{"line_number":132,"context_line":"                context, router_db,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_978d6e7d","line":129,"range":{"start_line":129,"start_character":32,"end_line":129,"end_character":62},"updated":"2017-09-20 02:39:18.000000000","message":"Can we distinguish device owner from the \"old_router\", and then migrate router ports in different situation?","commit_id":"9c989e7187e36e2d3fb5cb657140380652c886c2"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b07eb480d391d1f370d6e8be05c9c39696fbb3d6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        if migrating_to_distributed:"},{"line_number":127,"context_line":"            self.l3plugin._migrate_router_ports("},{"line_number":128,"context_line":"                context, router_db,"},{"line_number":129,"context_line":"                old_owner\u003dconst.DEVICE_OWNER_HA_REPLICATED_INT,"},{"line_number":130,"context_line":"                new_owner\u003dconst.DEVICE_OWNER_DVR_INTERFACE)"},{"line_number":131,"context_line":"            self.l3plugin._migrate_router_ports("},{"line_number":132,"context_line":"                context, router_db,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf57530f_4f087e27","line":129,"range":{"start_line":129,"start_character":32,"end_line":129,"end_character":62},"in_reply_to":"bf57530f_978d6e7d","updated":"2017-09-20 04:28:30.000000000","message":"Yes. We can do that. Thanks Dongcan","commit_id":"9c989e7187e36e2d3fb5cb657140380652c886c2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"37f7e3785a2ffd5ed46615dd9e8ffe282464751b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            not router_db.extra_attributes.distributed and"},{"line_number":125,"context_line":"            router.get(\u0027distributed\u0027) is True)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if migrating_to_distributed:"},{"line_number":128,"context_line":"            if old_router[\u0027ha\u0027]:"},{"line_number":129,"context_line":"                old_owner \u003d const.DEVICE_OWNER_HA_REPLICATED_INT"},{"line_number":130,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf57530f_e3b7493a","line":127,"updated":"2017-09-20 08:21:47.000000000","message":"Yes this reduces it to a single call for _migrate_router_ports.\nGood.","commit_id":"0afe2c201a7d114564a0f0aed03ba91ffd776023"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6ba455d613def2aebb3aa37e2f6426e749da5e08","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"            before_ha\u003dTrue, after_dvr\u003dTrue)"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"    def test_device_owner_during_router_migration_from_legacy_to_dvr(self):"},{"line_number":1030,"context_line":"        self._test_device_owner_during_router_migration(after_dvr\u003dTrue)"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"    def test_remove_ha_in_use(self):"},{"line_number":1033,"context_line":"        router \u003d self._create_router(ctx\u003dself.admin_ctx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff5d4b2f_a2d01dcb","line":1030,"updated":"2017-09-19 20:09:24.000000000","message":"I think there\u0027s actually 4 more test cases:\n\n1. DVR to DVR/HA\n2. HA to Legacy\n3. HA to DVR/HA\n4. Legacy to HA\n\nWhen I added those 4 I actually got a failure in the Legacy to HA migration, looks like a missing \u0027else\u0027 block in _reconfigure_ha_resources().  I\u0027ll send an update.","commit_id":"39dde3986ed86126b8f483dae27cae35d7f2d303"}]}
