)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9207e2ad53786c816b77949d94956ee8a3394bd2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"DEVICE_OWNER_HA_REPLICATED_INT) and not for all router ports(for example,"},{"line_number":21,"context_line":"DEVICE_OWNER_ROUTER_SNAT will be automatically deleted by DVR after deleting"},{"line_number":22,"context_line":"DEVICE_OWNER_DVR_INTERFACE). Without this tempest resource_cleanup is"},{"line_number":23,"context_line":"failing sometimes."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: 1714802"},{"line_number":26,"context_line":"Change-Id: I2a933d4cdd6de4e5ff31c8e3f97477819ba27afa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_c6753f9a","line":23,"updated":"2017-09-05 03:20:45.000000000","message":"how changes in ml2 related?","commit_id":"a69ae24928cdf63dce697d0a64c468cb38125c4b"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"7975e79ea68c2030d75635d77446f410f4588b6a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"DEVICE_OWNER_HA_REPLICATED_INT) and not for all router ports(for example,"},{"line_number":21,"context_line":"DEVICE_OWNER_ROUTER_SNAT will be automatically deleted by DVR after deleting"},{"line_number":22,"context_line":"DEVICE_OWNER_DVR_INTERFACE). Without this tempest resource_cleanup is"},{"line_number":23,"context_line":"failing sometimes."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes-Bug: 1714802"},{"line_number":26,"context_line":"Change-Id: I2a933d4cdd6de4e5ff31c8e3f97477819ba27afa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_f2011508","line":23,"in_reply_to":"7f287b81_c6753f9a","updated":"2017-09-05 08:33:47.000000000","message":"Jobs failed as there were some issues related to segments  http://logs.openstack.org/84/500384/1/check/gate-tempest-dsvm-neutron-dvr-multinode-scenario-ubuntu-xenial-nv/9d2769d/logs/screen-q-svc.txt.gz?level\u003dWARNING\n\nSo I tried temporary fixes for them.","commit_id":"a69ae24928cdf63dce697d0a64c468cb38125c4b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4036ebe3556624331041e089deb2f036148ef854","unresolved":false,"context_lines":[{"line_number":13,"context_line":"exist and not yet destroyed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"So in this patch, we check if pre migration router interfaces are deleted,"},{"line_number":16,"context_line":"the new interfaces are created and active before attempeting ssh connectivity."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Also in resource_cleanup, we call remove_router_interface for only router"},{"line_number":19,"context_line":"interface ports(i.e DEVICE_OWNER_ROUTER_INTF, DEVICE_OWNER_DVR_INTERFACE,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f287b81_8ddaa114","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":2},"updated":"2017-09-05 19:01:59.000000000","message":"s/and the\n\nAlso just a nit that some of these lines are \u003e80 chars","commit_id":"58dffd95213fc34d7907c3f484d067fd0863bda2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"693e212b5053e04d5c8766985b05d82923cbf039","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     venkata anil \u003canilvenkata@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-08 11:19:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tempest: check router interface exists before ssh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As explained in the bug, tempest DVR and HA migration scenario"},{"line_number":10,"context_line":"tests are failing intermittently, as we are not checking if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f2577a7_cfbeb4fe","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2017-09-08 23:45:06.000000000","message":"Isn\u0027t this kind of misleading? This patchset does more than fixing tempest tests. It touches the l3 dvr and ha functionality and also adjusts tempest tests. I think that the commit message has to reflect this better","commit_id":"28672db9d3b188ed7d883db9a70bedc3e2f0be49"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"693e212b5053e04d5c8766985b05d82923cbf039","unresolved":false,"context_lines":[{"line_number":18,"context_line":"attempting ssh connectivity."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Also, in resource_cleanup, we call remove_router_interface for"},{"line_number":21,"context_line":"only router interface ports(i.e DEVICE_OWNER_ROUTER_INTF,"},{"line_number":22,"context_line":"DEVICE_OWNER_DVR_INTERFACE, DEVICE_OWNER_HA_REPLICATED_INT) and"},{"line_number":23,"context_line":"not for all router ports(for example, DEVICE_OWNER_ROUTER_SNAT"},{"line_number":24,"context_line":"will be automatically deleted by DVR after deleting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f2577a7_cf1b5471","line":21,"range":{"start_line":21,"start_character":27,"end_line":21,"end_character":28},"updated":"2017-09-08 23:45:06.000000000","message":"Add a space before the (","commit_id":"28672db9d3b188ed7d883db9a70bedc3e2f0be49"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"693e212b5053e04d5c8766985b05d82923cbf039","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Also, in resource_cleanup, we call remove_router_interface for"},{"line_number":21,"context_line":"only router interface ports(i.e DEVICE_OWNER_ROUTER_INTF,"},{"line_number":22,"context_line":"DEVICE_OWNER_DVR_INTERFACE, DEVICE_OWNER_HA_REPLICATED_INT) and"},{"line_number":23,"context_line":"not for all router ports(for example, DEVICE_OWNER_ROUTER_SNAT"},{"line_number":24,"context_line":"will be automatically deleted by DVR after deleting"},{"line_number":25,"context_line":"DEVICE_OWNER_DVR_INTERFACE). Without this, tempest"},{"line_number":26,"context_line":"resource_cleanup is failing sometimes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f2577a7_af180875","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":25},"updated":"2017-09-08 23:45:06.000000000","message":"Ditto","commit_id":"28672db9d3b188ed7d883db9a70bedc3e2f0be49"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1da2e79e367e9fa08a434c1849bb824895645cd3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"destroyed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We need to check that the pre-migration router interfaces are"},{"line_number":17,"context_line":"deleted and the new interfaces are created and active before"},{"line_number":18,"context_line":"attempting ssh connectivity."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"note: I suspect connection tracking in ovs firewall driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_11bbaf0e","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":30},"updated":"2017-10-04 18:16:28.000000000","message":"Shouldn\u0027t it be new interfaces in respective namespaces are created and active before attempting ssh.","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"4c6bd0b4f6776ceb41f8999b14d4e5302c199b5e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"destroyed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We need to check that the pre-migration router interfaces are"},{"line_number":17,"context_line":"deleted and the new interfaces are created and active before"},{"line_number":18,"context_line":"attempting ssh connectivity."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"note: I suspect connection tracking in ovs firewall driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_ff7c4e73","line":17,"range":{"start_line":17,"start_character":15,"end_line":17,"end_character":30},"in_reply_to":"7f515b1d_11bbaf0e","updated":"2017-10-05 05:02:35.000000000","message":"Thanks Swami. But in a multinode setup, we can\u0027t check namespace existence on other nodes. So we check port status, which is set to ACTIVE by L2 agent when it finishes wiring the port.","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0f7118da70e2af6ba67e1c77979da43b7d4f0800","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"note: I suspect connection tracking in ovs firewall driver"},{"line_number":21,"context_line":"(br-int conntrack related flows) dropping packets when router"},{"line_number":22,"context_line":"migrated between DVR and HA. So disabling firewall driver temporarily."},{"line_number":23,"context_line":"Also seen many times ARP not resolved during migration in my"},{"line_number":24,"context_line":"local setup, and enabling arp_resonder reduced failure rate."},{"line_number":25,"context_line":"So temporarily enabled arp_responder."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_0ff2749b","line":22,"range":{"start_line":22,"start_character":29,"end_line":22,"end_character":69},"updated":"2017-10-04 11:31:35.000000000","message":"You can rebase on top of https://review.openstack.org/#/c/509228/","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"6d6efac52f66bb439bf09b9f95c56daa08e95e82","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"note: I suspect connection tracking in ovs firewall driver"},{"line_number":21,"context_line":"(br-int conntrack related flows) dropping packets when router"},{"line_number":22,"context_line":"migrated between DVR and HA. So disabling firewall driver temporarily."},{"line_number":23,"context_line":"Also seen many times ARP not resolved during migration in my"},{"line_number":24,"context_line":"local setup, and enabling arp_resonder reduced failure rate."},{"line_number":25,"context_line":"So temporarily enabled arp_responder."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_0d4cb974","line":22,"range":{"start_line":22,"start_character":29,"end_line":22,"end_character":69},"in_reply_to":"7f515b1d_0ff2749b","updated":"2017-10-04 14:17:42.000000000","message":"Thanks Jakub. Unfortunately this patch already has a dependency on https://review.openstack.org/#/c/507856/. So I am eagerly waiting one of these two patches to get merged ASAP(before I start rebase).","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0f7118da70e2af6ba67e1c77979da43b7d4f0800","unresolved":false,"context_lines":[{"line_number":22,"context_line":"migrated between DVR and HA. So disabling firewall driver temporarily."},{"line_number":23,"context_line":"Also seen many times ARP not resolved during migration in my"},{"line_number":24,"context_line":"local setup, and enabling arp_resonder reduced failure rate."},{"line_number":25,"context_line":"So temporarily enabled arp_responder."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: 1714802"},{"line_number":28,"context_line":"Change-Id: I2a933d4cdd6de4e5ff31c8e3f97477819ba27afa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_6f38c83c","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"updated":"2017-10-04 11:31:35.000000000","message":"shouldn\u0027t we enable it by default? AFAIR we disabled it because we needed newer version of ovs, which we already have.","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"4c6bd0b4f6776ceb41f8999b14d4e5302c199b5e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"migrated between DVR and HA. So disabling firewall driver temporarily."},{"line_number":23,"context_line":"Also seen many times ARP not resolved during migration in my"},{"line_number":24,"context_line":"local setup, and enabling arp_resonder reduced failure rate."},{"line_number":25,"context_line":"So temporarily enabled arp_responder."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: 1714802"},{"line_number":28,"context_line":"Change-Id: I2a933d4cdd6de4e5ff31c8e3f97477819ba27afa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_9fd8ba7f","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"7f515b1d_105f30e6","updated":"2017-10-05 05:02:35.000000000","message":"Thanks Jakub. https://review.openstack.org/#/c/509565/ submitted to enable it.","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"6d6efac52f66bb439bf09b9f95c56daa08e95e82","unresolved":false,"context_lines":[{"line_number":22,"context_line":"migrated between DVR and HA. So disabling firewall driver temporarily."},{"line_number":23,"context_line":"Also seen many times ARP not resolved during migration in my"},{"line_number":24,"context_line":"local setup, and enabling arp_resonder reduced failure rate."},{"line_number":25,"context_line":"So temporarily enabled arp_responder."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: 1714802"},{"line_number":28,"context_line":"Change-Id: I2a933d4cdd6de4e5ff31c8e3f97477819ba27afa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_ed027d09","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"7f515b1d_6f38c83c","updated":"2017-10-04 14:17:42.000000000","message":"No, it is not enabled by default. For example, see no arp_responder flag in http://logs.openstack.org/78/501978/4/check/gate-tempest-dsvm-neutron-dvr-multinode-scenario-ubuntu-xenial-nv/6c1528e/logs/etc/neutron/plugins/ml2/ml2_conf.ini.txt.gz\n(Currently only https://review.openstack.org/#/c/509228/ has zuul blessings :) so I picked up this as example).","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"00078ddced9832337d13cda86e75a2f2debb2385","unresolved":false,"context_lines":[{"line_number":22,"context_line":"migrated between DVR and HA. So disabling firewall driver temporarily."},{"line_number":23,"context_line":"Also seen many times ARP not resolved during migration in my"},{"line_number":24,"context_line":"local setup, and enabling arp_resonder reduced failure rate."},{"line_number":25,"context_line":"So temporarily enabled arp_responder."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: 1714802"},{"line_number":28,"context_line":"Change-Id: I2a933d4cdd6de4e5ff31c8e3f97477819ba27afa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_c51be670","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"7f515b1d_9fd8ba7f","updated":"2017-10-05 19:00:39.000000000","message":"So is it a temporary solution? If so, do we have a bug reported to fix that? Do we really need to support arp_responder\u003dFalse when in dvr mode?","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cbecdceff3e7d6ea1d34b08e3452631ce37bb199","unresolved":false,"context_lines":[{"line_number":22,"context_line":"migrated between DVR and HA. So disabling firewall driver temporarily."},{"line_number":23,"context_line":"Also seen many times ARP not resolved during migration in my"},{"line_number":24,"context_line":"local setup, and enabling arp_resonder reduced failure rate."},{"line_number":25,"context_line":"So temporarily enabled arp_responder."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: 1714802"},{"line_number":28,"context_line":"Change-Id: I2a933d4cdd6de4e5ff31c8e3f97477819ba27afa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7f515b1d_105f30e6","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":14},"in_reply_to":"7f515b1d_ed027d09","updated":"2017-10-04 14:53:08.000000000","message":"I was suggesting to enable it by default or open a discussion as I think we\u0027ve already met dependencies for arp responder.","commit_id":"195fa2d2df402f40cdc2104df02e9e497790721e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"53b2fee0a9df6f1abb26f201f38113a3c1e47687","unresolved":false,"context_lines":[{"line_number":14,"context_line":"destroyed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We need to check that the pre-migration router interfaces are"},{"line_number":17,"context_line":"deleted and the new interfaces are created and active(as we"},{"line_number":18,"context_line":"can\u0027t check namespace existence on other nodes, we rely on port"},{"line_number":19,"context_line":"status set by L2 agent after wiring the port) before"},{"line_number":20,"context_line":"attempting ssh connectivity."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7f515b1d_456ff6c4","line":17,"updated":"2017-10-05 19:06:08.000000000","message":"super-nit: missing space before brace","commit_id":"68c53b7d187208e6ccbf3f69b0f35d7bba4c8796"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5ae3348db870381e75617976ba16e3a213bd1632","unresolved":false,"context_lines":[{"line_number":14,"context_line":"destroyed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We need to check that the pre-migration router interfaces are"},{"line_number":17,"context_line":"deleted and the new interfaces are created and active(as we"},{"line_number":18,"context_line":"can\u0027t check namespace existence on other nodes, we rely on port"},{"line_number":19,"context_line":"status set by L2 agent after wiring the port) before"},{"line_number":20,"context_line":"attempting ssh connectivity."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7f515b1d_3cc76215","line":17,"in_reply_to":"7f515b1d_456ff6c4","updated":"2017-10-06 13:20:50.000000000","message":"sure","commit_id":"68c53b7d187208e6ccbf3f69b0f35d7bba4c8796"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":415,"context_line":"    def delete_router(cls, router):"},{"line_number":416,"context_line":"        body \u003d cls.client.list_router_interfaces(router[\u0027id\u0027])"},{"line_number":417,"context_line":"        interfaces \u003d [port for port in body[\u0027ports\u0027]"},{"line_number":418,"context_line":"                      if port[\u0027device_owner\u0027] in const.ROUTER_INTERFACE_OWNERS]"},{"line_number":419,"context_line":"        for i in interfaces:"},{"line_number":420,"context_line":"            try:"},{"line_number":421,"context_line":"                cls.client.remove_router_interface_with_subnet_id("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_0d5cbf49","line":418,"updated":"2017-09-19 20:16:38.000000000","message":"what about ROUTER_INTERFACE_OWNERS_SNAT? Shouldn\u0027t we also expect it to be cleaned up? Can you explain this change?\n\nLooking at the previous patchset commit message, it seems like a separate issue with the test suite, where we attempt to remove ports that are no longer. Should we move this part into a separate patch then?","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b7c23c9c68b91b65d2756e9a22457320b3053ad2","unresolved":false,"context_lines":[{"line_number":415,"context_line":"    def delete_router(cls, router):"},{"line_number":416,"context_line":"        body \u003d cls.client.list_router_interfaces(router[\u0027id\u0027])"},{"line_number":417,"context_line":"        interfaces \u003d [port for port in body[\u0027ports\u0027]"},{"line_number":418,"context_line":"                      if port[\u0027device_owner\u0027] in const.ROUTER_INTERFACE_OWNERS]"},{"line_number":419,"context_line":"        for i in interfaces:"},{"line_number":420,"context_line":"            try:"},{"line_number":421,"context_line":"                cls.client.remove_router_interface_with_subnet_id("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_f0add131","line":418,"in_reply_to":"ff5d4b2f_0d5cbf49","updated":"2017-09-21 04:28:51.000000000","message":"ROUTER_INTERFACE_OWNERS_SNAT \u003d (DEVICE_OWNER_ROUTER_INTF,\n                                DEVICE_OWNER_HA_REPLICATED_INT,\n                                DEVICE_OWNER_DVR_INTERFACE,\n                                DEVICE_OWNER_ROUTER_SNAT)\n\nFirst 3 interfaces are part of ROUTER_INTERFACE_OWNERS and will be deleted by line 421 i.e remove_router_interface_with_subnet_id.\n\nDEVICE_OWNER_ROUTER_SNAT will be automatically deleted by https://review.openstack.org/#/c/501717/. I was talking about this patch and it got merged.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"}],"neutron/tests/tempest/scenario/test_migration.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4036ebe3556624331041e089deb2f036148ef854","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                router_id,"},{"line_number":53,"context_line":"                device_owner),"},{"line_number":54,"context_line":"            timeout\u003d300, sleep\u003d5)"},{"line_number":55,"context_line":"        LOG.debug(\u0027Port with device_owner %s is deleted\u0027, device_owner)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def is_port_deleted(self, router_id, device_owner):"},{"line_number":58,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_2d028d0a","line":55,"updated":"2017-09-05 19:01:59.000000000","message":"Leftover debug?","commit_id":"58dffd95213fc34d7907c3f484d067fd0863bda2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4036ebe3556624331041e089deb2f036148ef854","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            timeout\u003d300, sleep\u003d5)"},{"line_number":55,"context_line":"        LOG.debug(\u0027Port with device_owner %s is deleted\u0027, device_owner)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def is_port_deleted(self, router_id, device_owner):"},{"line_number":58,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("},{"line_number":59,"context_line":"            device_id\u003drouter_id,"},{"line_number":60,"context_line":"            device_owner\u003ddevice_owner)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_cd12e958","line":57,"updated":"2017-09-05 19:01:59.000000000","message":"Can be private","commit_id":"58dffd95213fc34d7907c3f484d067fd0863bda2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4036ebe3556624331041e089deb2f036148ef854","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                router_id,"},{"line_number":70,"context_line":"                device_owner),"},{"line_number":71,"context_line":"            timeout\u003d300, sleep\u003d5)"},{"line_number":72,"context_line":"        LOG.debug(\u0027Port with device_owner %s is ready\u0027, device_owner)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def is_port_active(self, router_id, device_owner):"},{"line_number":75,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_8d1ce16a","line":72,"updated":"2017-09-05 19:01:59.000000000","message":"Leftover debug?","commit_id":"58dffd95213fc34d7907c3f484d067fd0863bda2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4036ebe3556624331041e089deb2f036148ef854","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            timeout\u003d300, sleep\u003d5)"},{"line_number":72,"context_line":"        LOG.debug(\u0027Port with device_owner %s is ready\u0027, device_owner)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def is_port_active(self, router_id, device_owner):"},{"line_number":75,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("},{"line_number":76,"context_line":"            device_id\u003drouter_id,"},{"line_number":77,"context_line":"            device_owner\u003ddevice_owner,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_6d177547","line":74,"updated":"2017-09-05 19:01:59.000000000","message":"Can be private","commit_id":"58dffd95213fc34d7907c3f484d067fd0863bda2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("},{"line_number":54,"context_line":"            device_id\u003drouter_id,"},{"line_number":55,"context_line":"            device_owner\u003ddevice_owner)"},{"line_number":56,"context_line":"        for port in ports.get(\u0027ports\u0027):"},{"line_number":57,"context_line":"            return False"},{"line_number":58,"context_line":"        return True"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _wait_until_port_ready(self, router_id, device_owner):"},{"line_number":61,"context_line":"        common_utils.wait_until_true("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_bfedda26","line":58,"range":{"start_line":56,"start_character":8,"end_line":58,"end_character":19},"updated":"2017-09-19 20:16:38.000000000","message":"eh... -\u003e return not bool(ports.get(\u0027ports\u0027))?","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d68c8cd4548719d987f43ac59dd8ef8224719fb1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("},{"line_number":54,"context_line":"            device_id\u003drouter_id,"},{"line_number":55,"context_line":"            device_owner\u003ddevice_owner)"},{"line_number":56,"context_line":"        for port in ports.get(\u0027ports\u0027):"},{"line_number":57,"context_line":"            return False"},{"line_number":58,"context_line":"        return True"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _wait_until_port_ready(self, router_id, device_owner):"},{"line_number":61,"context_line":"        common_utils.wait_until_true("}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_2d041517","line":58,"range":{"start_line":56,"start_character":8,"end_line":58,"end_character":19},"in_reply_to":"9f5c4f37_9030d509","updated":"2017-09-22 17:57:37.000000000","message":"return not ports.get(\u0027ports\u0027) will be even simpler","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b7c23c9c68b91b65d2756e9a22457320b3053ad2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("},{"line_number":54,"context_line":"            device_id\u003drouter_id,"},{"line_number":55,"context_line":"            device_owner\u003ddevice_owner)"},{"line_number":56,"context_line":"        for port in ports.get(\u0027ports\u0027):"},{"line_number":57,"context_line":"            return False"},{"line_number":58,"context_line":"        return True"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _wait_until_port_ready(self, router_id, device_owner):"},{"line_number":61,"context_line":"        common_utils.wait_until_true("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_9030d509","line":58,"range":{"start_line":56,"start_character":8,"end_line":58,"end_character":19},"in_reply_to":"ff5d4b2f_bfedda26","updated":"2017-09-21 04:28:51.000000000","message":"simpler :) Thanks Ihar, I will update.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def _is_port_active(self, router_id, device_owner):"},{"line_number":69,"context_line":"        if device_owner \u003d\u003d const.DEVICE_OWNER_AGENT_GW:"},{"line_number":70,"context_line":"            ports \u003d self.os_admin.network_client.list_ports("},{"line_number":71,"context_line":"                device_owner\u003ddevice_owner,"},{"line_number":72,"context_line":"                status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":73,"context_line":"            if len(ports) !\u003d 2:"},{"line_number":74,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_ffbb520b","line":71,"updated":"2017-09-19 20:16:38.000000000","message":"shouldn\u0027t we still pass router_id somewhere? otherwise we get all ports that may even belong to another agent, no?","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d68c8cd4548719d987f43ac59dd8ef8224719fb1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def _is_port_active(self, router_id, device_owner):"},{"line_number":69,"context_line":"        if device_owner \u003d\u003d const.DEVICE_OWNER_AGENT_GW:"},{"line_number":70,"context_line":"            ports \u003d self.os_admin.network_client.list_ports("},{"line_number":71,"context_line":"                device_owner\u003ddevice_owner,"},{"line_number":72,"context_line":"                status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":73,"context_line":"            if len(ports) !\u003d 2:"},{"line_number":74,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_b0261cb7","line":71,"in_reply_to":"9f5c4f37_d33417e1","updated":"2017-09-22 17:57:37.000000000","message":"This assumption that two agents are always present should not belong to the test case because people may want to have it passed in other setups. I suggest you change the logic somehow so that you don\u0027t rely on specific setup.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b7c23c9c68b91b65d2756e9a22457320b3053ad2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def _is_port_active(self, router_id, device_owner):"},{"line_number":69,"context_line":"        if device_owner \u003d\u003d const.DEVICE_OWNER_AGENT_GW:"},{"line_number":70,"context_line":"            ports \u003d self.os_admin.network_client.list_ports("},{"line_number":71,"context_line":"                device_owner\u003ddevice_owner,"},{"line_number":72,"context_line":"                status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":73,"context_line":"            if len(ports) !\u003d 2:"},{"line_number":74,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_d33417e1","line":71,"in_reply_to":"ff5d4b2f_ffbb520b","updated":"2017-09-21 04:28:51.000000000","message":"I think a comment is needed here. I can\u0027t use router_id as it is not part of this port. As scenario job uses only two agents and one public network, there will always be 2 ports, one port for each agent.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            ports \u003d self.os_admin.network_client.list_ports("},{"line_number":71,"context_line":"                device_owner\u003ddevice_owner,"},{"line_number":72,"context_line":"                status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":73,"context_line":"            if len(ports) !\u003d 2:"},{"line_number":74,"context_line":"                return False"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            ports \u003d self.os_admin.network_client.list_ports("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_7f452217","line":73,"updated":"2017-09-19 20:16:38.000000000","message":"could you please explain, in a comment, what 2 means?","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                device_owner\u003ddevice_owner,"},{"line_number":79,"context_line":"                status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":80,"context_line":"        for port in ports:"},{"line_number":81,"context_line":"            if port[pb.VIF_TYPE] not in [pb.VIF_TYPE_UNBOUND,"},{"line_number":82,"context_line":"                                         pb.VIF_TYPE_BINDING_FAILED]:"},{"line_number":83,"context_line":"                return True"},{"line_number":84,"context_line":"        return False"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _is_floatingip_active(self, router_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_a29edd04","line":83,"range":{"start_line":81,"start_character":12,"end_line":83,"end_character":27},"updated":"2017-09-19 20:16:38.000000000","message":"is it right that while you seem to expect 2 ports (as per line 73), you expect one of them only to be ACTIVE?","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b7c23c9c68b91b65d2756e9a22457320b3053ad2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                device_owner\u003ddevice_owner,"},{"line_number":79,"context_line":"                status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":80,"context_line":"        for port in ports:"},{"line_number":81,"context_line":"            if port[pb.VIF_TYPE] not in [pb.VIF_TYPE_UNBOUND,"},{"line_number":82,"context_line":"                                         pb.VIF_TYPE_BINDING_FAILED]:"},{"line_number":83,"context_line":"                return True"},{"line_number":84,"context_line":"        return False"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _is_floatingip_active(self, router_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_d362d7d8","line":83,"range":{"start_line":81,"start_character":12,"end_line":83,"end_character":27},"in_reply_to":"ff5d4b2f_a29edd04","updated":"2017-09-21 04:28:51.000000000","message":"ports in \"else\" part is expected to have only one part. But  \"if\" will always return 2 ports. I will correct this to work for both if and else. thanks Ihar.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        floatingips \u003d self.os_admin.network_client.list_floatingips("},{"line_number":88,"context_line":"            router_id\u003drouter_id,"},{"line_number":89,"context_line":"            status\u003dconst.ACTIVE).get(\u0027floatingips\u0027)"},{"line_number":90,"context_line":"        if len(floatingips) \u003d\u003d 1:"},{"line_number":91,"context_line":"            return True"},{"line_number":92,"context_line":"        return False"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_028fe9cc","line":90,"updated":"2017-09-19 20:16:38.000000000","message":"what if you ever want to have several fips? will it fail then? I think we should instead expect a specific floating ip to become ACTIVE, not fetch all of them and then hope it\u0027s the only one we want to check.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b7c23c9c68b91b65d2756e9a22457320b3053ad2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        floatingips \u003d self.os_admin.network_client.list_floatingips("},{"line_number":88,"context_line":"            router_id\u003drouter_id,"},{"line_number":89,"context_line":"            status\u003dconst.ACTIVE).get(\u0027floatingips\u0027)"},{"line_number":90,"context_line":"        if len(floatingips) \u003d\u003d 1:"},{"line_number":91,"context_line":"            return True"},{"line_number":92,"context_line":"        return False"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_939a1fc3","line":90,"in_reply_to":"ff5d4b2f_028fe9cc","updated":"2017-09-21 04:28:51.000000000","message":"sure","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    router_id, const.DEVICE_OWNER_ROUTER_SNAT)"},{"line_number":118,"context_line":"        self._wait_until_port_ready("},{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_c2c2f1e9","line":120,"updated":"2017-09-19 20:16:38.000000000","message":"not needed?.. where is it called then?","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"d10794400e8aed1e84fc8dffbeef78482884a632","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    router_id, const.DEVICE_OWNER_ROUTER_SNAT)"},{"line_number":118,"context_line":"        self._wait_until_port_ready("},{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_06aeefe6","line":120,"in_reply_to":"9f5c4f37_06126f59","updated":"2017-09-26 16:29:35.000000000","message":"Reported bug https://bugs.launchpad.net/neutron/+bug/1718585 for the same","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"7b781fd7a560333fb472dfdb371c61f758c770c1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    router_id, const.DEVICE_OWNER_ROUTER_SNAT)"},{"line_number":118,"context_line":"        self._wait_until_port_ready("},{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_06126f59","line":120,"in_reply_to":"9f5c4f37_d3b7773a","updated":"2017-09-21 05:16:26.000000000","message":"I felt flaotingip status is not reliable as it is set to active during creation itself [1] rather than waiting for agent [2] to update it once agent finishes adding SNAT/DNAT rules.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1234\n[2] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L131","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b7c23c9c68b91b65d2756e9a22457320b3053ad2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                    router_id, const.DEVICE_OWNER_ROUTER_SNAT)"},{"line_number":118,"context_line":"        self._wait_until_port_ready("},{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_d3b7773a","line":120,"in_reply_to":"ff5d4b2f_c2c2f1e9","updated":"2017-09-21 04:28:51.000000000","message":"I will enable it.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4430c2f430146abc5903cb2431c1dd0a6b9bf48","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"},{"line_number":124,"context_line":"        if before_ha and not after_ha:"},{"line_number":125,"context_line":"            self._wait_until_port_deleted("}],"source_content_type":"text/x-python","patch_set":7,"id":"ff5d4b2f_425cc14a","line":122,"updated":"2017-09-19 20:16:38.000000000","message":"(No action required) the fact that an API user needs to do all those checks to make sure that data plane is working is not ideal to say the least. I was thinking, wouldn\u0027t router[\u0027status\u0027] reflect all that? If that\u0027s not implemented right now, I am wondering whether that\u0027s something we want to look at in the future. The current approach will probably work but it\u0027s not very user friendly. Thoughts?","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"7b781fd7a560333fb472dfdb371c61f758c770c1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"},{"line_number":124,"context_line":"        if before_ha and not after_ha:"},{"line_number":125,"context_line":"            self._wait_until_port_deleted("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_5345c76f","line":122,"in_reply_to":"9f5c4f37_134aaf26","updated":"2017-09-21 05:16:26.000000000","message":"May be we can\u0027t have that i.e router[\u0027status\u0027] ACTIVE means all its resources up. For example,\nrouter has already two subnets and vms on those subnets sending  traffic through that router. When another subnet has to be added to router, we can\u0027t set to it DOWN and expect to set it again to ACTIVE only after 3rd subnet is successfully added. This may effect existing two subnets and existing packet traffic.\nClients can check router-port status after adding the subnets and gateway and before trying to use the router for traffic.\n\nMay be flaotingip status is not reliable as it is set to active during creation itself [1] rather than waiting for agent [2] to update it once agent finishes adding SNAT/DNAT rules.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L1234\n[2] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L131","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d68c8cd4548719d987f43ac59dd8ef8224719fb1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"},{"line_number":124,"context_line":"        if before_ha and not after_ha:"},{"line_number":125,"context_line":"            self._wait_until_port_deleted("}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_f07a5486","line":122,"in_reply_to":"9f5c4f37_5345c76f","updated":"2017-09-22 17:57:37.000000000","message":"There should be some single attribute that reflects whether eventual consistency \"arrived\" for a port/floatingip/router/any other resource. I think we could introduce a new status for router like PENDING_UPDATE that would suggest that the router is still up but has some changes to apply on backend.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b7c23c9c68b91b65d2756e9a22457320b3053ad2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            router_id, const.DEVICE_OWNER_ROUTER_GW)"},{"line_number":120,"context_line":"        #self._wait_until_floatingip_ready(router_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def _wait_until_router_ports_migrated("},{"line_number":123,"context_line":"            self, router_id, before_dvr, before_ha, after_dvr, after_ha):"},{"line_number":124,"context_line":"        if before_ha and not after_ha:"},{"line_number":125,"context_line":"            self._wait_until_port_deleted("}],"source_content_type":"text/x-python","patch_set":7,"id":"9f5c4f37_134aaf26","line":122,"in_reply_to":"ff5d4b2f_425cc14a","updated":"2017-09-21 04:28:51.000000000","message":"Yes, agree with you.  \n\nWe don\u0027t have code which sets router[\u0027status\u0027] to ACTIVE only after all the resources are up. We can implement that in future.","commit_id":"888dcabc8e26a715272c6409dc3ab3ef1fbb138c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cf4885a0fdcfd9fc7cd0851493d3db08d34407b0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            device_id\u003drouter_id,"},{"line_number":69,"context_line":"            device_owner\u003ddevice_owner,"},{"line_number":70,"context_line":"            status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":71,"context_line":"        if ports:"},{"line_number":72,"context_line":"            if ports[0][pb.VIF_TYPE] not in [pb.VIF_TYPE_UNBOUND,"},{"line_number":73,"context_line":"                                             pb.VIF_TYPE_BINDING_FAILED]:"},{"line_number":74,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_4fb9332c","line":71,"updated":"2017-09-26 18:02:47.000000000","message":"Shouldn\u0027t this still check \u0027for port in ports\u0027 ?","commit_id":"ac60eb50db52b35d82d8f4065744ebd820434d99"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"53b2fee0a9df6f1abb26f201f38113a3c1e47687","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("},{"line_number":54,"context_line":"            device_id\u003drouter_id,"},{"line_number":55,"context_line":"            device_owner\u003ddevice_owner)"},{"line_number":56,"context_line":"        return not bool(ports.get(\u0027ports\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _wait_until_port_ready(self, router_id, device_owner):"},{"line_number":59,"context_line":"        common_utils.wait_until_true("}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_e5a822da","line":56,"range":{"start_line":56,"start_character":19,"end_line":56,"end_character":24},"updated":"2017-10-05 19:06:08.000000000","message":"super-nit: can be removed since not will do the conversion for you","commit_id":"68c53b7d187208e6ccbf3f69b0f35d7bba4c8796"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5ae3348db870381e75617976ba16e3a213bd1632","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        ports \u003d self.os_admin.network_client.list_ports("},{"line_number":54,"context_line":"            device_id\u003drouter_id,"},{"line_number":55,"context_line":"            device_owner\u003ddevice_owner)"},{"line_number":56,"context_line":"        return not bool(ports.get(\u0027ports\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _wait_until_port_ready(self, router_id, device_owner):"},{"line_number":59,"context_line":"        common_utils.wait_until_true("}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_9c509660","line":56,"range":{"start_line":56,"start_character":19,"end_line":56,"end_character":24},"in_reply_to":"7f515b1d_e5a822da","updated":"2017-10-06 13:20:50.000000000","message":"sure, thanks Ihar","commit_id":"68c53b7d187208e6ccbf3f69b0f35d7bba4c8796"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"53b2fee0a9df6f1abb26f201f38113a3c1e47687","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            device_owner\u003ddevice_owner,"},{"line_number":70,"context_line":"            status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":71,"context_line":"        if ports:"},{"line_number":72,"context_line":"            if ports[0][pb.VIF_TYPE] not in [pb.VIF_TYPE_UNBOUND,"},{"line_number":73,"context_line":"                                             pb.VIF_TYPE_BINDING_FAILED]:"},{"line_number":74,"context_line":"                return True"},{"line_number":75,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_c5be46fe","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":23},"updated":"2017-10-05 19:06:08.000000000","message":"is it a problem that list_ports may return multiple matching ports, but you check only for the first? should we check for all ports up?","commit_id":"68c53b7d187208e6ccbf3f69b0f35d7bba4c8796"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5ae3348db870381e75617976ba16e3a213bd1632","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            device_owner\u003ddevice_owner,"},{"line_number":70,"context_line":"            status\u003dconst.ACTIVE).get(\u0027ports\u0027)"},{"line_number":71,"context_line":"        if ports:"},{"line_number":72,"context_line":"            if ports[0][pb.VIF_TYPE] not in [pb.VIF_TYPE_UNBOUND,"},{"line_number":73,"context_line":"                                             pb.VIF_TYPE_BINDING_FAILED]:"},{"line_number":74,"context_line":"                return True"},{"line_number":75,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f515b1d_dc5e0e75","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":23},"in_reply_to":"7f515b1d_c5be46fe","updated":"2017-10-06 13:20:50.000000000","message":"In this test, we have only one router interface. So ports will always have one port.","commit_id":"68c53b7d187208e6ccbf3f69b0f35d7bba4c8796"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c51227fbd65ebec5a897dfa3eef68438b7474fd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if ha:"},{"line_number":82,"context_line":"            self._wait_until_port_ready("},{"line_number":83,"context_line":"                router_id, const.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":84,"context_line":"            if not dvr:"},{"line_number":85,"context_line":"                self._wait_until_port_ready("},{"line_number":86,"context_line":"                    router_id, const.DEVICE_OWNER_HA_REPLICATED_INT)"},{"line_number":87,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_ec58d48a","line":84,"updated":"2017-10-08 20:27:13.000000000","message":"nit: I would prefer to do it in opposite side:\n\nif dvr:\n    do_something\nelse:\n    do something else\n\nIMHO it\u0027s easier to read :)","commit_id":"922f40d02348e6c3f2c05c984542c9e4a2bb8c09"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"d34a32e7d3ffd2e898f1e82a6e820f1a18e192ce","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        if ha:"},{"line_number":82,"context_line":"            self._wait_until_port_ready("},{"line_number":83,"context_line":"                router_id, const.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":84,"context_line":"            if not dvr:"},{"line_number":85,"context_line":"                self._wait_until_port_ready("},{"line_number":86,"context_line":"                    router_id, const.DEVICE_OWNER_HA_REPLICATED_INT)"},{"line_number":87,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_ffa62a0f","line":84,"in_reply_to":"7f515b1d_ec58d48a","updated":"2017-10-09 11:58:03.000000000","message":"sure, thanks","commit_id":"922f40d02348e6c3f2c05c984542c9e4a2bb8c09"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1c51227fbd65ebec5a897dfa3eef68438b7474fd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                router_id, const.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":98,"context_line":"            self._wait_until_port_deleted("},{"line_number":99,"context_line":"                    router_id, const.DEVICE_OWNER_HA_REPLICATED_INT)"},{"line_number":100,"context_line":"        if before_dvr and not after_dvr:"},{"line_number":101,"context_line":"            self._wait_until_port_deleted("},{"line_number":102,"context_line":"                router_id, const.DEVICE_OWNER_DVR_INTERFACE)"},{"line_number":103,"context_line":"            self._wait_until_port_deleted("}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_cc5d187a","line":100,"updated":"2017-10-08 20:27:13.000000000","message":"I\u0027m not an expert in L3 stuff but can I pass to this method 4 True values or 4 false values? Will it makes sense?","commit_id":"922f40d02348e6c3f2c05c984542c9e4a2bb8c09"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"d34a32e7d3ffd2e898f1e82a6e820f1a18e192ce","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                router_id, const.DEVICE_OWNER_ROUTER_HA_INTF)"},{"line_number":98,"context_line":"            self._wait_until_port_deleted("},{"line_number":99,"context_line":"                    router_id, const.DEVICE_OWNER_HA_REPLICATED_INT)"},{"line_number":100,"context_line":"        if before_dvr and not after_dvr:"},{"line_number":101,"context_line":"            self._wait_until_port_deleted("},{"line_number":102,"context_line":"                router_id, const.DEVICE_OWNER_DVR_INTERFACE)"},{"line_number":103,"context_line":"            self._wait_until_port_deleted("}],"source_content_type":"text/x-python","patch_set":16,"id":"7f515b1d_5f9c1ebf","line":100,"in_reply_to":"7f515b1d_cc5d187a","updated":"2017-10-09 11:58:03.000000000","message":"No, we can\u0027t as we are testing migration.","commit_id":"922f40d02348e6c3f2c05c984542c9e4a2bb8c09"}]}
