)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9923bbf1196396e41115abf63b6f50100b79ab48","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Addind a configuration option so that the tos parameter"},{"line_number":10,"context_line":"in VxLAN interfaces can be set to inherit in order to"},{"line_number":11,"context_line":"copy the inner header TOS value to the outer header."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d87b8ee75e28a346ccb1890f419f03120ffc15a"},{"line_number":14,"context_line":"Related-Bug: #1692951"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f2577a7_7c762e09","line":11,"updated":"2017-09-12 12:03:38.000000000","message":"DocImpact flag is necessary for such change IMO","commit_id":"03c4d453abe83157d4a169500c4c20bad6d31868"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"b3194b06fbfd4d7ef616204cebad4b08696fe352","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Addind a configuration option so that the tos parameter"},{"line_number":10,"context_line":"in VxLAN interfaces can be set to inherit in order to"},{"line_number":11,"context_line":"copy the inner header TOS value to the outer header."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d87b8ee75e28a346ccb1890f419f03120ffc15a"},{"line_number":14,"context_line":"Related-Bug: #1692951"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f2577a7_0bd0de1e","line":11,"in_reply_to":"5f2577a7_7c762e09","updated":"2017-09-13 08:00:30.000000000","message":"Done","commit_id":"03c4d453abe83157d4a169500c4c20bad6d31868"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fe7a46d37279f55955daad83df8a09a1f35a9445","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in LB VxLAN interfaces can be set to inherit in order to"},{"line_number":11,"context_line":"copy the inner header TOS value to the outer header."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact: new configuration option"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3d87b8ee75e28a346ccb1890f419f03120ffc15a"},{"line_number":16,"context_line":"Related-Bug: #1692951"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f2577a7_c6e40daf","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":35},"updated":"2017-09-13 09:24:52.000000000","message":"This is going to be the bug description. Add a bit more information, like \"added a new configutation option in LB, \u0027tos_inherit\u0027 blah blah\"\n\nJust a bit more, like in the release note.","commit_id":"2fa0814d089cf9e3d2579bf06876391ad729d661"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5cc0a28587bf83115e96880a13dd0d12cdcc0ea3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in LB VxLAN interfaces can be set to inherit in order to"},{"line_number":11,"context_line":"copy the inner header TOS value to the outer header."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact: Added a new boolean configuration option"},{"line_number":14,"context_line":"           \"tos_inherit\". When set, the tos parameter"},{"line_number":15,"context_line":"\t   of LB VxLAN ports is overwritten and set to"},{"line_number":16,"context_line":"\t   inherit. This copies the TOS value of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f2577a7_19335864","line":13,"updated":"2017-09-15 14:05:19.000000000","message":"Sorry for that but now, after some talks on PTG I think that this DocImpact is not needed anymore.\nDocumentation is in fact changed in this patch so there is no need to create new launchpad bug for it.","commit_id":"5ba1e31f739d57678e6c020d598245b1358388eb"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"7e98057b67233cdd70618290660d3e39f5977e81","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in LB VxLAN interfaces can be set to inherit in order to"},{"line_number":11,"context_line":"copy the inner header TOS value to the outer header."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact: Added a new boolean configuration option"},{"line_number":14,"context_line":"           \"tos_inherit\". When set, the tos parameter"},{"line_number":15,"context_line":"\t   of LB VxLAN ports is overwritten and set to"},{"line_number":16,"context_line":"\t   inherit. This copies the TOS value of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f2577a7_591680aa","line":13,"in_reply_to":"5f2577a7_19335864","updated":"2017-09-15 14:08:14.000000000","message":"Ok!","commit_id":"5ba1e31f739d57678e6c020d598245b1358388eb"}],"doc/source/admin/config-qos.rst":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"02b8288751607c4fef5ff5071859deec10bb7ce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7f515b1d_e99486ea","updated":"2017-10-05 16:25:50.000000000","message":"Is there anything that needs updating in the internals for QoS [1] that should be included herein??\n\n\n[1] https://github.com/openstack/neutron/blob/master/doc/source/contributor/internals/quality_of_service.rst","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"1184984887f9404a3f4d4d2ec71acac616ee79e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7f515b1d_95f072cb","in_reply_to":"7f515b1d_e99486ea","updated":"2017-10-06 07:37:20.000000000","message":"There won\u0027t be any changes to the QoS API actually, it\u0027s only a config file change. I merged this with the OVS one: https://review.openstack.org/#/c/501267/ Maybe I should abandon this one.","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"}],"neutron/conf/plugins/ml2/drivers/agent.py":[{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"f137672d8ce0f8cbcab5079171e20860663f1129","unresolved":false,"context_lines":[{"line_number":26,"context_line":"               help\u003d_(\"Set new timeout in seconds for new rpc calls after \""},{"line_number":27,"context_line":"                      \"agent receives SIGTERM. If value is set to 0, rpc \""},{"line_number":28,"context_line":"                      \"timeout won\u0027t be changed\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027tos\u0027,"},{"line_number":30,"context_line":"               help\u003d_(\"The TOS value to use for outer headers during tunnel \""},{"line_number":31,"context_line":"                      \"encapsulation. TOS is made of DSCP and ECN \""},{"line_number":32,"context_line":"                      \"bits. ECN is always inherited and must be zero, \""},{"line_number":33,"context_line":"                      \"otherwise the right DSCP mark won\u0027t be applied.\")),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027tos_inherit\u0027, default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d_(\"If set to true, the TOS value of tunnel \""},{"line_number":36,"context_line":"                       \"interfaces is overwritten and set to inherit. \""},{"line_number":37,"context_line":"                       \"The TOS value of the inner header is then \""},{"line_number":38,"context_line":"                       \"copied to the outer header. TOS is made of DSCP \""},{"line_number":39,"context_line":"                       \"and ECN bits. ECN is always inherited.\")),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_3331725b","line":39,"range":{"start_line":29,"start_character":0,"end_line":39,"end_character":66},"updated":"2017-09-29 08:21:30.000000000","message":"Transfered this here so that it would be shared with the OVS implementation: https://review.openstack.org/#/c/501267/5","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"0cc266b4860052612778bb4de942d5c0325951df","unresolved":false,"context_lines":[{"line_number":26,"context_line":"               help\u003d_(\"Set new timeout in seconds for new rpc calls after \""},{"line_number":27,"context_line":"                      \"agent receives SIGTERM. If value is set to 0, rpc \""},{"line_number":28,"context_line":"                      \"timeout won\u0027t be changed\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027tos\u0027,"},{"line_number":30,"context_line":"               help\u003d_(\"The TOS value to use for outer headers during tunnel \""},{"line_number":31,"context_line":"                      \"encapsulation. TOS is made of DSCP and ECN \""},{"line_number":32,"context_line":"                      \"bits. ECN is always inherited and must be zero, \""},{"line_number":33,"context_line":"                      \"otherwise the right DSCP mark won\u0027t be applied.\")),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027tos_inherit\u0027, default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d_(\"If set to true, the TOS value of tunnel \""},{"line_number":36,"context_line":"                       \"interfaces is overwritten and set to inherit. \""},{"line_number":37,"context_line":"                       \"The TOS value of the inner header is then \""},{"line_number":38,"context_line":"                       \"copied to the outer header. TOS is made of DSCP \""},{"line_number":39,"context_line":"                       \"and ECN bits. ECN is always inherited.\")),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_17440246","line":39,"range":{"start_line":29,"start_character":0,"end_line":39,"end_character":66},"in_reply_to":"7f515b1d_007ccce9","updated":"2017-10-02 09:07:50.000000000","message":"You are right, I\u0027ll merge LB with OVS and mark OVS review as closing the initial bug","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d9a4ef98c7a4bd944ccbc407f4370a4f5e8a799","unresolved":false,"context_lines":[{"line_number":26,"context_line":"               help\u003d_(\"Set new timeout in seconds for new rpc calls after \""},{"line_number":27,"context_line":"                      \"agent receives SIGTERM. If value is set to 0, rpc \""},{"line_number":28,"context_line":"                      \"timeout won\u0027t be changed\")),"},{"line_number":29,"context_line":"    cfg.IntOpt(\u0027tos\u0027,"},{"line_number":30,"context_line":"               help\u003d_(\"The TOS value to use for outer headers during tunnel \""},{"line_number":31,"context_line":"                      \"encapsulation. TOS is made of DSCP and ECN \""},{"line_number":32,"context_line":"                      \"bits. ECN is always inherited and must be zero, \""},{"line_number":33,"context_line":"                      \"otherwise the right DSCP mark won\u0027t be applied.\")),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027tos_inherit\u0027, default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d_(\"If set to true, the TOS value of tunnel \""},{"line_number":36,"context_line":"                       \"interfaces is overwritten and set to inherit. \""},{"line_number":37,"context_line":"                       \"The TOS value of the inner header is then \""},{"line_number":38,"context_line":"                       \"copied to the outer header. TOS is made of DSCP \""},{"line_number":39,"context_line":"                       \"and ECN bits. ECN is always inherited.\")),"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_007ccce9","line":39,"range":{"start_line":29,"start_character":0,"end_line":39,"end_character":66},"in_reply_to":"7f515b1d_3331725b","updated":"2017-09-29 21:04:23.000000000","message":"so maybe You should make this patch on top of OVS implementation, or at least mark it as WIP until OVS will be merged","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"}],"neutron/conf/plugins/ml2/drivers/linuxbridge.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"71cb344df4927935c762c51dcd76944d68fc012c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"mechanism driver\")),"},{"line_number":30,"context_line":"    cfg.IntOpt(\u0027ttl\u0027,"},{"line_number":31,"context_line":"               help\u003d_(\"TTL for vxlan interface protocol packets.\")),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027tos\u0027,"},{"line_number":33,"context_line":"               help\u003d_(\"TOS for vxlan interface protocol packets. Can be \""},{"line_number":34,"context_line":"                      \"set to inherit to copy the inner header TOS value \""},{"line_number":35,"context_line":"                      \"during encapsulation.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_eca0d944","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":14},"updated":"2017-09-07 03:51:29.000000000","message":"You made it to String. What input should a user give to copy the Inner Header TOS value to Outer Header ?\nThat is missing, and can be added as a Release note.","commit_id":"104dfd45441c89d63bfb2a613e57b5f75c552137"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"b66713962e74f8ff59dbe433ee9b819a07a3f34c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"mechanism driver\")),"},{"line_number":30,"context_line":"    cfg.IntOpt(\u0027ttl\u0027,"},{"line_number":31,"context_line":"               help\u003d_(\"TTL for vxlan interface protocol packets.\")),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027tos\u0027,"},{"line_number":33,"context_line":"               help\u003d_(\"TOS for vxlan interface protocol packets. Can be \""},{"line_number":34,"context_line":"                      \"set to inherit to copy the inner header TOS value \""},{"line_number":35,"context_line":"                      \"during encapsulation.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_c989fe26","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":14},"in_reply_to":"5f2577a7_1b6cfe34","updated":"2017-09-11 07:39:16.000000000","message":"Oh, sorry... I will commit a patch with your recommendations.\n\nThe tos value will be replaced with \u0027inherit\u0027. So the VxLAN port for example will have a config parameter \u0027tos\u003dinherit\u0027 which can be seen with: ip -d link","commit_id":"104dfd45441c89d63bfb2a613e57b5f75c552137"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"19750b12038deda66e846d87291fd5cfcd775154","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"mechanism driver\")),"},{"line_number":30,"context_line":"    cfg.IntOpt(\u0027ttl\u0027,"},{"line_number":31,"context_line":"               help\u003d_(\"TTL for vxlan interface protocol packets.\")),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027tos\u0027,"},{"line_number":33,"context_line":"               help\u003d_(\"TOS for vxlan interface protocol packets. Can be \""},{"line_number":34,"context_line":"                      \"set to inherit to copy the inner header TOS value \""},{"line_number":35,"context_line":"                      \"during encapsulation.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f2577a7_1b6cfe34","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":14},"in_reply_to":"7f287b81_bbd0c520","updated":"2017-09-09 06:41:27.000000000","message":"Sorry but you can\u0027t change a config parameter type in this way.\n\nYou should:\n- Create a new one, to allow a user to inherit the inner header TOS if wanted.\n- By default this new boolean parameter (it\u0027s all about to inherit or not) should override the value in \"tos\". If True, the value in \"tos\" should not apply if set.\n- Add a release note, as Reedip said.\n- Add documentation for this new parameter.\n- Add an implementation in the driver. How are you enforcing this value heritage?","commit_id":"104dfd45441c89d63bfb2a613e57b5f75c552137"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"1538c6f7ab9fc58d8b1ac1a20213cfa1063aa841","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                       \"mechanism driver\")),"},{"line_number":30,"context_line":"    cfg.IntOpt(\u0027ttl\u0027,"},{"line_number":31,"context_line":"               help\u003d_(\"TTL for vxlan interface protocol packets.\")),"},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027tos\u0027,"},{"line_number":33,"context_line":"               help\u003d_(\"TOS for vxlan interface protocol packets. Can be \""},{"line_number":34,"context_line":"                      \"set to inherit to copy the inner header TOS value \""},{"line_number":35,"context_line":"                      \"during encapsulation.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_bbd0c520","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":14},"in_reply_to":"7f287b81_eca0d944","updated":"2017-09-07 08:37:01.000000000","message":"It\u0027s in the help, it should be \"inherit\", maybe I should emphasize it so that it would be clearer?","commit_id":"104dfd45441c89d63bfb2a613e57b5f75c552137"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fe7a46d37279f55955daad83df8a09a1f35a9445","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    cfg.IntOpt(\u0027tos\u0027,"},{"line_number":33,"context_line":"               help\u003d_(\"TOS for vxlan interface protocol packets.\")),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027tos_inherit\u0027, default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d_(\"if set to true, the TOS value of vxlan \""},{"line_number":36,"context_line":"                       \"interfaces is overwritten and set to inherit. \""},{"line_number":37,"context_line":"                       \"The TOS value of the inner header is then \""},{"line_number":38,"context_line":"                       \"copied to the outer header.\")),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_46d13dcd","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":26},"updated":"2017-09-13 09:24:52.000000000","message":"nit: \u0027If\u0027 with capital letter","commit_id":"2fa0814d089cf9e3d2579bf06876391ad729d661"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"29afa5076424887445e0f438e2af794a2e2df7a4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d_(\"If set to true, the TOS value of vxlan \""},{"line_number":36,"context_line":"                       \"interfaces is overwritten and set to inherit. \""},{"line_number":37,"context_line":"                       \"The TOS value of the inner header is then \""},{"line_number":38,"context_line":"                       \"copied to the outer header.\")),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027vxlan_group\u0027, default\u003dDEFAULT_VXLAN_GROUP,"},{"line_number":40,"context_line":"               help\u003d_(\"Multicast group(s) for vxlan interface. A range of \""},{"line_number":41,"context_line":"                      \"group addresses may be specified by using CIDR \""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_1d713faa","line":38,"updated":"2017-09-13 14:14:28.000000000","message":"I\u0027m not sure if it is best idea to use two config options for tos setting. Maybe it would be better to \"merge\" it somehow with \"tos\" option above. E.g. if tos\u003d-1 then inherit? or something like that.\n\nOr at least You should add some info in logs (e.g. during initialize of agent) that \"tos_inherit\" is set so \"tos\" value will have no effect.","commit_id":"fde5df1293449f703de74069b8243e0757b573c1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8f8cc94d56fe5c26827cd5f373173ff3d495c2b9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d_(\"If set to true, the TOS value of vxlan \""},{"line_number":36,"context_line":"                       \"interfaces is overwritten and set to inherit. \""},{"line_number":37,"context_line":"                       \"The TOS value of the inner header is then \""},{"line_number":38,"context_line":"                       \"copied to the outer header.\")),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027vxlan_group\u0027, default\u003dDEFAULT_VXLAN_GROUP,"},{"line_number":40,"context_line":"               help\u003d_(\"Multicast group(s) for vxlan interface. A range of \""},{"line_number":41,"context_line":"                      \"group addresses may be specified by using CIDR \""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_e050f50c","line":38,"in_reply_to":"5f2577a7_03a31e51","updated":"2017-09-14 02:23:51.000000000","message":"if we can\u0027t change behavior of existing option that it\u0027s fine for me but IMO it\u0027s not cleaner. Adding more and more knobs to config files isn\u0027t clean IMO :)","commit_id":"fde5df1293449f703de74069b8243e0757b573c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c6424a9465f8d7d03cce5a86d92fc4a9302fd0c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                help\u003d_(\"If set to true, the TOS value of vxlan \""},{"line_number":36,"context_line":"                       \"interfaces is overwritten and set to inherit. \""},{"line_number":37,"context_line":"                       \"The TOS value of the inner header is then \""},{"line_number":38,"context_line":"                       \"copied to the outer header.\")),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027vxlan_group\u0027, default\u003dDEFAULT_VXLAN_GROUP,"},{"line_number":40,"context_line":"               help\u003d_(\"Multicast group(s) for vxlan interface. A range of \""},{"line_number":41,"context_line":"                      \"group addresses may be specified by using CIDR \""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_03a31e51","line":38,"in_reply_to":"5f2577a7_1d713faa","updated":"2017-09-13 15:35:45.000000000","message":"You can\u0027t overwrite a config option functionality, at least not without deprecating the old behaviour.\n\nThe idea of having a second variable, set to false by default, is cleaner.","commit_id":"fde5df1293449f703de74069b8243e0757b573c1"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"f137672d8ce0f8cbcab5079171e20860663f1129","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    4: 20,"},{"line_number":105,"context_line":"    6: 40,"},{"line_number":106,"context_line":"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# The value of tunnel ports tos option when set to inherit"},{"line_number":109,"context_line":"TUNNEL_TOS_INHERIT \u003d \u0027inherit\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_13343649","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":30},"updated":"2017-09-29 08:21:30.000000000","message":"Shared between LB and OVS: https://review.openstack.org/#/c/501267/5","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fe7a46d37279f55955daad83df8a09a1f35a9445","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                cfg.CONF.VXLAN.udp_srcport_max),"},{"line_number":326,"context_line":"                    \u0027dstport\u0027: cfg.CONF.VXLAN.udp_dstport,"},{"line_number":327,"context_line":"                    \u0027ttl\u0027: cfg.CONF.VXLAN.ttl}"},{"line_number":328,"context_line":"            if cfg.CONF.VXLAN.tos_inherit:"},{"line_number":329,"context_line":"                args[\u0027tos\u0027] \u003d \u0027inherit\u0027"},{"line_number":330,"context_line":"            else:"},{"line_number":331,"context_line":"                args[\u0027tos\u0027] \u003d cfg.CONF.VXLAN.tos"},{"line_number":332,"context_line":"            if self.vxlan_mode \u003d\u003d lconst.VXLAN_MCAST:"},{"line_number":333,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"},{"line_number":334,"context_line":"            if cfg.CONF.VXLAN.l2_population:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_06d1f5fb","line":331,"range":{"start_line":328,"start_character":12,"end_line":331,"end_character":48},"updated":"2017-09-13 09:24:52.000000000","message":"This could be:\n\u0027tos\u0027: \u0027inherit\u0027 if cfg.CONF.VXLAN.tos_inherit else cfg.CONF.VXLAN.tos","commit_id":"2fa0814d089cf9e3d2579bf06876391ad729d661"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"29afa5076424887445e0f438e2af794a2e2df7a4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                cfg.CONF.VXLAN.udp_srcport_max),"},{"line_number":326,"context_line":"                    \u0027dstport\u0027: cfg.CONF.VXLAN.udp_dstport,"},{"line_number":327,"context_line":"                    \u0027ttl\u0027: cfg.CONF.VXLAN.ttl,"},{"line_number":328,"context_line":"                    \u0027tos\u0027: (\u0027inherit\u0027 if cfg.CONF.VXLAN.tos_inherit"},{"line_number":329,"context_line":"                            else cfg.CONF.VXLAN.tos)}"},{"line_number":330,"context_line":"            if self.vxlan_mode \u003d\u003d lconst.VXLAN_MCAST:"},{"line_number":331,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_52321612","line":328,"updated":"2017-09-13 14:14:28.000000000","message":"IMO it should be defined in some constants file rather than using \"raw\" string here?","commit_id":"fde5df1293449f703de74069b8243e0757b573c1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0c6424a9465f8d7d03cce5a86d92fc4a9302fd0c","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                cfg.CONF.VXLAN.udp_srcport_max),"},{"line_number":326,"context_line":"                    \u0027dstport\u0027: cfg.CONF.VXLAN.udp_dstport,"},{"line_number":327,"context_line":"                    \u0027ttl\u0027: cfg.CONF.VXLAN.ttl,"},{"line_number":328,"context_line":"                    \u0027tos\u0027: (\u0027inherit\u0027 if cfg.CONF.VXLAN.tos_inherit"},{"line_number":329,"context_line":"                            else cfg.CONF.VXLAN.tos)}"},{"line_number":330,"context_line":"            if self.vxlan_mode \u003d\u003d lconst.VXLAN_MCAST:"},{"line_number":331,"context_line":"                args[\u0027group\u0027] \u003d self.get_vxlan_group(segmentation_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_23b97a79","line":328,"in_reply_to":"5f2577a7_52321612","updated":"2017-09-13 15:35:45.000000000","message":"ok with this","commit_id":"fde5df1293449f703de74069b8243e0757b573c1"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5cc0a28587bf83115e96880a13dd0d12cdcc0ea3","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                                                srcport\u003d(0, 0),"},{"line_number":432,"context_line":"                                                dstport\u003dNone,"},{"line_number":433,"context_line":"                                                ttl\u003dNone,"},{"line_number":434,"context_line":"                                                tos\u003d\u0027inherit\u0027,"},{"line_number":435,"context_line":"                                                dev\u003dself.lbm.local_int)"},{"line_number":436,"context_line":"                dv6_fn.assert_called_once_with()"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_f9376c4c","line":434,"updated":"2017-09-15 14:05:19.000000000","message":"nit: You can use this constant which You defined in neutron/plugins/ml2/drivers/linuxbridge/agent/common/constants.py","commit_id":"5ba1e31f739d57678e6c020d598245b1358388eb"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"7e98057b67233cdd70618290660d3e39f5977e81","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                                                srcport\u003d(0, 0),"},{"line_number":432,"context_line":"                                                dstport\u003dNone,"},{"line_number":433,"context_line":"                                                ttl\u003dNone,"},{"line_number":434,"context_line":"                                                tos\u003d\u0027inherit\u0027,"},{"line_number":435,"context_line":"                                                dev\u003dself.lbm.local_int)"},{"line_number":436,"context_line":"                dv6_fn.assert_called_once_with()"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f2577a7_190c7892","line":434,"in_reply_to":"5f2577a7_f9376c4c","updated":"2017-09-15 14:08:14.000000000","message":"Yes indeed","commit_id":"5ba1e31f739d57678e6c020d598245b1358388eb"}],"releasenotes/notes/add-tos-inherit-for-lb-vxlan-8deec06cd6897509.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d9a4ef98c7a4bd944ccbc407f4370a4f5e8a799","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The TOS value in LB VxLAN interfaces for the outer header can now be"},{"line_number":4,"context_line":"    inherited from the inner header. A boolean configuration option"},{"line_number":5,"context_line":"    \"tos_inherit\" was added. If set, the VxLAN interface will copy the"},{"line_number":6,"context_line":"    TOS value of the inner header to the outer header."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f515b1d_407524f9","line":3,"range":{"start_line":3,"start_character":21,"end_line":3,"end_character":23},"updated":"2017-09-29 21:04:23.000000000","message":"Maybe \"Linuxbridge\" instead of shortcut here would be better?","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"3dccfd76436f67bc1d26e215a996e9e0cb038f7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The TOS value in LB VxLAN interfaces for the outer header can now be"},{"line_number":4,"context_line":"    inherited from the inner header. A boolean configuration option"},{"line_number":5,"context_line":"    \"tos_inherit\" was added. If set, the VxLAN interface will copy the"},{"line_number":6,"context_line":"    TOS value of the inner header to the outer header."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f515b1d_d5882ac7","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":4},"updated":"2017-10-06 07:53:26.000000000","message":"add a |","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d9a4ef98c7a4bd944ccbc407f4370a4f5e8a799","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The TOS value in LB VxLAN interfaces for the outer header can now be"},{"line_number":4,"context_line":"    inherited from the inner header. A boolean configuration option"},{"line_number":5,"context_line":"    \"tos_inherit\" was added. If set, the VxLAN interface will copy the"},{"line_number":6,"context_line":"    TOS value of the inner header to the outer header."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f515b1d_806f9c29","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":17},"updated":"2017-09-29 21:04:23.000000000","message":"should be ``tos_inherit`` probably","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"3dccfd76436f67bc1d26e215a996e9e0cb038f7a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The TOS value in LB VxLAN interfaces for the outer header can now be"},{"line_number":4,"context_line":"    inherited from the inner header. A boolean configuration option"},{"line_number":5,"context_line":"    \"tos_inherit\" was added. If set, the VxLAN interface will copy the"},{"line_number":6,"context_line":"    TOS value of the inner header to the outer header."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f515b1d_9592b2f5","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":17},"in_reply_to":"7f515b1d_806f9c29","updated":"2017-10-06 07:53:26.000000000","message":"agree","commit_id":"6f288d6ee4716413c4752a382ba0759aababb4bc"}],"releasenotes/notes/add-tos-inherit-for-vxlan-8deec06cd6897509.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9923bbf1196396e41115abf63b6f50100b79ab48","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The TOS value in VxLAN interfaces for the outer header can now be"},{"line_number":4,"context_line":"    inherited from the inner header. A boolean configuration option"},{"line_number":5,"context_line":"    \u0027tos_inherit\u0027 was added. If set, the VxLAN interface will copy the"},{"line_number":6,"context_line":"    TOS value of the inner header to the outer header."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_5c737216","line":5,"updated":"2017-09-12 12:03:38.000000000","message":"I think that it should be ``tos_inherit`` rather than \u0027tos_inherit\u0027","commit_id":"03c4d453abe83157d4a169500c4c20bad6d31868"},{"author":{"_account_id":26504,"name":"Ali Sanhaji","email":"ali.sanhaji@orange.com","username":"alisanhaji"},"change_message_id":"b3194b06fbfd4d7ef616204cebad4b08696fe352","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The TOS value in VxLAN interfaces for the outer header can now be"},{"line_number":4,"context_line":"    inherited from the inner header. A boolean configuration option"},{"line_number":5,"context_line":"    \u0027tos_inherit\u0027 was added. If set, the VxLAN interface will copy the"},{"line_number":6,"context_line":"    TOS value of the inner header to the outer header."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_8bbccedc","line":5,"in_reply_to":"5f2577a7_5c737216","updated":"2017-09-13 08:00:30.000000000","message":"I will correct it","commit_id":"03c4d453abe83157d4a169500c4c20bad6d31868"}]}