)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c875ec92ea766dc2c73bb84e2e2ecac732e43acf","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                and subnet.ip_version \u003d\u003d 4"},{"line_number":452,"context_line":"                and self._is_subnet_isolated(subnet))"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            if enable_metadata:"},{"line_number":455,"context_line":"                subnet_dhcp_ip \u003d subnet_to_interface_ip[subnet.id]"},{"line_number":456,"context_line":"                host_routes.append("},{"line_number":457,"context_line":"                    \u0027%s/32,%s\u0027 % (METADATA_DEFAULT_IP, subnet_dhcp_ip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F5Nc%3D","line":454,"updated":"2013-10-08 12:14:29.000000000","message":"see below comment, but could eliminate enable_metadata variable and just have a function that does all the tests:\n\nif enable_metadata():","commit_id":"20f5e9ad1479ae8f21334e5cc4c79615296d81ce"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"30609d354ba076c9d75fe289eefc2529bdf1e166","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                and subnet.ip_version \u003d\u003d 4"},{"line_number":452,"context_line":"                and self._is_subnet_isolated(subnet))"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"            if enable_metadata:"},{"line_number":455,"context_line":"                subnet_dhcp_ip \u003d subnet_to_interface_ip[subnet.id]"},{"line_number":456,"context_line":"                host_routes.append("},{"line_number":457,"context_line":"                    \u0027%s/32,%s\u0027 % (METADATA_DEFAULT_IP, subnet_dhcp_ip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F4wU%3D","line":454,"in_reply_to":"AAAATH%2F%2F5Nc%3D","updated":"2013-10-08 13:39:24.000000000","message":"Done","commit_id":"20f5e9ad1479ae8f21334e5cc4c79615296d81ce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c875ec92ea766dc2c73bb84e2e2ecac732e43acf","unresolved":false,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        return \u0027,\u0027.join((set_tag + tag, \u0027%s\u0027 % option) + args)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    def _is_subnet_isolated(self, subnet):"},{"line_number":524,"context_line":"        \u0027\u0027\u0027Check that there is no Neutron router attached to the subnet.\u0027\u0027\u0027"},{"line_number":525,"context_line":"        if not subnet.gateway_ip:"},{"line_number":526,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F5No%3D","line":523,"updated":"2013-10-08 12:14:29.000000000","message":"Instead of having a boolean set on L 449 based on some conditions and a call to this function, why not have a single function to determine if enabled meta data.\n\nAdd docstring to describe the all the conditions, if combine.","commit_id":"20f5e9ad1479ae8f21334e5cc4c79615296d81ce"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"30609d354ba076c9d75fe289eefc2529bdf1e166","unresolved":false,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"        return \u0027,\u0027.join((set_tag + tag, \u0027%s\u0027 % option) + args)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    def _is_subnet_isolated(self, subnet):"},{"line_number":524,"context_line":"        \u0027\u0027\u0027Check that there is no Neutron router attached to the subnet.\u0027\u0027\u0027"},{"line_number":525,"context_line":"        if not subnet.gateway_ip:"},{"line_number":526,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F4wQ%3D","line":523,"in_reply_to":"AAAATH%2F%2F5No%3D","updated":"2013-10-08 13:39:24.000000000","message":"Done","commit_id":"20f5e9ad1479ae8f21334e5cc4c79615296d81ce"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"6ece7a986f5853b6beb70b087326b313faf824e8","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        return \u0027,\u0027.join((set_tag + tag, \u0027%s\u0027 % option) + args)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def _enable_metadata(self, subnet):"},{"line_number":520,"context_line":"        if self.conf.enable_isolated_metadata and subnet.ip_version \u003d\u003d 4:"},{"line_number":521,"context_line":"            if not subnet.gateway_ip:"},{"line_number":522,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F4bg%3D","line":519,"updated":"2013-10-08 14:50:34.000000000","message":"Nit: May be useful to add a docstring to elaborate on all the conditions.","commit_id":"44f37ca7d217e5610c87dcf6429d4c8bc31f5735"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"c2ec39782de49ff9ee3016ce0556f3ddc72ef6c7","unresolved":false,"context_lines":[{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        return \u0027,\u0027.join((set_tag + tag, \u0027%s\u0027 % option) + args)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def _enable_metadata(self, subnet):"},{"line_number":520,"context_line":"        if self.conf.enable_isolated_metadata and subnet.ip_version \u003d\u003d 4:"},{"line_number":521,"context_line":"            if not subnet.gateway_ip:"},{"line_number":522,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2F1J0%3D","line":519,"in_reply_to":"AAAATH%2F%2F4bg%3D","updated":"2013-10-09 09:02:18.000000000","message":"Done","commit_id":"44f37ca7d217e5610c87dcf6429d4c8bc31f5735"}]}
