)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f43a491fc0cd1ec330d5dd30ef1876b6c297d791","unresolved":false,"context_lines":[{"line_number":10,"context_line":"IPs are not configured properly in the DVR snat namespace"},{"line_number":11,"context_line":"for the master router namespace."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1716829"},{"line_number":16,"context_line":"Change-Id: Icc8c5d4e22313448e2066a29dbe509e4345b364c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f2577a7_81c70f13","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":27},"updated":"2017-09-13 10:34:05.000000000","message":"I think it is better to describe what this patch does a bit widely :) Just the same sentence from bug description will be fine.","commit_id":"d171a0856e80c232881b3552bff0c05720026561"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"ad3ef5e736c022dc414792e367de9ffd563154eb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"IPs are not configured properly in the DVR snat namespace"},{"line_number":11,"context_line":"for the master router namespace."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1716829"},{"line_number":16,"context_line":"Change-Id: Icc8c5d4e22313448e2066a29dbe509e4345b364c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f2577a7_83bb8e0c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":27},"in_reply_to":"5f2577a7_81c70f13","updated":"2017-10-05 15:13:19.000000000","message":"Sure will fix it.","commit_id":"d171a0856e80c232881b3552bff0c05720026561"}],"neutron/agent/l3/dvr_edge_ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8b477902b34143a53ab1fb9a2d4ae2c700e29607","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"},{"line_number":62,"context_line":"        fip_ip \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":63,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":64,"context_line":"            self.get_ex_gw_port())"},{"line_number":65,"context_line":"        if self.is_router_master():"},{"line_number":66,"context_line":"            self._add_vip(fip_cidr, interface_name)"},{"line_number":67,"context_line":"            return super(DvrEdgeHaRouter, self).add_centralized_floatingip("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_88c16683","line":64,"updated":"2017-09-13 16:54:50.000000000","message":"The three lines above should just be under the master check since there\u0027s no need to do work otherwise.  Or just change code to check !master and return early.","commit_id":"d171a0856e80c232881b3552bff0c05720026561"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5caeb69d2f44a2b351e77dcfc41b723e0fa86d9e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"},{"line_number":61,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":62,"context_line":"            self.get_ex_gw_port())"},{"line_number":63,"context_line":"        if self.is_router_master():"},{"line_number":64,"context_line":"            self._add_vip(fip_cidr, interface_name)"},{"line_number":65,"context_line":"            return super(DvrEdgeHaRouter, self).add_centralized_floatingip("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_b909082d","line":62,"updated":"2017-09-14 05:37:30.000000000","message":"Can you move this under the \u0027if\u0027 as well?  Otherwise interface_name isn\u0027t used.","commit_id":"5b5c70bfb83c14fe1c05258f9073b566ca311ee1"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"ad3ef5e736c022dc414792e367de9ffd563154eb","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def add_centralized_floatingip(self, fip, fip_cidr):"},{"line_number":61,"context_line":"        interface_name \u003d self.get_snat_external_device_interface_name("},{"line_number":62,"context_line":"            self.get_ex_gw_port())"},{"line_number":63,"context_line":"        if self.is_router_master():"},{"line_number":64,"context_line":"            self._add_vip(fip_cidr, interface_name)"},{"line_number":65,"context_line":"            return super(DvrEdgeHaRouter, self).add_centralized_floatingip("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_f1c440f7","line":62,"in_reply_to":"5f2577a7_b909082d","updated":"2017-10-05 15:13:19.000000000","message":"Sure will add it.","commit_id":"5b5c70bfb83c14fe1c05258f9073b566ca311ee1"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19cb726ff2f3f7fa9307ba42f83071b5fffc396a","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"            (r_info,"},{"line_number":1143,"context_line":"             mocked_r_ns_name,"},{"line_number":1144,"context_line":"             mocked_r_snat_ns_name) \u003d self._mocked_dvr_ha_router("},{"line_number":1145,"context_line":"                 agent, enable_gw, enable_cent_fip)"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        get_ns_name.return_value \u003d mocked_r_ns_name"},{"line_number":1148,"context_line":"        get_snat_ns_name.return_value \u003d mocked_r_snat_ns_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_69f18095","line":1145,"updated":"2017-09-20 20:02:11.000000000","message":"I think this can be done better by just having callers pass snat_bound_fip, let me try and hack it up a bit.","commit_id":"74f9dedd9092f7f7891cf01243f67b031a41d236"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"19cb726ff2f3f7fa9307ba42f83071b5fffc396a","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"        snat_ports \u003d router.get_snat_interfaces()"},{"line_number":1156,"context_line":"        if not snat_ports:"},{"line_number":1157,"context_line":"            return"},{"line_number":1158,"context_line":"        if router.is_router_master:"},{"line_number":1159,"context_line":"            centralized_floatingips \u003d ("},{"line_number":1160,"context_line":"                router.router[lib_constants.FLOATINGIP_KEY])"},{"line_number":1161,"context_line":"            for fip in centralized_floatingips:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f2577a7_4971240c","line":1158,"updated":"2017-09-20 20:02:11.000000000","message":"need () here right?","commit_id":"74f9dedd9092f7f7891cf01243f67b031a41d236"}]}