)]}'
{"neutron/tests/tempest/scenario/test_security_groups.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"027c0bc7c85adc94fa36460269d2cc2d351cd935","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        router \u003d cls.create_router_by_client()"},{"line_number":39,"context_line":"        cls.create_router_interface(router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":40,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":41,"context_line":"        cls.secgroup1 \u003d cls.os_primary.network_client.create_security_group("},{"line_number":42,"context_line":"            name\u003d\u0027secgroup_1\u0027)"},{"line_number":43,"context_line":"        cls.create_loginable_secgroup_rule("},{"line_number":44,"context_line":"            secgroup_id\u003dcls.secgroup1[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_09ebadb0","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":21},"updated":"2017-09-21 20:21:21.000000000","message":"please use meaningful names, f.e. cls.ssh_secgroup and cls.icmp_secgroup","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        router \u003d cls.create_router_by_client()"},{"line_number":39,"context_line":"        cls.create_router_interface(router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":40,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":41,"context_line":"        cls.secgroup1 \u003d cls.os_primary.network_client.create_security_group("},{"line_number":42,"context_line":"            name\u003d\u0027secgroup_1\u0027)"},{"line_number":43,"context_line":"        cls.create_loginable_secgroup_rule("},{"line_number":44,"context_line":"            secgroup_id\u003dcls.secgroup1[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_6e91ca99","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":21},"in_reply_to":"7f515b1d_09ebadb0","updated":"2017-09-25 12:53:45.000000000","message":"Done","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"027c0bc7c85adc94fa36460269d2cc2d351cd935","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        cls.create_router_interface(router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":40,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":41,"context_line":"        cls.secgroup1 \u003d cls.os_primary.network_client.create_security_group("},{"line_number":42,"context_line":"            name\u003d\u0027secgroup_1\u0027)"},{"line_number":43,"context_line":"        cls.create_loginable_secgroup_rule("},{"line_number":44,"context_line":"            secgroup_id\u003dcls.secgroup1[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":45,"context_line":"        cls.secgroup2 \u003d cls.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_a9d93923","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":28},"updated":"2017-09-21 20:21:21.000000000","message":"here too","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        cls.create_router_interface(router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":40,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":41,"context_line":"        cls.secgroup1 \u003d cls.os_primary.network_client.create_security_group("},{"line_number":42,"context_line":"            name\u003d\u0027secgroup_1\u0027)"},{"line_number":43,"context_line":"        cls.create_loginable_secgroup_rule("},{"line_number":44,"context_line":"            secgroup_id\u003dcls.secgroup1[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":45,"context_line":"        cls.secgroup2 \u003d cls.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_6eb667fd","line":42,"range":{"start_line":42,"start_character":18,"end_line":42,"end_character":28},"in_reply_to":"7f515b1d_a9d93923","updated":"2017-09-25 12:53:45.000000000","message":"Done","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"027c0bc7c85adc94fa36460269d2cc2d351cd935","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            name\u003d\u0027secgroup_2\u0027)"},{"line_number":47,"context_line":"        cls.create_pingable_secgroup_rule("},{"line_number":48,"context_line":"            secgroup_id\u003dcls.secgroup2[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":49,"context_line":"        for sec_grp in (cls.secgroup1, cls.secgroup2):"},{"line_number":50,"context_line":"            cls.security_groups.append(sec_grp[\u0027security_group\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create_vm_default_sec_grp(self, num_servers\u003d2, security_groups\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_891d5dbf","line":49,"updated":"2017-09-21 20:21:21.000000000","message":"if those groups are needed for a single test case, consider moving their creation into the test case.","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            name\u003d\u0027secgroup_2\u0027)"},{"line_number":47,"context_line":"        cls.create_pingable_secgroup_rule("},{"line_number":48,"context_line":"            secgroup_id\u003dcls.secgroup2[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":49,"context_line":"        for sec_grp in (cls.secgroup1, cls.secgroup2):"},{"line_number":50,"context_line":"            cls.security_groups.append(sec_grp[\u0027security_group\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create_vm_default_sec_grp(self, num_servers\u003d2, security_groups\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_510c6e3a","line":49,"in_reply_to":"7f515b1d_891d5dbf","updated":"2017-09-25 12:53:45.000000000","message":"I think ssh is always needed as I need to connect to the first VM somehow, but ICMP indeed makes sense to move to the specific test. What do you think?","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"027c0bc7c85adc94fa36460269d2cc2d351cd935","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        for sec_grp in (cls.secgroup1, cls.secgroup2):"},{"line_number":50,"context_line":"            cls.security_groups.append(sec_grp[\u0027security_group\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create_vm_default_sec_grp(self, num_servers\u003d2, security_groups\u003dNone):"},{"line_number":53,"context_line":"        servers, fips, server_ssh_clients \u003d ([], [], [])"},{"line_number":54,"context_line":"        for i in range(num_servers):"},{"line_number":55,"context_line":"            servers.append(self.create_server("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_c9235505","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":25},"updated":"2017-09-21 20:21:21.000000000","message":"I guess the name of the method doesn\u0027t reflect all its use cases anymore, because when you pass security_groups\u003d argument, it doesn\u0027t use default security group for the instance","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        for sec_grp in (cls.secgroup1, cls.secgroup2):"},{"line_number":50,"context_line":"            cls.security_groups.append(sec_grp[\u0027security_group\u0027])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create_vm_default_sec_grp(self, num_servers\u003d2, security_groups\u003dNone):"},{"line_number":53,"context_line":"        servers, fips, server_ssh_clients \u003d ([], [], [])"},{"line_number":54,"context_line":"        for i in range(num_servers):"},{"line_number":55,"context_line":"            servers.append(self.create_server("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_ce99db79","line":52,"range":{"start_line":52,"start_character":18,"end_line":52,"end_character":25},"in_reply_to":"7f515b1d_c9235505","updated":"2017-09-25 12:53:45.000000000","message":"Done","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d37cb3891dd8c0cdd8f67ce25cf050beffaac72e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsecgroup_id)"},{"line_number":119,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d964\u0027)"},{"line_number":122,"context_line":"    def test_several_sec_groups(self):"},{"line_number":123,"context_line":"        # add 2 sec groups to VM and test rules of both are working"},{"line_number":124,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027secgroup_1\u0027}, {\u0027name\u0027: \u0027secgroup_2\u0027}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_bb03b80f","line":121,"updated":"2017-09-19 13:56:34.000000000","message":"Looks like the same Id as L106.","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3670d9a79ea3f0ed1887f196d57739c52d7b0afd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsecgroup_id)"},{"line_number":119,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d964\u0027)"},{"line_number":122,"context_line":"    def test_several_sec_groups(self):"},{"line_number":123,"context_line":"        # add 2 sec groups to VM and test rules of both are working"},{"line_number":124,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027secgroup_1\u0027}, {\u0027name\u0027: \u0027secgroup_2\u0027}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_9b50f134","line":121,"in_reply_to":"ff5d4b2f_5ba39950","updated":"2017-09-19 15:09:32.000000000","message":"L106 ends with 864 while this with 964, so I guess pep8 is fine :) Although it would be nice to generate a new uuid instead of copying and replacing one number.","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsecgroup_id)"},{"line_number":119,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d964\u0027)"},{"line_number":122,"context_line":"    def test_several_sec_groups(self):"},{"line_number":123,"context_line":"        # add 2 sec groups to VM and test rules of both are working"},{"line_number":124,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027secgroup_1\u0027}, {\u0027name\u0027: \u0027secgroup_2\u0027}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_b3972d91","line":121,"in_reply_to":"ff5d4b2f_9b50f134","updated":"2017-09-25 12:53:45.000000000","message":"Why? If those are different numbers who cares how they were generated","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8381f4513db952df3e30daf1144b73558bd8159e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.create_secgroup_rules(rule_list, secgroup_id\u003dsecgroup_id)"},{"line_number":119,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d964\u0027)"},{"line_number":122,"context_line":"    def test_several_sec_groups(self):"},{"line_number":123,"context_line":"        # add 2 sec groups to VM and test rules of both are working"},{"line_number":124,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027secgroup_1\u0027}, {\u0027name\u0027: \u0027secgroup_2\u0027}]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_5ba39950","line":121,"in_reply_to":"ff5d4b2f_bb03b80f","updated":"2017-09-19 15:07:05.000000000","message":"pep8 job should be able to catch this. Something must be wrong with it then.","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"027c0bc7c85adc94fa36460269d2cc2d351cd935","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d964\u0027)"},{"line_number":122,"context_line":"    def test_several_sec_groups(self):"},{"line_number":123,"context_line":"        # add 2 sec groups to VM and test rules of both are working"},{"line_number":124,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027secgroup_1\u0027}, {\u0027name\u0027: \u0027secgroup_2\u0027}]"},{"line_number":125,"context_line":"        server_ssh_clients, fips, servers \u003d self.create_vm_default_sec_grp("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_a9f25999","line":122,"range":{"start_line":122,"start_character":13,"end_line":122,"end_character":20},"updated":"2017-09-21 20:21:21.000000000","message":"two","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @decorators.idempotent_id(\u00273d73ec1a-2ec6-45a9-b0f8-04a283d9d964\u0027)"},{"line_number":122,"context_line":"    def test_several_sec_groups(self):"},{"line_number":123,"context_line":"        # add 2 sec groups to VM and test rules of both are working"},{"line_number":124,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027secgroup_1\u0027}, {\u0027name\u0027: \u0027secgroup_2\u0027}]"},{"line_number":125,"context_line":"        server_ssh_clients, fips, servers \u003d self.create_vm_default_sec_grp("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_2e7e2f19","line":122,"range":{"start_line":122,"start_character":13,"end_line":122,"end_character":20},"in_reply_to":"7f515b1d_a9f25999","updated":"2017-09-25 12:53:45.000000000","message":"Done","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"027c0bc7c85adc94fa36460269d2cc2d351cd935","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        # make sure ICMP connectivity works"},{"line_number":132,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":133,"context_line":"                             should_succeed\u003dTrue)"},{"line_number":134,"context_line":"        port_id \u003d self.client.list_ports(device_id\u003dservers[0][\u0027server\u0027][\u0027id\u0027])["},{"line_number":135,"context_line":"            \u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.os_admin.network_client.update_port("},{"line_number":138,"context_line":"            port_id, security_groups\u003d[self.secgroup1[\u0027security_group\u0027][\u0027id\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_a975b9fc","line":135,"range":{"start_line":134,"start_character":78,"end_line":135,"end_character":29},"updated":"2017-09-21 20:21:21.000000000","message":"consider using two statements for this:\n\nports \u003d list_ports(...)\nport_id \u003d ports[....]\n\nit will be a bit easier to read","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        # make sure ICMP connectivity works"},{"line_number":132,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":133,"context_line":"                             should_succeed\u003dTrue)"},{"line_number":134,"context_line":"        port_id \u003d self.client.list_ports(device_id\u003dservers[0][\u0027server\u0027][\u0027id\u0027])["},{"line_number":135,"context_line":"            \u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.os_admin.network_client.update_port("},{"line_number":138,"context_line":"            port_id, security_groups\u003d[self.secgroup1[\u0027security_group\u0027][\u0027id\u0027]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_4ed4cbbd","line":135,"range":{"start_line":134,"start_character":78,"end_line":135,"end_character":29},"in_reply_to":"7f515b1d_a975b9fc","updated":"2017-09-25 12:53:45.000000000","message":"Done","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d37cb3891dd8c0cdd8f67ce25cf050beffaac72e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        port_id \u003d self.client.list_ports(device_id\u003dservers[0][\u0027server\u0027][\u0027id\u0027])["},{"line_number":135,"context_line":"            \u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.os_admin.network_client.update_port("},{"line_number":138,"context_line":"            port_id, security_groups\u003d[self.secgroup1[\u0027security_group\u0027][\u0027id\u0027]])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # make sure ssh connectivity works"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_b6462d4f","line":137,"range":{"start_line":137,"start_character":13,"end_line":137,"end_character":21},"updated":"2017-09-19 13:56:34.000000000","message":"Can\u0027t this be os_primary?  Shouldn\u0027t need to be admin to update this.","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        port_id \u003d self.client.list_ports(device_id\u003dservers[0][\u0027server\u0027][\u0027id\u0027])["},{"line_number":135,"context_line":"            \u0027ports\u0027][0][\u0027id\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.os_admin.network_client.update_port("},{"line_number":138,"context_line":"            port_id, security_groups\u003d[self.secgroup1[\u0027security_group\u0027][\u0027id\u0027]])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        # make sure ssh connectivity works"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_6eeae775","line":137,"range":{"start_line":137,"start_character":13,"end_line":137,"end_character":21},"in_reply_to":"ff5d4b2f_b6462d4f","updated":"2017-09-25 12:53:45.000000000","message":"Done","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d37cb3891dd8c0cdd8f67ce25cf050beffaac72e","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # make sure ICMP connectivity doesn\u0027t work"},{"line_number":146,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":147,"context_line":"                             should_succeed\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_969a09c3","line":147,"updated":"2017-09-19 13:56:34.000000000","message":"Guess if you went this far can update the port to use secgroup2 and make sure ping works, ssh doesn\u0027t.","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"69189541aff2421c89da00e5f42e79b69a73e299","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        # make sure ICMP connectivity doesn\u0027t work"},{"line_number":146,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":147,"context_line":"                             should_succeed\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_2e0e2f3b","line":147,"in_reply_to":"ff5d4b2f_969a09c3","updated":"2017-09-25 12:53:45.000000000","message":"At the moment ssh connectivity check doesn\u0027t support negative scenario, I can use exception to test it, but it will waste some test time, is it necessary for this case, or I can update according to you request and test only that only ICMP works?","commit_id":"4c3faeb7106905f36bd6dbaafb26b18959a51fbc"}]}