)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66b7698ace43cee2a11aaf5aa4d3a5ef23bcc1db","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-09-19 14:58:39 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing create_secgroup_rules in scenario tests base"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current code is changing the rule_list parameter."},{"line_number":10,"context_line":"The method now return the list of created rules"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I95a83adca6c2005bfad6987b94578b551d3672e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff5d4b2f_453f39d6","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":53},"updated":"2017-09-19 13:03:11.000000000","message":"I agree with this point. It is better to keep the original list.","commit_id":"93eebd693b2edfaada8bbd9f196b00a5e4eaed7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66b7698ace43cee2a11aaf5aa4d3a5ef23bcc1db","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixing create_secgroup_rules in scenario tests base"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current code is changing the rule_list parameter."},{"line_number":10,"context_line":"The method now return the list of created rules"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I95a83adca6c2005bfad6987b94578b551d3672e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff5d4b2f_a5303509","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":47},"updated":"2017-09-19 13:03:11.000000000","message":"Why is this change needed? It would be nice if some more context is provided.","commit_id":"93eebd693b2edfaada8bbd9f196b00a5e4eaed7a"}],"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66b7698ace43cee2a11aaf5aa4d3a5ef23bcc1db","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    break"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for rule in rule_list_dict:"},{"line_number":114,"context_line":"            direction \u003d rule.pop(\u0027direction\u0027)"},{"line_number":115,"context_line":"            rule_list_result.append(client.create_security_group_rule("},{"line_number":116,"context_line":"                direction\u003ddirection,"},{"line_number":117,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_a04ca376","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":45},"updated":"2017-09-19 13:03:11.000000000","message":"This means \u0027direction\u0027 key must exist in \u0027rule\u0027 dict and there seems no need to use pop() here. We can change the call below to:\n\n  client.create_security_group_rule(\n    security_group_id\u003dsecgroup_id, **rule)","commit_id":"93eebd693b2edfaada8bbd9f196b00a5e4eaed7a"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"1c9d2f7fdb61a3e170c63852a42df94ff090642d","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    break"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        for rule in rule_list_dict:"},{"line_number":114,"context_line":"            direction \u003d rule.pop(\u0027direction\u0027)"},{"line_number":115,"context_line":"            rule_list_result.append(client.create_security_group_rule("},{"line_number":116,"context_line":"                direction\u003ddirection,"},{"line_number":117,"context_line":"                security_group_id\u003dsecgroup_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_b8402c37","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":45},"in_reply_to":"ff5d4b2f_a04ca376","updated":"2017-09-25 09:05:46.000000000","message":"The direction is mandatory (https://developer.openstack.org/api-ref/network/v2/)","commit_id":"93eebd693b2edfaada8bbd9f196b00a5e4eaed7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66b7698ace43cee2a11aaf5aa4d3a5ef23bcc1db","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                direction\u003ddirection,"},{"line_number":117,"context_line":"                security_group_id\u003dsecgroup_id,"},{"line_number":118,"context_line":"                **rule))"},{"line_number":119,"context_line":"        return rule_list_result"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"},{"line_number":122,"context_line":"    def create_loginable_secgroup_rule(cls, secgroup_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff5d4b2f_a0fee302","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":31},"updated":"2017-09-19 13:03:11.000000000","message":"Who uses the returned value? Do we need it? If it plans to be used in a follow-up patch, it is better to mention it.","commit_id":"93eebd693b2edfaada8bbd9f196b00a5e4eaed7a"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"1c9d2f7fdb61a3e170c63852a42df94ff090642d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                direction\u003ddirection,"},{"line_number":117,"context_line":"                security_group_id\u003dsecgroup_id,"},{"line_number":118,"context_line":"                **rule))"},{"line_number":119,"context_line":"        return rule_list_result"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @classmethod"},{"line_number":122,"context_line":"    def create_loginable_secgroup_rule(cls, secgroup_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_d8a9a8df","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":31},"in_reply_to":"ff5d4b2f_a0fee302","updated":"2017-09-25 09:05:46.000000000","message":"Yes. A follow up patch will use it.","commit_id":"93eebd693b2edfaada8bbd9f196b00a5e4eaed7a"}]}