)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"baebc064d83556d7a24a8f5a7d8ca3dd42fcbdf7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ml2: fix update_device_up to send lm events with linux bridge"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of a live migration and with linux bridge the events are not"},{"line_number":10,"context_line":"send to Nova that because the port UUID returned by _device_to_port_id"},{"line_number":11,"context_line":"may be a truncated UUID and the current plugin._get_port() can\u0027t find"},{"line_number":12,"context_line":"it."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f515b1d_e29db857","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":25},"updated":"2017-09-25 21:16:03.000000000","message":"This is difficult to read. I suggest:\n\nsent to Nova, because","commit_id":"1bfdacee9b216638ec807ccc1ff2b2587461d089"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"baebc064d83556d7a24a8f5a7d8ca3dd42fcbdf7","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            # need to notify nova explicitly"},{"line_number":255,"context_line":"            port \u003d ml2_db.get_port(rpc_context, port_id)"},{"line_number":256,"context_line":"            # _device_to_port_id may have returned a truncated UUID if the"},{"line_number":257,"context_line":"            # agent did not provide a full one (e.g. Linux Bridge case). We"},{"line_number":258,"context_line":"            # need to look up the full one before calling provisioning_complete"},{"line_number":259,"context_line":"            if not port:"},{"line_number":260,"context_line":"                LOG.debug(\"Port %s not found, will not notify nova.\", port_id)"},{"line_number":261,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_6231c8a2","line":258,"range":{"start_line":257,"start_character":73,"end_line":258,"end_character":79},"updated":"2017-09-25 21:16:03.000000000","message":"This comment is misleading. We are not looking up a full UUID. We are retrieving the port from the DB using a potentially truncated uuid: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/db.py#L163. The comment should indicate that","commit_id":"1bfdacee9b216638ec807ccc1ff2b2587461d089"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bec8f99b6fe9fcbc6bd34d56aef0047811514616","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            # need to notify nova explicitly"},{"line_number":255,"context_line":"            port \u003d ml2_db.get_port(rpc_context, port_id)"},{"line_number":256,"context_line":"            # _device_to_port_id may have returned a truncated UUID if the"},{"line_number":257,"context_line":"            # agent did not provide a full one (e.g. Linux Bridge case). We"},{"line_number":258,"context_line":"            # need to look up the full one before calling provisioning_complete"},{"line_number":259,"context_line":"            if not port:"},{"line_number":260,"context_line":"                LOG.debug(\"Port %s not found, will not notify nova.\", port_id)"},{"line_number":261,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_a830b6e9","line":258,"range":{"start_line":257,"start_character":73,"end_line":258,"end_character":79},"in_reply_to":"7f515b1d_6231c8a2","updated":"2017-09-26 06:41:52.000000000","message":"Yes I reused comment line 283 which was added for a same kind of problem. But it does not seem right.","commit_id":"1bfdacee9b216638ec807ccc1ff2b2587461d089"}]}
