)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cb81296c97cb85cac2718fea6961554d65bb435","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbhaley@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-09 17:43:47 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change OVS agent to update skipped port status to DOWN"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the OVS agent skips processing a port because it was"},{"line_number":10,"context_line":"not found on the integration bridge, it doesn\u0027t send back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_ab3e0db5","line":7,"updated":"2017-10-25 18:56:44.000000000","message":"does it also affect linuxbridge agent?","commit_id":"a789d23b0242ae3b4c13856e96a72a3acc5a3697"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d4af681548ddd730e938a0b0863d4ec353bc3697","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"    def treat_devices_skipped(self, devices):"},{"line_number":1631,"context_line":"        LOG.info(\"Ports %s skipped, changing status to down\", devices)"},{"line_number":1632,"context_line":"        devices_down \u003d self.plugin_rpc.update_device_list(self.context,"},{"line_number":1633,"context_line":"                                                          [],"},{"line_number":1634,"context_line":"                                                          devices,"},{"line_number":1635,"context_line":"                                                          self.agent_id,"},{"line_number":1636,"context_line":"                                                          self.conf.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_592153fb","line":1633,"updated":"2017-09-22 20:52:19.000000000","message":"I think this will work, but please confirm that \u0027update_device_list\u0027 will ignore this request if the port is no longer bound to this agent. I want to make sure we don\u0027t set a port to DOWN that just got moved to another agent.","commit_id":"af912226e957826ced3898cfc64501b98c8fc901"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0b36a2917ff5bd888a231159b164880497ac13e7","unresolved":false,"context_lines":[{"line_number":1630,"context_line":"    def treat_devices_skipped(self, devices):"},{"line_number":1631,"context_line":"        LOG.info(\"Ports %s skipped, changing status to down\", devices)"},{"line_number":1632,"context_line":"        devices_down \u003d self.plugin_rpc.update_device_list(self.context,"},{"line_number":1633,"context_line":"                                                          [],"},{"line_number":1634,"context_line":"                                                          devices,"},{"line_number":1635,"context_line":"                                                          self.agent_id,"},{"line_number":1636,"context_line":"                                                          self.conf.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_64b8e229","line":1633,"in_reply_to":"7f515b1d_592153fb","updated":"2017-09-22 21:14:34.000000000","message":"Kevin, yes the server-side of update_device_list() checks the host in update_device_down() like this:\n\n        if (host and not plugin.port_bound_to_host(rpc_context,\n                                                   port_id, host)):\n            LOG.debug(\"Device %(device)s not bound to the\"\n                      \" agent host %(host)s\",\n                      {\u0027device\u0027: device, \u0027host\u0027: host})\n\nSo seems to do the right thing.\n\nBut like you said, this might not happen on Pike, I need to try there first, definitely happens on Ocata.","commit_id":"af912226e957826ced3898cfc64501b98c8fc901"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cb81296c97cb85cac2718fea6961554d65bb435","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"                                                          self.conf.host)"},{"line_number":1637,"context_line":"        failed_devices \u003d set(devices_down.get(\u0027failed_devices_down\u0027))"},{"line_number":1638,"context_line":"        if failed_devices:"},{"line_number":1639,"context_line":"            LOG.debug(\"Port down failed for %s\", failed_devices)"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"    def process_network_ports(self, port_info, ovs_restarted):"},{"line_number":1642,"context_line":"        failed_devices \u003d {\u0027added\u0027: set(), \u0027removed\u0027: set()}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_4b50b90b","line":1639,"updated":"2017-10-25 18:56:44.000000000","message":"I assume it\u0027s debug because the port may be gone.","commit_id":"a789d23b0242ae3b4c13856e96a72a3acc5a3697"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d2625880251fec7482e64f49c65f01244f2d39e7","unresolved":false,"context_lines":[{"line_number":1636,"context_line":"                                                          self.conf.host)"},{"line_number":1637,"context_line":"        failed_devices \u003d set(devices_down.get(\u0027failed_devices_down\u0027))"},{"line_number":1638,"context_line":"        if failed_devices:"},{"line_number":1639,"context_line":"            LOG.debug(\"Port down failed for %s\", failed_devices)"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"    def process_network_ports(self, port_info, ovs_restarted):"},{"line_number":1642,"context_line":"        failed_devices \u003d {\u0027added\u0027: set(), \u0027removed\u0027: set()}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_f6ace89f","line":1639,"in_reply_to":"3f4b6375_4b50b90b","updated":"2017-10-25 20:01:12.000000000","message":"Right, at least in the traces I saw the port was gone.","commit_id":"a789d23b0242ae3b4c13856e96a72a3acc5a3697"}]}
