)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5f3516db9551e22c424c291fb3bbdf0987eca4c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     venkata anil \u003canilvenkata@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-04 11:18:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor DVR HA migarations DB operations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when a router is migrated from/to HA, router interface device_owner"},{"line_number":10,"context_line":"in DB is updated in the AFTER_UPDATE event handler. Because of this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f515b1d_0aa81475","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":27},"updated":"2017-10-04 20:09:43.000000000","message":"guess if you re-spin should fix this typo","commit_id":"7910c3a1c090ed7a46a32b371ecf73157ddba88f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5f3516db9551e22c424c291fb3bbdf0987eca4c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor DVR HA migarations DB operations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when a router is migrated from/to HA, router interface device_owner"},{"line_number":10,"context_line":"in DB is updated in the AFTER_UPDATE event handler. Because of this"},{"line_number":11,"context_line":"we see StaleDataError Trace as described in the bug report."},{"line_number":12,"context_line":"Instead, we follow DVR approach and update it in PRECOMMIT_UPDATE"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f515b1d_aab0e0de","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2017-10-04 20:09:43.000000000","message":"nit: and make this When","commit_id":"7910c3a1c090ed7a46a32b371ecf73157ddba88f"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3eaeff3fb6c35ed2b0dac5cf8f00114eef451c90","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            context, router_db[\u0027id\u0027])[\u0027agents\u0027]"},{"line_number":148,"context_line":"        for agent in cur_agents:"},{"line_number":149,"context_line":"            self.l3plugin._unbind_router(context, router_db[\u0027id\u0027], agent[\u0027id\u0027])"},{"line_number":150,"context_line":"        self.l3plugin.set_extra_attr_value("},{"line_number":151,"context_line":"            context, router_db, \u0027distributed\u0027, migrating_to_distributed)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @registry.receives(resources.ROUTER, [events.AFTER_UPDATE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_fad93c82","line":150,"range":{"start_line":150,"start_character":3,"end_line":150,"end_character":43},"updated":"2017-10-03 05:52:13.000000000","message":"Is this change required for the pre-commit approach.\nAre it is just a refactor","commit_id":"ffa11b4dae54c08af40011a6db1ee7ed85dd1431"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"0eea59d3c587885a607f3558c46579992fecc657","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            context, router_db[\u0027id\u0027])[\u0027agents\u0027]"},{"line_number":148,"context_line":"        for agent in cur_agents:"},{"line_number":149,"context_line":"            self.l3plugin._unbind_router(context, router_db[\u0027id\u0027], agent[\u0027id\u0027])"},{"line_number":150,"context_line":"        self.l3plugin.set_extra_attr_value("},{"line_number":151,"context_line":"            context, router_db, \u0027distributed\u0027, migrating_to_distributed)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @registry.receives(resources.ROUTER, [events.AFTER_UPDATE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_318479b1","line":150,"range":{"start_line":150,"start_character":3,"end_line":150,"end_character":43},"in_reply_to":"7f515b1d_fad93c82","updated":"2017-10-04 10:16:16.000000000","message":"It is a needed refactor. \n\nAs you know  _handle_distributed_migration(),\n1) updates router interface owner\n2) then updates router_db.extra_attributes.distributed\n3) unbinds router from agent\nand as all of the above steps are db operations and if any db operation fails it will retry. For example if db operation fails at step 3, then retry is called again. But this time, inside _validate_router_migration() we have updated \"router_db.extra_attributes.distributed\". Because of this _validate_router_migration may return False, and step 3 never successfully executed.\n\nSo it is better to set \"distributed\" flag at the end. I will update the commit message to reflect this.","commit_id":"ffa11b4dae54c08af40011a6db1ee7ed85dd1431"}]}
