)]}'
{"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ad315cba4aa6ca95f9ebdc37b613a66f29b7692","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"                                L3SchedulerBaseMixin):"},{"line_number":1843,"context_line":"    \"\"\"Test cases to test get_l3_agents."},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"    5 l3 agents are registered in the order - legacy, dvr_snat, dvr, fake_mode"},{"line_number":1846,"context_line":"    and legacy"},{"line_number":1847,"context_line":"    \"\"\""},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":"    scenarios \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_1f3fc687","line":1846,"range":{"start_line":1845,"start_character":3,"end_line":1846,"end_character":14},"updated":"2017-09-27 18:33:36.000000000","message":"Add \u0027dvr_no_external\u0027 as well.","commit_id":"3ea8307af046db85466a499ec64b9e156ffb873d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"68024353ddd50d7ee0d5af060e324a49cd135d4a","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"                                L3SchedulerBaseMixin):"},{"line_number":1843,"context_line":"    \"\"\"Test cases to test get_l3_agents."},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"    5 l3 agents are registered in the order - legacy, dvr_snat, dvr, fake_mode"},{"line_number":1846,"context_line":"    and legacy"},{"line_number":1847,"context_line":"    \"\"\""},{"line_number":1848,"context_line":""},{"line_number":1849,"context_line":"    scenarios \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_d11e0873","line":1846,"range":{"start_line":1845,"start_character":3,"end_line":1846,"end_character":14},"in_reply_to":"7f515b1d_1f3fc687","updated":"2017-10-05 22:03:11.000000000","message":"Swami - thanks for all the suggestions, I\u0027ve addressed all your comments in a follow-on to not mix them in here.\n\nhttps://review.openstack.org/509914","commit_id":"3ea8307af046db85466a499ec64b9e156ffb873d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ad315cba4aa6ca95f9ebdc37b613a66f29b7692","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"            dict(agent_modes\u003d[\u0027dvr\u0027],"},{"line_number":1871,"context_line":"                 host\u003d[\u0027host_2\u0027],"},{"line_number":1872,"context_line":"                 expected_agent_modes\u003d[\u0027dvr\u0027],"},{"line_number":1873,"context_line":"                 expected_host\u003d[\u0027host_2\u0027])),"},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"        (\u0027legacy and dvr snat\u0027,"},{"line_number":1876,"context_line":"            dict(agent_modes\u003d[\u0027legacy\u0027, \u0027dvr_snat\u0027, \u0027legacy\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_bfc43292","line":1873,"updated":"2017-09-27 18:33:36.000000000","message":"Also here you can add \u0027dvr_no_external\u0027","commit_id":"3ea8307af046db85466a499ec64b9e156ffb873d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ad315cba4aa6ca95f9ebdc37b613a66f29b7692","unresolved":false,"context_lines":[{"line_number":1872,"context_line":"                 expected_agent_modes\u003d[\u0027dvr\u0027],"},{"line_number":1873,"context_line":"                 expected_host\u003d[\u0027host_2\u0027])),"},{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"        (\u0027legacy and dvr snat\u0027,"},{"line_number":1876,"context_line":"            dict(agent_modes\u003d[\u0027legacy\u0027, \u0027dvr_snat\u0027, \u0027legacy\u0027],"},{"line_number":1877,"context_line":"                 host\u003d[\u0027host_3\u0027],"},{"line_number":1878,"context_line":"                 expected_agent_modes\u003d[\u0027legacy\u0027, \u0027dvr_snat\u0027, \u0027legacy\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_7f8c7a7e","line":1875,"range":{"start_line":1875,"start_character":6,"end_line":1875,"end_character":31},"updated":"2017-09-27 18:33:36.000000000","message":"Do we need a combination of legacy and dvr_snat.\nWe either use \u0027dvr_snat\u0027 or \u0027legacy\u0027.\nIf legacy is used, then probably there is only other legacy agents and no mixture of dvr and legacy.","commit_id":"3ea8307af046db85466a499ec64b9e156ffb873d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ad315cba4aa6ca95f9ebdc37b613a66f29b7692","unresolved":false,"context_lines":[{"line_number":1878,"context_line":"                 expected_agent_modes\u003d[\u0027legacy\u0027, \u0027dvr_snat\u0027, \u0027legacy\u0027],"},{"line_number":1879,"context_line":"                 expected_host\u003d[\u0027host_3\u0027])),"},{"line_number":1880,"context_line":""},{"line_number":1881,"context_line":"        (\u0027legacy and dvr\u0027,"},{"line_number":1882,"context_line":"            dict(agent_modes\u003d[\u0027legacy\u0027, \u0027dvr\u0027],"},{"line_number":1883,"context_line":"                 host\u003d[\u0027host_3\u0027],"},{"line_number":1884,"context_line":"                 expected_agent_modes\u003d[\u0027legacy\u0027, \u0027dvr\u0027, \u0027legacy\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_1ff10602","line":1881,"range":{"start_line":1881,"start_character":6,"end_line":1881,"end_character":26},"updated":"2017-09-27 18:33:36.000000000","message":"Same applies to here.\nIt seems redundant.","commit_id":"3ea8307af046db85466a499ec64b9e156ffb873d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ad315cba4aa6ca95f9ebdc37b613a66f29b7692","unresolved":false,"context_lines":[{"line_number":1890,"context_line":"                 expected_agent_modes\u003d[\u0027dvr_snat\u0027, \u0027dvr\u0027],"},{"line_number":1891,"context_line":"                 expected_host\u003d[\u0027host_4\u0027])),"},{"line_number":1892,"context_line":""},{"line_number":1893,"context_line":"        (\u0027legacy, dvr_snat and dvr\u0027,"},{"line_number":1894,"context_line":"            dict(agent_modes\u003d[\u0027legacy\u0027, \u0027dvr_snat\u0027, \u0027dvr\u0027],"},{"line_number":1895,"context_line":"                 host\u003d[\u0027host_5\u0027],"},{"line_number":1896,"context_line":"                 expected_agent_modes\u003d[\u0027legacy\u0027, \u0027dvr_snat\u0027, \u0027dvr\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_7fe11a2a","line":1893,"range":{"start_line":1893,"start_character":8,"end_line":1893,"end_character":36},"updated":"2017-09-27 18:33:36.000000000","message":"Same here.","commit_id":"3ea8307af046db85466a499ec64b9e156ffb873d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ad315cba4aa6ca95f9ebdc37b613a66f29b7692","unresolved":false,"context_lines":[{"line_number":1896,"context_line":"                 expected_agent_modes\u003d[\u0027legacy\u0027, \u0027dvr_snat\u0027, \u0027dvr\u0027,"},{"line_number":1897,"context_line":"                                       \u0027legacy\u0027],"},{"line_number":1898,"context_line":"                 expected_host\u003d[\u0027host_5\u0027])),"},{"line_number":1899,"context_line":""},{"line_number":1900,"context_line":"        (\u0027invalid\u0027,"},{"line_number":1901,"context_line":"            dict(agent_modes\u003d[\u0027invalid\u0027],"},{"line_number":1902,"context_line":"                 host\u003d[\u0027host_invalid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_3fd9627e","line":1899,"updated":"2017-09-27 18:33:36.000000000","message":"Also you can include a combination of\n\u0027dvr_snat, dvr and dvr_no_external\u0027","commit_id":"3ea8307af046db85466a499ec64b9e156ffb873d"}]}