)]}'
{"neutron/db/vpn/vpn_db.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c2cbeff7041f26c8672ffcbddac0dc906a0f4b4f","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                if lifetime_info:"},{"line_number":505,"context_line":"                    if lifetime_info.get(\u0027units\u0027):"},{"line_number":506,"context_line":"                        ipsecp[\u0027lifetime_units\u0027] \u003d lifetime_info[\u0027units\u0027]"},{"line_number":507,"context_line":"                    if lifetime_info.get(\u0027value\u0027):"},{"line_number":508,"context_line":"                        ipsecp[\u0027lifetime_value\u0027] \u003d lifetime_info[\u0027value\u0027]"},{"line_number":509,"context_line":"                ipsecp_db.update(ipsecp)"},{"line_number":510,"context_line":"        return self._make_ipsecpolicy_dict(ipsecp_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fvf4%3D","line":507,"updated":"2013-10-10 12:50:58.000000000","message":"I am not sure why this patch fixes the reported bug. In the bug report, lifetime value is specified and lifetime dict has \"value\" field and I think lifetime_info[\u0027value\u0027] should be present here.","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1b82797511f9c009e135d76f16f544ecc2685260","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                if lifetime_info:"},{"line_number":505,"context_line":"                    if lifetime_info.get(\u0027units\u0027):"},{"line_number":506,"context_line":"                        ipsecp[\u0027lifetime_units\u0027] \u003d lifetime_info[\u0027units\u0027]"},{"line_number":507,"context_line":"                    if lifetime_info.get(\u0027value\u0027):"},{"line_number":508,"context_line":"                        ipsecp[\u0027lifetime_value\u0027] \u003d lifetime_info[\u0027value\u0027]"},{"line_number":509,"context_line":"                ipsecp_db.update(ipsecp)"},{"line_number":510,"context_line":"        return self._make_ipsecpolicy_dict(ipsecp_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fug8%3D","line":507,"in_reply_to":"AAAATH%2F%2Fu%2Bg%3D","updated":"2013-10-10 16:20:48.000000000","message":"Thanks Paul for clarifying the past discussion.\n\nWhat in my mind is just to change key_specs and make \u0027value\u0027 a required field. I think empty lifetime is still valid.\n\nAnyway it looks okay. Thanks for the clarification.","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"2c53ad444f739726030cfe4f3e8da983f777cc9f","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                if lifetime_info:"},{"line_number":505,"context_line":"                    if lifetime_info.get(\u0027units\u0027):"},{"line_number":506,"context_line":"                        ipsecp[\u0027lifetime_units\u0027] \u003d lifetime_info[\u0027units\u0027]"},{"line_number":507,"context_line":"                    if lifetime_info.get(\u0027value\u0027):"},{"line_number":508,"context_line":"                        ipsecp[\u0027lifetime_value\u0027] \u003d lifetime_info[\u0027value\u0027]"},{"line_number":509,"context_line":"                ipsecp_db.update(ipsecp)"},{"line_number":510,"context_line":"        return self._make_ipsecpolicy_dict(ipsecp_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fu%2Bg%3D","line":507,"in_reply_to":"AAAATH%2F%2FvbU%3D","updated":"2013-10-10 14:46:41.000000000","message":"Although I agree with you, the decision was made to allow units and value to provided independently.","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"80d556d4b03f0632a06be048ee2e2f917dfa71a1","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                if lifetime_info:"},{"line_number":505,"context_line":"                    if lifetime_info.get(\u0027units\u0027):"},{"line_number":506,"context_line":"                        ipsecp[\u0027lifetime_units\u0027] \u003d lifetime_info[\u0027units\u0027]"},{"line_number":507,"context_line":"                    if lifetime_info.get(\u0027value\u0027):"},{"line_number":508,"context_line":"                        ipsecp[\u0027lifetime_value\u0027] \u003d lifetime_info[\u0027value\u0027]"},{"line_number":509,"context_line":"                ipsecp_db.update(ipsecp)"},{"line_number":510,"context_line":"        return self._make_ipsecpolicy_dict(ipsecp_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FvSU%3D","line":507,"in_reply_to":"AAAATH%2F%2FvbU%3D","updated":"2013-10-10 13:36:08.000000000","message":"are you thinking about changing lifetime validation from type:dict_or_empty to type:dict?","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e7dff7a5ab8a8c2b41594676c233d6ec70abf8c3","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                if lifetime_info:"},{"line_number":505,"context_line":"                    if lifetime_info.get(\u0027units\u0027):"},{"line_number":506,"context_line":"                        ipsecp[\u0027lifetime_units\u0027] \u003d lifetime_info[\u0027units\u0027]"},{"line_number":507,"context_line":"                    if lifetime_info.get(\u0027value\u0027):"},{"line_number":508,"context_line":"                        ipsecp[\u0027lifetime_value\u0027] \u003d lifetime_info[\u0027value\u0027]"},{"line_number":509,"context_line":"                ipsecp_db.update(ipsecp)"},{"line_number":510,"context_line":"        return self._make_ipsecpolicy_dict(ipsecp_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FvbU%3D","line":507,"in_reply_to":"AAAATH%2F%2Fve0%3D","updated":"2013-10-10 13:06:09.000000000","message":"Ah... if so it sounds reasonable.\n\nIt may not be a scope of this patch, IMO I don\u0027t think there is a case where only a unit is changed and a value is not specified. It seems better to make both fields mandatory if lifetime is specified.\n\nWhat do you think?","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"82489b444b4e7a6f05452b4ebb0b5f1bf65882f1","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                if lifetime_info:"},{"line_number":505,"context_line":"                    if lifetime_info.get(\u0027units\u0027):"},{"line_number":506,"context_line":"                        ipsecp[\u0027lifetime_units\u0027] \u003d lifetime_info[\u0027units\u0027]"},{"line_number":507,"context_line":"                    if lifetime_info.get(\u0027value\u0027):"},{"line_number":508,"context_line":"                        ipsecp[\u0027lifetime_value\u0027] \u003d lifetime_info[\u0027value\u0027]"},{"line_number":509,"context_line":"                ipsecp_db.update(ipsecp)"},{"line_number":510,"context_line":"        return self._make_ipsecpolicy_dict(ipsecp_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fve0%3D","line":507,"in_reply_to":"AAAATH%2F%2Fvf4%3D","updated":"2013-10-10 12:54:26.000000000","message":"right, but there was a typo, I believe; instead of lifetime_info[\u0027value\u0027] it was lifetime_info(\u0027value\u0027)","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"}],"neutron/tests/unit/db/vpn/test_db_vpnaas.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"2c53ad444f739726030cfe4f3e8da983f777cc9f","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                                     ikepolicy3),"},{"line_number":506,"context_line":"                                                    (\u0027name\u0027, \u0027asc\u0027), 2, 2,"},{"line_number":507,"context_line":"                                                    \u0027ikepolicies\u0027)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_update_ikepolicy(self):"},{"line_number":510,"context_line":"        \"\"\"Test case to update an ikepolicy.\"\"\""},{"line_number":511,"context_line":"        name \u003d \"new_ikepolicy1\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fu%2BA%3D","line":508,"updated":"2013-10-10 14:46:41.000000000","message":"Since IKE policy has same fields as IPSec policy, please add in test cases here too for lifetime changes.","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"91468c03afda07e804049a5d2c0f897c1f2949c8","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                                     ikepolicy3),"},{"line_number":506,"context_line":"                                                    (\u0027name\u0027, \u0027asc\u0027), 2, 2,"},{"line_number":507,"context_line":"                                                    \u0027ikepolicies\u0027)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_update_ikepolicy(self):"},{"line_number":510,"context_line":"        \"\"\"Test case to update an ikepolicy.\"\"\""},{"line_number":511,"context_line":"        name \u003d \"new_ikepolicy1\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Ft24%3D","line":508,"in_reply_to":"AAAATH%2F%2Fu%2BA%3D","updated":"2013-10-10 19:23:24.000000000","message":"Done","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"2c53ad444f739726030cfe4f3e8da983f777cc9f","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                                                    (\u0027name\u0027, \u0027asc\u0027), 2, 2,"},{"line_number":691,"context_line":"                                                    \u0027ipsecpolicies\u0027)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def test_update_ipsecpolicy(self):"},{"line_number":694,"context_line":"        \"\"\"Test case to update an ipsecpolicy.\"\"\""},{"line_number":695,"context_line":"        name \u003d \"new_ipsecpolicy1\""},{"line_number":696,"context_line":"        keys \u003d [(\u0027name\u0027, name),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Fu%2BQ%3D","line":693,"updated":"2013-10-10 14:46:41.000000000","message":"Please add a test case for changing just units, and one just changing value.","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"91468c03afda07e804049a5d2c0f897c1f2949c8","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                                                    (\u0027name\u0027, \u0027asc\u0027), 2, 2,"},{"line_number":691,"context_line":"                                                    \u0027ipsecpolicies\u0027)"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def test_update_ipsecpolicy(self):"},{"line_number":694,"context_line":"        \"\"\"Test case to update an ipsecpolicy.\"\"\""},{"line_number":695,"context_line":"        name \u003d \"new_ipsecpolicy1\""},{"line_number":696,"context_line":"        keys \u003d [(\u0027name\u0027, name),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2Ft20%3D","line":693,"in_reply_to":"AAAATH%2F%2Fu%2BQ%3D","updated":"2013-10-10 19:23:24.000000000","message":"Done","commit_id":"227a7078362125a6d99bcf21d9cbbab0cda6482e"}]}
