)]}'
{"neutron/agent/linux/openvswitch_firewall/iptables.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cc6c9809ee68a1c82a6ff75107a8864b6f442c0b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    table. Specifically it checks for other_config[\u0027iptables_cleaned\u0027] boolean"},{"line_number":44,"context_line":"    value."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    HYBRID_PORT_PREFIX \u003d \u0027qvo\u0027"},{"line_number":47,"context_line":"    CLEANED_METADATA \u003d \u0027iptables_cleaned\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __init__(self, int_br):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_e82a62e5","line":46,"updated":"2017-10-11 02:28:42.000000000","message":"nit: could be file scope and used on L20","commit_id":"9d74de162a2dd7bf5c2df59ccf9ff812f8e46387"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cc6c9809ee68a1c82a6ff75107a8864b6f442c0b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # TODO(jlibosva): Make it a single transaction"},{"line_number":92,"context_line":"        other_config \u003d self.int_br.db_get_val("},{"line_number":93,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027)"},{"line_number":94,"context_line":"        other_config[self.CLEANED_METADATA] \u003d \u0027true\u0027"},{"line_number":95,"context_line":"        self.int_br.set_db_attribute("},{"line_number":96,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027, other_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_48f61692","line":94,"updated":"2017-10-11 02:28:42.000000000","message":"I know there\u0027s something I don\u0027t know about why this isn\u0027t True","commit_id":"9d74de162a2dd7bf5c2df59ccf9ff812f8e46387"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"28f2de26c24eb30486e13aa5cea2e9bfc5e3e7cd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # TODO(jlibosva): Make it a single transaction"},{"line_number":92,"context_line":"        other_config \u003d self.int_br.db_get_val("},{"line_number":93,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027)"},{"line_number":94,"context_line":"        other_config[self.CLEANED_METADATA] \u003d \u0027true\u0027"},{"line_number":95,"context_line":"        self.int_br.set_db_attribute("},{"line_number":96,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027, other_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_bdf5c5cd","line":94,"in_reply_to":"5f4e5783_48f61692","updated":"2017-10-11 07:46:52.000000000","message":"I need to check how True is translated when storing to ovsdb and if we can use boolean type here. I had a feeling when using map type, all items inside are just strings.","commit_id":"9d74de162a2dd7bf5c2df59ccf9ff812f8e46387"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"616b36b14beffba62d8b12452c0958b41fd98ba3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # TODO(jlibosva): Make it a single transaction"},{"line_number":92,"context_line":"        other_config \u003d self.int_br.db_get_val("},{"line_number":93,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027)"},{"line_number":94,"context_line":"        other_config[self.CLEANED_METADATA] \u003d \u0027true\u0027"},{"line_number":95,"context_line":"        self.int_br.set_db_attribute("},{"line_number":96,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027, other_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_e04a6d7e","line":94,"in_reply_to":"5f4e5783_bdf5c5cd","updated":"2017-10-11 11:42:52.000000000","message":"Definition of the column specifies both key and value as strings: https://github.com/openvswitch/ovs/blob/master/vswitchd/vswitch.ovsschema#L117-L118\n\nWe could create some translation layer in ovs_lib or ovsdbapp that would make some type basic translation, so we could use common Python types.","commit_id":"9d74de162a2dd7bf5c2df59ccf9ff812f8e46387"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cef3f082b2eaa677e5122e677429d6bcc119cddb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # TODO(jlibosva): Make it a single transaction"},{"line_number":92,"context_line":"        other_config \u003d self.int_br.db_get_val("},{"line_number":93,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027)"},{"line_number":94,"context_line":"        other_config[self.CLEANED_METADATA] \u003d \u0027true\u0027"},{"line_number":95,"context_line":"        self.int_br.set_db_attribute("},{"line_number":96,"context_line":"            \u0027Bridge\u0027, self.int_br.br_name, \u0027other_config\u0027, other_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_b0d39e38","line":94,"in_reply_to":"5f4e5783_e04a6d7e","updated":"2017-10-11 16:05:50.000000000","message":"Well that seems like overkill to me.","commit_id":"9d74de162a2dd7bf5c2df59ccf9ff812f8e46387"}]}
