)]}'
{"neutron/tests/unit/agent/metadata/test_driver.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"997af6a06acf7783ec280d819c4b843cce2b231f","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_metadata_nat_rules(self):"},{"line_number":41,"context_line":"        rules \u003d (\u0027PREROUTING\u0027, \u0027-d 169.254.169.254/32 -i qr-+ \u0027"},{"line_number":42,"context_line":"                 \u0027-p tcp -m tcp --dport 80 -j REDIRECT --to-ports 9697\u0027)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            [rules],"},{"line_number":45,"context_line":"            metadata_driver.MetadataDriver.metadata_nat_rules(9697))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_09ddcd13","line":42,"updated":"2017-10-10 19:39:23.000000000","message":"Is this change of port number related somehow to Your patch?","commit_id":"4350da91939552afad6e0ea8cd05dfc274e1be43"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e22c3da15854f0c1b3692f84c774a802444715c6","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_metadata_nat_rules(self):"},{"line_number":41,"context_line":"        rules \u003d (\u0027PREROUTING\u0027, \u0027-d 169.254.169.254/32 -i qr-+ \u0027"},{"line_number":42,"context_line":"                 \u0027-p tcp -m tcp --dport 80 -j REDIRECT --to-ports 9697\u0027)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            [rules],"},{"line_number":45,"context_line":"            metadata_driver.MetadataDriver.metadata_nat_rules(9697))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_6c3d6fba","line":42,"in_reply_to":"5f4e5783_09ddcd13","updated":"2017-10-10 19:59:20.000000000","message":"Yes, I broke the rule, I can do this in a follow-on.  9697 is the correct port, which is why I used it on L65","commit_id":"4350da91939552afad6e0ea8cd05dfc274e1be43"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"16a6f8b37d0469f7e5fe1f5c3a1b6584599161ff","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_metadata_nat_rules(self):"},{"line_number":41,"context_line":"        rules \u003d (\u0027PREROUTING\u0027, \u0027-d 169.254.169.254/32 -i qr-+ \u0027"},{"line_number":42,"context_line":"                 \u0027-p tcp -m tcp --dport 80 -j REDIRECT --to-ports 9697\u0027)"},{"line_number":43,"context_line":"        self.assertEqual("},{"line_number":44,"context_line":"            [rules],"},{"line_number":45,"context_line":"            metadata_driver.MetadataDriver.metadata_nat_rules(9697))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_2ced37ef","line":42,"in_reply_to":"5f4e5783_6c3d6fba","updated":"2017-10-10 20:12:00.000000000","message":"You are the core here so IMHO it\u0027s up to You how You will do it :)\nI would prefer to do it in separate patch with proper commit message (or at least mention about it in commit message of this patch).","commit_id":"4350da91939552afad6e0ea8cd05dfc274e1be43"}]}