)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c7d29f6e8e64769ebf18ecdc890db3357b9abb36","unresolved":false,"context_lines":[{"line_number":15,"context_line":"is remaining in DOWN status and L3 agent was never spawning keepalived"},{"line_number":16,"context_line":"on L3 agent restart(if keepalived is killed)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1723848"},{"line_number":19,"context_line":"Change-Id: I629eeff905bf02ec5f7ee68cccc7c19f1b47d5aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f4e5783_83d8bfee","line":18,"updated":"2017-10-17 19:25:18.000000000","message":"the bug suggests that in master, it\u0027s not an issue. if so, why do we land the patch in master?","commit_id":"4f9a6a8b7661c3792101580d14d401e8426bf72a"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"e78c5fc467235e9f0633b6115f4405a084f8975a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"is remaining in DOWN status and L3 agent was never spawning keepalived"},{"line_number":16,"context_line":"on L3 agent restart(if keepalived is killed)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1723848"},{"line_number":19,"context_line":"Change-Id: I629eeff905bf02ec5f7ee68cccc7c19f1b47d5aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_04a956de","line":18,"in_reply_to":"5f4e5783_83d8bfee","updated":"2017-10-18 04:40:28.000000000","message":"Yes. In master this is not an issue.\n\nMay be for backward compatibility? In a installation, if the agents are from branches(without OVO support) and server is from master, then this patch can address that also.","commit_id":"4f9a6a8b7661c3792101580d14d401e8426bf72a"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"ef314fecfd828a16c0e0f0f524079490d10456b2","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        with self.port() as port:"},{"line_number":814,"context_line":"            with mock.patch.object(self.plugin,"},{"line_number":815,"context_line":"                                   \u0027_notify_port_updated\u0027) as notify_mock:"},{"line_number":816,"context_line":"                port[\u0027port\u0027][\u0027status\u0027] \u003d constants.PORT_STATUS_ACTIVE"},{"line_number":817,"context_line":"                plugin.update_port(ctx, port[\u0027port\u0027][\u0027id\u0027], port)"},{"line_number":818,"context_line":"                self.assertTrue(notify_mock.called)"},{"line_number":819,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_849ae66b","line":816,"updated":"2017-10-18 05:07:44.000000000","message":"For futureproofness, shouldn\u0027t you assert that the initial status is DOWN ?","commit_id":"4f9a6a8b7661c3792101580d14d401e8426bf72a"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"e644a5631cd60d20f48b6592eb1b39b726a5b26e","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        with self.port() as port:"},{"line_number":814,"context_line":"            with mock.patch.object(self.plugin,"},{"line_number":815,"context_line":"                                   \u0027_notify_port_updated\u0027) as notify_mock:"},{"line_number":816,"context_line":"                port[\u0027port\u0027][\u0027status\u0027] \u003d constants.PORT_STATUS_ACTIVE"},{"line_number":817,"context_line":"                plugin.update_port(ctx, port[\u0027port\u0027][\u0027id\u0027], port)"},{"line_number":818,"context_line":"                self.assertTrue(notify_mock.called)"},{"line_number":819,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_aac80b74","line":816,"in_reply_to":"3f4b6375_849ae66b","updated":"2017-10-18 06:59:19.000000000","message":"Thanks Thomas.\nIf I add that, then I may get one more suggestion :)  that I have to check the status of port after update call.\nThis is not necessary and test is simple now, so I prefer to keep it as it is.","commit_id":"4f9a6a8b7661c3792101580d14d401e8426bf72a"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"0d960442102fd7520037146c907909338a68b8b8","unresolved":false,"context_lines":[{"line_number":813,"context_line":"        with self.port() as port:"},{"line_number":814,"context_line":"            with mock.patch.object(self.plugin,"},{"line_number":815,"context_line":"                                   \u0027_notify_port_updated\u0027) as notify_mock:"},{"line_number":816,"context_line":"                port[\u0027port\u0027][\u0027status\u0027] \u003d constants.PORT_STATUS_ACTIVE"},{"line_number":817,"context_line":"                plugin.update_port(ctx, port[\u0027port\u0027][\u0027id\u0027], port)"},{"line_number":818,"context_line":"                self.assertTrue(notify_mock.called)"},{"line_number":819,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_cd65a1e3","line":816,"in_reply_to":"3f4b6375_aac80b74","updated":"2017-10-18 07:38:50.000000000","message":"Ack, don\u0027t change.","commit_id":"4f9a6a8b7661c3792101580d14d401e8426bf72a"}]}