)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pattabi Ayyasami \u003cpattabi@brocade.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-11 16:09:52 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: Brocade Plugin and Device Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I96eb443cf03b40171bef8580ae52a6837178e27f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FlO8%3D","line":7,"updated":"2013-10-14 11:46:47.000000000","message":"Please add more info to the commit message: at least you should mention that the patch is about loadbalancers (not Neutron core plugin as it may seem).","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pattabi Ayyasami \u003cpattabi@brocade.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-11 16:09:52 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: Brocade Plugin and Device Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I96eb443cf03b40171bef8580ae52a6837178e27f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FZCU%3D","line":7,"in_reply_to":"AAAATH%2F%2FlO8%3D","updated":"2013-10-16 20:59:47.000000000","message":"Will add more info as part of the next patch upload","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-10-16 16:19:38 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Brocade Plugin Driver and Device Driver for generic LBaaS Plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I96eb443cf03b40171bef8580ae52a6837178e27f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAATH%2F%2FXRI%3D","line":8,"updated":"2013-10-17 08:02:07.000000000","message":"Please specify a related blueprint before change id:\n Implements blueprint ...","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34c60fdde744cabd7e3164449d46b01f33ce9733","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: Brocade Plugin Driver and Device Driver for LBaaS Plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementation of the blueprint"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/neutron/+spec/neutron-lbaas-vendor-device-driver"},{"line_number":11,"context_line":"This Patch Set supports simple file based device inventory"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATX%2F%2F%2Fms%3D","line":9,"updated":"2013-10-23 07:03:48.000000000","message":"Consider:\n Implements blueprint neutron-lbaas-vendor-device-driver\n\nAlso bp name looks quite generic, why not name it like brocade-lbaas-driver?","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"b6d1df78f154c5d3ca6673c30b63617b09d98ea8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: Brocade Plugin Driver and Device Driver for LBaaS Plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementation of the blueprint"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/neutron/+spec/neutron-lbaas-vendor-device-driver"},{"line_number":11,"context_line":"This Patch Set supports simple file based device inventory"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAATX%2F%2F9K4%3D","line":9,"in_reply_to":"AAAATX%2F%2F%2Fms%3D","updated":"2013-10-23 17:49:05.000000000","message":"Will update","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"}],"etc/neutron.conf":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"118b764d9086b04c381cb6aef01f200153c816c8","unresolved":false,"context_lines":[{"line_number":381,"context_line":"#service_compression_throughput\u003d100"},{"line_number":382,"context_line":"#service_cache\u003d20"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"[brocade]"},{"line_number":385,"context_line":"# Uncomment the following line and specify the absolute file name"},{"line_number":386,"context_line":"# containing the device information"},{"line_number":387,"context_line":"#devices_file_name\u003d/etc/neutron/services/loadbalancer/brocade/devices.json"}],"source_content_type":"text/plain","patch_set":14,"id":"AAAATn%2F%2F%2Fpg%3D","line":384,"updated":"2013-10-24 05:23:59.000000000","message":"Sorry for nit picking on this - I believe the consensus is to move vendor-specific config out of this conf file. Please see:\nhttps://review.openstack.org/#/c/51877/\n\nIt has been moved to a new conf file.","commit_id":"69d4d6dbca60768b908f0f2c7e1fda5c13708696"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"9e595c1ae08f8fac46214c96fa3cc047b4db3b0d","unresolved":false,"context_lines":[{"line_number":381,"context_line":"#service_compression_throughput\u003d100"},{"line_number":382,"context_line":"#service_cache\u003d20"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"[brocade]"},{"line_number":385,"context_line":"# Uncomment the following line and specify the absolute file name"},{"line_number":386,"context_line":"# containing the device information"},{"line_number":387,"context_line":"#devices_file_name\u003d/etc/neutron/services/loadbalancer/brocade/devices.json"}],"source_content_type":"text/plain","patch_set":14,"id":"AAAATn%2F%2F8rs%3D","line":384,"in_reply_to":"AAAATn%2F%2F%2Fpg%3D","updated":"2013-10-24 18:35:15.000000000","message":"I will move this out of this config file. I looked at  https://review.openstack.org/#/c/51877/\n\nI see that a new config file /etc/services.conf being introduced. Will this config file also be passed as a command line argument when the neutron-server is started ? I did not see any change to the command line change as part of that review.  May be my lack of understanding here.\n\nAlso, what should I do now ? Wait for the new config file to be part of the trunk or for now should i add a conf file (services.conf) as part of this patch set ?","commit_id":"69d4d6dbca60768b908f0f2c7e1fda5c13708696"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"b02cd82592f0e9d53b2454510f37196e8412bb24","unresolved":false,"context_lines":[{"line_number":381,"context_line":"#service_compression_throughput\u003d100"},{"line_number":382,"context_line":"#service_cache\u003d20"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"[brocade]"},{"line_number":385,"context_line":"# Uncomment the following line and specify the absolute file name"},{"line_number":386,"context_line":"# containing the device information"},{"line_number":387,"context_line":"#devices_file_name\u003d/etc/neutron/services/loadbalancer/brocade/devices.json"}],"source_content_type":"text/plain","patch_set":14,"id":"AAAATn%2F%2F8eA%3D","line":384,"in_reply_to":"AAAATn%2F%2F8rs%3D","updated":"2013-10-24 19:48:02.000000000","message":"\u003e Will this config file also be passed as a command line argument when the neutron-server is started?\nYes, at least devstack should do that. Otherwise it is deployment responsibility to provide correct startup script for the neutron server.","commit_id":"69d4d6dbca60768b908f0f2c7e1fda5c13708696"}],"etc/services.conf":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"c27d6dafd35d808ab7d5c8bc1ca322bcf5a2db81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[brocade]"},{"line_number":2,"context_line":"# Uncomment the following line and specify the absolute file name"},{"line_number":3,"context_line":"# containing the device information"},{"line_number":4,"context_line":"#devices_file_name\u003d/etc/neutron/services/loadbalancer/brocade/devices.json"}],"source_content_type":"text/plain","patch_set":15,"id":"AAAATn%2F%2F7kE%3D","line":2,"updated":"2013-10-25 02:00:10.000000000","message":"services.conf gives the impression of being a generic config file when it is just for Brocade, will it be possible to move it inside of the brocade subdirectory?","commit_id":"374bee192d74303ee83a966732dddf2f04170b5d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a9b6d8399972549218bf44c31f79975dc7e2947a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[brocade]"},{"line_number":2,"context_line":"# Uncomment the following line and specify the absolute file name"},{"line_number":3,"context_line":"# containing the device information"},{"line_number":4,"context_line":"#devices_file_name\u003d/etc/neutron/services/loadbalancer/brocade/devices.json"}],"source_content_type":"text/plain","patch_set":15,"id":"AAAATn%2F%2F7IA%3D","line":2,"in_reply_to":"AAAATn%2F%2F7kE%3D","updated":"2013-10-25 06:37:58.000000000","message":"Actually it is intended to be a generic config file for services. Please see Sumit\u0027s comment on patch set 14.","commit_id":"374bee192d74303ee83a966732dddf2f04170b5d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"8ce95463dd26b3e3d30b742158c7a570177eb1bc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[brocade]"},{"line_number":2,"context_line":"# Uncomment the following line and specify the absolute file name"},{"line_number":3,"context_line":"# containing the device information"},{"line_number":4,"context_line":"#devices_file_name\u003d/etc/neutron/services/loadbalancer/brocade/devices.json"}],"source_content_type":"text/plain","patch_set":15,"id":"AAAATn%2F%2F7Gs%3D","line":2,"in_reply_to":"AAAATn%2F%2F7kE%3D","updated":"2013-10-25 06:45:01.000000000","message":"in fact, this file will also be used by radware lbaas driver, see https://review.openstack.org/#/c/51877/","commit_id":"374bee192d74303ee83a966732dddf2f04170b5d"}],"neutron/plugins/brocade/lbaas/device_driver/__init__.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlO4%3D","line":3,"updated":"2013-10-14 11:46:47.000000000","message":"Should be \u0027Copyright (c) 2013 OpenStack Foundation.\u0027","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZB0%3D","line":3,"in_reply_to":"AAAATH%2F%2FlO4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/device_driver/brocade_adx_driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 Brocade, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlOw%3D","line":1,"updated":"2013-10-14 11:46:47.000000000","message":"2013","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Pattabi Ayyasami, Brocade Communications Systems,Inc."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"\"\"\"This module communicates with the Brocade ADX Load Balnacer Device"},{"line_number":18,"context_line":"using XML/SOAP APIs.Implements the driver APIs for the load balancer"},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"import brocade_adx_driver_impl as brocade_adx_driver_impl"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlOA%3D","line":17,"updated":"2013-10-14 11:46:47.000000000","message":"nit: better to surround the comment with empty lines","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Pattabi Ayyasami, Brocade Communications Systems,Inc."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"\"\"\"This module communicates with the Brocade ADX Load Balnacer Device"},{"line_number":18,"context_line":"using XML/SOAP APIs.Implements the driver APIs for the load balancer"},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"import brocade_adx_driver_impl as brocade_adx_driver_impl"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZBo%3D","line":17,"in_reply_to":"AAAATH%2F%2FlOA%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\"This module communicates with the Brocade ADX Load Balnacer Device"},{"line_number":18,"context_line":"using XML/SOAP APIs.Implements the driver APIs for the load balancer"},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"import brocade_adx_driver_impl as brocade_adx_driver_impl"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from brocade_adx_driver_impl import BrocadeAdxDriverImpl"},{"line_number":23,"context_line":"from neutron.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlNk%3D","line":20,"updated":"2013-10-14 11:46:47.000000000","message":"please follow import conventions described in neutron/HACKING.RST","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\"This module communicates with the Brocade ADX Load Balnacer Device"},{"line_number":18,"context_line":"using XML/SOAP APIs.Implements the driver APIs for the load balancer"},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"import brocade_adx_driver_impl as brocade_adx_driver_impl"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from brocade_adx_driver_impl import BrocadeAdxDriverImpl"},{"line_number":23,"context_line":"from neutron.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZBk%3D","line":20,"in_reply_to":"AAAATH%2F%2FlNk%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"import brocade_adx_driver_impl as brocade_adx_driver_impl"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from brocade_adx_driver_impl import BrocadeAdxDriverImpl"},{"line_number":23,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlNE%3D","line":22,"updated":"2013-10-14 11:46:47.000000000","message":"module level imports are more preferable than class level imports","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"import brocade_adx_driver_impl as brocade_adx_driver_impl"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from brocade_adx_driver_impl import BrocadeAdxDriverImpl"},{"line_number":23,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZBY%3D","line":22,"in_reply_to":"AAAATH%2F%2FlNE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        LOG.debug(\u0027BrocadeAdxDriver method %s called with arguments %s %s\u0027"},{"line_number":31,"context_line":"                  % (method.__name__, args, kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnuY%3D","line":28,"updated":"2013-10-12 13:41:34.000000000","message":"i think this decorator duplicates more flexible method from neutron/common/log.py","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        LOG.debug(\u0027BrocadeAdxDriver method %s called with arguments %s %s\u0027"},{"line_number":31,"context_line":"                  % (method.__name__, args, kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZBQ%3D","line":28,"in_reply_to":"AAAATH%2F%2FnuY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class BrocadeAdxDriver():"},{"line_number":37,"context_line":"    def delete_device(self, device):"},{"line_number":38,"context_line":"        LOG.info(_(\u0027Delete Device :%s\u0027), device)"},{"line_number":39,"context_line":"        brocade_adx_driver_impl.delete_device(device)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnuQ%3D","line":37,"updated":"2013-10-12 13:41:34.000000000","message":"no logging for this method?","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class BrocadeAdxDriver():"},{"line_number":37,"context_line":"    def delete_device(self, device):"},{"line_number":38,"context_line":"        LOG.info(_(\u0027Delete Device :%s\u0027), device)"},{"line_number":39,"context_line":"        brocade_adx_driver_impl.delete_device(device)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZBI%3D","line":37,"in_reply_to":"AAAATH%2F%2FnuQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class BrocadeAdxDriver():"},{"line_number":37,"context_line":"    def delete_device(self, device):"},{"line_number":38,"context_line":"        LOG.info(_(\u0027Delete Device :%s\u0027), device)"},{"line_number":39,"context_line":"        brocade_adx_driver_impl.delete_device(device)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @log"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnuU%3D","line":38,"updated":"2013-10-12 13:41:34.000000000","message":"nit: space after : not before","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class BrocadeAdxDriver():"},{"line_number":37,"context_line":"    def delete_device(self, device):"},{"line_number":38,"context_line":"        LOG.info(_(\u0027Delete Device :%s\u0027), device)"},{"line_number":39,"context_line":"        brocade_adx_driver_impl.delete_device(device)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @log"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZBA%3D","line":38,"in_reply_to":"AAAATH%2F%2FnuU%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/device_driver/brocade_adx_driver_impl.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 Brocade, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlJg%3D","line":1,"updated":"2013-10-14 11:46:47.000000000","message":"2013","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    UnsupportedFeature,"},{"line_number":19,"context_line":"    ConfigError"},{"line_number":20,"context_line":")"},{"line_number":21,"context_line":"from brocade_adx_service import DeviceCache"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.context import get_admin_context"},{"line_number":24,"context_line":"from neutron.db import api as db_api"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlLo%3D","line":21,"updated":"2013-10-14 11:46:47.000000000","message":"\"Do not make relative imports\" (HACKING.rst)","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    UnsupportedFeature,"},{"line_number":19,"context_line":"    ConfigError"},{"line_number":20,"context_line":")"},{"line_number":21,"context_line":"from brocade_adx_service import DeviceCache"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.context import get_admin_context"},{"line_number":24,"context_line":"from neutron.db import api as db_api"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZA0%3D","line":21,"in_reply_to":"AAAATH%2F%2FlLo%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"db_api.configure_db()"},{"line_number":32,"context_line":"DB_PLUGIN \u003d LoadBalancerPluginDb()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def log(method):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnuE%3D","line":32,"updated":"2013-10-12 13:41:34.000000000","message":"I think it\u0027s not a good way to do. We already have an instance of the class as part of lbaas plugin. It\u0027s better to pass existing instance to the driver. That also could help to avoid possible load ordering issues.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":"db_api.configure_db()"},{"line_number":32,"context_line":"DB_PLUGIN \u003d LoadBalancerPluginDb()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def log(method):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAk%3D","line":32,"in_reply_to":"AAAATH%2F%2FnuE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Modified the code to take the lbaas plugin and pass the instance to the driver.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"DB_PLUGIN \u003d LoadBalancerPluginDb()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def log(method):"},{"line_number":36,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":37,"context_line":"        LOG.debug(\u0027BrocadeAdxDriverImpl method %s called with arguments %s %s\u0027"},{"line_number":38,"context_line":"                  % (method.__name__, args, kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnuM%3D","line":35,"updated":"2013-10-12 13:41:34.000000000","message":"duplicating common log decorator","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":32,"context_line":"DB_PLUGIN \u003d LoadBalancerPluginDb()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def log(method):"},{"line_number":36,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":37,"context_line":"        LOG.debug(\u0027BrocadeAdxDriverImpl method %s called with arguments %s %s\u0027"},{"line_number":38,"context_line":"                  % (method.__name__, args, kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAg%3D","line":35,"in_reply_to":"AAAATH%2F%2FnuM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        service_clients \u003d DeviceCache.get_adx_service_client(device)"},{"line_number":47,"context_line":"        self.slb_service_client \u003d service_clients[0]"},{"line_number":48,"context_line":"        self.sys_service_client \u003d service_clients[1]"},{"line_number":49,"context_line":"        self.device_version \u003d \u002712.5\u0027"},{"line_number":50,"context_line":"        if \u0027device_version\u0027 in device:"},{"line_number":51,"context_line":"            self.device_version \u003d device[\u0027device_version\u0027]"},{"line_number":52,"context_line":"        LOG.debug(_(\u0027ADX Version: %s\u0027), self.device_version)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlLc%3D","line":49,"updated":"2013-10-14 11:46:47.000000000","message":"better to use a constant defined at the beginning of the module","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        service_clients \u003d DeviceCache.get_adx_service_client(device)"},{"line_number":47,"context_line":"        self.slb_service_client \u003d service_clients[0]"},{"line_number":48,"context_line":"        self.sys_service_client \u003d service_clients[1]"},{"line_number":49,"context_line":"        self.device_version \u003d \u002712.5\u0027"},{"line_number":50,"context_line":"        if \u0027device_version\u0027 in device:"},{"line_number":51,"context_line":"            self.device_version \u003d device[\u0027device_version\u0027]"},{"line_number":52,"context_line":"        LOG.debug(_(\u0027ADX Version: %s\u0027), self.device_version)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAc%3D","line":49,"in_reply_to":"AAAATH%2F%2FlLc%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        LOG.debug(_(\u0027ADX Version: %s\u0027), self.device_version)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _get_pool(self, pool_id):"},{"line_number":55,"context_line":"        pool \u003d DB_PLUGIN.get_pool(get_admin_context(), pool_id)"},{"line_number":56,"context_line":"        return pool"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _get_vip(self, vip_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlLM%3D","line":55,"updated":"2013-10-14 11:46:47.000000000","message":"return DB_PLUGIN.get_pool(get_admin_context(), pool_id)","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        LOG.debug(_(\u0027ADX Version: %s\u0027), self.device_version)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _get_pool(self, pool_id):"},{"line_number":55,"context_line":"        pool \u003d DB_PLUGIN.get_pool(get_admin_context(), pool_id)"},{"line_number":56,"context_line":"        return pool"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _get_vip(self, vip_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAY%3D","line":55,"in_reply_to":"AAAATH%2F%2FlLM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def _get_pool_members(self, pool_id):"},{"line_number":63,"context_line":"        pool \u003d self._get_pool(pool_id)"},{"line_number":64,"context_line":"        member_ids \u003d pool[\u0027members\u0027]"},{"line_number":65,"context_line":"        members \u003d []"},{"line_number":66,"context_line":"        for member_id in member_ids:"},{"line_number":67,"context_line":"            member \u003d DB_PLUGIN.get_member(get_admin_context(), member_id)"},{"line_number":68,"context_line":"            members.append(member)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnuA%3D","line":65,"updated":"2013-10-12 13:41:34.000000000","message":"lines 64-69 could be rewritten:\n ctx \u003d get_admin_context()\n return [DB_PLUGIN.get_member(ctx, member_id) for member_id in pool[\u0027members\u0027]]","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def _get_pool_members(self, pool_id):"},{"line_number":63,"context_line":"        pool \u003d self._get_pool(pool_id)"},{"line_number":64,"context_line":"        member_ids \u003d pool[\u0027members\u0027]"},{"line_number":65,"context_line":"        members \u003d []"},{"line_number":66,"context_line":"        for member_id in member_ids:"},{"line_number":67,"context_line":"            member \u003d DB_PLUGIN.get_member(get_admin_context(), member_id)"},{"line_number":68,"context_line":"            members.append(member)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAU%3D","line":65,"in_reply_to":"AAAATH%2F%2FnuA%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _get_health_monitors(self, pool_id):"},{"line_number":72,"context_line":"        pool \u003d DB_PLUGIN.get_pool(get_admin_context(), pool_id)"},{"line_number":73,"context_line":"        monitors \u003d []"},{"line_number":74,"context_line":"        monitor_ids \u003d pool[\u0027health_monitors\u0027]"},{"line_number":75,"context_line":"        for id in monitor_ids:"},{"line_number":76,"context_line":"            monitors.append(DB_PLUGIN.get_health_monitor(get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnt0%3D","line":73,"updated":"2013-10-12 13:41:34.000000000","message":"same suggestion to use list comprehension as in previous comment","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _get_health_monitors(self, pool_id):"},{"line_number":72,"context_line":"        pool \u003d DB_PLUGIN.get_pool(get_admin_context(), pool_id)"},{"line_number":73,"context_line":"        monitors \u003d []"},{"line_number":74,"context_line":"        monitor_ids \u003d pool[\u0027health_monitors\u0027]"},{"line_number":75,"context_line":"        for id in monitor_ids:"},{"line_number":76,"context_line":"            monitors.append(DB_PLUGIN.get_health_monitor(get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAM%3D","line":73,"in_reply_to":"AAAATH%2F%2Fnt0%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            address \u003d member[\u0027address\u0027]"},{"line_number":83,"context_line":"            protocol_port \u003d member[\u0027protocol_port\u0027]"},{"line_number":84,"context_line":"            is_backup \u003d member.get(\u0027is_backup\u0027, None)"},{"line_number":85,"context_line":"            max_connections \u003d member.get(\u0027max_connections\u0027, None)"},{"line_number":86,"context_line":"            admin_state_up \u003d member.get(\u0027admin_state_up\u0027, True)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fntw%3D","line":84,"updated":"2013-10-12 13:41:34.000000000","message":"None is not needed, if there\u0027s no is_backup, None is returned anyway","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            address \u003d member[\u0027address\u0027]"},{"line_number":83,"context_line":"            protocol_port \u003d member[\u0027protocol_port\u0027]"},{"line_number":84,"context_line":"            is_backup \u003d member.get(\u0027is_backup\u0027, None)"},{"line_number":85,"context_line":"            max_connections \u003d member.get(\u0027max_connections\u0027, None)"},{"line_number":86,"context_line":"            admin_state_up \u003d member.get(\u0027admin_state_up\u0027, True)"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAE%3D","line":84,"in_reply_to":"AAAATH%2F%2Fntw%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            address \u003d member[\u0027address\u0027]"},{"line_number":83,"context_line":"            protocol_port \u003d member[\u0027protocol_port\u0027]"},{"line_number":84,"context_line":"            is_backup \u003d member.get(\u0027is_backup\u0027, None)"},{"line_number":85,"context_line":"            max_connections \u003d member.get(\u0027max_connections\u0027, None)"},{"line_number":86,"context_line":"            admin_state_up \u003d member.get(\u0027admin_state_up\u0027, True)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            rsServer \u003d self.slb_service_client.factory.create(\"Server\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnts%3D","line":85,"updated":"2013-10-12 13:41:34.000000000","message":"same","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            address \u003d member[\u0027address\u0027]"},{"line_number":83,"context_line":"            protocol_port \u003d member[\u0027protocol_port\u0027]"},{"line_number":84,"context_line":"            is_backup \u003d member.get(\u0027is_backup\u0027, None)"},{"line_number":85,"context_line":"            max_connections \u003d member.get(\u0027max_connections\u0027, None)"},{"line_number":86,"context_line":"            admin_state_up \u003d member.get(\u0027admin_state_up\u0027, True)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            rsServer \u003d self.slb_service_client.factory.create(\"Server\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZAA%3D","line":85,"in_reply_to":"AAAATH%2F%2Fnts%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            reply \u003d (self.slb_service_client.service"},{"line_number":99,"context_line":"                     .getRealServerPortConfiguration(rsServerPort))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            rsPortConfigurationSequence \u003d \\"},{"line_number":102,"context_line":"                (self.slb_service_client.factory"},{"line_number":103,"context_line":"                 .create(\u0027ArrayOfRealServerPortConfigurationSequence\u0027))"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnto%3D","line":101,"updated":"2013-10-12 13:41:34.000000000","message":"backslash should not be used per HACKING guidelines. Use parens like in L98","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            reply \u003d (self.slb_service_client.service"},{"line_number":99,"context_line":"                     .getRealServerPortConfiguration(rsServerPort))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"            rsPortConfigurationSequence \u003d \\"},{"line_number":102,"context_line":"                (self.slb_service_client.factory"},{"line_number":103,"context_line":"                 .create(\u0027ArrayOfRealServerPortConfigurationSequence\u0027))"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2F0%3D","line":101,"in_reply_to":"AAAATH%2F%2Fnto%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            reply.rsPortConfig.serverPort \u003d rsServerPort"},{"line_number":106,"context_line":"            rsPortAdminState \u003d \u0027ENABLED\u0027"},{"line_number":107,"context_line":"            if(admin_state_up \u003d\u003d False):"},{"line_number":108,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":109,"context_line":"            reply.rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fntg%3D","line":107,"updated":"2013-10-12 13:41:34.000000000","message":"if not admin_state_up:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            reply.rsPortConfig.serverPort \u003d rsServerPort"},{"line_number":106,"context_line":"            rsPortAdminState \u003d \u0027ENABLED\u0027"},{"line_number":107,"context_line":"            if(admin_state_up \u003d\u003d False):"},{"line_number":108,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":109,"context_line":"            reply.rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2Fw%3D","line":107,"in_reply_to":"AAAATH%2F%2Fntg%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":109,"context_line":"            reply.rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            if is_backup !\u003d None:"},{"line_number":112,"context_line":"                reply.rsPortConfig.isBackup \u003d is_backup"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            if max_connections:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fntc%3D","line":111,"updated":"2013-10-12 13:41:34.000000000","message":"if is_backup is not None:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":109,"context_line":"            reply.rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"            if is_backup !\u003d None:"},{"line_number":112,"context_line":"                reply.rsPortConfig.isBackup \u003d is_backup"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            if max_connections:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2Fo%3D","line":111,"in_reply_to":"AAAATH%2F%2Fntc%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            if max_connections:"},{"line_number":115,"context_line":"                reply.rsPortConfig.maxConnection \u003d max_connections"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            rsPortConfigurationList \u003d []"},{"line_number":118,"context_line":"            rsPortConfigurationList.append(reply.rsPortConfig)"},{"line_number":119,"context_line":"            rsPortConfigurationSequence.RealServerPortConfigurationSequence \\"},{"line_number":120,"context_line":"                \u003d rsPortConfigurationList"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FntY%3D","line":117,"updated":"2013-10-12 13:41:34.000000000","message":"i suggest to shorten the name: rsPortConfList","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            if max_connections:"},{"line_number":115,"context_line":"                reply.rsPortConfig.maxConnection \u003d max_connections"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"            rsPortConfigurationList \u003d []"},{"line_number":118,"context_line":"            rsPortConfigurationList.append(reply.rsPortConfig)"},{"line_number":119,"context_line":"            rsPortConfigurationSequence.RealServerPortConfigurationSequence \\"},{"line_number":120,"context_line":"                \u003d rsPortConfigurationList"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2Fk%3D","line":117,"in_reply_to":"AAAATH%2F%2FntY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def _update_real_server_properties(self, member):"},{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            address \u003d member[\u0027address\u0027]"},{"line_number":132,"context_line":"            weight \u003d member.get(\u0027weight\u0027, None)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            rsServer \u003d self.slb_service_client.factory.create(\"Server\")"},{"line_number":135,"context_line":"            rsServer.IP \u003d address"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlKs%3D","line":132,"updated":"2013-10-14 11:46:47.000000000","message":"None not needed","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def _update_real_server_properties(self, member):"},{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            address \u003d member[\u0027address\u0027]"},{"line_number":132,"context_line":"            weight \u003d member.get(\u0027weight\u0027, None)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"            rsServer \u003d self.slb_service_client.factory.create(\"Server\")"},{"line_number":135,"context_line":"            rsServer.IP \u003d address"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2Fc%3D","line":132,"in_reply_to":"AAAATH%2F%2FlKs%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            reply \u003d (self.slb_service_client.service"},{"line_number":137,"context_line":"                     .getRealServerConfiguration(rsServer))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            rsConfigurationSequence \u003d \\"},{"line_number":140,"context_line":"                (self.slb_service_client.factory"},{"line_number":141,"context_line":"                 .create(\"ArrayOfRealServerConfigurationSequence\"))"},{"line_number":142,"context_line":"            if weight:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FntU%3D","line":139,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            reply \u003d (self.slb_service_client.service"},{"line_number":137,"context_line":"                     .getRealServerConfiguration(rsServer))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            rsConfigurationSequence \u003d \\"},{"line_number":140,"context_line":"                (self.slb_service_client.factory"},{"line_number":141,"context_line":"                 .create(\"ArrayOfRealServerConfigurationSequence\"))"},{"line_number":142,"context_line":"            if weight:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2FY%3D","line":139,"in_reply_to":"AAAATH%2F%2FntU%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            rsConfigurationList \u003d []"},{"line_number":146,"context_line":"            rsConfigurationList.append(reply.rsConfig)"},{"line_number":147,"context_line":"            rsConfigurationSequence.RealServerConfigurationSequence \u003d \\"},{"line_number":148,"context_line":"                rsConfigurationList"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            LOG.debug(_(\"Update real server properties: %s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FntQ%3D","line":147,"updated":"2013-10-12 13:41:34.000000000","message":"backslash could be avoided if name is shortened","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            rsConfigurationList \u003d []"},{"line_number":146,"context_line":"            rsConfigurationList.append(reply.rsConfig)"},{"line_number":147,"context_line":"            rsConfigurationSequence.RealServerConfigurationSequence \u003d \\"},{"line_number":148,"context_line":"                rsConfigurationList"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            LOG.debug(_(\"Update real server properties: %s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2FU%3D","line":147,"in_reply_to":"AAAATH%2F%2FntQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def _bind_member_to_vip(self, member, vip):"},{"line_number":195,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":196,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":197,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":198,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":199,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":200,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlIE%3D","line":197,"updated":"2013-10-14 11:46:47.000000000","message":"rsName \u003d member.get(\u0027name\u0027, \u003cdefault\u003e)","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    def _bind_member_to_vip(self, member, vip):"},{"line_number":195,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":196,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":197,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":198,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":199,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":200,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2FM%3D","line":197,"in_reply_to":"AAAATH%2F%2FlIE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def _unbind_member_from_vip(self, member, vip):"},{"line_number":237,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":238,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":239,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":240,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":241,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":242,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fns4%3D","line":239,"updated":"2013-10-12 13:41:34.000000000","message":"L239-241 could be simplified to:\n if member.get(\u0027name\u0027):\n    rsName \u003d member[\u0027name\u0027]","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    def _unbind_member_from_vip(self, member, vip):"},{"line_number":237,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":238,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":239,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":240,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":241,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":242,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2FI%3D","line":239,"in_reply_to":"AAAATH%2F%2Fns4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        health_monitor_name \u003d health_monitor[\u0027id\u0027]"},{"line_number":281,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":282,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":283,"context_line":"                health_monitor_name \u003d health_monitor[\u0027name\u0027]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FntE%3D","line":282,"updated":"2013-10-12 13:41:34.000000000","message":"same as above","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        health_monitor_name \u003d health_monitor[\u0027id\u0027]"},{"line_number":281,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":282,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":283,"context_line":"                health_monitor_name \u003d health_monitor[\u0027name\u0027]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2B8%3D","line":282,"in_reply_to":"AAAATH%2F%2FntE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":286,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":287,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":288,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":289,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":290,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnsw%3D","line":287,"updated":"2013-10-12 13:41:34.000000000","message":"same as above","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":286,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":287,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":288,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":289,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":290,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2B4%3D","line":287,"in_reply_to":"AAAATH%2F%2Fnsw%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        rsAdminState \u003d \u0027UNDEFINED\u0027"},{"line_number":292,"context_line":"        rsRunTimeStatus \u003d \u0027UNDEFINED\u0027"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if(member[\u0027admin_state_up\u0027] \u003d\u003d True):"},{"line_number":295,"context_line":"            rsAdminState \u003d \u0027ENABLED\u0027"},{"line_number":296,"context_line":"        else:"},{"line_number":297,"context_line":"            rsAdminState \u003d \u0027DISABLED\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnss%3D","line":294,"updated":"2013-10-12 13:41:34.000000000","message":"L294-297 could be converged to:\n rsAdminState \u003d \u0027ENABLED\u0027 if member[\u0027admin_state_up\u0027] else \u0027DISABLED\u0027","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        rsAdminState \u003d \u0027UNDEFINED\u0027"},{"line_number":292,"context_line":"        rsRunTimeStatus \u003d \u0027UNDEFINED\u0027"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if(member[\u0027admin_state_up\u0027] \u003d\u003d True):"},{"line_number":295,"context_line":"            rsAdminState \u003d \u0027ENABLED\u0027"},{"line_number":296,"context_line":"        else:"},{"line_number":297,"context_line":"            rsAdminState \u003d \u0027DISABLED\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2B0%3D","line":294,"in_reply_to":"AAAATH%2F%2Fnss%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            realServerPortConfig.portPolicyName \u003d health_monitor_name"},{"line_number":316,"context_line":"            realServerPortConfig.enablePeriodicHealthCheck \u003d True"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"            rsPortConfigSequence \u003d \\"},{"line_number":319,"context_line":"                (self.slb_service_client.factory"},{"line_number":320,"context_line":"                 .create(\u0027ArrayOfRealServerPortConfigurationSequence\u0027))"},{"line_number":321,"context_line":"            (rsPortConfigSequence"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnsg%3D","line":318,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            realServerPortConfig.portPolicyName \u003d health_monitor_name"},{"line_number":316,"context_line":"            realServerPortConfig.enablePeriodicHealthCheck \u003d True"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"            rsPortConfigSequence \u003d \\"},{"line_number":319,"context_line":"                (self.slb_service_client.factory"},{"line_number":320,"context_line":"                 .create(\u0027ArrayOfRealServerPortConfigurationSequence\u0027))"},{"line_number":321,"context_line":"            (rsPortConfigSequence"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2Bs%3D","line":318,"in_reply_to":"AAAATH%2F%2Fnsg%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":331,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":332,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":333,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":334,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":335,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnsY%3D","line":332,"updated":"2013-10-12 13:41:34.000000000","message":"same:\n if member.get(\u0027name\u0027):","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":331,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":332,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":333,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":334,"context_line":"                rsName \u003d member[\u0027name\u0027]"},{"line_number":335,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2Bo%3D","line":332,"in_reply_to":"AAAATH%2F%2FnsY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        rsAdminState \u003d \u0027UNDEFINED\u0027"},{"line_number":337,"context_line":"        rsRunTimeStatus \u003d \u0027UNDEFINED\u0027"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if(member[\u0027admin_state_up\u0027] \u003d\u003d True):"},{"line_number":340,"context_line":"            rsAdminState \u003d \u0027ENABLED\u0027"},{"line_number":341,"context_line":"        else:"},{"line_number":342,"context_line":"            rsAdminState \u003d \u0027DISABLED\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnsU%3D","line":339,"updated":"2013-10-12 13:41:34.000000000","message":"rsAdminState \u003d \u0027ENABLED\u0027 if member[\u0027admin_state_up\u0027] else \u0027DISABLED\u0027","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        rsAdminState \u003d \u0027UNDEFINED\u0027"},{"line_number":337,"context_line":"        rsRunTimeStatus \u003d \u0027UNDEFINED\u0027"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if(member[\u0027admin_state_up\u0027] \u003d\u003d True):"},{"line_number":340,"context_line":"            rsAdminState \u003d \u0027ENABLED\u0027"},{"line_number":341,"context_line":"        else:"},{"line_number":342,"context_line":"            rsAdminState \u003d \u0027DISABLED\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2Bg%3D","line":339,"in_reply_to":"AAAATH%2F%2FnsU%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            rsAdminState \u003d \u0027DISABLED\u0027"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            rs \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"},{"line_number":346,"context_line":"            rs.IP \u003d rsIpAddress"},{"line_number":347,"context_line":"            rs.Name \u003d rsName"},{"line_number":348,"context_line":"            rsL4Port \u003d self.slb_service_client.factory.create(\u0027L4Port\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnsA%3D","line":345,"updated":"2013-10-12 13:41:34.000000000","message":"the code in 345-361 seems to be duplicating code in 300-318 with slight difference. I see another versions of the same sequence in this class.\nThis definitely should be extracted in a separate method.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            rsAdminState \u003d \u0027DISABLED\u0027"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        try:"},{"line_number":345,"context_line":"            rs \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"},{"line_number":346,"context_line":"            rs.IP \u003d rsIpAddress"},{"line_number":347,"context_line":"            rs.Name \u003d rsName"},{"line_number":348,"context_line":"            rsL4Port \u003d self.slb_service_client.factory.create(\u0027L4Port\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2BQ%3D","line":345,"in_reply_to":"AAAATH%2F%2FnsA%3D","updated":"2013-10-16 20:59:47.000000000","message":"Introduced 2 methods to create the Server and ServerPort","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            server \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"},{"line_number":376,"context_line":"            server.IP \u003d vip[\u0027address\u0027]"},{"line_number":377,"context_line":"            server.Name \u003d vip[\u0027name\u0027]"},{"line_number":378,"context_line":"            predictorMethodConfiguration \u003d \\"},{"line_number":379,"context_line":"                (self.slb_service_client.factory"},{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnr4%3D","line":378,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            server \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"},{"line_number":376,"context_line":"            server.IP \u003d vip[\u0027address\u0027]"},{"line_number":377,"context_line":"            server.Name \u003d vip[\u0027name\u0027]"},{"line_number":378,"context_line":"            predictorMethodConfiguration \u003d \\"},{"line_number":379,"context_line":"                (self.slb_service_client.factory"},{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2BM%3D","line":378,"in_reply_to":"AAAATH%2F%2Fnr4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            predictorMethodConfiguration \u003d \\"},{"line_number":379,"context_line":"                (self.slb_service_client.factory"},{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"},{"line_number":382,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027LEAST_CONN\u0027"},{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlF4%3D","line":381,"updated":"2013-10-14 11:46:47.000000000","message":"consider using a mapping instead of multiple if/elif. See neutron/services/loadbalancer/drivers/haproxy/cfg.py BALANCE_MAP","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            predictorMethodConfiguration \u003d \\"},{"line_number":379,"context_line":"                (self.slb_service_client.factory"},{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"},{"line_number":382,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027LEAST_CONN\u0027"},{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnr0%3D","line":381,"updated":"2013-10-12 13:41:34.000000000","message":"parenthesis are not needed","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            predictorMethodConfiguration \u003d \\"},{"line_number":379,"context_line":"                (self.slb_service_client.factory"},{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"},{"line_number":382,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027LEAST_CONN\u0027"},{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY98%3D","line":381,"in_reply_to":"AAAATH%2F%2FlF4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            predictorMethodConfiguration \u003d \\"},{"line_number":379,"context_line":"                (self.slb_service_client.factory"},{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"},{"line_number":382,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027LEAST_CONN\u0027"},{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY%2BE%3D","line":381,"in_reply_to":"AAAATH%2F%2Fnr0%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"},{"line_number":382,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027LEAST_CONN\u0027"},{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                error_message \u003d (\u0027Load Balancing Metohod/Predictor %s \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnrw%3D","line":383,"updated":"2013-10-12 13:41:34.000000000","message":"same","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                 .create(\u0027PredictorMethodConfiguration\u0027))"},{"line_number":381,"context_line":"            if(lb_method \u003d\u003d \u0027LEAST_CONNECTIONS\u0027):"},{"line_number":382,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027LEAST_CONN\u0027"},{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                error_message \u003d (\u0027Load Balancing Metohod/Predictor %s \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY90%3D","line":383,"in_reply_to":"AAAATH%2F%2Fnrw%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                error_message \u003d (\u0027Load Balancing Metohod/Predictor %s \u0027"},{"line_number":387,"context_line":"                                 \u0027not supported\u0027 % (lb_method))"},{"line_number":388,"context_line":"                raise UnsupportedFeature(msg\u003derror_message)"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnrg%3D","line":386,"updated":"2013-10-12 13:41:34.000000000","message":"use i18n:\n error_message \u003d (_(\u0027Load Balancing Method/Predictor %s not supported\u0027) % lb_method)\n\nalso typo: Metohod","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            elif(lb_method \u003d\u003d \u0027ROUND_ROBIN\u0027):"},{"line_number":384,"context_line":"                predictorMethodConfiguration.predictor \u003d \u0027ROUND_ROBIN\u0027"},{"line_number":385,"context_line":"            else:"},{"line_number":386,"context_line":"                error_message \u003d (\u0027Load Balancing Metohod/Predictor %s \u0027"},{"line_number":387,"context_line":"                                 \u0027not supported\u0027 % (lb_method))"},{"line_number":388,"context_line":"                raise UnsupportedFeature(msg\u003derror_message)"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY9w%3D","line":386,"in_reply_to":"AAAATH%2F%2Fnrg%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            raise ConfigError(msg\u003de.message)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @log"},{"line_number":397,"context_line":"    def create_vip(self, vip):"},{"line_number":398,"context_line":"        # Properties not supported : connection_limit, description"},{"line_number":399,"context_line":"        # protocol and protocol_port will need to be same."},{"line_number":400,"context_line":"        # Basically, protocol property will be ignored."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FlD4%3D","line":397,"updated":"2013-10-14 11:46:47.000000000","message":"The function is quite big, consider refactoring into several private helper functions","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            raise ConfigError(msg\u003de.message)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @log"},{"line_number":397,"context_line":"    def create_vip(self, vip):"},{"line_number":398,"context_line":"        # Properties not supported : connection_limit, description"},{"line_number":399,"context_line":"        # protocol and protocol_port will need to be same."},{"line_number":400,"context_line":"        # Basically, protocol property will be ignored."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY9Y%3D","line":397,"in_reply_to":"AAAATH%2F%2FlD4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        pool_id \u003d vip[\u0027pool_id\u0027]"},{"line_number":407,"context_line":"        description \u003d vip[\u0027description\u0027]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        admin_state_up \u003d True"},{"line_number":410,"context_line":"        if \u0027admin_state_up\u0027 in vip:"},{"line_number":411,"context_line":"            admin_state_up \u003d vip[\u0027admin_state_up\u0027]"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnrU%3D","line":409,"updated":"2013-10-12 13:41:34.000000000","message":"L409-411 to:\n admin_state_up \u003d vip.get(\u0027admin_state_up\u0027, True)","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        pool_id \u003d vip[\u0027pool_id\u0027]"},{"line_number":407,"context_line":"        description \u003d vip[\u0027description\u0027]"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        admin_state_up \u003d True"},{"line_number":410,"context_line":"        if \u0027admin_state_up\u0027 in vip:"},{"line_number":411,"context_line":"            admin_state_up \u003d vip[\u0027admin_state_up\u0027]"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY9M%3D","line":409,"in_reply_to":"AAAATH%2F%2FnrU%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            admin_state_up \u003d vip[\u0027admin_state_up\u0027]"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        dsr \u003d \u0027NO_DSR\u0027"},{"line_number":414,"context_line":"        if \u0027dsr\u0027 in vip:"},{"line_number":415,"context_line":"            dsr \u003d vip[\u0027dsr\u0027]"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        dsr_no_fast_delete \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnrQ%3D","line":414,"updated":"2013-10-12 13:41:34.000000000","message":"similar to above","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            admin_state_up \u003d vip[\u0027admin_state_up\u0027]"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        dsr \u003d \u0027NO_DSR\u0027"},{"line_number":414,"context_line":"        if \u0027dsr\u0027 in vip:"},{"line_number":415,"context_line":"            dsr \u003d vip[\u0027dsr\u0027]"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        dsr_no_fast_delete \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY9I%3D","line":414,"in_reply_to":"AAAATH%2F%2FnrQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            dsr \u003d vip[\u0027dsr\u0027]"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        dsr_no_fast_delete \u003d False"},{"line_number":418,"context_line":"        if \u0027dsr_no_fast_delete\u0027 in vip:"},{"line_number":419,"context_line":"            dsr_no_fast_delete \u003d vip[\u0027dsr_no_fast_delete\u0027]"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        enable_hc_l3_dsr \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnrM%3D","line":418,"updated":"2013-10-12 13:41:34.000000000","message":"same","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":415,"context_line":"            dsr \u003d vip[\u0027dsr\u0027]"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        dsr_no_fast_delete \u003d False"},{"line_number":418,"context_line":"        if \u0027dsr_no_fast_delete\u0027 in vip:"},{"line_number":419,"context_line":"            dsr_no_fast_delete \u003d vip[\u0027dsr_no_fast_delete\u0027]"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        enable_hc_l3_dsr \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY9A%3D","line":418,"in_reply_to":"AAAATH%2F%2FnrM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":419,"context_line":"            dsr_no_fast_delete \u003d vip[\u0027dsr_no_fast_delete\u0027]"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        enable_hc_l3_dsr \u003d False"},{"line_number":422,"context_line":"        if \u0027enable_hc_l3_dsr\u0027 in vip:"},{"line_number":423,"context_line":"            enable_hc_l3_dsr \u003d vip[\u0027enable_hc_l3_dsr\u0027]"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        server \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnrI%3D","line":422,"updated":"2013-10-12 13:41:34.000000000","message":"same","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":419,"context_line":"            dsr_no_fast_delete \u003d vip[\u0027dsr_no_fast_delete\u0027]"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        enable_hc_l3_dsr \u003d False"},{"line_number":422,"context_line":"        if \u0027enable_hc_l3_dsr\u0027 in vip:"},{"line_number":423,"context_line":"            enable_hc_l3_dsr \u003d vip[\u0027enable_hc_l3_dsr\u0027]"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        server \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY84%3D","line":422,"in_reply_to":"AAAATH%2F%2FnrI%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        if \u0027enable_hc_l3_dsr\u0027 in vip:"},{"line_number":423,"context_line":"            enable_hc_l3_dsr \u003d vip[\u0027enable_hc_l3_dsr\u0027]"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        server \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"},{"line_number":426,"context_line":"        server.Name \u003d vsName"},{"line_number":427,"context_line":"        server.IP \u003d vsIpAddress"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnq8%3D","line":425,"updated":"2013-10-12 13:41:34.000000000","message":"L425-434 seems to be the code repeated multiple times in this file. Consider refactoring","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        if \u0027enable_hc_l3_dsr\u0027 in vip:"},{"line_number":423,"context_line":"            enable_hc_l3_dsr \u003d vip[\u0027enable_hc_l3_dsr\u0027]"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        server \u003d self.slb_service_client.factory.create(\u0027Server\u0027)"},{"line_number":426,"context_line":"        server.Name \u003d vsName"},{"line_number":427,"context_line":"        server.IP \u003d vsIpAddress"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8w%3D","line":425,"in_reply_to":"AAAATH%2F%2Fnq8%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        # Create Virtual Server"},{"line_number":437,"context_line":"        try:"},{"line_number":438,"context_line":"            vsConfigSequence \u003d \\"},{"line_number":439,"context_line":"                (self.slb_service_client.factory"},{"line_number":440,"context_line":"                 .create(\u0027ArrayOfVirtualServerConfigurationSequence\u0027))"},{"line_number":441,"context_line":"            vsConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnrE%3D","line":438,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        # Create Virtual Server"},{"line_number":437,"context_line":"        try:"},{"line_number":438,"context_line":"            vsConfigSequence \u003d \\"},{"line_number":439,"context_line":"                (self.slb_service_client.factory"},{"line_number":440,"context_line":"                 .create(\u0027ArrayOfVirtualServerConfigurationSequence\u0027))"},{"line_number":441,"context_line":"            vsConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8o%3D","line":438,"in_reply_to":"AAAATH%2F%2FnrE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        # Create Virtual Server Port"},{"line_number":476,"context_line":"        try:"},{"line_number":477,"context_line":"            vsPortConfigSequence \u003d \\"},{"line_number":478,"context_line":"                (self.slb_service_client.factory"},{"line_number":479,"context_line":"                 .create(\u0027ArrayOfVirtualServerPortConfigurationSequence\u0027))"},{"line_number":480,"context_line":"            vsPortConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnq0%3D","line":477,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        # Create Virtual Server Port"},{"line_number":476,"context_line":"        try:"},{"line_number":477,"context_line":"            vsPortConfigSequence \u003d \\"},{"line_number":478,"context_line":"                (self.slb_service_client.factory"},{"line_number":479,"context_line":"                 .create(\u0027ArrayOfVirtualServerPortConfigurationSequence\u0027))"},{"line_number":480,"context_line":"            vsPortConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8k%3D","line":477,"in_reply_to":"AAAATH%2F%2Fnq0%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"            vsPortConfig.virtualServer \u003d server"},{"line_number":484,"context_line":"            vsPortConfig.port \u003d l4Port"},{"line_number":485,"context_line":"            vsPortAdminState \u003d \u0027ENABLED\u0027"},{"line_number":486,"context_line":"            if(admin_state_up \u003d\u003d False):"},{"line_number":487,"context_line":"                vsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":488,"context_line":"            vsPortConfig.adminState \u003d vsPortAdminState"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnqo%3D","line":485,"updated":"2013-10-12 13:41:34.000000000","message":"vsPortAdminState \u003d \u0027ENABLED\u0027 if admin_state_up else \u0027DISABLED\u0027","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"            vsPortConfig.virtualServer \u003d server"},{"line_number":484,"context_line":"            vsPortConfig.port \u003d l4Port"},{"line_number":485,"context_line":"            vsPortAdminState \u003d \u0027ENABLED\u0027"},{"line_number":486,"context_line":"            if(admin_state_up \u003d\u003d False):"},{"line_number":487,"context_line":"                vsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":488,"context_line":"            vsPortConfig.adminState \u003d vsPortAdminState"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8g%3D","line":485,"in_reply_to":"AAAATH%2F%2Fnqo%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"            if \u0027session_persistence\u0027 in vip:"},{"line_number":491,"context_line":"                type \u003d vip[\u0027session_persistence\u0027][\u0027type\u0027]"},{"line_number":492,"context_line":"                if(type \u003d\u003d \u0027SOURCE_IP\u0027):"},{"line_number":493,"context_line":"                    vsPortConfig.enableSticky \u003d True"},{"line_number":494,"context_line":"                else:"},{"line_number":495,"context_line":"                    error_message \u003d (\u0027Session Persistence of type %s \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnqg%3D","line":492,"updated":"2013-10-12 13:41:34.000000000","message":"parens not needed.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"            if \u0027session_persistence\u0027 in vip:"},{"line_number":491,"context_line":"                type \u003d vip[\u0027session_persistence\u0027][\u0027type\u0027]"},{"line_number":492,"context_line":"                if(type \u003d\u003d \u0027SOURCE_IP\u0027):"},{"line_number":493,"context_line":"                    vsPortConfig.enableSticky \u003d True"},{"line_number":494,"context_line":"                else:"},{"line_number":495,"context_line":"                    error_message \u003d (\u0027Session Persistence of type %s \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8c%3D","line":492,"in_reply_to":"AAAATH%2F%2Fnqg%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                if(type \u003d\u003d \u0027SOURCE_IP\u0027):"},{"line_number":493,"context_line":"                    vsPortConfig.enableSticky \u003d True"},{"line_number":494,"context_line":"                else:"},{"line_number":495,"context_line":"                    error_message \u003d (\u0027Session Persistence of type %s \u0027"},{"line_number":496,"context_line":"                                     \u0027not supported\u0027 % (type))"},{"line_number":497,"context_line":"                    raise UnsupportedFeature(msg\u003derror_message)"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnqY%3D","line":495,"updated":"2013-10-12 13:41:34.000000000","message":"add internationalisation:\n error_message \u003d (_(\u0027Session Persistence of type %s not supported\u0027 % type))","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                if(type \u003d\u003d \u0027SOURCE_IP\u0027):"},{"line_number":493,"context_line":"                    vsPortConfig.enableSticky \u003d True"},{"line_number":494,"context_line":"                else:"},{"line_number":495,"context_line":"                    error_message \u003d (\u0027Session Persistence of type %s \u0027"},{"line_number":496,"context_line":"                                     \u0027not supported\u0027 % (type))"},{"line_number":497,"context_line":"                    raise UnsupportedFeature(msg\u003derror_message)"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8Y%3D","line":495,"in_reply_to":"AAAATH%2F%2FnqY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":552,"context_line":"            pass"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        try:"},{"line_number":555,"context_line":"            if(vipPortCount \u003d\u003d 2):"},{"line_number":556,"context_line":"                self.slb_service_client.service.deleteVirtualServer(vs)"},{"line_number":557,"context_line":"        except WebFault as e:"},{"line_number":558,"context_line":"            raise ConfigError(msg\u003de.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnqQ%3D","line":555,"updated":"2013-10-12 13:41:34.000000000","message":"if vipPortCount \u003d\u003d 2:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":552,"context_line":"            pass"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"        try:"},{"line_number":555,"context_line":"            if(vipPortCount \u003d\u003d 2):"},{"line_number":556,"context_line":"                self.slb_service_client.service.deleteVirtualServer(vs)"},{"line_number":557,"context_line":"        except WebFault as e:"},{"line_number":558,"context_line":"            raise ConfigError(msg\u003de.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8U%3D","line":555,"in_reply_to":"AAAATH%2F%2FnqQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        vsPort \u003d new_vip[\u0027protocol_port\u0027]"},{"line_number":573,"context_line":"        vsName \u003d new_vip[\u0027name\u0027]"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        session_persistence \u003d None"},{"line_number":576,"context_line":"        if \u0027session_persistence\u0027 in new_vip:"},{"line_number":577,"context_line":"            session_persistence \u003d new_vip[\u0027session_persistence\u0027]"},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnqM%3D","line":575,"updated":"2013-10-12 13:41:34.000000000","message":"L575-577:\n session_persistence \u003d new_vip.get(\u0027session_persistence\u0027)","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":572,"context_line":"        vsPort \u003d new_vip[\u0027protocol_port\u0027]"},{"line_number":573,"context_line":"        vsName \u003d new_vip[\u0027name\u0027]"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        session_persistence \u003d None"},{"line_number":576,"context_line":"        if \u0027session_persistence\u0027 in new_vip:"},{"line_number":577,"context_line":"            session_persistence \u003d new_vip[\u0027session_persistence\u0027]"},{"line_number":578,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8Q%3D","line":575,"in_reply_to":"AAAATH%2F%2FnqM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        if \u0027admin_state_up\u0027 in new_vip:"},{"line_number":591,"context_line":"            admin_state_up \u003d new_vip[\u0027admin_state_up\u0027]"},{"line_number":592,"context_line":"            try:"},{"line_number":593,"context_line":"                if(admin_state_up \u003d\u003d True):"},{"line_number":594,"context_line":"                        (self.slb_service_client.service"},{"line_number":595,"context_line":"                         .enableVirtualServerPort(vsServerPort))"},{"line_number":596,"context_line":"                elif(admin_state_up \u003d\u003d False):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnqE%3D","line":593,"updated":"2013-10-12 13:41:34.000000000","message":"if admin_state_up:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        if \u0027admin_state_up\u0027 in new_vip:"},{"line_number":591,"context_line":"            admin_state_up \u003d new_vip[\u0027admin_state_up\u0027]"},{"line_number":592,"context_line":"            try:"},{"line_number":593,"context_line":"                if(admin_state_up \u003d\u003d True):"},{"line_number":594,"context_line":"                        (self.slb_service_client.service"},{"line_number":595,"context_line":"                         .enableVirtualServerPort(vsServerPort))"},{"line_number":596,"context_line":"                elif(admin_state_up \u003d\u003d False):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8M%3D","line":593,"in_reply_to":"AAAATH%2F%2FnqE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":593,"context_line":"                if(admin_state_up \u003d\u003d True):"},{"line_number":594,"context_line":"                        (self.slb_service_client.service"},{"line_number":595,"context_line":"                         .enableVirtualServerPort(vsServerPort))"},{"line_number":596,"context_line":"                elif(admin_state_up \u003d\u003d False):"},{"line_number":597,"context_line":"                        (self.slb_service_client.service"},{"line_number":598,"context_line":"                         .disableVirtualServerPort(vsServerPort))"},{"line_number":599,"context_line":"            except WebFault as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnp8%3D","line":596,"updated":"2013-10-12 13:41:34.000000000","message":"just use \n else:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":593,"context_line":"                if(admin_state_up \u003d\u003d True):"},{"line_number":594,"context_line":"                        (self.slb_service_client.service"},{"line_number":595,"context_line":"                         .enableVirtualServerPort(vsServerPort))"},{"line_number":596,"context_line":"                elif(admin_state_up \u003d\u003d False):"},{"line_number":597,"context_line":"                        (self.slb_service_client.service"},{"line_number":598,"context_line":"                         .disableVirtualServerPort(vsServerPort))"},{"line_number":599,"context_line":"            except WebFault as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8I%3D","line":596,"in_reply_to":"AAAATH%2F%2Fnp8%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        if session_persistence:"},{"line_number":603,"context_line":"            type \u003d new_vip[\u0027session_persistence\u0027][\u0027type\u0027]"},{"line_number":604,"context_line":"            if(type \u003d\u003d \u0027SOURCE_IP\u0027):"},{"line_number":605,"context_line":"                try:"},{"line_number":606,"context_line":"                    (self.slb_service_client.service"},{"line_number":607,"context_line":"                     .enableStickyOnVirtualServerPort(vsServerPort))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnqA%3D","line":604,"updated":"2013-10-12 13:41:34.000000000","message":"no parens:\n if type \u003d\u003d \u0027SOURCE_IP\u0027:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        if session_persistence:"},{"line_number":603,"context_line":"            type \u003d new_vip[\u0027session_persistence\u0027][\u0027type\u0027]"},{"line_number":604,"context_line":"            if(type \u003d\u003d \u0027SOURCE_IP\u0027):"},{"line_number":605,"context_line":"                try:"},{"line_number":606,"context_line":"                    (self.slb_service_client.service"},{"line_number":607,"context_line":"                     .enableStickyOnVirtualServerPort(vsServerPort))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8E%3D","line":604,"in_reply_to":"AAAATH%2F%2FnqA%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":638,"context_line":"    def _is_port_policy_in_use(self, health_monitor_name):"},{"line_number":639,"context_line":"        startIndex \u003d 1"},{"line_number":640,"context_line":"        numRetrieved \u003d 15"},{"line_number":641,"context_line":"        portPolicySummaryFilter \u003d \\"},{"line_number":642,"context_line":"            (self.slb_service_client.factory"},{"line_number":643,"context_line":"             .create(\u0027PortPolicySummaryFilter\u0027))"},{"line_number":644,"context_line":"        simpleFilter \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnp4%3D","line":641,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":638,"context_line":"    def _is_port_policy_in_use(self, health_monitor_name):"},{"line_number":639,"context_line":"        startIndex \u003d 1"},{"line_number":640,"context_line":"        numRetrieved \u003d 15"},{"line_number":641,"context_line":"        portPolicySummaryFilter \u003d \\"},{"line_number":642,"context_line":"            (self.slb_service_client.factory"},{"line_number":643,"context_line":"             .create(\u0027PortPolicySummaryFilter\u0027))"},{"line_number":644,"context_line":"        simpleFilter \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY8A%3D","line":641,"in_reply_to":"AAAATH%2F%2Fnp4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        portPolicySummaryFilter \u003d \\"},{"line_number":642,"context_line":"            (self.slb_service_client.factory"},{"line_number":643,"context_line":"             .create(\u0027PortPolicySummaryFilter\u0027))"},{"line_number":644,"context_line":"        simpleFilter \u003d \\"},{"line_number":645,"context_line":"            (self.slb_service_client.factory"},{"line_number":646,"context_line":"             .create(\u0027PortPolicySummarySimpleFilter\u0027))"},{"line_number":647,"context_line":"        simpleFilter.field \u003d \u0027POLICY_NAME\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnp0%3D","line":644,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":641,"context_line":"        portPolicySummaryFilter \u003d \\"},{"line_number":642,"context_line":"            (self.slb_service_client.factory"},{"line_number":643,"context_line":"             .create(\u0027PortPolicySummaryFilter\u0027))"},{"line_number":644,"context_line":"        simpleFilter \u003d \\"},{"line_number":645,"context_line":"            (self.slb_service_client.factory"},{"line_number":646,"context_line":"             .create(\u0027PortPolicySummarySimpleFilter\u0027))"},{"line_number":647,"context_line":"        simpleFilter.field \u003d \u0027POLICY_NAME\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY78%3D","line":644,"in_reply_to":"AAAATH%2F%2Fnp0%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                     .getAllPortPolicies(startIndex,"},{"line_number":656,"context_line":"                                         numRetrieved,"},{"line_number":657,"context_line":"                                         portPolicySummaryFilter))"},{"line_number":658,"context_line":"            if reply and reply.policyList !\u003d \u0027\u0027:"},{"line_number":659,"context_line":"                policyList \u003d reply.policyList.PortPoliciesSummarySequence"},{"line_number":660,"context_line":"                for policy in policyList:"},{"line_number":661,"context_line":"                    is_inUse \u003d policy.inUse"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnpo%3D","line":658,"updated":"2013-10-12 13:41:34.000000000","message":"empty string evaluates to False, so more pythonic way would be to write:\n if reply and reply.policyList:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":655,"context_line":"                     .getAllPortPolicies(startIndex,"},{"line_number":656,"context_line":"                                         numRetrieved,"},{"line_number":657,"context_line":"                                         portPolicySummaryFilter))"},{"line_number":658,"context_line":"            if reply and reply.policyList !\u003d \u0027\u0027:"},{"line_number":659,"context_line":"                policyList \u003d reply.policyList.PortPoliciesSummarySequence"},{"line_number":660,"context_line":"                for policy in policyList:"},{"line_number":661,"context_line":"                    is_inUse \u003d policy.inUse"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY74%3D","line":658,"in_reply_to":"AAAATH%2F%2Fnpo%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":657,"context_line":"                                         portPolicySummaryFilter))"},{"line_number":658,"context_line":"            if reply and reply.policyList !\u003d \u0027\u0027:"},{"line_number":659,"context_line":"                policyList \u003d reply.policyList.PortPoliciesSummarySequence"},{"line_number":660,"context_line":"                for policy in policyList:"},{"line_number":661,"context_line":"                    is_inUse \u003d policy.inUse"},{"line_number":662,"context_line":"                    return is_inUse"},{"line_number":663,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnpU%3D","line":660,"updated":"2013-10-12 13:41:34.000000000","message":"it\u0027s not clear what this loop does since it exits in first iteration.\nAre you trying to find any policy inUse and then return true?\n\nThen it would be:\n  return any(policy.inUse for policy in policyList)","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":657,"context_line":"                                         portPolicySummaryFilter))"},{"line_number":658,"context_line":"            if reply and reply.policyList !\u003d \u0027\u0027:"},{"line_number":659,"context_line":"                policyList \u003d reply.policyList.PortPoliciesSummarySequence"},{"line_number":660,"context_line":"                for policy in policyList:"},{"line_number":661,"context_line":"                    is_inUse \u003d policy.inUse"},{"line_number":662,"context_line":"                    return is_inUse"},{"line_number":663,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7w%3D","line":660,"in_reply_to":"AAAATH%2F%2FnpU%3D","updated":"2013-10-16 20:59:47.000000000","message":"Yes. The code tries to find any policy (in this case it will return only one policy because of the filter). I have modified the code as per you had suggested.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    @log"},{"line_number":672,"context_line":"    def _does_port_policy_exist(self, health_monitor):"},{"line_number":673,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":674,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":675,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":676,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":677,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnpQ%3D","line":674,"updated":"2013-10-12 13:41:34.000000000","message":"L674-676:\n if health_monitor.get(\u0027name\u0027):\n     name \u003d health_monitor[\u0027name\u0027]","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    @log"},{"line_number":672,"context_line":"    def _does_port_policy_exist(self, health_monitor):"},{"line_number":673,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":674,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":675,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":676,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":677,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7s%3D","line":674,"in_reply_to":"AAAATH%2F%2FnpQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":677,"context_line":"        try:"},{"line_number":678,"context_line":"            reply \u003d self.slb_service_client.service.getPortPolicy(name)"},{"line_number":679,"context_line":"            if(reply \u003d\u003d False):"},{"line_number":680,"context_line":"                return False"},{"line_number":681,"context_line":"        except WebFault:"},{"line_number":682,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnpM%3D","line":679,"updated":"2013-10-12 13:41:34.000000000","message":"if not reply:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":677,"context_line":"        try:"},{"line_number":678,"context_line":"            reply \u003d self.slb_service_client.service.getPortPolicy(name)"},{"line_number":679,"context_line":"            if(reply \u003d\u003d False):"},{"line_number":680,"context_line":"                return False"},{"line_number":681,"context_line":"        except WebFault:"},{"line_number":682,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7o%3D","line":679,"in_reply_to":"AAAATH%2F%2FnpM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        return True"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    @log"},{"line_number":686,"context_line":"    def _create_port_policy(self, health_monitor):"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":689,"context_line":"        if \u0027name\u0027 in health_monitor:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fk4Y%3D","line":686,"updated":"2013-10-14 11:46:47.000000000","message":"Consider dividing into several funcs as well","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        return True"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    @log"},{"line_number":686,"context_line":"    def _create_port_policy(self, health_monitor):"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":689,"context_line":"        if \u0027name\u0027 in health_monitor:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7U%3D","line":686,"in_reply_to":"AAAATH%2F%2Fk4Y%3D","updated":"2013-10-16 20:59:47.000000000","message":"I will look at the code and see if I could split into several functions. For now, I will leave it the same way though I agree that the function is quite big","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    def _create_port_policy(self, health_monitor):"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":689,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":690,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":691,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnpI%3D","line":689,"updated":"2013-10-12 13:41:34.000000000","message":"use .get(\u0027name\u0027) as above","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    def _create_port_policy(self, health_monitor):"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":689,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":690,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":691,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7g%3D","line":689,"in_reply_to":"AAAATH%2F%2FnpI%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        delay \u003d health_monitor[\u0027delay\u0027]"},{"line_number":695,"context_line":"        max_retries \u003d health_monitor[\u0027max_retries\u0027]"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        if(monitor_type \u003d\u003d \u0027HTTP\u0027 or"},{"line_number":698,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":699,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fk4M%3D","line":697,"updated":"2013-10-14 11:46:47.000000000","message":"if monitor_type in [\u0027HTTP\u0027, \u0027HTTPS\u0027, \u0027TCP\u0027]:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        delay \u003d health_monitor[\u0027delay\u0027]"},{"line_number":695,"context_line":"        max_retries \u003d health_monitor[\u0027max_retries\u0027]"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        if(monitor_type \u003d\u003d \u0027HTTP\u0027 or"},{"line_number":698,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":699,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7c%3D","line":697,"in_reply_to":"AAAATH%2F%2Fk4M%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                        start_status_codes.append(int(code))"},{"line_number":753,"context_line":"                        end_status_codes.append(int(code))"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"            if(monitor_type \u003d\u003d \u0027HTTP\u0027):"},{"line_number":756,"context_line":"                httpPortPolicy \u003d (self.slb_service_client.factory"},{"line_number":757,"context_line":"                                  .create(\u0027HttpPortPolicy\u0027))"},{"line_number":758,"context_line":"                urlHealthCheck \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnpE%3D","line":755,"updated":"2013-10-12 13:41:34.000000000","message":"parens unneeded here and on L775, 786","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                        start_status_codes.append(int(code))"},{"line_number":753,"context_line":"                        end_status_codes.append(int(code))"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"            if(monitor_type \u003d\u003d \u0027HTTP\u0027):"},{"line_number":756,"context_line":"                httpPortPolicy \u003d (self.slb_service_client.factory"},{"line_number":757,"context_line":"                                  .create(\u0027HttpPortPolicy\u0027))"},{"line_number":758,"context_line":"                urlHealthCheck \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7Q%3D","line":755,"in_reply_to":"AAAATH%2F%2FnpE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":819,"context_line":"            raise UnsupportedFeature(msg\u003dm)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":822,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":823,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":824,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":825,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnpA%3D","line":822,"updated":"2013-10-12 13:41:34.000000000","message":"same as above:\n if health_monitor.get(\u0027name\u0027):","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":819,"context_line":"            raise UnsupportedFeature(msg\u003dm)"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        name \u003d health_monitor[\u0027id\u0027]"},{"line_number":822,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":823,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":824,"context_line":"                name \u003d health_monitor[\u0027name\u0027]"},{"line_number":825,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7M%3D","line":822,"in_reply_to":"AAAATH%2F%2FnpA%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        # Create Port Policy"},{"line_number":829,"context_line":"        # if the Monitor Type is TCP / HTTP / HTTPS"},{"line_number":830,"context_line":"        if(monitor_type \u003d\u003d \u0027HTTP\u0027 or"},{"line_number":831,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":832,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":833,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkvg%3D","line":830,"updated":"2013-10-14 11:46:47.000000000","message":"if monitor_type in [\u0027HTTP\u0027, \u0027HTTPS\u0027, \u0027TCP\u0027]:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        # Create Port Policy"},{"line_number":829,"context_line":"        # if the Monitor Type is TCP / HTTP / HTTPS"},{"line_number":830,"context_line":"        if(monitor_type \u003d\u003d \u0027HTTP\u0027 or"},{"line_number":831,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":832,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":833,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7E%3D","line":830,"in_reply_to":"AAAATH%2F%2Fkvg%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":831,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":832,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"            if (self._does_port_policy_exist(health_monitor) \u003d\u003d False):"},{"line_number":835,"context_line":"                self._create_port_policy(health_monitor)"},{"line_number":836,"context_line":"            else:"},{"line_number":837,"context_line":"                LOG.debug(_(\u0027Port Policy %s already exists on the device\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fno8%3D","line":834,"updated":"2013-10-12 13:41:34.000000000","message":"if not self._does_port_policy_exist(health_monitor):","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":831,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":832,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"            if (self._does_port_policy_exist(health_monitor) \u003d\u003d False):"},{"line_number":835,"context_line":"                self._create_port_policy(health_monitor)"},{"line_number":836,"context_line":"            else:"},{"line_number":837,"context_line":"                LOG.debug(_(\u0027Port Policy %s already exists on the device\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY7A%3D","line":834,"in_reply_to":"AAAATH%2F%2Fno8%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":853,"context_line":"    @log"},{"line_number":854,"context_line":"    def delete_health_monitor(self, health_monitor, pool_id):"},{"line_number":855,"context_line":"        healthMonitorName \u003d health_monitor[\u0027id\u0027]"},{"line_number":856,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":857,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":858,"context_line":"                healthMonitorName \u003d health_monitor[\u0027name\u0027]"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fno4%3D","line":856,"updated":"2013-10-12 13:41:34.000000000","message":"same as above","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":853,"context_line":"    @log"},{"line_number":854,"context_line":"    def delete_health_monitor(self, health_monitor, pool_id):"},{"line_number":855,"context_line":"        healthMonitorName \u003d health_monitor[\u0027id\u0027]"},{"line_number":856,"context_line":"        if \u0027name\u0027 in health_monitor:"},{"line_number":857,"context_line":"            if health_monitor[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":858,"context_line":"                healthMonitorName \u003d health_monitor[\u0027name\u0027]"},{"line_number":859,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY68%3D","line":856,"in_reply_to":"AAAATH%2F%2Fno4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":868,"context_line":"        if(monitor_type \u003d\u003d \u0027HTTP\u0027 or"},{"line_number":869,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":870,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":871,"context_line":"            if (self._does_port_policy_exist(health_monitor) \u003d\u003d False):"},{"line_number":872,"context_line":"                LOG.debug(\u0027Health Monitor %s does not exist on the device\u0027,"},{"line_number":873,"context_line":"                          healthMonitorName)"},{"line_number":874,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnos%3D","line":871,"updated":"2013-10-12 13:41:34.000000000","message":"if not ...","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":868,"context_line":"        if(monitor_type \u003d\u003d \u0027HTTP\u0027 or"},{"line_number":869,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":870,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":871,"context_line":"            if (self._does_port_policy_exist(health_monitor) \u003d\u003d False):"},{"line_number":872,"context_line":"                LOG.debug(\u0027Health Monitor %s does not exist on the device\u0027,"},{"line_number":873,"context_line":"                          healthMonitorName)"},{"line_number":874,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY64%3D","line":871,"in_reply_to":"AAAATH%2F%2Fnos%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":869,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":870,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":871,"context_line":"            if (self._does_port_policy_exist(health_monitor) \u003d\u003d False):"},{"line_number":872,"context_line":"                LOG.debug(\u0027Health Monitor %s does not exist on the device\u0027,"},{"line_number":873,"context_line":"                          healthMonitorName)"},{"line_number":874,"context_line":"                return"},{"line_number":875,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnoo%3D","line":872,"updated":"2013-10-12 13:41:34.000000000","message":"i18n is missing","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":869,"context_line":"           monitor_type \u003d\u003d \u0027HTTPS\u0027 or"},{"line_number":870,"context_line":"           monitor_type \u003d\u003d \u0027TCP\u0027):"},{"line_number":871,"context_line":"            if (self._does_port_policy_exist(health_monitor) \u003d\u003d False):"},{"line_number":872,"context_line":"                LOG.debug(\u0027Health Monitor %s does not exist on the device\u0027,"},{"line_number":873,"context_line":"                          healthMonitorName)"},{"line_number":874,"context_line":"                return"},{"line_number":875,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY60%3D","line":872,"in_reply_to":"AAAATH%2F%2Fnoo%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":877,"context_line":"                try:"},{"line_number":878,"context_line":"                    (self.slb_service_client.service"},{"line_number":879,"context_line":"                     .deletePortPolicy(healthMonitorName))"},{"line_number":880,"context_line":"                    LOG.debug(\u0027Health Monitor %s deleted successfully\u0027,"},{"line_number":881,"context_line":"                              healthMonitorName)"},{"line_number":882,"context_line":"                except WebFault as e:"},{"line_number":883,"context_line":"                    raise ConfigError(msg\u003de.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnok%3D","line":880,"updated":"2013-10-12 13:41:34.000000000","message":"i18n is missing","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":877,"context_line":"                try:"},{"line_number":878,"context_line":"                    (self.slb_service_client.service"},{"line_number":879,"context_line":"                     .deletePortPolicy(healthMonitorName))"},{"line_number":880,"context_line":"                    LOG.debug(\u0027Health Monitor %s deleted successfully\u0027,"},{"line_number":881,"context_line":"                              healthMonitorName)"},{"line_number":882,"context_line":"                except WebFault as e:"},{"line_number":883,"context_line":"                    raise ConfigError(msg\u003de.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6w%3D","line":880,"in_reply_to":"AAAATH%2F%2Fnok%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                except WebFault as e:"},{"line_number":883,"context_line":"                    raise ConfigError(msg\u003de.message)"},{"line_number":884,"context_line":"        elif(monitor_type \u003d\u003d \u0027PING\u0027):"},{"line_number":885,"context_line":"            m \u003d \u0027Delete of PING Monitor not supported\u0027"},{"line_number":886,"context_line":"            LOG.debug(m)"},{"line_number":887,"context_line":"            raise UnsupportedFeature(msg\u003dm)"},{"line_number":888,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnog%3D","line":885,"updated":"2013-10-12 13:41:34.000000000","message":"i18n is missing","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                except WebFault as e:"},{"line_number":883,"context_line":"                    raise ConfigError(msg\u003de.message)"},{"line_number":884,"context_line":"        elif(monitor_type \u003d\u003d \u0027PING\u0027):"},{"line_number":885,"context_line":"            m \u003d \u0027Delete of PING Monitor not supported\u0027"},{"line_number":886,"context_line":"            LOG.debug(m)"},{"line_number":887,"context_line":"            raise UnsupportedFeature(msg\u003dm)"},{"line_number":888,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6s%3D","line":885,"in_reply_to":"AAAATH%2F%2Fnog%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        pool_id \u003d member[\u0027pool_id\u0027]"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        name \u003d address"},{"line_number":898,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":899,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":900,"context_line":"                name \u003d member[\u0027name\u0027]"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnoc%3D","line":898,"updated":"2013-10-12 13:41:34.000000000","message":"use .get here and below","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        pool_id \u003d member[\u0027pool_id\u0027]"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        name \u003d address"},{"line_number":898,"context_line":"        if \u0027name\u0027 in member:"},{"line_number":899,"context_line":"            if member[\u0027name\u0027] !\u003d \u0027\u0027:"},{"line_number":900,"context_line":"                name \u003d member[\u0027name\u0027]"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6o%3D","line":898,"in_reply_to":"AAAATH%2F%2Fnoc%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        rs.IP \u003d address"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        try:"},{"line_number":917,"context_line":"            rsConfigSequence \u003d \\"},{"line_number":918,"context_line":"                (self.slb_service_client.factory"},{"line_number":919,"context_line":"                 .create(\u0027ArrayOfRealServerConfigurationSequence\u0027))"},{"line_number":920,"context_line":"            rsConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnoQ%3D","line":917,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        rs.IP \u003d address"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        try:"},{"line_number":917,"context_line":"            rsConfigSequence \u003d \\"},{"line_number":918,"context_line":"                (self.slb_service_client.factory"},{"line_number":919,"context_line":"                 .create(\u0027ArrayOfRealServerConfigurationSequence\u0027))"},{"line_number":920,"context_line":"            rsConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6k%3D","line":917,"in_reply_to":"AAAATH%2F%2FnoQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":933,"context_line":"             .createRealServerWithConfiguration(rsConfigSequence))"},{"line_number":934,"context_line":"        except WebFault as e:"},{"line_number":935,"context_line":"            LOG.debug(_(\u0027Error in creating Real Server %s\u0027), e)"},{"line_number":936,"context_line":"            pass"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"        # Create Real Server Port"},{"line_number":939,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkvM%3D","line":936,"updated":"2013-10-14 11:46:47.000000000","message":"not needed","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":933,"context_line":"             .createRealServerWithConfiguration(rsConfigSequence))"},{"line_number":934,"context_line":"        except WebFault as e:"},{"line_number":935,"context_line":"            LOG.debug(_(\u0027Error in creating Real Server %s\u0027), e)"},{"line_number":936,"context_line":"            pass"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"        # Create Real Server Port"},{"line_number":939,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6g%3D","line":936,"in_reply_to":"AAAATH%2F%2FkvM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":937,"context_line":""},{"line_number":938,"context_line":"        # Create Real Server Port"},{"line_number":939,"context_line":"        try:"},{"line_number":940,"context_line":"            rsPortConfigSequence \u003d \\"},{"line_number":941,"context_line":"                (self.slb_service_client.factory"},{"line_number":942,"context_line":"                 .create(\u0027ArrayOfRealServerPortConfigurationSequence\u0027))"},{"line_number":943,"context_line":"            rsPortConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnoM%3D","line":940,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":937,"context_line":""},{"line_number":938,"context_line":"        # Create Real Server Port"},{"line_number":939,"context_line":"        try:"},{"line_number":940,"context_line":"            rsPortConfigSequence \u003d \\"},{"line_number":941,"context_line":"                (self.slb_service_client.factory"},{"line_number":942,"context_line":"                 .create(\u0027ArrayOfRealServerPortConfigurationSequence\u0027))"},{"line_number":943,"context_line":"            rsPortConfig \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6c%3D","line":940,"in_reply_to":"AAAATH%2F%2FnoM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":951,"context_line":"            rsServerPort.port \u003d rsL4Port"},{"line_number":952,"context_line":"            rsPortConfig.serverPort \u003d rsServerPort"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"            rsPortAdminState \u003d \u0027ENABLED\u0027"},{"line_number":955,"context_line":"            if(admin_state_up \u003d\u003d False):"},{"line_number":956,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":957,"context_line":"            rsPortConfig.adminState \u003d rsPortAdminState"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnoI%3D","line":954,"updated":"2013-10-12 13:41:34.000000000","message":"please refactor 954-956 as suggested above","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":951,"context_line":"            rsServerPort.port \u003d rsL4Port"},{"line_number":952,"context_line":"            rsPortConfig.serverPort \u003d rsServerPort"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"            rsPortAdminState \u003d \u0027ENABLED\u0027"},{"line_number":955,"context_line":"            if(admin_state_up \u003d\u003d False):"},{"line_number":956,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":957,"context_line":"            rsPortConfig.adminState \u003d rsPortAdminState"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6Y%3D","line":954,"in_reply_to":"AAAATH%2F%2FnoI%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":956,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":957,"context_line":"            rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"            if \u0027max_connections\u0027 in member:"},{"line_number":960,"context_line":"                rsPortConfig.maxConnection \u003d member[\u0027max_connections\u0027]"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"            rsPortConfig.isBackup \u003d is_backup"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnoE%3D","line":959,"updated":"2013-10-12 13:41:34.000000000","message":"use .get:\n rsPortConfig.maxConnection \u003d member.get(\u0027max_connections\u0027, DEFAULT_MAX_CONN)\n\nby the way,  maxConnection or maxConnections?","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":956,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":957,"context_line":"            rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"            if \u0027max_connections\u0027 in member:"},{"line_number":960,"context_line":"                rsPortConfig.maxConnection \u003d member[\u0027max_connections\u0027]"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"            rsPortConfig.isBackup \u003d is_backup"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY6E%3D","line":959,"in_reply_to":"AAAATH%2F%2FnoE%3D","updated":"2013-10-16 20:59:47.000000000","message":"On our hardware box, it is maxConnection :-)\nI incorporated your other comment","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":976,"context_line":"        # bind the member to the vip"},{"line_number":977,"context_line":"        pool \u003d self._get_pool(pool_id)"},{"line_number":978,"context_line":"        vip_id \u003d pool[\u0027vip_id\u0027]"},{"line_number":979,"context_line":"        if(vip_id !\u003d None):"},{"line_number":980,"context_line":"            vip \u003d self._get_vip(vip_id)"},{"line_number":981,"context_line":"            self._bind_member_to_vip(member, vip)"},{"line_number":982,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnoA%3D","line":979,"updated":"2013-10-12 13:41:34.000000000","message":"if vip_id is not None:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":976,"context_line":"        # bind the member to the vip"},{"line_number":977,"context_line":"        pool \u003d self._get_pool(pool_id)"},{"line_number":978,"context_line":"        vip_id \u003d pool[\u0027vip_id\u0027]"},{"line_number":979,"context_line":"        if(vip_id !\u003d None):"},{"line_number":980,"context_line":"            vip \u003d self._get_vip(vip_id)"},{"line_number":981,"context_line":"            self._bind_member_to_vip(member, vip)"},{"line_number":982,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY58%3D","line":979,"in_reply_to":"AAAATH%2F%2FnoA%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"        except WebFault as e:"},{"line_number":1007,"context_line":"            raise ConfigError(msg\u003de.message)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        try:"},{"line_number":1010,"context_line":"            # Delete the Real Server"},{"line_number":1011,"context_line":"            # if this is the only port other than default port"},{"line_number":1012,"context_line":"            if(rsPortCount \u003d\u003d 2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkuY%3D","line":1009,"updated":"2013-10-14 11:46:47.000000000","message":"second try block not needed: can combine with try block from line #1004","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"        except WebFault as e:"},{"line_number":1007,"context_line":"            raise ConfigError(msg\u003de.message)"},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"        try:"},{"line_number":1010,"context_line":"            # Delete the Real Server"},{"line_number":1011,"context_line":"            # if this is the only port other than default port"},{"line_number":1012,"context_line":"            if(rsPortCount \u003d\u003d 2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY54%3D","line":1009,"in_reply_to":"AAAATH%2F%2FkuY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"        try:"},{"line_number":1010,"context_line":"            # Delete the Real Server"},{"line_number":1011,"context_line":"            # if this is the only port other than default port"},{"line_number":1012,"context_line":"            if(rsPortCount \u003d\u003d 2):"},{"line_number":1013,"context_line":"                self.slb_service_client.service.deleteRealServer(rs)"},{"line_number":1014,"context_line":"        except WebFault as e:"},{"line_number":1015,"context_line":"            raise ConfigError(msg\u003de.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnn8%3D","line":1012,"updated":"2013-10-12 13:41:34.000000000","message":"unneeded parens","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"        try:"},{"line_number":1010,"context_line":"            # Delete the Real Server"},{"line_number":1011,"context_line":"            # if this is the only port other than default port"},{"line_number":1012,"context_line":"            if(rsPortCount \u003d\u003d 2):"},{"line_number":1013,"context_line":"                self.slb_service_client.service.deleteRealServer(rs)"},{"line_number":1014,"context_line":"        except WebFault as e:"},{"line_number":1015,"context_line":"            raise ConfigError(msg\u003de.message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY50%3D","line":1012,"in_reply_to":"AAAATH%2F%2Fnn8%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"            # If pool bound to a vip, unbind the Members from vip"},{"line_number":1056,"context_line":"            old_pool \u003d self._get_pool(old_pool_id)"},{"line_number":1057,"context_line":"            old_vip_id \u003d old_pool[\u0027vip_id\u0027]"},{"line_number":1058,"context_line":"            if(old_vip_id and old_vip_id !\u003d \u0027\u0027):"},{"line_number":1059,"context_line":"                old_vip \u003d self._get_vip(old_vip_id)"},{"line_number":1060,"context_line":"                self._unbind_member_from_vip(new_member, old_vip)"},{"line_number":1061,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnn4%3D","line":1058,"updated":"2013-10-12 13:41:34.000000000","message":"that is equal to just: \n if old_vip_id:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"            # If pool bound to a vip, unbind the Members from vip"},{"line_number":1056,"context_line":"            old_pool \u003d self._get_pool(old_pool_id)"},{"line_number":1057,"context_line":"            old_vip_id \u003d old_pool[\u0027vip_id\u0027]"},{"line_number":1058,"context_line":"            if(old_vip_id and old_vip_id !\u003d \u0027\u0027):"},{"line_number":1059,"context_line":"                old_vip \u003d self._get_vip(old_vip_id)"},{"line_number":1060,"context_line":"                self._unbind_member_from_vip(new_member, old_vip)"},{"line_number":1061,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5w%3D","line":1058,"in_reply_to":"AAAATH%2F%2Fnn4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1063,"context_line":"            # UnBind the Members from vip"},{"line_number":1064,"context_line":"            new_pool \u003d self._get_pool(new_pool_id)"},{"line_number":1065,"context_line":"            new_vip_id \u003d new_pool[\u0027vip_id\u0027]"},{"line_number":1066,"context_line":"            if(new_vip_id and new_vip_id !\u003d \u0027\u0027):"},{"line_number":1067,"context_line":"                new_vip \u003d self._get_vip(new_vip_id)"},{"line_number":1068,"context_line":"                self._bind_member_to_vip(new_member, new_vip)"},{"line_number":1069,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnn0%3D","line":1066,"updated":"2013-10-12 13:41:34.000000000","message":"same as above","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1063,"context_line":"            # UnBind the Members from vip"},{"line_number":1064,"context_line":"            new_pool \u003d self._get_pool(new_pool_id)"},{"line_number":1065,"context_line":"            new_vip_id \u003d new_pool[\u0027vip_id\u0027]"},{"line_number":1066,"context_line":"            if(new_vip_id and new_vip_id !\u003d \u0027\u0027):"},{"line_number":1067,"context_line":"                new_vip \u003d self._get_vip(new_vip_id)"},{"line_number":1068,"context_line":"                self._bind_member_to_vip(new_member, new_vip)"},{"line_number":1069,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5s%3D","line":1066,"in_reply_to":"AAAATH%2F%2Fnn0%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"        try:"},{"line_number":1073,"context_line":"            self.sys_service_client.service.writeConfig()"},{"line_number":1074,"context_line":"        except Exception as e:"},{"line_number":1075,"context_line":"            raise e"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    @log"},{"line_number":1078,"context_line":"    def create_pool(self, pool):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FktU%3D","line":1075,"updated":"2013-10-14 11:46:47.000000000","message":"seems that try/except is not needed if just reraising all exceptions","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"        try:"},{"line_number":1073,"context_line":"            self.sys_service_client.service.writeConfig()"},{"line_number":1074,"context_line":"        except Exception as e:"},{"line_number":1075,"context_line":"            raise e"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    @log"},{"line_number":1078,"context_line":"    def create_pool(self, pool):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5g%3D","line":1075,"in_reply_to":"AAAATH%2F%2FktU%3D","updated":"2013-10-16 20:59:47.000000000","message":"for now, I have this as a placeholder. Will wrap this exception to a very specific error in future","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"        pool_name \u003d pool[\u0027name\u0027]"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"        try:"},{"line_number":1082,"context_line":"            serverGroupList \u003d \\"},{"line_number":1083,"context_line":"                (self.slb_service_client.factory"},{"line_number":1084,"context_line":"                 .create(\u0027ArrayOfRealServerGroupSequence\u0027))"},{"line_number":1085,"context_line":"            realServerGroup \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnnw%3D","line":1082,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"        pool_name \u003d pool[\u0027name\u0027]"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"        try:"},{"line_number":1082,"context_line":"            serverGroupList \u003d \\"},{"line_number":1083,"context_line":"                (self.slb_service_client.factory"},{"line_number":1084,"context_line":"                 .create(\u0027ArrayOfRealServerGroupSequence\u0027))"},{"line_number":1085,"context_line":"            realServerGroup \u003d (self.slb_service_client.factory"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5Y%3D","line":1082,"in_reply_to":"AAAATH%2F%2Fnnw%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    @log"},{"line_number":1096,"context_line":"    def update_pool(self, new_pool, old_pool):"},{"line_number":1097,"context_line":"        if(\u0027lb_method\u0027 in new_pool):"},{"line_number":1098,"context_line":"            lb_method \u003d new_pool[\u0027lb_method\u0027]"},{"line_number":1099,"context_line":"            vip_id \u003d new_pool[\u0027vip_id\u0027]"},{"line_number":1100,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnnk%3D","line":1097,"updated":"2013-10-12 13:41:34.000000000","message":"unneeded parens","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"    @log"},{"line_number":1096,"context_line":"    def update_pool(self, new_pool, old_pool):"},{"line_number":1097,"context_line":"        if(\u0027lb_method\u0027 in new_pool):"},{"line_number":1098,"context_line":"            lb_method \u003d new_pool[\u0027lb_method\u0027]"},{"line_number":1099,"context_line":"            vip_id \u003d new_pool[\u0027vip_id\u0027]"},{"line_number":1100,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5U%3D","line":1097,"in_reply_to":"AAAATH%2F%2Fnnk%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"            lb_method \u003d new_pool[\u0027lb_method\u0027]"},{"line_number":1099,"context_line":"            vip_id \u003d new_pool[\u0027vip_id\u0027]"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"            if vip_id and vip_id !\u003d \u0027\u0027:"},{"line_number":1102,"context_line":"                vip \u003d self._get_vip(vip_id)"},{"line_number":1103,"context_line":"                self._set_predictor_on_virtual_server(vip, lb_method)"},{"line_number":1104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnns%3D","line":1101,"updated":"2013-10-12 13:41:34.000000000","message":"equal to:\n if vip_id:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"            lb_method \u003d new_pool[\u0027lb_method\u0027]"},{"line_number":1099,"context_line":"            vip_id \u003d new_pool[\u0027vip_id\u0027]"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"            if vip_id and vip_id !\u003d \u0027\u0027:"},{"line_number":1102,"context_line":"                vip \u003d self._get_vip(vip_id)"},{"line_number":1103,"context_line":"                self._set_predictor_on_virtual_server(vip, lb_method)"},{"line_number":1104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5Q%3D","line":1101,"in_reply_to":"AAAATH%2F%2Fnns%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"                                .create(\u0027ServerPort\u0027))"},{"line_number":1151,"context_line":"                rsServerPort.srvr \u003d rs"},{"line_number":1152,"context_line":"                rsServerPort.port \u003d rsL4Port"},{"line_number":1153,"context_line":"                reply \u003d \\"},{"line_number":1154,"context_line":"                    (self.slb_service_client.service"},{"line_number":1155,"context_line":"                     .getRealServerPortMonitoringDetails(rsServerPort))"},{"line_number":1156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnnc%3D","line":1153,"updated":"2013-10-12 13:41:34.000000000","message":"backslash","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"                                .create(\u0027ServerPort\u0027))"},{"line_number":1151,"context_line":"                rsServerPort.srvr \u003d rs"},{"line_number":1152,"context_line":"                rsServerPort.port \u003d rsL4Port"},{"line_number":1153,"context_line":"                reply \u003d \\"},{"line_number":1154,"context_line":"                    (self.slb_service_client.service"},{"line_number":1155,"context_line":"                     .getRealServerPortMonitoringDetails(rsServerPort))"},{"line_number":1156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5M%3D","line":1153,"in_reply_to":"AAAATH%2F%2Fnnc%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"            l4Port.NameOrNumber \u003d protocol_port"},{"line_number":1182,"context_line":"            portProfile.port \u003d l4Port"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"            if(self.isStandardPort(protocol_port) \u003d\u003d False):"},{"line_number":1185,"context_line":"                if(protocol \u003d\u003d \u0027HTTPS\u0027):"},{"line_number":1186,"context_line":"                    portProfile.protocol \u003d \u0027SSL\u0027"},{"line_number":1187,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnnY%3D","line":1184,"updated":"2013-10-12 13:41:34.000000000","message":"if not self.isStandardPort(protocol_port):","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"            l4Port.NameOrNumber \u003d protocol_port"},{"line_number":1182,"context_line":"            portProfile.port \u003d l4Port"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"            if(self.isStandardPort(protocol_port) \u003d\u003d False):"},{"line_number":1185,"context_line":"                if(protocol \u003d\u003d \u0027HTTPS\u0027):"},{"line_number":1186,"context_line":"                    portProfile.protocol \u003d \u0027SSL\u0027"},{"line_number":1187,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5E%3D","line":1184,"in_reply_to":"AAAATH%2F%2FnnY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"            portProfile.port \u003d l4Port"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"            if(self.isStandardPort(protocol_port) \u003d\u003d False):"},{"line_number":1185,"context_line":"                if(protocol \u003d\u003d \u0027HTTPS\u0027):"},{"line_number":1186,"context_line":"                    portProfile.protocol \u003d \u0027SSL\u0027"},{"line_number":1187,"context_line":"                else:"},{"line_number":1188,"context_line":"                    portProfile.protocol \u003d protocol"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnnM%3D","line":1185,"updated":"2013-10-12 13:41:34.000000000","message":"unneeded parens","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"            portProfile.port \u003d l4Port"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"            if(self.isStandardPort(protocol_port) \u003d\u003d False):"},{"line_number":1185,"context_line":"                if(protocol \u003d\u003d \u0027HTTPS\u0027):"},{"line_number":1186,"context_line":"                    portProfile.protocol \u003d \u0027SSL\u0027"},{"line_number":1187,"context_line":"                else:"},{"line_number":1188,"context_line":"                    portProfile.protocol \u003d protocol"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY5A%3D","line":1185,"in_reply_to":"AAAATH%2F%2FnnM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"    @log"},{"line_number":1200,"context_line":"    def delete_port_profile(self, port_profile):"},{"line_number":1201,"context_line":"        protocol_port \u003d port_profile[\u0027protocol_port\u0027]"},{"line_number":1202,"context_line":"        #protocol \u003d port_profile[\u0027protocol\u0027]"},{"line_number":1203,"context_line":"        try:"},{"line_number":1204,"context_line":"            l4Port \u003d self.slb_service_client.factory.create(\u0027L4Port\u0027)"},{"line_number":1205,"context_line":"            l4Port.NameOrNumber \u003d protocol_port"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnnE%3D","line":1202,"updated":"2013-10-12 13:41:34.000000000","message":"please remove commented code","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"    @log"},{"line_number":1200,"context_line":"    def delete_port_profile(self, port_profile):"},{"line_number":1201,"context_line":"        protocol_port \u003d port_profile[\u0027protocol_port\u0027]"},{"line_number":1202,"context_line":"        #protocol \u003d port_profile[\u0027protocol\u0027]"},{"line_number":1203,"context_line":"        try:"},{"line_number":1204,"context_line":"            l4Port \u003d self.slb_service_client.factory.create(\u0027L4Port\u0027)"},{"line_number":1205,"context_line":"            l4Port.NameOrNumber \u003d protocol_port"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY48%3D","line":1202,"in_reply_to":"AAAATH%2F%2FnnE%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1216,"context_line":"                      161, 22, 23, 443, 69, 3389]"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"    def isStandardPort(self, port):"},{"line_number":1219,"context_line":"        if port in self.standard_ports:"},{"line_number":1220,"context_line":"            return True"},{"line_number":1221,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnnA%3D","line":1219,"updated":"2013-10-12 13:41:34.000000000","message":"converge 1219-1221 to:\n return port in self.standard_ports","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1216,"context_line":"                      161, 22, 23, 443, 69, 3389]"},{"line_number":1217,"context_line":""},{"line_number":1218,"context_line":"    def isStandardPort(self, port):"},{"line_number":1219,"context_line":"        if port in self.standard_ports:"},{"line_number":1220,"context_line":"            return True"},{"line_number":1221,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY44%3D","line":1219,"in_reply_to":"AAAATH%2F%2FnnA%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/device_driver/brocade_adx_driver_impl.py.99":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 Brocade, Inc.  All rights reserved.\r"},{"line_number":2,"context_line":"#\r"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATH%2F%2Fnt4%3D","line":1,"updated":"2013-10-12 13:41:34.000000000","message":"that looks like a backup of the original file and should be removed completely","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 Brocade, Inc.  All rights reserved.\r"},{"line_number":2,"context_line":"#\r"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATH%2F%2FY40%3D","line":1,"in_reply_to":"AAAATH%2F%2Fnt4%3D","updated":"2013-10-16 20:59:47.000000000","message":"Removed","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/device_driver/brocade_adx_exceptions.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class UnsupportedFeature(qexception.NeutronException):"},{"line_number":21,"context_line":"    message \u003d _(\u0027Unsupported Feature : %(msg)s\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class UnsupportedOption(qexception.NeutronException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnmo%3D","line":21,"updated":"2013-10-12 13:41:34.000000000","message":"nit: remove space before :","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class UnsupportedFeature(qexception.NeutronException):"},{"line_number":21,"context_line":"    message \u003d _(\u0027Unsupported Feature : %(msg)s\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class UnsupportedOption(qexception.NeutronException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY4w%3D","line":21,"in_reply_to":"AAAATH%2F%2Fnmo%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ConfigError(qexception.NeutronException):"},{"line_number":29,"context_line":"    message \u003d _(\u0027Configuration Error on the device : %(msg)s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnmk%3D","line":29,"updated":"2013-10-12 13:41:34.000000000","message":"nit: remove space before :","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ConfigError(qexception.NeutronException):"},{"line_number":29,"context_line":"    message \u003d _(\u0027Configuration Error on the device : %(msg)s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY4s%3D","line":29,"in_reply_to":"AAAATH%2F%2Fnmk%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/device_driver/brocade_adx_service.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import base64"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import StringIO"},{"line_number":20,"context_line":"#import time"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from httplib2 import Http"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnmg%3D","line":20,"updated":"2013-10-12 13:41:34.000000000","message":"please delete commented lines here and below","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import base64"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import StringIO"},{"line_number":20,"context_line":"#import time"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from httplib2 import Http"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY4k%3D","line":20,"in_reply_to":"AAAATH%2F%2Fnmg%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron import manager"},{"line_number":26,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from suds.client import Client"},{"line_number":29,"context_line":"from suds.sax.element import Element"},{"line_number":30,"context_line":"#from suds.transport.http import HttpAuthenticated"},{"line_number":31,"context_line":"from suds.transport import Transport"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkr0%3D","line":28,"updated":"2013-10-14 11:46:47.000000000","message":"this should go after #22","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron import manager"},{"line_number":26,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from suds.client import Client"},{"line_number":29,"context_line":"from suds.sax.element import Element"},{"line_number":30,"context_line":"#from suds.transport.http import HttpAuthenticated"},{"line_number":31,"context_line":"from suds.transport import Transport"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY4g%3D","line":28,"in_reply_to":"AAAATH%2F%2Fkr0%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def init(cls):"},{"line_number":43,"context_line":"        if not cls._initialized:"},{"line_number":44,"context_line":"            devices \u003d (manager.NeutronManager"},{"line_number":45,"context_line":"                       .get_service_plugins()[\"DEVICE_MANAGER\"]"},{"line_number":46,"context_line":"                       .get_devices(get_admin_context()))"},{"line_number":47,"context_line":"            LOG.debug(_(\"No of Devices in the DB: %d\"), len(devices))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnmc%3D","line":44,"updated":"2013-10-12 13:41:34.000000000","message":"when does DeviceCache.init method invoked?\nI feel this code could lead to a deadlock because one plugin starts to depend on another through a common singleton that manages their loading.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def init(cls):"},{"line_number":43,"context_line":"        if not cls._initialized:"},{"line_number":44,"context_line":"            devices \u003d (manager.NeutronManager"},{"line_number":45,"context_line":"                       .get_service_plugins()[\"DEVICE_MANAGER\"]"},{"line_number":46,"context_line":"                       .get_devices(get_admin_context()))"},{"line_number":47,"context_line":"            LOG.debug(_(\"No of Devices in the DB: %d\"), len(devices))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY3k%3D","line":44,"in_reply_to":"AAAATH%2F%2Fnmc%3D","updated":"2013-10-16 20:59:47.000000000","message":"DeviceCache.init method is invoked very first time a request is received by the device driver. I have avoided the dead lock refactoring the code on the Device Inventory Plugin","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        user \u003d management[\u0027user\u0027]"},{"line_number":58,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":61,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":62,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":63,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnmU%3D","line":60,"updated":"2013-10-12 13:41:34.000000000","message":"parens not needed","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        user \u003d management[\u0027user\u0027]"},{"line_number":58,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":61,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":62,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":63,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY3c%3D","line":60,"in_reply_to":"AAAATH%2F%2FnmU%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":61,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":62,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":63,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"},{"line_number":64,"context_line":"                slb_service_client \u003d adxSlbService.createSlbServiceClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnmY%3D","line":61,"updated":"2013-10-12 13:41:34.000000000","message":"if ip not in cls._ADX_SERVICE_CLIENTS:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":61,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":62,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":63,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"},{"line_number":64,"context_line":"                slb_service_client \u003d adxSlbService.createSlbServiceClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY3Y%3D","line":61,"in_reply_to":"AAAATH%2F%2FnmY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        user \u003d management[\u0027user\u0027]"},{"line_number":90,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":93,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":94,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":95,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnmM%3D","line":92,"updated":"2013-10-12 13:41:34.000000000","message":"parens not needed:","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        user \u003d management[\u0027user\u0027]"},{"line_number":90,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":93,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":94,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":95,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY3U%3D","line":92,"in_reply_to":"AAAATH%2F%2FnmM%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":93,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":94,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":95,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"},{"line_number":96,"context_line":"                slb_service_client \u003d adxSlbService.createSlbServiceClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FnmQ%3D","line":93,"updated":"2013-10-12 13:41:34.000000000","message":"if ip not in ...","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        password \u003d management[\u0027password\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if(device[\u0027device_type\u0027] \u003d\u003d \u0027BROCADE_ADX\u0027):"},{"line_number":93,"context_line":"            if not (ip in cls._ADX_SERVICE_CLIENTS):"},{"line_number":94,"context_line":"                LOG.debug(_(\u0027Adx Service Client not yet initialized ...\u0027))"},{"line_number":95,"context_line":"                adxSlbService \u003d AdxService(ip, user, password)"},{"line_number":96,"context_line":"                slb_service_client \u003d adxSlbService.createSlbServiceClient()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY3I%3D","line":93,"in_reply_to":"AAAATH%2F%2FnmQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/device_inventory/algorithm.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    import NoValidDevice"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class Algorithm():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkro%3D","line":26,"updated":"2013-10-14 11:46:47.000000000","message":"LOG is unused","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    import NoValidDevice"},{"line_number":24,"context_line":"from neutron.plugins.common import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class Algorithm():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY3A%3D","line":26,"in_reply_to":"AAAATH%2F%2Fkro%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if not filtered:"},{"line_number":45,"context_line":"            raise NoValidDevice()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        device \u003d filtered[0]"},{"line_number":48,"context_line":"        return device"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkrQ%3D","line":47,"updated":"2013-10-14 11:46:47.000000000","message":"this will always return the first device, consider random choice","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if not filtered:"},{"line_number":45,"context_line":"            raise NoValidDevice()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        device \u003d filtered[0]"},{"line_number":48,"context_line":"        return device"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY2g%3D","line":47,"in_reply_to":"AAAATH%2F%2FkrQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"device match is based on subnet id. it is assumed that there will be atmost 1 device for a given subnet.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/device_inventory/device_selector.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            LOG.debug(_(\"Found device %(device)s\"), {\"device\": device})"},{"line_number":44,"context_line":"            return device"},{"line_number":45,"context_line":"        except NoValidDevice as e:"},{"line_number":46,"context_line":"            LOG.info(_(\"No valid device was found.\"))"},{"line_number":47,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkrM%3D","line":46,"updated":"2013-10-14 11:46:47.000000000","message":"should this be warn or error log level","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            LOG.debug(_(\"Found device %(device)s\"), {\"device\": device})"},{"line_number":44,"context_line":"            return device"},{"line_number":45,"context_line":"        except NoValidDevice as e:"},{"line_number":46,"context_line":"            LOG.info(_(\"No valid device was found.\"))"},{"line_number":47,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY2Y%3D","line":46,"in_reply_to":"AAAATH%2F%2FkrM%3D","updated":"2013-10-16 20:59:47.000000000","message":"changed to error","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/plugin/brocade_lbaas_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BrocadeLoadBalancerPlugin(LoadBalancerPlugin):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    Implementation of the Brocade Quantum Loadbalancer Service Plugin."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkqQ%3D","line":25,"updated":"2013-10-14 11:46:47.000000000","message":"Seems the class doesn\u0027t bring any new value in comparation with LoadBalancerPlugin","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class BrocadeLoadBalancerPlugin(LoadBalancerPlugin):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":"    Implementation of the Brocade Quantum Loadbalancer Service Plugin."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY10%3D","line":25,"in_reply_to":"AAAATH%2F%2FkqQ%3D","updated":"2013-10-16 20:59:47.000000000","message":"This was our plugin extension to one of our customers to support additional functionality. \n\nI have removed this class from the next patch upload.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    Most DB related works are implemented in class"},{"line_number":31,"context_line":"    brocade_loadbalancer_db.BrocadeLoadBalancerPluginDb."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    supported_extension_aliases \u003d [\"lbaas\", \"brocade-ext-lbaas\"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(BrocadeLoadBalancerPlugin, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkq4%3D","line":33,"updated":"2013-10-14 11:46:47.000000000","message":"where the \u0027brocade-ext-lbaas\u0027 extension is defined?","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    Most DB related works are implemented in class"},{"line_number":31,"context_line":"    brocade_loadbalancer_db.BrocadeLoadBalancerPluginDb."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    supported_extension_aliases \u003d [\"lbaas\", \"brocade-ext-lbaas\"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(BrocadeLoadBalancerPlugin, self).__init__()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY1g%3D","line":33,"in_reply_to":"AAAATH%2F%2Fkq4%3D","updated":"2013-10-16 20:59:47.000000000","message":"As mentioned above, we had our extension. Not applicable in future patch sets.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    supported_extension_aliases \u003d [\"lbaas\", \"brocade-ext-lbaas\"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(BrocadeLoadBalancerPlugin, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_plugin_type(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkqc%3D","line":35,"updated":"2013-10-14 11:46:47.000000000","message":"no need to override","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    supported_extension_aliases \u003d [\"lbaas\", \"brocade-ext-lbaas\"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(BrocadeLoadBalancerPlugin, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_plugin_type(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY1Y%3D","line":35,"in_reply_to":"AAAATH%2F%2Fkqc%3D","updated":"2013-10-16 20:59:47.000000000","message":"Not Applicable as this file will be removed.","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(BrocadeLoadBalancerPlugin, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_plugin_type(self):"},{"line_number":39,"context_line":"        return constants.LOADBALANCER"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_plugin_description(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FkqY%3D","line":38,"updated":"2013-10-14 11:46:47.000000000","message":"no need to override","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def __init__(self):"},{"line_number":36,"context_line":"        super(BrocadeLoadBalancerPlugin, self).__init__()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get_plugin_type(self):"},{"line_number":39,"context_line":"        return constants.LOADBALANCER"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def get_plugin_description(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY1U%3D","line":38,"in_reply_to":"AAAATH%2F%2FkqY%3D","updated":"2013-10-16 20:59:47.000000000","message":"Not applicable","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/plugins/brocade/lbaas/plugin_driver/lbaas_plugin_driver.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"3c3f665348b47368149eda69c860fec4106333f1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEFAULT_DEVICE_DRIVER \u003d (\"neutron.plugins.brocade.lbaas.device_driver\""},{"line_number":34,"context_line":"                         \".brocade_adx_driver.BrocadeAdxDriver\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027device_driver_fqn\u0027,"},{"line_number":38,"context_line":"               default\u003dDEFAULT_DEVICE_DRIVER,"},{"line_number":39,"context_line":"               help\u003d_(\u0027LBaaS Device Driver Fully Qualified Name\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fnl8%3D","line":36,"updated":"2013-10-12 13:41:34.000000000","message":"that option is not used by the latest neutron code","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEFAULT_DEVICE_DRIVER \u003d (\"neutron.plugins.brocade.lbaas.device_driver\""},{"line_number":34,"context_line":"                         \".brocade_adx_driver.BrocadeAdxDriver\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027device_driver_fqn\u0027,"},{"line_number":38,"context_line":"               default\u003dDEFAULT_DEVICE_DRIVER,"},{"line_number":39,"context_line":"               help\u003d_(\u0027LBaaS Device Driver Fully Qualified Name\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY08%3D","line":36,"in_reply_to":"AAAATH%2F%2Fnl8%3D","updated":"2013-10-16 20:59:47.000000000","message":"Agree. Have updated the Neutron Code base and integrated with the Service Provider Implementation","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":42,"context_line":"cfg.CONF.register_opts(lbaas_plugin_opts, \"LBAAS\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def log(method):"},{"line_number":46,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":47,"context_line":"        LOG.debug(\u0027BrocadeLbaaSPluginDriver method %s called \u0027"},{"line_number":48,"context_line":"                  \u0027with arguments %s %s\u0027 % (method.__name__, args, kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkps%3D","line":45,"updated":"2013-10-14 11:46:47.000000000","message":"please use neutron.common.log.log()","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":42,"context_line":"cfg.CONF.register_opts(lbaas_plugin_opts, \"LBAAS\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def log(method):"},{"line_number":46,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":47,"context_line":"        LOG.debug(\u0027BrocadeLbaaSPluginDriver method %s called \u0027"},{"line_number":48,"context_line":"                  \u0027with arguments %s %s\u0027 % (method.__name__, args, kwargs))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY04%3D","line":45,"in_reply_to":"AAAATH%2F%2Fkps%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2b99ede61420b79d43b5eb7b16862b76922ebacf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"class BrocadeLbaaSPluginDriver(abstract_driver.LoadBalancerAbstractDriver):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":"        Brocade LBAAS Plugin Driver"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, plugin):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fkpc%3D","line":56,"updated":"2013-10-14 11:46:47.000000000","message":"\"\"\" Brocade LBAAS Plugin Driver \"\"\" for one-liner doc strings","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"0ce36f76f5ec2321caffba831c285048d16d56ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"class BrocadeLbaaSPluginDriver(abstract_driver.LoadBalancerAbstractDriver):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":"        Brocade LBAAS Plugin Driver"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, plugin):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FY00%3D","line":56,"in_reply_to":"AAAATH%2F%2Fkpc%3D","updated":"2013-10-16 20:59:47.000000000","message":"Done","commit_id":"8033b2b1de60c3e6d2a7dddc944335e5c19e4f4d"}],"neutron/services/loadbalancer/drivers/brocade/__init__.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"c27d6dafd35d808ab7d5c8bc1ca322bcf5a2db81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 Brocade Communications Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F%2F7kk%3D","line":2,"updated":"2013-10-25 02:00:10.000000000","message":"nit: missing \"#\" in line 2","commit_id":"374bee192d74303ee83a966732dddf2f04170b5d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"abf45b6609eee203ac8181ba3f1f7dae2d20eee4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 Brocade Communications Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F%2F7TY%3D","line":2,"in_reply_to":"AAAATn%2F%2F7kk%3D","updated":"2013-10-25 05:07:31.000000000","message":"i believe it\u0027s up to taste; different neutron source files do this  differently: with or without empty line","commit_id":"374bee192d74303ee83a966732dddf2f04170b5d"}],"neutron/services/loadbalancer/drivers/brocade/device_driver/__init__.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# \u0027Copyright (c) 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXRA%3D","line":3,"updated":"2013-10-17 08:02:07.000000000","message":"nit: \u0027 at the beginning not needed","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# \u0027Copyright (c) 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVHE%3D","line":3,"in_reply_to":"AAAATH%2F%2FXRA%3D","updated":"2013-10-17 16:54:59.000000000","message":"Will fix in the next patch upload","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"c27d6dafd35d808ab7d5c8bc1ca322bcf5a2db81","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 Brocade Communications Systems, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F%2F7kg%3D","line":2,"updated":"2013-10-25 02:00:10.000000000","message":"ditto","commit_id":"374bee192d74303ee83a966732dddf2f04170b5d"}],"neutron/services/loadbalancer/drivers/brocade/device_driver/brocade_adx_driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Brocade Communications Systems, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXQ8%3D","line":1,"updated":"2013-10-17 08:02:07.000000000","message":"\u0027# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4\u0027 missed. Please check other copyrights headers as well.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Brocade Communications Systems, Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVGw%3D","line":1,"in_reply_to":"AAAATH%2F%2FXQ8%3D","updated":"2013-10-17 16:54:59.000000000","message":"Will fix in the next patch","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.services.loadbalancer.drivers.brocade.device_driver import ("},{"line_number":21,"context_line":"    brocade_adx_driver_impl as driver_impl,"},{"line_number":22,"context_line":"    brocade_adx_service as adx_service"},{"line_number":23,"context_line":")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVAI%3D","line":23,"updated":"2013-10-17 17:33:43.000000000","message":"Please consider one import per line.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34c60fdde744cabd7e3164449d46b01f33ce9733","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    brocade_adx_service as adx_service"},{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class BrocadeAdxDeviceDriver():"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2Fl4%3D","line":29,"updated":"2013-10-23 07:03:48.000000000","message":"LOG is unused","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"b6d1df78f154c5d3ca6673c30b63617b09d98ea8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    brocade_adx_service as adx_service"},{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class BrocadeAdxDeviceDriver():"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Lk%3D","line":29,"in_reply_to":"AAAATX%2F%2F%2Fl4%3D","updated":"2013-10-23 17:49:05.000000000","message":"Done","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"}],"neutron/services/loadbalancer/drivers/brocade/device_driver/brocade_adx_driver_impl.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.services.loadbalancer.drivers.brocade.device_driver import ("},{"line_number":24,"context_line":"    brocade_adx_exceptions as adx_exception,"},{"line_number":25,"context_line":"    brocade_adx_service as adx_service"},{"line_number":26,"context_line":")"},{"line_number":27,"context_line":"from neutron.services.loadbalancer import constants"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU%2F8%3D","line":26,"updated":"2013-10-17 17:33:43.000000000","message":"one import per line.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return self.plugin.get_pool(get_admin_context(), pool_id)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_vip(self, vip_id):"},{"line_number":64,"context_line":"        vip \u003d self.plugin.get_vip(get_admin_context(), vip_id)"},{"line_number":65,"context_line":"        return vip"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_pool_members(self, pool_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXQU%3D","line":64,"updated":"2013-10-17 08:02:07.000000000","message":"return self.plugin.get_vip(get_admin_context(), vip_id)","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return self.plugin.get_pool(get_admin_context(), pool_id)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _get_vip(self, vip_id):"},{"line_number":64,"context_line":"        vip \u003d self.plugin.get_vip(get_admin_context(), vip_id)"},{"line_number":65,"context_line":"        return vip"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _get_pool_members(self, pool_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVGs%3D","line":64,"in_reply_to":"AAAATH%2F%2FXQU%3D","updated":"2013-10-17 16:54:59.000000000","message":"Will fix","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                return"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            msg \u003d _(\u0027Update Admin State to %(admin_state)s\u0027)"},{"line_number":111,"context_line":"            LOG.debug(msg % {\u0027admin_state\u0027: new_admin_state_up})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            rsServerPort \u003d self._adx_server_port(address, protocol_port)"},{"line_number":114,"context_line":"            reply \u003d (self.slb_service"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXPo%3D","line":111,"updated":"2013-10-17 08:02:07.000000000","message":"No need for % in LOG methods:\n LOG.debug(msg, {\u0027admin_state\u0027: new_admin_state_up})","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                return"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            msg \u003d _(\u0027Update Admin State to %(admin_state)s\u0027)"},{"line_number":111,"context_line":"            LOG.debug(msg % {\u0027admin_state\u0027: new_admin_state_up})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            rsServerPort \u003d self._adx_server_port(address, protocol_port)"},{"line_number":114,"context_line":"            reply \u003d (self.slb_service"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVGk%3D","line":111,"in_reply_to":"AAAATH%2F%2FXPo%3D","updated":"2013-10-17 16:54:59.000000000","message":"Will fix","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":122,"context_line":"            reply.rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            rsPortConfList \u003d []"},{"line_number":125,"context_line":"            rsPortConfList.append(reply.rsPortConfig)"},{"line_number":126,"context_line":"            rsPortConfSeq.RealServerPortConfigurationSequence \u003d rsPortConfList"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXPc%3D","line":124,"updated":"2013-10-17 08:02:07.000000000","message":"consider rsPortConfList \u003d [reply.rsPortConfig]","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                rsPortAdminState \u003d \u0027DISABLED\u0027"},{"line_number":122,"context_line":"            reply.rsPortConfig.adminState \u003d rsPortAdminState"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            rsPortConfList \u003d []"},{"line_number":125,"context_line":"            rsPortConfList.append(reply.rsPortConfig)"},{"line_number":126,"context_line":"            rsPortConfSeq.RealServerPortConfigurationSequence \u003d rsPortConfList"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVGY%3D","line":124,"in_reply_to":"AAAATH%2F%2FXPc%3D","updated":"2013-10-17 16:54:59.000000000","message":"ok","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        except WebFault as e:"},{"line_number":165,"context_line":"            raise adx_exception.ConfigError(msg\u003de.message)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _getRealServerPortCount(self, rsIpAddress):"},{"line_number":168,"context_line":"        server \u003d self._adx_server(rsIpAddress)"},{"line_number":169,"context_line":"        startIndex \u003d 1"},{"line_number":170,"context_line":"        numRetrieved \u003d 5"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXOo%3D","line":167,"updated":"2013-10-17 08:02:07.000000000","message":"This and next method looks pretty much the same. Consider refactoring into one method.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1d45c7e8f5d69b55b1489c1c1b17c8c8b122a1d4","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        except WebFault as e:"},{"line_number":165,"context_line":"            raise adx_exception.ConfigError(msg\u003de.message)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _getRealServerPortCount(self, rsIpAddress):"},{"line_number":168,"context_line":"        server \u003d self._adx_server(rsIpAddress)"},{"line_number":169,"context_line":"        startIndex \u003d 1"},{"line_number":170,"context_line":"        numRetrieved \u003d 5"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FTHA%3D","line":167,"in_reply_to":"AAAATH%2F%2FVFg%3D","updated":"2013-10-18 06:28:59.000000000","message":"Consider:\n    def _get_server_port_count(self, ip_address, is_virtual):\n        server \u003d self._adx_server(ip_address)\n        startIndex \u003d 1\n        numRetrieved \u003d 5\n        api_call \u003d (self.slb_service.getAllVirtualServerPortsSummary if is_virtual\n                    else self.slb_service.getAllRealServerPortsSummary)\n\n        try:\n            reply \u003d api_call(server, startIndex, numRetrieved))\n            return reply.genericInfo.totalEntriesAvailable\n        except WebFault:\n            reurn 0","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        except WebFault as e:"},{"line_number":165,"context_line":"            raise adx_exception.ConfigError(msg\u003de.message)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _getRealServerPortCount(self, rsIpAddress):"},{"line_number":168,"context_line":"        server \u003d self._adx_server(rsIpAddress)"},{"line_number":169,"context_line":"        startIndex \u003d 1"},{"line_number":170,"context_line":"        numRetrieved \u003d 5"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVFg%3D","line":167,"in_reply_to":"AAAATH%2F%2FXOo%3D","updated":"2013-10-17 16:54:59.000000000","message":"The SOAP/XML API call to the back end is different getAllRealServerPortsSummary versus getAllVirtualServerPortsSummary. \n\nI am afraid it is difficult to refactor into one method","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            rsPortCount \u003d reply.genericInfo.totalEntriesAvailable"},{"line_number":178,"context_line":"            return rsPortCount"},{"line_number":179,"context_line":"        except WebFault:"},{"line_number":180,"context_line":"            pass"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        return 0"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU%2Fo%3D","line":180,"updated":"2013-10-17 17:33:43.000000000","message":"Replace this with \"return 0\" and remove L.182. It seems more clear to me.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        except WebFault:"},{"line_number":197,"context_line":"            pass"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        return 0"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _bind_member_to_vip(self, member, vip):"},{"line_number":202,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU%2Fk%3D","line":199,"updated":"2013-10-17 17:33:43.000000000","message":"Ditto","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _bind_member_to_vip(self, member, vip):"},{"line_number":202,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":203,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":204,"context_line":"        if member.get(\u0027name\u0027):"},{"line_number":205,"context_line":"            rsName \u003d member[\u0027name\u0027]"},{"line_number":206,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXN0%3D","line":204,"updated":"2013-10-17 08:02:07.000000000","message":"members have no \u0027name\u0027 field in lbaas model, consider using member id","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _bind_member_to_vip(self, member, vip):"},{"line_number":202,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"},{"line_number":203,"context_line":"        rsName \u003d rsIpAddress"},{"line_number":204,"context_line":"        if member.get(\u0027name\u0027):"},{"line_number":205,"context_line":"            rsName \u003d member[\u0027name\u0027]"},{"line_number":206,"context_line":"        rsPort \u003d member[\u0027protocol_port\u0027]"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVFE%3D","line":204,"in_reply_to":"AAAATH%2F%2FXN0%3D","updated":"2013-10-17 16:54:59.000000000","message":"\u0027name\u0027 is part of our extended data model. Since in the generic lbaas model, \u0027name\u0027 is not present, I use IP Address as Name.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _bind_monitor_to_member(self, health_monitor, member):"},{"line_number":242,"context_line":"        health_monitor_name \u003d health_monitor[\u0027id\u0027]"},{"line_number":243,"context_line":"        if health_monitor.get(\u0027name\u0027):"},{"line_number":244,"context_line":"            health_monitor_name \u003d health_monitor[\u0027name\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXNw%3D","line":243,"updated":"2013-10-17 08:02:07.000000000","message":"same for health_monitors","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _bind_monitor_to_member(self, health_monitor, member):"},{"line_number":242,"context_line":"        health_monitor_name \u003d health_monitor[\u0027id\u0027]"},{"line_number":243,"context_line":"        if health_monitor.get(\u0027name\u0027):"},{"line_number":244,"context_line":"            health_monitor_name \u003d health_monitor[\u0027name\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        rsIpAddress \u003d member[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVE8%3D","line":243,"in_reply_to":"AAAATH%2F%2FXNw%3D","updated":"2013-10-17 16:54:59.000000000","message":"\"name\" ispart of our extended data model support. since not present in the lbaas generic model, i use id as the name.\n\nI want to keep this code so it becomes easy for us to support attribute extensions in future","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        new_admin_state_up \u003d new_vip.get(\u0027admin_state_up\u0027)"},{"line_number":468,"context_line":"        if new_admin_state_up !\u003d old_admin_state_up:"},{"line_number":469,"context_line":"            msg \u003d _(\u0027Update Admin State to %(state)s\u0027)"},{"line_number":470,"context_line":"            LOG.debug(msg % {\u0027state\u0027: new_admin_state_up})"},{"line_number":471,"context_line":"            try:"},{"line_number":472,"context_line":"                if new_admin_state_up:"},{"line_number":473,"context_line":"                    (self.slb_service"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXNc%3D","line":470,"updated":"2013-10-17 08:02:07.000000000","message":"LOG.debug(msg, {\u0027state\u0027: new_admin_state_up})","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        new_admin_state_up \u003d new_vip.get(\u0027admin_state_up\u0027)"},{"line_number":468,"context_line":"        if new_admin_state_up !\u003d old_admin_state_up:"},{"line_number":469,"context_line":"            msg \u003d _(\u0027Update Admin State to %(state)s\u0027)"},{"line_number":470,"context_line":"            LOG.debug(msg % {\u0027state\u0027: new_admin_state_up})"},{"line_number":471,"context_line":"            try:"},{"line_number":472,"context_line":"                if new_admin_state_up:"},{"line_number":473,"context_line":"                    (self.slb_service"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVE0%3D","line":470,"in_reply_to":"AAAATH%2F%2FXNc%3D","updated":"2013-10-17 16:54:59.000000000","message":"ok","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                portPolicy.protocol \u003d (ADX_PROTOCOL_MAP"},{"line_number":598,"context_line":"                                       .get(constants.PROTOCOL_HTTPS))"},{"line_number":599,"context_line":"                portPolicy.l4Check \u003d False"},{"line_number":600,"context_line":"            else:"},{"line_number":601,"context_line":"                # TCP Monitor"},{"line_number":602,"context_line":"                portPolicy.name \u003d name"},{"line_number":603,"context_line":"                portPolicy.l4Check \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXM4%3D","line":600,"updated":"2013-10-17 08:02:07.000000000","message":"elif monitor_type \u003d\u003d constants.HEALTH_MONITOR_TCP just in case adding more types in future","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                portPolicy.protocol \u003d (ADX_PROTOCOL_MAP"},{"line_number":598,"context_line":"                                       .get(constants.PROTOCOL_HTTPS))"},{"line_number":599,"context_line":"                portPolicy.l4Check \u003d False"},{"line_number":600,"context_line":"            else:"},{"line_number":601,"context_line":"                # TCP Monitor"},{"line_number":602,"context_line":"                portPolicy.name \u003d name"},{"line_number":603,"context_line":"                portPolicy.l4Check \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVEw%3D","line":600,"in_reply_to":"AAAATH%2F%2FXM4%3D","updated":"2013-10-17 16:54:59.000000000","message":"ok","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"            except WebFault:"},{"line_number":1020,"context_line":"                pass"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"        return {\u0027bytes_in\u0027: bytesIn,"},{"line_number":1023,"context_line":"                \u0027bytes_out\u0027: bytesOut,"},{"line_number":1024,"context_line":"                \u0027active_connections\u0027: activeConnections,"},{"line_number":1025,"context_line":"                \u0027total_connections\u0027: totalConnections}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXMU%3D","line":1022,"updated":"2013-10-17 08:02:07.000000000","message":"please use constants from neutron.services.loadbalancer.constants","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"            except WebFault:"},{"line_number":1020,"context_line":"                pass"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"        return {\u0027bytes_in\u0027: bytesIn,"},{"line_number":1023,"context_line":"                \u0027bytes_out\u0027: bytesOut,"},{"line_number":1024,"context_line":"                \u0027active_connections\u0027: activeConnections,"},{"line_number":1025,"context_line":"                \u0027total_connections\u0027: totalConnections}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVEk%3D","line":1022,"in_reply_to":"AAAATH%2F%2FXMU%3D","updated":"2013-10-17 16:54:59.000000000","message":"will change","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"                      1645, 554, 5060, 5061, 25,"},{"line_number":1072,"context_line":"                      161, 22, 23, 443, 69, 3389]"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def isStandardPort(self, port):"},{"line_number":1075,"context_line":"        return port in self.standard_ports"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXMI%3D","line":1074,"updated":"2013-10-17 08:02:07.000000000","message":"Does it need to be a class method? Consider defining this function inside method where it is used (create_port_profile())","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"                      1645, 554, 5060, 5061, 25,"},{"line_number":1072,"context_line":"                      161, 22, 23, 443, 69, 3389]"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def isStandardPort(self, port):"},{"line_number":1075,"context_line":"        return port in self.standard_ports"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVEc%3D","line":1074,"in_reply_to":"AAAATH%2F%2FXMI%3D","updated":"2013-10-17 16:54:59.000000000","message":"at this time, i am not very sure if this method will be used in other places too. i will consider moving it as an inline method","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34c60fdde744cabd7e3164449d46b01f33ce9733","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    brocade_adx_service as adx_service"},{"line_number":29,"context_line":")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from suds import WebFault"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2Flk%3D","line":31,"updated":"2013-10-23 07:03:48.000000000","message":"this import section should go before neutron imports","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"b6d1df78f154c5d3ca6673c30b63617b09d98ea8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    brocade_adx_service as adx_service"},{"line_number":29,"context_line":")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from suds import WebFault"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Ls%3D","line":31,"in_reply_to":"AAAATX%2F%2F%2Flk%3D","updated":"2013-10-23 17:49:05.000000000","message":"Done","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34c60fdde744cabd7e3164449d46b01f33ce9733","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        except WebFault as e:"},{"line_number":160,"context_line":"            raise adx_exception.ConfigError(msg\u003de.message)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _get_rs_port_count(self, rsIpAddress):"},{"line_number":163,"context_line":"        server \u003d self._adx_server(rsIpAddress)"},{"line_number":164,"context_line":"        startIndex \u003d 1"},{"line_number":165,"context_line":"        numRetrieved \u003d 5"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2FlE%3D","line":162,"updated":"2013-10-23 07:03:48.000000000","message":"Please avoid code duplication. Consider refactoring two methods below into one:\n    def _get_server_port_count(self, ip_address, is_virtual):\n        server \u003d self._adx_server(ip_address)\n        startIndex \u003d 1\n        numRetrieved \u003d 5\n        api_call \u003d (self.slb_service.getAllVirtualServerPortsSummary if is_virtual\n                    else self.slb_service.getAllRealServerPortsSummary)\n        try:\n            reply \u003d api_call(server, startIndex, numRetrieved))\n            return reply.genericInfo.totalEntriesAvailable\n        except WebFault:\n            reurn 0","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"b6d1df78f154c5d3ca6673c30b63617b09d98ea8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        except WebFault as e:"},{"line_number":160,"context_line":"            raise adx_exception.ConfigError(msg\u003de.message)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _get_rs_port_count(self, rsIpAddress):"},{"line_number":163,"context_line":"        server \u003d self._adx_server(rsIpAddress)"},{"line_number":164,"context_line":"        startIndex \u003d 1"},{"line_number":165,"context_line":"        numRetrieved \u003d 5"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Lw%3D","line":162,"in_reply_to":"AAAATX%2F%2F%2FlE%3D","updated":"2013-10-23 17:49:05.000000000","message":"Done","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34c60fdde744cabd7e3164449d46b01f33ce9733","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"                      1645, 554, 5060, 5061, 25,"},{"line_number":1041,"context_line":"                      161, 22, 23, 443, 69, 3389]"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"    def _is_standard_port(self, port):"},{"line_number":1044,"context_line":"        return port in self.standard_ports"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2Fkw%3D","line":1043,"updated":"2013-10-23 07:03:48.000000000","message":"is it used anywhere except _create_real_server_port(). If not consider inline function","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"b6d1df78f154c5d3ca6673c30b63617b09d98ea8","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"                      1645, 554, 5060, 5061, 25,"},{"line_number":1041,"context_line":"                      161, 22, 23, 443, 69, 3389]"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"    def _is_standard_port(self, port):"},{"line_number":1044,"context_line":"        return port in self.standard_ports"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9L0%3D","line":1043,"in_reply_to":"AAAATX%2F%2F%2Fkw%3D","updated":"2013-10-23 17:49:05.000000000","message":"Done","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"}],"neutron/services/loadbalancer/drivers/brocade/device_driver/brocade_adx_service.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import StringIO"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from httplib2 import Http"},{"line_number":22,"context_line":"from suds.client import Client"},{"line_number":23,"context_line":"from suds.sax.element import Element"},{"line_number":24,"context_line":"from suds.transport import Transport"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXL4%3D","line":21,"updated":"2013-10-17 08:02:07.000000000","message":"module level imports are preferable than class level imports for better readability.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import StringIO"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from httplib2 import Http"},{"line_number":22,"context_line":"from suds.client import Client"},{"line_number":23,"context_line":"from suds.sax.element import Element"},{"line_number":24,"context_line":"from suds.transport import Transport"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVEU%3D","line":21,"in_reply_to":"AAAATH%2F%2FXL4%3D","updated":"2013-10-17 16:54:59.000000000","message":"agree","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import StringIO"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from httplib2 import Http"},{"line_number":22,"context_line":"from suds.client import Client"},{"line_number":23,"context_line":"from suds.sax.element import Element"},{"line_number":24,"context_line":"from suds.transport import Transport"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXLs%3D","line":22,"updated":"2013-10-17 08:02:07.000000000","message":"from suds import client as suds_client\n\nLater in code suds_client.Client() will be more clear than just Client()","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import StringIO"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from httplib2 import Http"},{"line_number":22,"context_line":"from suds.client import Client"},{"line_number":23,"context_line":"from suds.sax.element import Element"},{"line_number":24,"context_line":"from suds.transport import Transport"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVEQ%3D","line":22,"in_reply_to":"AAAATH%2F%2FXLs%3D","updated":"2013-10-17 16:54:59.000000000","message":"agree","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"}],"neutron/services/loadbalancer/drivers/brocade/device_inventory/algorithm.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Algorithm():"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    Algorithm which chooses appropriate device based on the subnet_id"},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXLQ%3D","line":27,"updated":"2013-10-17 08:02:07.000000000","message":"IMHO class name is too generic","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":24,"context_line":")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Algorithm():"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    Algorithm which chooses appropriate device based on the subnet_id"},{"line_number":30,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVEM%3D","line":27,"in_reply_to":"AAAATH%2F%2FXLQ%3D","updated":"2013-10-17 16:54:59.000000000","message":"will change the name probably to SubnetIdBasedAlgorithm","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    Algorithm which chooses appropriate device based on the subnet_id"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    def __call__(self, devices, subnet_id):"},{"line_number":32,"context_line":"        if len(devices) \u003d\u003d 0:"},{"line_number":33,"context_line":"            raise device_inventory.NoValidDevice()"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU%2FA%3D","line":31,"updated":"2013-10-17 17:33:43.000000000","message":"I don\u0027t see any reason Algorithm needs to be a class. It has no state or instance variables. If so this can be a function. Any reason?","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    Algorithm which chooses appropriate device based on the subnet_id"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    def __call__(self, devices, subnet_id):"},{"line_number":32,"context_line":"        if len(devices) \u003d\u003d 0:"},{"line_number":33,"context_line":"            raise device_inventory.NoValidDevice()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        filtered \u003d [device for device in devices"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU%2B0%3D","line":32,"updated":"2013-10-17 17:33:43.000000000","message":"Please consider:\n\n  if not devices:","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"}],"neutron/services/loadbalancer/drivers/brocade/device_inventory/brocade_adx_device_inventory.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import sqlalchemy as sa"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from sqlalchemy.orm import exc as orm_exc"},{"line_number":24,"context_line":"from sqlalchemy import types"},{"line_number":25,"context_line":"from sqlalchemy.types import TypeDecorator"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXLM%3D","line":22,"updated":"2013-10-17 08:02:07.000000000","message":"blank line not needed","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import sqlalchemy as sa"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from sqlalchemy.orm import exc as orm_exc"},{"line_number":24,"context_line":"from sqlalchemy import types"},{"line_number":25,"context_line":"from sqlalchemy.types import TypeDecorator"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVEE%3D","line":22,"in_reply_to":"AAAATH%2F%2FXLM%3D","updated":"2013-10-17 16:54:59.000000000","message":"will remove","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from sqlalchemy.orm import exc as orm_exc"},{"line_number":24,"context_line":"from sqlalchemy import types"},{"line_number":25,"context_line":"from sqlalchemy.types import TypeDecorator"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from neutron.common import exceptions as q_exc"},{"line_number":28,"context_line":"from neutron.common import log"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU8Y%3D","line":25,"updated":"2013-10-17 17:33:43.000000000","message":"Please use module-level import.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.db import api as db"},{"line_number":30,"context_line":"from neutron.db import model_base"},{"line_number":31,"context_line":"from neutron.db import models_v2"},{"line_number":32,"context_line":"from neutron.extensions.deviceinventory import DeviceInventoryPluginBase"},{"line_number":33,"context_line":"from neutron import manager"},{"line_number":34,"context_line":"from neutron.openstack.common import jsonutils"},{"line_number":35,"context_line":"from neutron.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU8U%3D","line":32,"updated":"2013-10-17 17:33:43.000000000","message":"ditto","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    device_type \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":74,"context_line":"    device_version \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":75,"context_line":"    management \u003d sa.Column(JsonType(255), nullable\u003dTrue)"},{"line_number":76,"context_line":"    subnet_id \u003d sa.Column(sa.String(36), default\u003d\"\")"},{"line_number":77,"context_line":"    capabilities \u003d sa.Column(JsonType(255), nullable\u003dTrue)"},{"line_number":78,"context_line":"    status \u003d sa.Column(sa.String(36), nullable\u003dFalse,"},{"line_number":79,"context_line":"                       default\u003dconstants.PENDING_CREATE)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU8A%3D","line":76,"updated":"2013-10-17 17:33:43.000000000","message":"foreign key?","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":82,"context_line":"class BrocadeDeviceInventoryPluginDb(DeviceInventoryPluginBase):"},{"line_number":83,"context_line":"    \"\"\"Simplistic device manager plugin provided.\"\"\""},{"line_number":84,"context_line":"    def __init__(self):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _get_tenant_id_for_create(self, context, resource):"},{"line_number":88,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU7o%3D","line":85,"updated":"2013-10-17 17:33:43.000000000","message":"Seems unnecessary.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def __init__(self):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _get_tenant_id_for_create(self, context, resource):"},{"line_number":88,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"},{"line_number":89,"context_line":"            tenant_id \u003d resource[\u0027tenant_id\u0027]"},{"line_number":90,"context_line":"        elif (\u0027tenant_id\u0027 in resource and"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU7U%3D","line":87,"updated":"2013-10-17 17:33:43.000000000","message":"It seems it is a exact copy of get_tenant_\nid_for_create in db_base_plugin. If so honor DRY policy.\n\nI see many code copy in this class (here to L.149). Please avoid duplicated codes.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"ee4a332e22c4cf1ecc0661d21cd00e4726a8a5d4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def __init__(self):"},{"line_number":85,"context_line":"        pass"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def _get_tenant_id_for_create(self, context, resource):"},{"line_number":88,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"},{"line_number":89,"context_line":"            tenant_id \u003d resource[\u0027tenant_id\u0027]"},{"line_number":90,"context_line":"        elif (\u0027tenant_id\u0027 in resource and"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FOmc%3D","line":87,"in_reply_to":"AAAATH%2F%2FU7U%3D","updated":"2013-10-20 21:52:55.000000000","message":"I think this class should just inherit CommonDbMixin","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def create_device(self, context, device):"},{"line_number":228,"context_line":"        d \u003d (super(BrocadeDeviceInventoryPlugin, self)"},{"line_number":229,"context_line":"             .create_device(context, device))"},{"line_number":230,"context_line":"        return d"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @log.log"},{"line_number":233,"context_line":"    def update_device(self, context, device):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU6s%3D","line":230,"updated":"2013-10-17 17:33:43.000000000","message":"Consider:\n\n  return super(BrocadeDeviceInventroyPlugin, self).create_device(...)","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    def update_device(self, context, device):"},{"line_number":234,"context_line":"        d \u003d (super(BrocadeDeviceInventoryPlugin, self)"},{"line_number":235,"context_line":"             .update_device(context, device))"},{"line_number":236,"context_line":"        return d"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    @log.log"},{"line_number":239,"context_line":"    def delete_device(self, context, id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU6o%3D","line":236,"updated":"2013-10-17 17:33:43.000000000","message":"ditto","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"}],"neutron/services/loadbalancer/drivers/brocade/device_inventory/device_selector.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron.services.loadbalancer.drivers.brocade.device_inventory import ("},{"line_number":25,"context_line":"    algorithm,"},{"line_number":26,"context_line":"    brocade_adx_device_inventory as device_inv"},{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU%2BE%3D","line":27,"updated":"2013-10-17 17:33:43.000000000","message":"Import one module per line.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        LOG.debug(_(\"Get device for the subnet %s\"), subnet_id)"},{"line_number":39,"context_line":"        devices \u003d (manager.NeutronManager"},{"line_number":40,"context_line":"                   .get_service_plugins()[\"DEVICE_MANAGER\"]"},{"line_number":41,"context_line":"                   .get_devices(get_admin_context()))"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            device \u003d self.algorithm(devices, subnet_id)"},{"line_number":44,"context_line":"            LOG.debug(_(\"Found device %(device)s\"), {\"device\": device})"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU9Q%3D","line":41,"updated":"2013-10-17 17:33:43.000000000","message":"context cannot be used?\nIf you need admin role, context.elevated() can be used too. The difference from get_admin_context is that tenant/user is preserved when elevated.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                   .get_devices(get_admin_context()))"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            device \u003d self.algorithm(devices, subnet_id)"},{"line_number":44,"context_line":"            LOG.debug(_(\"Found device %(device)s\"), {\"device\": device})"},{"line_number":45,"context_line":"            return device"},{"line_number":46,"context_line":"        except device_inv.NoValidDevice as e:"},{"line_number":47,"context_line":"            LOG.error(_(\"No valid device was found.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU9E%3D","line":44,"updated":"2013-10-17 17:33:43.000000000","message":"No need to use keyword substitution.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            LOG.debug(_(\"Found device %(device)s\"), {\"device\": device})"},{"line_number":45,"context_line":"            return device"},{"line_number":46,"context_line":"        except device_inv.NoValidDevice as e:"},{"line_number":47,"context_line":"            LOG.error(_(\"No valid device was found.\"))"},{"line_number":48,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU%2BQ%3D","line":47,"updated":"2013-10-17 17:33:43.000000000","message":"I think it is useful to add subnet_id in the log message.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            return device"},{"line_number":46,"context_line":"        except device_inv.NoValidDevice as e:"},{"line_number":47,"context_line":"            LOG.error(_(\"No valid device was found.\"))"},{"line_number":48,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU8k%3D","line":48,"updated":"2013-10-17 17:33:43.000000000","message":"Please consider using openstack.common.excutils.save_and_reraise_exception. The docstring in save_and_reraise_exception describes the detail.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"ee4a332e22c4cf1ecc0661d21cd00e4726a8a5d4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            return device"},{"line_number":46,"context_line":"        except device_inv.NoValidDevice as e:"},{"line_number":47,"context_line":"            LOG.error(_(\"No valid device was found.\"))"},{"line_number":48,"context_line":"            raise e"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FOmE%3D","line":48,"in_reply_to":"AAAATH%2F%2FU8k%3D","updated":"2013-10-20 21:52:55.000000000","message":"Can we just \u0027raise\u0027 here?","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"}],"neutron/services/loadbalancer/drivers/brocade/extensions/deviceinventory.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3be3990eb6c066a6a9c753cc94f790b006871ae6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FXK0%3D","line":3,"updated":"2013-10-17 08:02:07.000000000","message":"2013","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"a8079d22dba09d692ec45cbc963b02cb73e48183","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FVD4%3D","line":3,"in_reply_to":"AAAATH%2F%2FXK0%3D","updated":"2013-10-17 16:54:59.000000000","message":"will fix","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"}],"neutron/services/loadbalancer/drivers/brocade/plugin_driver/brocade_adx_plugin_driver.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                                  new_vip[\"id\"],"},{"line_number":80,"context_line":"                                  constants.ACTIVE)"},{"line_number":81,"context_line":"        except Exception as e:"},{"line_number":82,"context_line":"            LOG.debug(_(\"Exception in update_vip in device driver : %s\"), e)"},{"line_number":83,"context_line":"            self.db.update_status(context,"},{"line_number":84,"context_line":"                                  loadbalancer_db.Vip,"},{"line_number":85,"context_line":"                                  new_vip[\"id\"],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU54%3D","line":82,"updated":"2013-10-17 17:33:43.000000000","message":"The log level is DEBUG. Is it okay?","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            # call the device driver api"},{"line_number":93,"context_line":"            self.device_driver.delete_vip(device, vip)"},{"line_number":94,"context_line":"        except Exception as e:"},{"line_number":95,"context_line":"            LOG.debug(_(\"Exception in delete_vip in device driver : %s\"), e)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # Delete VIP from DB any case"},{"line_number":98,"context_line":"        self.plugin._delete_db_vip(context, vip[\"id\"])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU50%3D","line":95,"updated":"2013-10-17 17:33:43.000000000","message":"ditto","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.db.update_status(context, loadbalancer_db.Pool, pool[\"id\"],"},{"line_number":107,"context_line":"                                  constants.ACTIVE)"},{"line_number":108,"context_line":"        except Exception as e:"},{"line_number":109,"context_line":"            LOG.debug(_(\"Exception in create_pool in device driver : %s\"), e)"},{"line_number":110,"context_line":"            self.db.update_status(context, loadbalancer_db.Pool, pool[\"id\"],"},{"line_number":111,"context_line":"                                  constants.ERROR)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU5g%3D","line":109,"updated":"2013-10-17 17:33:43.000000000","message":"same as the above","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938cc870de1579cf952b120b4ea372858495dd71","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                  new_pool[\"id\"],"},{"line_number":122,"context_line":"                                  constants.ACTIVE)"},{"line_number":123,"context_line":"        except Exception as e:"},{"line_number":124,"context_line":"            LOG.debug(_(\"Exception in update in device driver : %s\"), e)"},{"line_number":125,"context_line":"            self.db.update_status(context,"},{"line_number":126,"context_line":"                                  loadbalancer_db.Pool,"},{"line_number":127,"context_line":"                                  new_pool[\"id\"],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATH%2F%2FU5c%3D","line":124,"updated":"2013-10-17 17:33:43.000000000","message":"same as the above\n\nThere are same log output below.","commit_id":"7ff095439dbf974e19d0369daa9267597a60f794"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34c60fdde744cabd7e3164449d46b01f33ce9733","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @log.log"},{"line_number":174,"context_line":"    def stats(self, context, pool_id):"},{"line_number":175,"context_line":"        return {\"bytes_in\": 0,"},{"line_number":176,"context_line":"                \"bytes_out\": 0,"},{"line_number":177,"context_line":"                \"active_connections\": 0,"},{"line_number":178,"context_line":"                \"total_connections\": 0}"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2FkE%3D","line":175,"updated":"2013-10-23 07:03:48.000000000","message":"please use constants from neutron.services.loadbalancer.constants","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"b6d1df78f154c5d3ca6673c30b63617b09d98ea8","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @log.log"},{"line_number":174,"context_line":"    def stats(self, context, pool_id):"},{"line_number":175,"context_line":"        return {\"bytes_in\": 0,"},{"line_number":176,"context_line":"                \"bytes_out\": 0,"},{"line_number":177,"context_line":"                \"active_connections\": 0,"},{"line_number":178,"context_line":"                \"total_connections\": 0}"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Lg%3D","line":175,"in_reply_to":"AAAATX%2F%2F%2FkE%3D","updated":"2013-10-23 17:49:05.000000000","message":"Done","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34c60fdde744cabd7e3164449d46b01f33ce9733","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def update_health_monitor(self, context, old_health_monitor,"},{"line_number":228,"context_line":"                              health_monitor,"},{"line_number":229,"context_line":"                              pool_association):"},{"line_number":230,"context_line":"        pass"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @log.log"},{"line_number":233,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F%2Fjk%3D","line":230,"updated":"2013-10-23 07:03:48.000000000","message":"TODO?","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"},{"author":{"_account_id":7590,"name":"Pattabi Ayyasami","email":"pattabi@brocade.com","username":"pattabibrocade.com"},"change_message_id":"b6d1df78f154c5d3ca6673c30b63617b09d98ea8","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def update_health_monitor(self, context, old_health_monitor,"},{"line_number":228,"context_line":"                              health_monitor,"},{"line_number":229,"context_line":"                              pool_association):"},{"line_number":230,"context_line":"        pass"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    @log.log"},{"line_number":233,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATX%2F%2F9Lc%3D","line":230,"in_reply_to":"AAAATX%2F%2F%2Fjk%3D","updated":"2013-10-23 17:49:05.000000000","message":"Yes. This is still a TODO from my side. I will update the method implementation appropriately.","commit_id":"01cc020999ac9927220fbb8b5a6ba88efb045dcd"}]}
