)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26709,"name":"Rong.Wang","email":"rong.wang@easystack.cn","username":"wangrong"},"change_message_id":"af72b4d07490960478464863272033a4328cb6a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix ingress bw limit for OVS DPDK ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For OVS based DPDK ports ingress bandwidth limit is now implemented"},{"line_number":10,"context_line":"using egress-policier qos type."},{"line_number":11,"context_line":"Additionally limit values are set in other_config of QoS because there"},{"line_number":12,"context_line":"is no queue used in this case."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_c7002704","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":21},"updated":"2017-10-25 12:51:29.000000000","message":"may should be \"egress-policer\"","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d75f66dd06c7127d4d8fcc3d27cbf3613e1c3a51","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix ingress bw limit for OVS DPDK ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For OVS based DPDK ports ingress bandwidth limit is now implemented"},{"line_number":10,"context_line":"using egress-policier qos type."},{"line_number":11,"context_line":"Additionally limit values are set in other_config of QoS because there"},{"line_number":12,"context_line":"is no queue used in this case."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_3695e033","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":21},"in_reply_to":"3f4b6375_c7002704","updated":"2017-10-25 19:46:40.000000000","message":"Done","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":26709,"name":"Rong.Wang","email":"rong.wang@easystack.cn","username":"wangrong"},"change_message_id":"b74dd2bb4f55679a92584242a75c7a835ee1eb64","unresolved":false,"context_lines":[{"line_number":757,"context_line":"            external_ids \u003d {\u0027id\u0027: port_name}"},{"line_number":758,"context_line":"            qos_uuid \u003d txn.add("},{"line_number":759,"context_line":"                self.ovsdb.db_create("},{"line_number":760,"context_line":"                    \u0027QoS\u0027, external_ids\u003dexternal_ids, type\u003d\u0027egress-policier\u0027,"},{"line_number":761,"context_line":"                    other_config\u003dother_config))"},{"line_number":762,"context_line":"        return qos_uuid"},{"line_number":763,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_4472f87c","line":760,"range":{"start_line":760,"start_character":60,"end_line":760,"end_character":75},"updated":"2017-10-25 10:26:06.000000000","message":"should be \"egress-policer\"","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d75f66dd06c7127d4d8fcc3d27cbf3613e1c3a51","unresolved":false,"context_lines":[{"line_number":757,"context_line":"            external_ids \u003d {\u0027id\u0027: port_name}"},{"line_number":758,"context_line":"            qos_uuid \u003d txn.add("},{"line_number":759,"context_line":"                self.ovsdb.db_create("},{"line_number":760,"context_line":"                    \u0027QoS\u0027, external_ids\u003dexternal_ids, type\u003d\u0027egress-policier\u0027,"},{"line_number":761,"context_line":"                    other_config\u003dother_config))"},{"line_number":762,"context_line":"        return qos_uuid"},{"line_number":763,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_76711844","line":760,"range":{"start_line":760,"start_character":60,"end_line":760,"end_character":75},"in_reply_to":"3f4b6375_4472f87c","updated":"2017-10-25 19:46:40.000000000","message":"Done","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83d9c743bbb467bf5ea5bdffebd15edda3f23fb9","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"DPDK_DATAPATH_TYPES \u003d ["},{"line_number":68,"context_line":"    constants.OVS_DATAPATH_NETDEV,"},{"line_number":69,"context_line":"    constants.OVS_DPDK_VHOST_USER,"},{"line_number":70,"context_line":"    constants.OVS_DPDK_VHOST_USER_CLIENT]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_d4192cd7","line":69,"in_reply_to":"","updated":"2017-11-02 03:21:57.000000000","message":"This is not a datapath_type it is an interface type.","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"DPDK_DATAPATH_TYPES \u003d ["},{"line_number":68,"context_line":"    constants.OVS_DATAPATH_NETDEV,"},{"line_number":69,"context_line":"    constants.OVS_DPDK_VHOST_USER,"},{"line_number":70,"context_line":"    constants.OVS_DPDK_VHOST_USER_CLIENT]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_0e644f21","line":69,"in_reply_to":"3f4b6375_d4192cd7","updated":"2017-11-02 09:02:42.000000000","message":"ok, changed","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f89d0e2de370f44b043f976a86120a663977d9f8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"DPDK_DATAPATH_TYPES \u003d ["},{"line_number":68,"context_line":"    constants.OVS_DATAPATH_NETDEV,"},{"line_number":69,"context_line":"    constants.OVS_DPDK_VHOST_USER,"},{"line_number":70,"context_line":"    constants.OVS_DPDK_VHOST_USER_CLIENT]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def _ovsdb_result_pending(result):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_636fb592","line":70,"updated":"2017-10-30 15:41:39.000000000","message":"nit: guess you could define this in the constants file","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":67,"context_line":"DPDK_DATAPATH_TYPES \u003d ["},{"line_number":68,"context_line":"    constants.OVS_DATAPATH_NETDEV,"},{"line_number":69,"context_line":"    constants.OVS_DPDK_VHOST_USER,"},{"line_number":70,"context_line":"    constants.OVS_DPDK_VHOST_USER_CLIENT]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def _ovsdb_result_pending(result):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_4ea8071f","line":70,"in_reply_to":"3f4b6375_636fb592","updated":"2017-11-02 09:02:42.000000000","message":"I removed it from here","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2d306691e3a8bbc79af53e84fbc9764e1a627362","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                    queues\u003dqueues))"},{"line_number":749,"context_line":"        return qos_uuid"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def _update_bw_limit_profile_dpdk(self, txn, port_name, qos_uuid,"},{"line_number":752,"context_line":"                                      other_config):"},{"line_number":753,"context_line":"        if qos_uuid:"},{"line_number":754,"context_line":"            txn.add(self.ovsdb.db_set("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_de02be09","line":751,"range":{"start_line":751,"start_character":44,"end_line":751,"end_character":49},"updated":"2017-10-30 15:55:56.000000000","message":"Nit: I would remove the dependency on creating txn outside of this class and use the nested transaction here. The nested transaction is returned automatically when you use self.ovsdb.transaction() and transaction already exists.","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                    queues\u003dqueues))"},{"line_number":749,"context_line":"        return qos_uuid"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def _update_bw_limit_profile_dpdk(self, txn, port_name, qos_uuid,"},{"line_number":752,"context_line":"                                      other_config):"},{"line_number":753,"context_line":"        if qos_uuid:"},{"line_number":754,"context_line":"            txn.add(self.ovsdb.db_set("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_6e74e3cf","line":751,"range":{"start_line":751,"start_character":44,"end_line":751,"end_character":49},"in_reply_to":"3f4b6375_de02be09","updated":"2017-11-02 09:02:42.000000000","message":"Yes, but it is like that in all other methods for QoS. Maybe I can propose this change in another patch for all methods? What You think about that?","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83d9c743bbb467bf5ea5bdffebd15edda3f23fb9","unresolved":false,"context_lines":[{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def update_ingress_bw_limit_for_port("},{"line_number":802,"context_line":"            self, port_name, max_kbps, max_burst_kbps,"},{"line_number":803,"context_line":"            port_datapath_type):"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":806,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_b4e6b0af","line":803,"updated":"2017-11-02 03:21:57.000000000","message":"The is no such thig as a port datapath_type\nBridges have datapath_types interfaces have a type filed but it a completely different concept","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2d306691e3a8bbc79af53e84fbc9764e1a627362","unresolved":false,"context_lines":[{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def update_ingress_bw_limit_for_port("},{"line_number":802,"context_line":"            self, port_name, max_kbps, max_burst_kbps,"},{"line_number":803,"context_line":"            port_datapath_type):"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":806,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_03624117","line":803,"range":{"start_line":803,"start_character":12,"end_line":803,"end_character":30},"updated":"2017-10-30 15:55:56.000000000","message":"We should make a default value here to provide backward compatibility.","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def update_ingress_bw_limit_for_port("},{"line_number":802,"context_line":"            self, port_name, max_kbps, max_burst_kbps,"},{"line_number":803,"context_line":"            port_datapath_type):"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":806,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_8e603f03","line":803,"range":{"start_line":803,"start_character":12,"end_line":803,"end_character":30},"in_reply_to":"3f4b6375_03624117","updated":"2017-11-02 09:02:42.000000000","message":"ok, added","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def update_ingress_bw_limit_for_port("},{"line_number":802,"context_line":"            self, port_name, max_kbps, max_burst_kbps,"},{"line_number":803,"context_line":"            port_datapath_type):"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":806,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_4e56c72c","line":803,"in_reply_to":"3f4b6375_b4e6b0af","updated":"2017-11-02 09:02:42.000000000","message":"ok, changed","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"9ce2443e3d9a45f58c544ba1a51ff8bd772b15bc","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":801,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        if datapath_type \u003d\u003d constants.OVS_DATAPATH_NETDEV:"},{"line_number":804,"context_line":"            self._update_ingress_bw_limit_for_dpdk_port("},{"line_number":805,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":806,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_3b38599e","line":803,"range":{"start_line":803,"start_character":10,"end_line":803,"end_character":57},"updated":"2017-11-02 17:34:11.000000000","message":"if you check interface type in ovsdb is OVS_DPDK_VHOST_USER/_CLIENT that should be enough, netdev could still be something other than DPDK.","commit_id":"67807785dd72222649da6f8f224f301a9cbc6b4c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17f3b20bec7d15e28fbb7f7de2d1916332c0edc6","unresolved":false,"context_lines":[{"line_number":800,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":801,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"        if datapath_type \u003d\u003d constants.OVS_DATAPATH_NETDEV:"},{"line_number":804,"context_line":"            self._update_ingress_bw_limit_for_dpdk_port("},{"line_number":805,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":806,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_3e7b407b","line":803,"range":{"start_line":803,"start_character":10,"end_line":803,"end_character":57},"in_reply_to":"3f4b6375_3b38599e","updated":"2017-11-08 12:44:24.000000000","message":"yes and then my patch can be much smaller. Thx :)","commit_id":"67807785dd72222649da6f8f224f301a9cbc6b4c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c5b32ec5d668c7b3812e24f90e7b7dfa0bd5cb4c","unresolved":false,"context_lines":[{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def update_ingress_bw_limit_for_port(self, port_name, max_kbps,"},{"line_number":797,"context_line":"                                         max_burst_kbps):"},{"line_number":798,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":799,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":800,"context_line":"        port_type \u003d self._get_port_val(port_name, \"type\")"},{"line_number":801,"context_line":"        if port_type in constants.OVS_DPDK_PORT_TYPES:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_589e1a08","line":798,"range":{"start_line":798,"start_character":29,"end_line":798,"end_character":44},"updated":"2017-11-20 13:52:39.000000000","message":"is this the correct base.\ni generally expect network bandwidth to be base 2 unless otherwise specified.","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8abd1e8b0d809c4871829e2418091fecf598b72b","unresolved":false,"context_lines":[{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def update_ingress_bw_limit_for_port(self, port_name, max_kbps,"},{"line_number":797,"context_line":"                                         max_burst_kbps):"},{"line_number":798,"context_line":"        max_bw_in_bits \u003d str(max_kbps * 1000)"},{"line_number":799,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":800,"context_line":"        port_type \u003d self._get_port_val(port_name, \"type\")"},{"line_number":801,"context_line":"        if port_type in constants.OVS_DPDK_PORT_TYPES:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_a6e11c9d","line":798,"range":{"start_line":798,"start_character":29,"end_line":798,"end_character":44},"in_reply_to":"ff82abbf_589e1a08","updated":"2017-11-21 18:57:41.000000000","message":"I think it is fine. If not it should be reported as separate bug and fixed in other patch.","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"3f46978c830e6442aeee704c6ac5dd69057c6818","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":820,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def get_ingress_bw_limit_for_dpdk_port(self, port_name):"},{"line_number":823,"context_line":"        max_kbps \u003d None"},{"line_number":824,"context_line":"        max_burst_kbit \u003d None"},{"line_number":825,"context_line":"        res \u003d self._find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_80bcc2dc","line":822,"range":{"start_line":822,"start_character":8,"end_line":822,"end_character":42},"updated":"2017-11-14 02:50:24.000000000","message":"This function just be called by the UTs, will it be reconstructed like update_bw_limit part in L796-L806? I think it\u0027s better to do the same thing towards get_bw_limit. Do you agree?","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"edb5adee167b59201859030d4c05ee3485d0efac","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":820,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def get_ingress_bw_limit_for_dpdk_port(self, port_name):"},{"line_number":823,"context_line":"        max_kbps \u003d None"},{"line_number":824,"context_line":"        max_burst_kbit \u003d None"},{"line_number":825,"context_line":"        res \u003d self._find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_785e7ee7","line":822,"range":{"start_line":822,"start_character":8,"end_line":822,"end_character":42},"in_reply_to":"1f485f77_2f1e0d70","updated":"2017-11-20 14:17:34.000000000","message":"You could remove this function entirely if you put a conditional in \"get_ingress_bw_limit_for_port\" that swapped \u0027max_rate\u0027 for \u0027cir\u0027 and \u0027burst\u0027 for \u0027cbs\u0027 when DPDK is enabled on the interface.","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c5b32ec5d668c7b3812e24f90e7b7dfa0bd5cb4c","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":820,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def get_ingress_bw_limit_for_dpdk_port(self, port_name):"},{"line_number":823,"context_line":"        max_kbps \u003d None"},{"line_number":824,"context_line":"        max_burst_kbit \u003d None"},{"line_number":825,"context_line":"        res \u003d self._find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_98c6e216","line":822,"range":{"start_line":822,"start_character":8,"end_line":822,"end_character":42},"in_reply_to":"1f485f77_2f1e0d70","updated":"2017-11-20 13:52:39.000000000","message":"if this is only used in the functional test it should not be defined here it should be defined in the functional tests.\n\nif you define it here you need unit tests for this function.","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"16e91634cef4a8ff4476d33ae18eae2e950f9e2d","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":820,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def get_ingress_bw_limit_for_dpdk_port(self, port_name):"},{"line_number":823,"context_line":"        max_kbps \u003d None"},{"line_number":824,"context_line":"        max_burst_kbit \u003d None"},{"line_number":825,"context_line":"        res \u003d self._find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_2f1e0d70","line":822,"range":{"start_line":822,"start_character":8,"end_line":822,"end_character":42},"in_reply_to":"1f485f77_80bcc2dc","updated":"2017-11-14 15:12:20.000000000","message":"This function is called by functional test. I decided to left it as it is now because it\u0027s more \"verbose\" in functional test or reader what assertion is done there. That\u0027s why I don\u0027t want to \"hide\" choose of dpdk/non dpdk port logic inside this method.","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4cbe93e4c1184944e3a2485a46a4a610943e1fde","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":820,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def get_ingress_bw_limit_for_dpdk_port(self, port_name):"},{"line_number":823,"context_line":"        max_kbps \u003d None"},{"line_number":824,"context_line":"        max_burst_kbit \u003d None"},{"line_number":825,"context_line":"        res \u003d self._find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_f94e0dc0","line":822,"range":{"start_line":822,"start_character":8,"end_line":822,"end_character":42},"in_reply_to":"ff82abbf_785e7ee7","updated":"2017-11-20 17:40:54.000000000","message":"ok, I will take a look for that ASAP, thx.","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4cbe93e4c1184944e3a2485a46a4a610943e1fde","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":820,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def get_ingress_bw_limit_for_dpdk_port(self, port_name):"},{"line_number":823,"context_line":"        max_kbps \u003d None"},{"line_number":824,"context_line":"        max_burst_kbit \u003d None"},{"line_number":825,"context_line":"        res \u003d self._find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_d966a952","line":822,"range":{"start_line":822,"start_character":8,"end_line":822,"end_character":42},"in_reply_to":"ff82abbf_98c6e216","updated":"2017-11-20 17:40:54.000000000","message":"there are almost none unit tests for this module so I don\u0027t think I should do it for this one.","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8abd1e8b0d809c4871829e2418091fecf598b72b","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":820,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def get_ingress_bw_limit_for_dpdk_port(self, port_name):"},{"line_number":823,"context_line":"        max_kbps \u003d None"},{"line_number":824,"context_line":"        max_burst_kbit \u003d None"},{"line_number":825,"context_line":"        res \u003d self._find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_41e91a18","line":822,"range":{"start_line":822,"start_character":8,"end_line":822,"end_character":42},"in_reply_to":"ff82abbf_f94e0dc0","updated":"2017-11-21 18:57:41.000000000","message":"It\u0027s now changed","commit_id":"3682335e8e3117899304aa98cecc8f44a7010371"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09ce7b8f5b5ca01b3f0979e947c61e970c003910","unresolved":false,"context_lines":[{"line_number":746,"context_line":"    def _update_bw_limit_profile_dpdk(self, txn, port_name, qos_uuid,"},{"line_number":747,"context_line":"                                      other_config):"},{"line_number":748,"context_line":"        if qos_uuid:"},{"line_number":749,"context_line":"            txn.add(self.ovsdb.db_set("},{"line_number":750,"context_line":"                \u0027QoS\u0027, qos_uuid, (\u0027other_config\u0027, other_config)))"},{"line_number":751,"context_line":"        else:"},{"line_number":752,"context_line":"            external_ids \u003d {\u0027id\u0027: port_name}"},{"line_number":753,"context_line":"            qos_uuid \u003d txn.add("}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_0e976aee","line":750,"range":{"start_line":749,"start_character":11,"end_line":750,"end_character":65},"updated":"2017-12-07 12:21:58.000000000","message":"for key , val in other_config.items()\ntxn.add(self.ovsdb.db_set(\n                \u0027QoS\u0027, qos_uuid, (\"other_config%s\" %key, value)))","commit_id":"2a7751a269d0cb4cedaf4897feffce920743ef95"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fd9a3012570ee18b86d8716ee18a43bbb917b0fd","unresolved":false,"context_lines":[{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def _update_ingress_bw_limit_for_dpdk_port("},{"line_number":783,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":784,"context_line":"        qos_other_config \u003d {"},{"line_number":785,"context_line":"            \u0027cir\u0027: max_bw_in_bits,"},{"line_number":786,"context_line":"            \u0027cbs\u0027: max_burst_in_bits,"},{"line_number":787,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_30b8ed28","line":784,"updated":"2017-12-04 13:24:03.000000000","message":"Is it safe to not include whatever was stored in other_config before? Let\u0027s say we write another feature using other_config in QoS table then we will rewrite its content here. Or is my comment just YAGNI","commit_id":"2a7751a269d0cb4cedaf4897feffce920743ef95"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"09ce7b8f5b5ca01b3f0979e947c61e970c003910","unresolved":false,"context_lines":[{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def _update_ingress_bw_limit_for_dpdk_port("},{"line_number":783,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":784,"context_line":"        qos_other_config \u003d {"},{"line_number":785,"context_line":"            \u0027cir\u0027: max_bw_in_bits,"},{"line_number":786,"context_line":"            \u0027cbs\u0027: max_burst_in_bits,"},{"line_number":787,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_ae267e14","line":784,"in_reply_to":"df87a7cf_1164afe3","updated":"2017-12-07 12:21:58.000000000","message":"you do not need to do a read modify write style workflow for this. When writing to the ovsdb you can instead update just the sub keys of the other_config instead of the dictionary.","commit_id":"2a7751a269d0cb4cedaf4897feffce920743ef95"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"83345d91375e5fa741305df9b977a5a2963516bf","unresolved":false,"context_lines":[{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def _update_ingress_bw_limit_for_dpdk_port("},{"line_number":783,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":784,"context_line":"        qos_other_config \u003d {"},{"line_number":785,"context_line":"            \u0027cir\u0027: max_bw_in_bits,"},{"line_number":786,"context_line":"            \u0027cbs\u0027: max_burst_in_bits,"},{"line_number":787,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_1164afe3","line":784,"in_reply_to":"df87a7cf_30b8ed28","updated":"2017-12-05 12:03:29.000000000","message":"I don\u0027t think that there will be anything else stored in qos other_config. It is used only for bandwidth limiting.\nAlso please note that it\u0027s the same for queue already. IMHO if it would be an issue it should be fixed in separate patch in all places.","commit_id":"2a7751a269d0cb4cedaf4897feffce920743ef95"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"afd375ffaf0a381101d1340de3f44a109f0b3697","unresolved":false,"context_lines":[{"line_number":746,"context_line":"    def _update_bw_limit_profile_dpdk(self, txn, port_name, qos_uuid,"},{"line_number":747,"context_line":"                                      other_config):"},{"line_number":748,"context_line":"        if qos_uuid:"},{"line_number":749,"context_line":"            txn.add(self.ovsdb.db_set("},{"line_number":750,"context_line":"                \u0027QoS\u0027, qos_uuid, (\u0027other_config\u0027, other_config)))"},{"line_number":751,"context_line":"        else:"},{"line_number":752,"context_line":"            external_ids \u003d {\u0027id\u0027: port_name}"},{"line_number":753,"context_line":"            qos_uuid \u003d txn.add("}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_0e652a1e","line":750,"range":{"start_line":749,"start_character":12,"end_line":750,"end_character":65},"updated":"2017-12-07 12:22:24.000000000","message":"for key , val in other_config.items()\ntxn.add(self.ovsdb.db_set(\n                \u0027QoS\u0027, qos_uuid, (\"other_config%s\" %key, value)))","commit_id":"22bce337fceb4afac2e99981d68dfe65a2556190"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"600e0d779c5064106850636af29bbb6d3dc089c8","unresolved":false,"context_lines":[{"line_number":746,"context_line":"    def _update_bw_limit_profile_dpdk(self, txn, port_name, qos_uuid,"},{"line_number":747,"context_line":"                                      other_config):"},{"line_number":748,"context_line":"        if qos_uuid:"},{"line_number":749,"context_line":"            txn.add(self.ovsdb.db_set("},{"line_number":750,"context_line":"                \u0027QoS\u0027, qos_uuid, (\u0027other_config\u0027, other_config)))"},{"line_number":751,"context_line":"        else:"},{"line_number":752,"context_line":"            external_ids \u003d {\u0027id\u0027: port_name}"},{"line_number":753,"context_line":"            qos_uuid \u003d txn.add("}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_df960d3f","line":750,"range":{"start_line":749,"start_character":12,"end_line":750,"end_character":65},"in_reply_to":"df87a7cf_0e4e8a96","updated":"2017-12-07 14:42:34.000000000","message":"can we do it for now in \"old\" way and I will report bug and fix it in all places together in separate patch?","commit_id":"22bce337fceb4afac2e99981d68dfe65a2556190"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6e138d293f89e60941d0401b5c5632fd9f12fa8f","unresolved":false,"context_lines":[{"line_number":746,"context_line":"    def _update_bw_limit_profile_dpdk(self, txn, port_name, qos_uuid,"},{"line_number":747,"context_line":"                                      other_config):"},{"line_number":748,"context_line":"        if qos_uuid:"},{"line_number":749,"context_line":"            txn.add(self.ovsdb.db_set("},{"line_number":750,"context_line":"                \u0027QoS\u0027, qos_uuid, (\u0027other_config\u0027, other_config)))"},{"line_number":751,"context_line":"        else:"},{"line_number":752,"context_line":"            external_ids \u003d {\u0027id\u0027: port_name}"},{"line_number":753,"context_line":"            qos_uuid \u003d txn.add("}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_0e4e8a96","line":750,"range":{"start_line":749,"start_character":12,"end_line":750,"end_character":65},"in_reply_to":"df87a7cf_0e652a1e","updated":"2017-12-07 12:23:29.000000000","message":"actully its \"other_config:%s\"","commit_id":"22bce337fceb4afac2e99981d68dfe65a2556190"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a754aa0a9dbc92ef5bb47c110ccf30a3ae0a8170","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            self._update_ingress_bw_limit_for_port("},{"line_number":814,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def get_ingress_bw_limit_for_port(self, port_name, dpdk_port\u003dFalse):"},{"line_number":817,"context_line":"        if dpdk_port:"},{"line_number":818,"context_line":"            return self._get_ingress_bw_limit_for_dpdk_port(port_name)"},{"line_number":819,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f91af0f_e100396a","line":816,"range":{"start_line":816,"start_character":55,"end_line":816,"end_character":64},"updated":"2018-01-05 12:11:33.000000000","message":"Is this used anywhere? I mean do we have a caller that uses this param?","commit_id":"27a3027eb8f6a0c75d270e75311b3aa034358a24"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6ecaac8273323c4bb2d8157d91efc79f86d63cc7","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            self._update_ingress_bw_limit_for_port("},{"line_number":814,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def get_ingress_bw_limit_for_port(self, port_name, dpdk_port\u003dFalse):"},{"line_number":817,"context_line":"        if dpdk_port:"},{"line_number":818,"context_line":"            return self._get_ingress_bw_limit_for_dpdk_port(port_name)"},{"line_number":819,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f91af0f_a189d1ca","line":816,"range":{"start_line":816,"start_character":55,"end_line":816,"end_character":64},"in_reply_to":"9f91af0f_6122e902","updated":"2018-01-05 12:21:31.000000000","message":"So why do we need another function if it\u0027s not used in production code? Shouldn\u0027t we rather provide two public methods and used whatever is more suitable:\n\nself.get_ingress_bw_limit_for_dpdk_port()\nself.get_ingress_bw_limit_for_port()","commit_id":"27a3027eb8f6a0c75d270e75311b3aa034358a24"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7c812ab9302e7d33a585c1913d17cdc3747fe515","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            self._update_ingress_bw_limit_for_port("},{"line_number":814,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def get_ingress_bw_limit_for_port(self, port_name, dpdk_port\u003dFalse):"},{"line_number":817,"context_line":"        if dpdk_port:"},{"line_number":818,"context_line":"            return self._get_ingress_bw_limit_for_dpdk_port(port_name)"},{"line_number":819,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f91af0f_fdbd1ad8","line":816,"range":{"start_line":816,"start_character":55,"end_line":816,"end_character":64},"in_reply_to":"9f91af0f_857e1817","updated":"2018-01-08 07:54:43.000000000","message":"ok, done","commit_id":"27a3027eb8f6a0c75d270e75311b3aa034358a24"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c91b90c4cec05b2d88131ae23762e737b1d72ccc","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            self._update_ingress_bw_limit_for_port("},{"line_number":814,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def get_ingress_bw_limit_for_port(self, port_name, dpdk_port\u003dFalse):"},{"line_number":817,"context_line":"        if dpdk_port:"},{"line_number":818,"context_line":"            return self._get_ingress_bw_limit_for_dpdk_port(port_name)"},{"line_number":819,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f91af0f_a5e23c00","line":816,"range":{"start_line":816,"start_character":55,"end_line":816,"end_character":64},"in_reply_to":"9f91af0f_a189d1ca","updated":"2018-01-05 13:03:18.000000000","message":"so You want in fact to convert this method to function in some tests helpers module and here provide two \"public\" methods:\n\nget_ingress_bw_limit_for_port()\nget_ingress_bw_limit_for_dpdk_port()\n\nam I understand You correct?\nIf yes, of course we can do it like that but what will be advantage of it? Maybe just do two \"public\" methods and call directly one of them in tests would be enough?\n\nBTW. I did it like it is now to be kind of consistent with other methods like \"update_ingress_bw_limit\" and \"delete_ingress_bw_limit\"","commit_id":"27a3027eb8f6a0c75d270e75311b3aa034358a24"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3761d7e022656471d95790ffb75d66a8a5110a38","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            self._update_ingress_bw_limit_for_port("},{"line_number":814,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def get_ingress_bw_limit_for_port(self, port_name, dpdk_port\u003dFalse):"},{"line_number":817,"context_line":"        if dpdk_port:"},{"line_number":818,"context_line":"            return self._get_ingress_bw_limit_for_dpdk_port(port_name)"},{"line_number":819,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f91af0f_857e1817","line":816,"range":{"start_line":816,"start_character":55,"end_line":816,"end_character":64},"in_reply_to":"9f91af0f_a5e23c00","updated":"2018-01-05 13:08:20.000000000","message":"No no. What I meant was to remove the leading underscore from current _get methods and remove whole get_ingress_bw_limit_for_port method with dpkd_port parameter.\n\nWith this current code as is, when you want to get limit for non-dpdk port, you call:\n\n get_ingress_bw_limit_for_port(dpdk_port\u003dFalse) and get_ingress_bw_limit_for_port(dpkd_port\u003dTrue) for dpdk port respectively. What I\u0027m suggesting is to avoid having an extra method that only calls different method based on boolean and call the needed method directly instead. So instead of calling e.g.:\n\n get_ingress_bw_limit_for_port(dpdk_port\u003dTrue) -\u003e we call directly get_ingress_bw_limit_for_dpdk_port()\n\nI miss why do we need the boolean and seems to me it just introduces some small unnecessary complexity to the code.","commit_id":"27a3027eb8f6a0c75d270e75311b3aa034358a24"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb5fe7bca2fdbfa178383b539d7aace42e539477","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            self._update_ingress_bw_limit_for_port("},{"line_number":814,"context_line":"                port_name, max_bw_in_bits, max_burst_in_bits)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"    def get_ingress_bw_limit_for_port(self, port_name, dpdk_port\u003dFalse):"},{"line_number":817,"context_line":"        if dpdk_port:"},{"line_number":818,"context_line":"            return self._get_ingress_bw_limit_for_dpdk_port(port_name)"},{"line_number":819,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f91af0f_6122e902","line":816,"range":{"start_line":816,"start_character":55,"end_line":816,"end_character":64},"in_reply_to":"9f91af0f_e100396a","updated":"2018-01-05 12:13:22.000000000","message":"yes, in functional test: https://review.openstack.org/#/c/513398/9/neutron/tests/functional/agent/test_ovs_lib.py","commit_id":"27a3027eb8f6a0c75d270e75311b3aa034358a24"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"399d901c6563cc18ecb7ae55cdc9117be5ca8400","unresolved":false,"context_lines":[{"line_number":790,"context_line":"    def _update_ingress_bw_limit_for_dpdk_port("},{"line_number":791,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":792,"context_line":"        qos_other_config \u003d {"},{"line_number":793,"context_line":"            \u0027cir\u0027: max_bw_in_bits,"},{"line_number":794,"context_line":"            \u0027cbs\u0027: max_burst_in_bits,"},{"line_number":795,"context_line":"        }"},{"line_number":796,"context_line":"        qos \u003d self.find_qos(port_name)"},{"line_number":797,"context_line":"        qos_uuid \u003d qos[\u0027_uuid\u0027] if qos else None"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f91af0f_90fb62bf","line":794,"range":{"start_line":793,"start_character":0,"end_line":794,"end_character":37},"updated":"2018-01-09 21:40:58.000000000","message":"Reading this on-line document, https://software.intel.com/en-us/articles/qos-configuration-and-usage-for-open-vswitch-with-dpdk, it turns out that these parameters should be expressed in bytes","commit_id":"967f3eb499b5272ff5ee4f1441e21e58ee104b5c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d9684ca24f11aaad71e69a19436b12f0b4945783","unresolved":false,"context_lines":[{"line_number":790,"context_line":"    def _update_ingress_bw_limit_for_dpdk_port("},{"line_number":791,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":792,"context_line":"        qos_other_config \u003d {"},{"line_number":793,"context_line":"            \u0027cir\u0027: max_bw_in_bits,"},{"line_number":794,"context_line":"            \u0027cbs\u0027: max_burst_in_bits,"},{"line_number":795,"context_line":"        }"},{"line_number":796,"context_line":"        qos \u003d self.find_qos(port_name)"},{"line_number":797,"context_line":"        qos_uuid \u003d qos[\u0027_uuid\u0027] if qos else None"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f96bb07_5694a344","line":794,"range":{"start_line":793,"start_character":0,"end_line":794,"end_character":37},"in_reply_to":"7f96bb07_5339263f","updated":"2018-01-11 12:01:29.000000000","message":"changed in PS11","commit_id":"967f3eb499b5272ff5ee4f1441e21e58ee104b5c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"18697775901196476fa78bf59873054a6dd78743","unresolved":false,"context_lines":[{"line_number":790,"context_line":"    def _update_ingress_bw_limit_for_dpdk_port("},{"line_number":791,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":792,"context_line":"        qos_other_config \u003d {"},{"line_number":793,"context_line":"            \u0027cir\u0027: max_bw_in_bits,"},{"line_number":794,"context_line":"            \u0027cbs\u0027: max_burst_in_bits,"},{"line_number":795,"context_line":"        }"},{"line_number":796,"context_line":"        qos \u003d self.find_qos(port_name)"},{"line_number":797,"context_line":"        qos_uuid \u003d qos[\u0027_uuid\u0027] if qos else None"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f96bb07_5339263f","line":794,"range":{"start_line":793,"start_character":0,"end_line":794,"end_character":37},"in_reply_to":"9f91af0f_90fb62bf","updated":"2018-01-10 20:41:21.000000000","message":"You\u0027re right. In Ovs docs: http://openvswitch.org/support/dist-docs/ovs-vswitchd.conf.db.5.html it is also like that.\nFunny thing is that for \"linux-htb\" queue type both max-rate and burst are in bit/s - so there is no consistency between those two solutions :/","commit_id":"967f3eb499b5272ff5ee4f1441e21e58ee104b5c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9ed67cd2c34b23dc9bab085a259a5a6138ea1364","unresolved":false,"context_lines":[{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def update_ingress_bw_limit_for_port(self, port_name, max_kbps,"},{"line_number":808,"context_line":"                                         max_burst_kbps):"},{"line_number":809,"context_line":"        max_bw_in_bits \u003d max_kbps * common_constants.SI_BASE"},{"line_number":810,"context_line":"        max_burst_in_bits \u003d max_burst_kbps * common_constants.SI_BASE"},{"line_number":811,"context_line":"        port_type \u003d self._get_port_val(port_name, \"type\")"},{"line_number":812,"context_line":"        if port_type in constants.OVS_DPDK_PORT_TYPES:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f96bb07_c70cdfa6","line":809,"range":{"start_line":809,"start_character":25,"end_line":809,"end_character":60},"updated":"2018-01-17 12:23:50.000000000","message":"Suggestion: Similarly to what is done on lines 860 and 865, we could do:\n\n max_bw_in_bytes \u003d common_utils.kilobits_to_bytes(max_kbps)\n\nand then just\n\n str(max_bw_in_bytes)\n\non L796.","commit_id":"56b8c7e489c365b2bfc54d8bea751b28827cf5bc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"df4374850510c48eda800707a627470aec85a159","unresolved":false,"context_lines":[{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def update_ingress_bw_limit_for_port(self, port_name, max_kbps,"},{"line_number":808,"context_line":"                                         max_burst_kbps):"},{"line_number":809,"context_line":"        max_bw_in_bits \u003d max_kbps * common_constants.SI_BASE"},{"line_number":810,"context_line":"        max_burst_in_bits \u003d max_burst_kbps * common_constants.SI_BASE"},{"line_number":811,"context_line":"        port_type \u003d self._get_port_val(port_name, \"type\")"},{"line_number":812,"context_line":"        if port_type in constants.OVS_DPDK_PORT_TYPES:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f96bb07_51f13f00","line":809,"range":{"start_line":809,"start_character":25,"end_line":809,"end_character":60},"in_reply_to":"7f96bb07_7f444774","updated":"2018-01-18 14:57:35.000000000","message":"Aha, I missed the dpdk use case ...","commit_id":"56b8c7e489c365b2bfc54d8bea751b28827cf5bc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1915d88545412c6140a502c20f0c4e177e55a442","unresolved":false,"context_lines":[{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def update_ingress_bw_limit_for_port(self, port_name, max_kbps,"},{"line_number":808,"context_line":"                                         max_burst_kbps):"},{"line_number":809,"context_line":"        max_bw_in_bits \u003d max_kbps * common_constants.SI_BASE"},{"line_number":810,"context_line":"        max_burst_in_bits \u003d max_burst_kbps * common_constants.SI_BASE"},{"line_number":811,"context_line":"        port_type \u003d self._get_port_val(port_name, \"type\")"},{"line_number":812,"context_line":"        if port_type in constants.OVS_DPDK_PORT_TYPES:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f96bb07_7f444774","line":809,"range":{"start_line":809,"start_character":25,"end_line":809,"end_character":60},"in_reply_to":"7f96bb07_c70cdfa6","updated":"2018-01-18 14:52:16.000000000","message":"But it will not work like You wants. I can\u0027t calculate here bytes directly because I need to pass bits to \"not DPDK\" ports to use it in L771-772","commit_id":"56b8c7e489c365b2bfc54d8bea751b28827cf5bc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9ed67cd2c34b23dc9bab085a259a5a6138ea1364","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                    common_constants.SI_BASE)"},{"line_number":863,"context_line":"            max_burst_in_bytes \u003d other_config.get(\"cbs\")"},{"line_number":864,"context_line":"            if max_burst_in_bytes is not None:"},{"line_number":865,"context_line":"                max_burst_kbit \u003d common_utils.bits_to_kilobits("},{"line_number":866,"context_line":"                    common_utils.bytes_to_bits(int(max_burst_in_bytes)),"},{"line_number":867,"context_line":"                    common_constants.SI_BASE)"},{"line_number":868,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"    def delete_ingress_bw_limit_for_port(self, port_name):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f96bb07_8737b74d","line":867,"range":{"start_line":865,"start_character":33,"end_line":867,"end_character":45},"updated":"2018-01-17 12:23:50.000000000","message":"Suggestion: Create a function bytes_to_kilobits, with my comment on L809 you won\u0027t even need to import common_constants.","commit_id":"56b8c7e489c365b2bfc54d8bea751b28827cf5bc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"df4374850510c48eda800707a627470aec85a159","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                    common_constants.SI_BASE)"},{"line_number":863,"context_line":"            max_burst_in_bytes \u003d other_config.get(\"cbs\")"},{"line_number":864,"context_line":"            if max_burst_in_bytes is not None:"},{"line_number":865,"context_line":"                max_burst_kbit \u003d common_utils.bits_to_kilobits("},{"line_number":866,"context_line":"                    common_utils.bytes_to_bits(int(max_burst_in_bytes)),"},{"line_number":867,"context_line":"                    common_constants.SI_BASE)"},{"line_number":868,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"    def delete_ingress_bw_limit_for_port(self, port_name):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f96bb07_f18acb61","line":867,"range":{"start_line":865,"start_character":33,"end_line":867,"end_character":45},"in_reply_to":"7f96bb07_5f22abba","updated":"2018-01-18 14:57:35.000000000","message":"You\u0027re right","commit_id":"56b8c7e489c365b2bfc54d8bea751b28827cf5bc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1915d88545412c6140a502c20f0c4e177e55a442","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                    common_constants.SI_BASE)"},{"line_number":863,"context_line":"            max_burst_in_bytes \u003d other_config.get(\"cbs\")"},{"line_number":864,"context_line":"            if max_burst_in_bytes is not None:"},{"line_number":865,"context_line":"                max_burst_kbit \u003d common_utils.bits_to_kilobits("},{"line_number":866,"context_line":"                    common_utils.bytes_to_bits(int(max_burst_in_bytes)),"},{"line_number":867,"context_line":"                    common_constants.SI_BASE)"},{"line_number":868,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"    def delete_ingress_bw_limit_for_port(self, port_name):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f96bb07_5f22abba","line":867,"range":{"start_line":865,"start_character":33,"end_line":867,"end_character":45},"in_reply_to":"7f96bb07_8737b74d","updated":"2018-01-18 14:52:16.000000000","message":"If I would even do such function, I would need to add base as parameter and it would be still imported here. Do You think it is worth to do it still?","commit_id":"56b8c7e489c365b2bfc54d8bea751b28827cf5bc"},{"author":{"_account_id":26709,"name":"Rong.Wang","email":"rong.wang@easystack.cn","username":"wangrong"},"change_message_id":"c2b1ecef4a367c79b194605ccb6e592a219f5ac3","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":779,"context_line":"        # cir and cbs should be set in bytes instead of bits"},{"line_number":780,"context_line":"        qos_other_config \u003d {"},{"line_number":781,"context_line":"            \u0027cir\u0027: str(max_bw_in_bits / 8),"},{"line_number":782,"context_line":"            \u0027cbs\u0027: str(max_burst_in_bits / 8)"},{"line_number":783,"context_line":"        }"},{"line_number":784,"context_line":"        qos \u003d self.find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_7ae46b0d","line":781,"range":{"start_line":781,"start_character":40,"end_line":781,"end_character":41},"updated":"2018-01-18 03:11:13.000000000","message":"A little question, I saw you used macro definition \u0027SI_BASE\u0027 to replace 1024, how about use macro definition of the number \u00278\u0027?\n^^","commit_id":"1be857435288e4008a41fe67bbc8795dd3d8b134"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1915d88545412c6140a502c20f0c4e177e55a442","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            self, port_name, max_bw_in_bits, max_burst_in_bits):"},{"line_number":779,"context_line":"        # cir and cbs should be set in bytes instead of bits"},{"line_number":780,"context_line":"        qos_other_config \u003d {"},{"line_number":781,"context_line":"            \u0027cir\u0027: str(max_bw_in_bits / 8),"},{"line_number":782,"context_line":"            \u0027cbs\u0027: str(max_burst_in_bits / 8)"},{"line_number":783,"context_line":"        }"},{"line_number":784,"context_line":"        qos \u003d self.find_qos(port_name)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_df1f9b69","line":781,"range":{"start_line":781,"start_character":40,"end_line":781,"end_character":41},"in_reply_to":"7f96bb07_7ae46b0d","updated":"2018-01-18 14:52:16.000000000","message":"I\u0027m not sute if this is necessary","commit_id":"1be857435288e4008a41fe67bbc8795dd3d8b134"}],"neutron/agent/rpc.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"9ce2443e3d9a45f58c544ba1a51ff8bd772b15bc","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            \u0027qos_policy_id\u0027: port_obj.qos_policy_id,"},{"line_number":263,"context_line":"            \u0027network_qos_policy_id\u0027: net_qos_policy_id,"},{"line_number":264,"context_line":"            \u0027profile\u0027: port_obj.binding.profile,"},{"line_number":265,"context_line":"            \u0027vif_details\u0027: port_obj.binding.vif_details,"},{"line_number":266,"context_line":"            \u0027security_groups\u0027: list(port_obj.security_group_ids)"},{"line_number":267,"context_line":"        }"},{"line_number":268,"context_line":"        LOG.debug(\"Returning: %s\", entry)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_7b5131d9","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":56},"updated":"2017-11-02 17:34:11.000000000","message":"This should not be necessary if you read the interface type.","commit_id":"67807785dd72222649da6f8f224f301a9cbc6b4c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17f3b20bec7d15e28fbb7f7de2d1916332c0edc6","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            \u0027qos_policy_id\u0027: port_obj.qos_policy_id,"},{"line_number":263,"context_line":"            \u0027network_qos_policy_id\u0027: net_qos_policy_id,"},{"line_number":264,"context_line":"            \u0027profile\u0027: port_obj.binding.profile,"},{"line_number":265,"context_line":"            \u0027vif_details\u0027: port_obj.binding.vif_details,"},{"line_number":266,"context_line":"            \u0027security_groups\u0027: list(port_obj.security_group_ids)"},{"line_number":267,"context_line":"        }"},{"line_number":268,"context_line":"        LOG.debug(\"Returning: %s\", entry)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_67812c4e","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":56},"in_reply_to":"3f4b6375_7b5131d9","updated":"2017-11-08 12:44:24.000000000","message":"removed","commit_id":"67807785dd72222649da6f8f224f301a9cbc6b4c"}],"neutron/plugins/ml2/drivers/openvswitch/agent/extension_drivers/qos_driver.py":[{"author":{"_account_id":26709,"name":"Rong.Wang","email":"rong.wang@easystack.cn","username":"wangrong"},"change_message_id":"e10f9f83d4a5f615f6faac0ca641861771a606ed","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            port_datapath_type \u003d agent_consts.OVS_DATAPATH_SYSTEM"},{"line_number":63,"context_line":"            if vif_details:"},{"line_number":64,"context_line":"                port_datapath_type \u003d vif_details.get("},{"line_number":65,"context_line":"                    \"datapath_type\", agent_consts.OVS_DATAPATH_SYSTEM)"},{"line_number":66,"context_line":"            self._update_ingress_bandwidth_limit("},{"line_number":67,"context_line":"                vif_port, rule, port_datapath_type)"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_40544b21","line":65,"range":{"start_line":65,"start_character":21,"end_line":65,"end_character":34},"updated":"2017-10-24 08:42:00.000000000","message":"I checked the mitaka branch, the vif_details not have the key datapath_type.\n\nAre you sure the master branch has the key datapath_type?","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f0fa38aa5886f8239d4179c6fe1ab5eb9fc0e6fd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            port_datapath_type \u003d agent_consts.OVS_DATAPATH_SYSTEM"},{"line_number":63,"context_line":"            if vif_details:"},{"line_number":64,"context_line":"                port_datapath_type \u003d vif_details.get("},{"line_number":65,"context_line":"                    \"datapath_type\", agent_consts.OVS_DATAPATH_SYSTEM)"},{"line_number":66,"context_line":"            self._update_ingress_bandwidth_limit("},{"line_number":67,"context_line":"                vif_port, rule, port_datapath_type)"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_06f1cc01","line":65,"range":{"start_line":65,"start_character":21,"end_line":65,"end_character":34},"in_reply_to":"3f4b6375_40544b21","updated":"2017-10-24 08:49:56.000000000","message":"yes, On master it is in vif_details for sure","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2d306691e3a8bbc79af53e84fbc9764e1a627362","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                      \"deleted\", port_id)"},{"line_number":59,"context_line":"            return"},{"line_number":60,"context_line":"        if rule.direction \u003d\u003d constants.INGRESS_DIRECTION:"},{"line_number":61,"context_line":"            vif_details \u003d port.get(\"vif_details\")"},{"line_number":62,"context_line":"            port_datapath_type \u003d agent_consts.OVS_DATAPATH_SYSTEM"},{"line_number":63,"context_line":"            if vif_details:"},{"line_number":64,"context_line":"                port_datapath_type \u003d vif_details.get("},{"line_number":65,"context_line":"                    \"datapath_type\", agent_consts.OVS_DATAPATH_SYSTEM)"},{"line_number":66,"context_line":"            self._update_ingress_bandwidth_limit("},{"line_number":67,"context_line":"                vif_port, rule, port_datapath_type)"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_1e3176ed","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":70},"updated":"2017-10-30 15:55:56.000000000","message":"Nit: you can avoid the if\n\n vif_details \u003d port.get(\"vif_details\", {})\n port_datapath_type \u003d vif_details.get(\"datapath_type\",\n                                      agent_consts.OVS_DATAPATH_SYSTEM)","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"83d9c743bbb467bf5ea5bdffebd15edda3f23fb9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            port_datapath_type \u003d agent_consts.OVS_DATAPATH_SYSTEM"},{"line_number":63,"context_line":"            if vif_details:"},{"line_number":64,"context_line":"                port_datapath_type \u003d vif_details.get("},{"line_number":65,"context_line":"                    \"datapath_type\", agent_consts.OVS_DATAPATH_SYSTEM)"},{"line_number":66,"context_line":"            self._update_ingress_bandwidth_limit("},{"line_number":67,"context_line":"                vif_port, rule, port_datapath_type)"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_74b27896","line":65,"in_reply_to":"3f4b6375_1e3176ed","updated":"2017-11-02 03:21:57.000000000","message":"It should be bridge_datapath_type or just datapath_type","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                      \"deleted\", port_id)"},{"line_number":59,"context_line":"            return"},{"line_number":60,"context_line":"        if rule.direction \u003d\u003d constants.INGRESS_DIRECTION:"},{"line_number":61,"context_line":"            vif_details \u003d port.get(\"vif_details\")"},{"line_number":62,"context_line":"            port_datapath_type \u003d agent_consts.OVS_DATAPATH_SYSTEM"},{"line_number":63,"context_line":"            if vif_details:"},{"line_number":64,"context_line":"                port_datapath_type \u003d vif_details.get("},{"line_number":65,"context_line":"                    \"datapath_type\", agent_consts.OVS_DATAPATH_SYSTEM)"},{"line_number":66,"context_line":"            self._update_ingress_bandwidth_limit("},{"line_number":67,"context_line":"                vif_port, rule, port_datapath_type)"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_6e0bc329","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":70},"in_reply_to":"3f4b6375_1e3176ed","updated":"2017-11-02 09:02:42.000000000","message":"right, changed","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            port_datapath_type \u003d agent_consts.OVS_DATAPATH_SYSTEM"},{"line_number":63,"context_line":"            if vif_details:"},{"line_number":64,"context_line":"                port_datapath_type \u003d vif_details.get("},{"line_number":65,"context_line":"                    \"datapath_type\", agent_consts.OVS_DATAPATH_SYSTEM)"},{"line_number":66,"context_line":"            self._update_ingress_bandwidth_limit("},{"line_number":67,"context_line":"                vif_port, rule, port_datapath_type)"},{"line_number":68,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_e9044d17","line":65,"in_reply_to":"3f4b6375_74b27896","updated":"2017-11-02 09:02:42.000000000","message":"changed","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"9ce2443e3d9a45f58c544ba1a51ff8bd772b15bc","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                 \u0027port_security_enabled\u0027: port.get(psec.PORTSECURITY, True),"},{"line_number":143,"context_line":"                 \u0027qos_policy_id\u0027: port.get(qos_consts.QOS_POLICY_ID),"},{"line_number":144,"context_line":"                 \u0027network_qos_policy_id\u0027: network_qos_policy_id,"},{"line_number":145,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE],"},{"line_number":146,"context_line":"                 \u0027vif_details\u0027: port.get(portbindings.VIF_DETAILS, {})}"},{"line_number":147,"context_line":"        LOG.debug(\"Returning: %s\", entry)"},{"line_number":148,"context_line":"        return entry"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_5b6795b8","line":146,"range":{"start_line":145,"start_character":54,"end_line":146,"end_character":70},"updated":"2017-11-02 17:34:11.000000000","message":"ditto","commit_id":"67807785dd72222649da6f8f224f301a9cbc6b4c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17f3b20bec7d15e28fbb7f7de2d1916332c0edc6","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                 \u0027port_security_enabled\u0027: port.get(psec.PORTSECURITY, True),"},{"line_number":143,"context_line":"                 \u0027qos_policy_id\u0027: port.get(qos_consts.QOS_POLICY_ID),"},{"line_number":144,"context_line":"                 \u0027network_qos_policy_id\u0027: network_qos_policy_id,"},{"line_number":145,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE],"},{"line_number":146,"context_line":"                 \u0027vif_details\u0027: port.get(portbindings.VIF_DETAILS, {})}"},{"line_number":147,"context_line":"        LOG.debug(\"Returning: %s\", entry)"},{"line_number":148,"context_line":"        return entry"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_27f0d4fd","line":146,"range":{"start_line":145,"start_character":54,"end_line":146,"end_character":70},"in_reply_to":"3f4b6375_5b6795b8","updated":"2017-11-08 12:44:24.000000000","message":"removed","commit_id":"67807785dd72222649da6f8f224f301a9cbc6b4c"}],"neutron/tests/functional/agent/test_ovs_lib.py":[{"author":{"_account_id":26709,"name":"Rong.Wang","email":"rong.wang@easystack.cn","username":"wangrong"},"change_message_id":"5efb05ced918635bc170643a729615cf9916eb30","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        self.assertIsNone(max_rate)"},{"line_number":403,"context_line":"        self.assertIsNone(burst)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_ingress_bw_limit_dpdp_port(self):"},{"line_number":406,"context_line":"        port_name, _ \u003d self.create_ovs_port()"},{"line_number":407,"context_line":"        self.br.update_ingress_bw_limit_for_port("},{"line_number":408,"context_line":"            port_name, 700, 70, agent_const.OVS_DATAPATH_NETDEV)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_117e7dae","line":405,"range":{"start_line":405,"start_character":29,"end_line":405,"end_character":34},"updated":"2017-10-25 12:23:54.000000000","message":"may be dpdk","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d75f66dd06c7127d4d8fcc3d27cbf3613e1c3a51","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        self.assertIsNone(max_rate)"},{"line_number":403,"context_line":"        self.assertIsNone(burst)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_ingress_bw_limit_dpdp_port(self):"},{"line_number":406,"context_line":"        port_name, _ \u003d self.create_ovs_port()"},{"line_number":407,"context_line":"        self.br.update_ingress_bw_limit_for_port("},{"line_number":408,"context_line":"            port_name, 700, 70, agent_const.OVS_DATAPATH_NETDEV)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_56929c4d","line":405,"range":{"start_line":405,"start_character":29,"end_line":405,"end_character":34},"in_reply_to":"3f4b6375_117e7dae","updated":"2017-10-25 19:46:40.000000000","message":"Done","commit_id":"5351b06b20bd0428bf94742db5daa3460f4be51c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2d306691e3a8bbc79af53e84fbc9764e1a627362","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    def test_ingress_bw_limit(self):"},{"line_number":387,"context_line":"        port_name, _ \u003d self.create_ovs_port()"},{"line_number":388,"context_line":"        self.br.update_ingress_bw_limit_for_port("},{"line_number":389,"context_line":"            port_name, 700, 70, agent_const.OVS_DATAPATH_SYSTEM)"},{"line_number":390,"context_line":"        max_rate, burst \u003d self.br.get_ingress_bw_limit_for_port(port_name)"},{"line_number":391,"context_line":"        self.assertEqual(700, max_rate)"},{"line_number":392,"context_line":"        self.assertEqual(70, burst)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_3e49d25f","line":389,"range":{"start_line":389,"start_character":32,"end_line":389,"end_character":63},"updated":"2017-10-30 15:55:56.000000000","message":"So this should be probably the default :)","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ecb56ed1ab14b0645a58a831ef3973c98b3bc7aa","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    def test_ingress_bw_limit(self):"},{"line_number":387,"context_line":"        port_name, _ \u003d self.create_ovs_port()"},{"line_number":388,"context_line":"        self.br.update_ingress_bw_limit_for_port("},{"line_number":389,"context_line":"            port_name, 700, 70, agent_const.OVS_DATAPATH_SYSTEM)"},{"line_number":390,"context_line":"        max_rate, burst \u003d self.br.get_ingress_bw_limit_for_port(port_name)"},{"line_number":391,"context_line":"        self.assertEqual(700, max_rate)"},{"line_number":392,"context_line":"        self.assertEqual(70, burst)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_a923f5a6","line":389,"range":{"start_line":389,"start_character":32,"end_line":389,"end_character":63},"in_reply_to":"3f4b6375_3e49d25f","updated":"2017-11-02 09:02:42.000000000","message":"yep. It is now","commit_id":"783dd1a02eff1ddd62ca4a383a6d55a58c4bdf2a"}]}
