)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777b8afcc2bb429e74d0a1b06ecd8154ca4ec4fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the modules eventlet friendly as early as possible"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"eventlet monkey patch must happens before any reference can made to a"},{"line_number":10,"context_line":"not patched version of the classes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example if an import module gets a logger before monkey patching,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FKd0%3D","line":9,"updated":"2013-11-13 15:00:07.000000000","message":"s/happens/happen/","commit_id":"a1b193fc3500c3f115c80eb9679fdfd507100b38"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777b8afcc2bb429e74d0a1b06ecd8154ca4ec4fc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the modules eventlet friendly as early as possible"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"eventlet monkey patch must happens before any reference can made to a"},{"line_number":10,"context_line":"not patched version of the classes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example if an import module gets a logger before monkey patching,"},{"line_number":13,"context_line":"it can made reference to not patched version of the modules."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FKdU%3D","line":10,"updated":"2013-11-13 15:00:07.000000000","message":"s/not patched/unpatched/","commit_id":"a1b193fc3500c3f115c80eb9679fdfd507100b38"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777b8afcc2bb429e74d0a1b06ecd8154ca4ec4fc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"not patched version of the classes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For example if an import module gets a logger before monkey patching,"},{"line_number":13,"context_line":"it can made reference to not patched version of the modules."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The late patching can lead to bad performance, strange behavior or even to dead lock."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FKc0%3D","line":13,"updated":"2013-11-13 15:00:07.000000000","message":"s/made/make/","commit_id":"a1b193fc3500c3f115c80eb9679fdfd507100b38"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777b8afcc2bb429e74d0a1b06ecd8154ca4ec4fc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For example if an import module gets a logger before monkey patching,"},{"line_number":13,"context_line":"it can made reference to not patched version of the modules."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The late patching can lead to bad performance, strange behavior or even to dead lock."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now the monkey patch happens on module load, so it cannot be unit"},{"line_number":18,"context_line":"tested as it was tested before."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FKZY%3D","line":15,"updated":"2013-11-13 15:00:07.000000000","message":"Do you have examples of cases where bad performance was observed and improved by this patch?","commit_id":"a1b193fc3500c3f115c80eb9679fdfd507100b38"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777b8afcc2bb429e74d0a1b06ecd8154ca4ec4fc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"The late patching can lead to bad performance, strange behavior or even to dead lock."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now the monkey patch happens on module load, so it cannot be unit"},{"line_number":18,"context_line":"tested as it was tested before."},{"line_number":19,"context_line":"The eventlet monkey patching happens even before the module\u0027s main function called."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7db37b6a6b15e0038c028bafd6c9f1f09f258955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FKZE%3D","line":18,"updated":"2013-11-13 15:00:07.000000000","message":"Would it be possible to make use of is_monkey_patched(module) in the unit tests to test this?\n\nhttp://eventlet.net/doc/patching.html#monkey-patch","commit_id":"a1b193fc3500c3f115c80eb9679fdfd507100b38"}],"neutron/tests/unit/nec/test_nec_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"777b8afcc2bb429e74d0a1b06ecd8154ca4ec4fc","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            cfg.AGENT.polling_interval \u003d 10"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"            nec_neutron_agent.main()"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"            self.assertTrue(logging_config.setup_logging.called)"},{"line_number":361,"context_line":"            agent.assert_has_calls(["},{"line_number":362,"context_line":"                mock.call(\u0027br-int-x\u0027, \u0027dummy-helper\u0027, 10),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FKZw%3D","line":359,"updated":"2013-11-13 15:00:07.000000000","message":"Would it be possible to use something like eventlet.patcher.is_monkey_patched(module) to show that something was not patched before this change and is patched after the change?","commit_id":"a1b193fc3500c3f115c80eb9679fdfd507100b38"}]}