)]}'
{"neutron/tests/unit/extensions/base.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b716bb8f5b592b4ea62858c0f226b49b14ab2ee3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class ExtensionTestCase(testlib_api.WebTestCase):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _setUpExtension(self, plugin, service_type,"},{"line_number":41,"context_line":"                        resource_attribute_map, extension_class,"},{"line_number":42,"context_line":"                        resource_prefix, plural_mappings\u003dNone,"},{"line_number":43,"context_line":"                        translate_resource_name\u003dFalse,"},{"line_number":44,"context_line":"                        allow_pagination\u003dFalse, allow_sorting\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_336b72f2","line":41,"range":{"start_line":41,"start_character":24,"end_line":41,"end_character":46},"updated":"2017-10-27 19:09:09.000000000","message":"Based on what I\u0027m seeing, this is the only change that\u0027s breaking consumers. I\u0027m still verifying locally.\n\n\n\nI would prefer this patch not be a revert, but rather just add this resource_attribute_map back into this method. Although it\u0027s unused we can add a TODO that we are going to phase it out.\n\n\nIf there are errors other than those related to _setUpExtension() please let me know.","commit_id":"f916d9eb4b90ebf54a43a1195c6de389a00a52fa"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"82f2bf12e1ac1488b7c5427bdee7821fddfabf10","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class ExtensionTestCase(testlib_api.WebTestCase):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _setUpExtension(self, plugin, service_type,"},{"line_number":41,"context_line":"                        resource_attribute_map, extension_class,"},{"line_number":42,"context_line":"                        resource_prefix, plural_mappings\u003dNone,"},{"line_number":43,"context_line":"                        translate_resource_name\u003dFalse,"},{"line_number":44,"context_line":"                        allow_pagination\u003dFalse, allow_sorting\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_dea9c5dd","line":41,"range":{"start_line":41,"start_character":24,"end_line":41,"end_character":46},"in_reply_to":"3f4b6375_336b72f2","updated":"2017-10-27 19:23:57.000000000","message":"I just testing with sfc, bpgvpn and vpnaas. By simply adding this param back into this method it fixes the py27 failures I was seeing. That said I still think this patch should not be a revert and rather a 2 LOC patch adding resource_attribute_map back as a param and adding a TODO to phase it out.","commit_id":"f916d9eb4b90ebf54a43a1195c6de389a00a52fa"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e8468d69a835c0ac981bef7dce35795d4b716acc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class ExtensionTestCase(testlib_api.WebTestCase):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _setUpExtension(self, plugin, service_type,"},{"line_number":41,"context_line":"                        resource_attribute_map, extension_class,"},{"line_number":42,"context_line":"                        resource_prefix, plural_mappings\u003dNone,"},{"line_number":43,"context_line":"                        translate_resource_name\u003dFalse,"},{"line_number":44,"context_line":"                        allow_pagination\u003dFalse, allow_sorting\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_0bb03e8b","line":41,"range":{"start_line":41,"start_character":24,"end_line":41,"end_character":46},"in_reply_to":"3f4b6375_8b29cef3","updated":"2017-10-27 21:41:46.000000000","message":"You are right, there are 2 callers in nenutron.","commit_id":"f916d9eb4b90ebf54a43a1195c6de389a00a52fa"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"43d39995f024c23284d62e79587bc9a7f001febc","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class ExtensionTestCase(testlib_api.WebTestCase):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _setUpExtension(self, plugin, service_type,"},{"line_number":41,"context_line":"                        resource_attribute_map, extension_class,"},{"line_number":42,"context_line":"                        resource_prefix, plural_mappings\u003dNone,"},{"line_number":43,"context_line":"                        translate_resource_name\u003dFalse,"},{"line_number":44,"context_line":"                        allow_pagination\u003dFalse, allow_sorting\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_8b29cef3","line":41,"range":{"start_line":41,"start_character":24,"end_line":41,"end_character":46},"in_reply_to":"3f4b6375_dea9c5dd","updated":"2017-10-27 21:31:51.000000000","message":"It this approach works then great, the rest of the change is indeed worth keeping.\n\nBut I\u0027m curious if we can just add the argument back, without taking it into account, and expect all the code that was using it to work. I\u0027m myself unsure that the change recreates all the necessary side effects.","commit_id":"f916d9eb4b90ebf54a43a1195c6de389a00a52fa"}]}
