)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e4748292289b2b680b4dcba767c732f0d0f8f25","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            args +\u003d [\u0027scope\u0027, scope]"},{"line_number":609,"context_line":"        if to:"},{"line_number":610,"context_line":"            # remove any cidr portion to make sure we match exactly"},{"line_number":611,"context_line":"            to \u003d to.split(\u0027/\u0027)[0]"},{"line_number":612,"context_line":"            args +\u003d [\u0027to\u0027, to]"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        retval \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_a96fc790","line":611,"updated":"2017-10-30 20:47:52.000000000","message":"is it possible that this method will be called with IP address (not cidr)? If so Your code will fail with IndexError\n\nMaybe better solution would be to use netaddr.IPNetwork object, something like:\n\n    to \u003d netaddr.IPNetwork(to)\n    args +\u003d [\u0027to\u0027, str(to.ip)]\n\nWhat You think?","commit_id":"f9419da99f12dfd8e4d76dbd7dd8198eb0ff9f81"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5b0dc075c968ca64251d15e7362cc1bcd2e1e8ec","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            args +\u003d [\u0027scope\u0027, scope]"},{"line_number":609,"context_line":"        if to:"},{"line_number":610,"context_line":"            # remove any cidr portion to make sure we match exactly"},{"line_number":611,"context_line":"            to \u003d to.split(\u0027/\u0027)[0]"},{"line_number":612,"context_line":"            args +\u003d [\u0027to\u0027, to]"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        retval \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_a25b4785","line":611,"in_reply_to":"3f4b6375_21e1abd1","updated":"2017-10-31 14:29:30.000000000","message":"Well now you\u0027ve convinced me to remove this line completely and change callers to pass an IP (or cidr if they wish), as doing this could cause a regression if someone had expected it to succeed with a cidr.  I\u0027ll document the args better.","commit_id":"f9419da99f12dfd8e4d76dbd7dd8198eb0ff9f81"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b570048947bbec2132a20d79e1be68c7e4d33df","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            args +\u003d [\u0027scope\u0027, scope]"},{"line_number":609,"context_line":"        if to:"},{"line_number":610,"context_line":"            # remove any cidr portion to make sure we match exactly"},{"line_number":611,"context_line":"            to \u003d to.split(\u0027/\u0027)[0]"},{"line_number":612,"context_line":"            args +\u003d [\u0027to\u0027, to]"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        retval \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_21e1abd1","line":611,"in_reply_to":"3f4b6375_494bb386","updated":"2017-10-30 22:28:36.000000000","message":"Yes, You are right in this case. Sorry :)\nBut what if as argument will be passed netaddr.IPAddress or IPNetwork object? As we are moving to OVO objects more and more it might be possible IMHO and then it will fail","commit_id":"f9419da99f12dfd8e4d76dbd7dd8198eb0ff9f81"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c8101f9addb30ced5008dc6d5026d9e0b96a870e","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            args +\u003d [\u0027scope\u0027, scope]"},{"line_number":609,"context_line":"        if to:"},{"line_number":610,"context_line":"            # remove any cidr portion to make sure we match exactly"},{"line_number":611,"context_line":"            to \u003d to.split(\u0027/\u0027)[0]"},{"line_number":612,"context_line":"            args +\u003d [\u0027to\u0027, to]"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        retval \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_494bb386","line":611,"in_reply_to":"3f4b6375_a96fc790","updated":"2017-10-30 21:05:22.000000000","message":"It worked in my testing:\n\n\u003e\u003e\u003e to \u003d \u002710.0.0.1\u0027\n\u003e\u003e\u003e to.split(\u0027/\u0027)[0]\n\u002710.0.0.1\u0027\n\nI think the functional test passes 0.0.0.0","commit_id":"f9419da99f12dfd8e4d76dbd7dd8198eb0ff9f81"}]}
