)]}'
{"neutron/tests/tempest/scenario/test_security_groups.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56425f453cc01576bedf76c3427f2c128f645877","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        for subnet in subnet_list:"},{"line_number":171,"context_line":"            if subnet[\u0027network_id\u0027] \u003d\u003d self.network[\u0027id\u0027]:"},{"line_number":172,"context_line":"                cidr \u003d subnet[\u0027cidr\u0027]"},{"line_number":173,"context_line":"                break"},{"line_number":174,"context_line":"        self.assertIsNotNone(cidr, \"CIDR was not found\")"},{"line_number":175,"context_line":"        ssh_secgrp \u003d self.os_primary.network_client.create_security_group("},{"line_number":176,"context_line":"            name\u003d\u0027ssh_secgrp\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_82d70850","line":173,"updated":"2017-11-01 15:41:37.000000000","message":"Can\u0027t you just use self.subnet[\u0027cidr\u0027] ?  Is this subnet invisible to the tenant somehow?","commit_id":"5ecb6d169f938c3abbd049a2d60345583691da60"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"945714a3f60bb687188aead3f85f7c20fcf4d519","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        for subnet in subnet_list:"},{"line_number":171,"context_line":"            if subnet[\u0027network_id\u0027] \u003d\u003d self.network[\u0027id\u0027]:"},{"line_number":172,"context_line":"                cidr \u003d subnet[\u0027cidr\u0027]"},{"line_number":173,"context_line":"                break"},{"line_number":174,"context_line":"        self.assertIsNotNone(cidr, \"CIDR was not found\")"},{"line_number":175,"context_line":"        ssh_secgrp \u003d self.os_primary.network_client.create_security_group("},{"line_number":176,"context_line":"            name\u003d\u0027ssh_secgrp\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c3d97056","line":173,"in_reply_to":"3f4b6375_82d70850","updated":"2017-11-02 07:38:12.000000000","message":"Done","commit_id":"5ecb6d169f938c3abbd049a2d60345583691da60"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"56425f453cc01576bedf76c3427f2c128f645877","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027ssh_secgrp\u0027},"},{"line_number":190,"context_line":"                                {\u0027name\u0027: \u0027icmp_secgrp_with_cidr\u0027}]"},{"line_number":191,"context_line":"        server_ssh_clients, fips, servers \u003d self.create_vm_testing_sec_grp("},{"line_number":192,"context_line":"            num_servers\u003d2, security_groups\u003dsecurity_groups_list)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # make sure ssh connectivity works"},{"line_number":195,"context_line":"        self.check_connectivity(fips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_227614a6","line":192,"updated":"2017-11-01 15:41:37.000000000","message":"nit: don\u0027t need num_servers\u003d2 since it\u0027s the default","commit_id":"5ecb6d169f938c3abbd049a2d60345583691da60"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"945714a3f60bb687188aead3f85f7c20fcf4d519","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        security_groups_list \u003d [{\u0027name\u0027: \u0027ssh_secgrp\u0027},"},{"line_number":190,"context_line":"                                {\u0027name\u0027: \u0027icmp_secgrp_with_cidr\u0027}]"},{"line_number":191,"context_line":"        server_ssh_clients, fips, servers \u003d self.create_vm_testing_sec_grp("},{"line_number":192,"context_line":"            num_servers\u003d2, security_groups\u003dsecurity_groups_list)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # make sure ssh connectivity works"},{"line_number":195,"context_line":"        self.check_connectivity(fips[0][\u0027floating_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a3de743b","line":192,"in_reply_to":"3f4b6375_227614a6","updated":"2017-11-02 07:38:12.000000000","message":"Done","commit_id":"5ecb6d169f938c3abbd049a2d60345583691da60"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ae258bf28d73ca331f7f2c3b681487f1ec76ec5","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # make sure ICMP connectivity works"},{"line_number":200,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":201,"context_line":"            \u0027fixed_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_db70770b","line":201,"updated":"2017-10-31 09:32:30.000000000","message":"shouldn\u0027t You maybe remove this \"remote_ip_prefix\" rule and check then that there is no connectivity? Just to be sure that test works :)","commit_id":"5ecb6d169f938c3abbd049a2d60345583691da60"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b4f748d0ae45f7f104772722ff34399588574b3f","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        # make sure ICMP connectivity works"},{"line_number":200,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":201,"context_line":"            \u0027fixed_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_66e9eab5","line":201,"in_reply_to":"3f4b6375_db70770b","updated":"2017-10-31 10:05:07.000000000","message":"Indeed this is the next step, if this code is ok","commit_id":"5ecb6d169f938c3abbd049a2d60345583691da60"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"226381aedd49f5a00df2af553c585d39205f32da","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # make sure ICMP connectivity works"},{"line_number":195,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":196,"context_line":"            \u0027fixed_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_8dbf14a9","line":196,"updated":"2017-11-02 17:35:56.000000000","message":"Looks good.  Were you also going to address Slawek\u0027s comment about removing the rule and verifying it fails here?","commit_id":"0c205e2e0565d6b49bcb095521146be29411ce84"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"8abdd4f0f81d167b721c08cca85ea5833b3b3243","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        # make sure ICMP connectivity works"},{"line_number":195,"context_line":"        self.check_remote_connectivity(server_ssh_clients[0], fips[1]["},{"line_number":196,"context_line":"            \u0027fixed_ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_662f553f","line":196,"in_reply_to":"3f4b6375_8dbf14a9","updated":"2017-11-02 19:07:52.000000000","message":"As I moved to another project, I don\u0027t think I\u0027ll find the time in the near future to do it, but I talked to other guys who are supposed to cover the negative case.\nI think it makes sense to merge it if it\u0027s good and the negative case will follow by another member of the group","commit_id":"0c205e2e0565d6b49bcb095521146be29411ce84"}]}