)]}'
{"neutron/agent/linux/interface.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"945038d20d5fb88c5a14dc50e704d250ed8416b5","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                # answers: Invalid argument"},{"line_number":376,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":377,"context_line":"                    ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":378,"context_line":"                    ovs.delete_port(tap_name)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # NOTE(ihrachys): the order here is significant: we must set MTU after"},{"line_number":381,"context_line":"        # the device is moved into a namespace, otherwise OVS bridge does not"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_49e85315","line":378,"updated":"2017-10-30 20:39:00.000000000","message":"You should add some UT to cover this new code IMO","commit_id":"a850d6cb1c4805a2d6ac8a27f0fc5f9109bd6e93"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"6ad08bce7011e994ecfd245f835871fcca0308e6","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            except exceptions.ProcessExecutionError:"},{"line_number":385,"context_line":"                # To prevent the namespace failure from blasting"},{"line_number":386,"context_line":"                # ovs, the ovs port created should be reverted"},{"line_number":387,"context_line":"                # When the namespae is corrupted, the ProcessExecutionError"},{"line_number":388,"context_line":"                # has execption message as:"},{"line_number":389,"context_line":"                # Exit code: 2; Stdin: ; Stdout: ; Stderr: RTNETLINK"},{"line_number":390,"context_line":"                # answers: Invalid argument"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_497835f7","line":387,"updated":"2018-08-31 21:07:06.000000000","message":"nit: s/namespae/namespace/","commit_id":"3d8aa8404ac6d7a5b88e84b8770070494cb3eb5b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"efcbc7b28bdda8f9f8994ab026e293a1a5780602","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                # When the namespace is corrupted, the ProcessExecutionError"},{"line_number":388,"context_line":"                # has execption message as:"},{"line_number":389,"context_line":"                # Exit code: 2; Stdin: ; Stdout: ; Stderr: RTNETLINK"},{"line_number":390,"context_line":"                # answers: Invalid argument"},{"line_number":391,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":392,"context_line":"                    ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":393,"context_line":"                    ovs.delete_port(tap_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_1ea80d76","line":390,"updated":"2018-09-04 09:03:29.000000000","message":"shouldn\u0027t we log any warning or error in such case?","commit_id":"0ca2117574d719e55d6ff00548657f99218b4952"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae1a499080745c1af2b52eaf1f75e8863e541672","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                # When the namespace is corrupted, the ProcessExecutionError"},{"line_number":388,"context_line":"                # has execption message as:"},{"line_number":389,"context_line":"                # Exit code: 2; Stdin: ; Stdout: ; Stderr: RTNETLINK"},{"line_number":390,"context_line":"                # answers: Invalid argument"},{"line_number":391,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":392,"context_line":"                    ovs \u003d ovs_lib.OVSBridge(bridge)"},{"line_number":393,"context_line":"                    ovs.delete_port(tap_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_c5a076f6","line":390,"in_reply_to":"3f79a3b5_1ea80d76","updated":"2018-09-04 18:42:31.000000000","message":"Done","commit_id":"0ca2117574d719e55d6ff00548657f99218b4952"}],"neutron/tests/unit/agent/linux/test_interface.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"408d0bd1166917dada1542f6063e8ed32d8c5894","unresolved":false,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"            self.ip.assert_has_calls(expected)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def test_plug_new(self, bridge\u003dNone, namespace\u003dNone):"},{"line_number":463,"context_line":"        with mock.patch(\u0027neutron.agent.ovsdb.impl_idl._connection\u0027):"},{"line_number":464,"context_line":"            if not bridge:"},{"line_number":465,"context_line":"                bridge \u003d \u0027br-int\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_7963b4dd","line":462,"range":{"start_line":462,"start_character":28,"end_line":462,"end_character":55},"updated":"2018-01-03 08:33:29.000000000","message":"why do You need those parameters? Where You are using it?","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e05a6cda99c2117ccfe1dae99468a824dff86494","unresolved":false,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"            self.ip.assert_has_calls(expected)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def test_plug_new(self, bridge\u003dNone, namespace\u003dNone):"},{"line_number":463,"context_line":"        with mock.patch(\u0027neutron.agent.ovsdb.impl_idl._connection\u0027):"},{"line_number":464,"context_line":"            if not bridge:"},{"line_number":465,"context_line":"                bridge \u003d \u0027br-int\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_b9737c80","line":462,"range":{"start_line":462,"start_character":28,"end_line":462,"end_character":55},"in_reply_to":"9f91af0f_7963b4dd","updated":"2018-01-03 08:59:48.000000000","message":"Done","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"408d0bd1166917dada1542f6063e8ed32d8c5894","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                                   \u0027delete_port\u0027) as delete_port:"},{"line_number":472,"context_line":"                with mock.patch.object(ovs_lib.OVSBridge, \u0027replace_port\u0027):"},{"line_number":473,"context_line":"                    ovs \u003d interface.OVSInterfaceDriver(self.conf)"},{"line_number":474,"context_line":"                    reaise \u003d mock.patch.object(excutils,"},{"line_number":475,"context_line":"                                    \u0027save_and_reraise_exception\u0027)"},{"line_number":476,"context_line":"                    reaise.start()"},{"line_number":477,"context_line":"                    proEr \u003d utils.ProcessExecutionError(\u0027\u0027, 2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_59a030f5","line":474,"range":{"start_line":474,"start_character":20,"end_line":474,"end_character":26},"updated":"2018-01-03 08:33:29.000000000","message":"reraise maybe?","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e05a6cda99c2117ccfe1dae99468a824dff86494","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                                   \u0027delete_port\u0027) as delete_port:"},{"line_number":472,"context_line":"                with mock.patch.object(ovs_lib.OVSBridge, \u0027replace_port\u0027):"},{"line_number":473,"context_line":"                    ovs \u003d interface.OVSInterfaceDriver(self.conf)"},{"line_number":474,"context_line":"                    reaise \u003d mock.patch.object(excutils,"},{"line_number":475,"context_line":"                                    \u0027save_and_reraise_exception\u0027)"},{"line_number":476,"context_line":"                    reaise.start()"},{"line_number":477,"context_line":"                    proEr \u003d utils.ProcessExecutionError(\u0027\u0027, 2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_d970c075","line":474,"range":{"start_line":474,"start_character":20,"end_line":474,"end_character":26},"in_reply_to":"9f91af0f_59a030f5","updated":"2018-01-03 08:59:48.000000000","message":"Done","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"408d0bd1166917dada1542f6063e8ed32d8c5894","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                    proEr \u003d utils.ProcessExecutionError(\u0027\u0027, 2)"},{"line_number":478,"context_line":"                    ProcessExecutionError \u003d mock.Mock(side_effect\u003dproEr)"},{"line_number":479,"context_line":"                    ip \u003d self.ip.return_value"},{"line_number":480,"context_line":"                    ip.ensure_namespace.side_effect \u003d (ProcessExecutionError)"},{"line_number":481,"context_line":"                    ovs.plug_new(\u002701234567-1234-1234-99\u0027,"},{"line_number":482,"context_line":"                         \u0027port-1234\u0027,"},{"line_number":483,"context_line":"                         \u0027tap0\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_79b89429","line":480,"range":{"start_line":480,"start_character":54,"end_line":480,"end_character":77},"updated":"2018-01-03 08:33:29.000000000","message":"brackets are not necessary here","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e05a6cda99c2117ccfe1dae99468a824dff86494","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                    proEr \u003d utils.ProcessExecutionError(\u0027\u0027, 2)"},{"line_number":478,"context_line":"                    ProcessExecutionError \u003d mock.Mock(side_effect\u003dproEr)"},{"line_number":479,"context_line":"                    ip \u003d self.ip.return_value"},{"line_number":480,"context_line":"                    ip.ensure_namespace.side_effect \u003d (ProcessExecutionError)"},{"line_number":481,"context_line":"                    ovs.plug_new(\u002701234567-1234-1234-99\u0027,"},{"line_number":482,"context_line":"                         \u0027port-1234\u0027,"},{"line_number":483,"context_line":"                         \u0027tap0\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_796df496","line":480,"range":{"start_line":480,"start_character":54,"end_line":480,"end_character":77},"in_reply_to":"9f91af0f_79b89429","updated":"2018-01-03 08:59:48.000000000","message":"Done","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"408d0bd1166917dada1542f6063e8ed32d8c5894","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                    ProcessExecutionError \u003d mock.Mock(side_effect\u003dproEr)"},{"line_number":479,"context_line":"                    ip \u003d self.ip.return_value"},{"line_number":480,"context_line":"                    ip.ensure_namespace.side_effect \u003d (ProcessExecutionError)"},{"line_number":481,"context_line":"                    ovs.plug_new(\u002701234567-1234-1234-99\u0027,"},{"line_number":482,"context_line":"                         \u0027port-1234\u0027,"},{"line_number":483,"context_line":"                         \u0027tap0\u0027,"},{"line_number":484,"context_line":"                         \u0027aa:bb:cc:dd:ee:ff\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_99b55834","line":481,"range":{"start_line":481,"start_character":33,"end_line":481,"end_character":56},"updated":"2018-01-03 08:33:29.000000000","message":"shouldn\u0027t You use \"namespace\" variable here?","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e05a6cda99c2117ccfe1dae99468a824dff86494","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                    ProcessExecutionError \u003d mock.Mock(side_effect\u003dproEr)"},{"line_number":479,"context_line":"                    ip \u003d self.ip.return_value"},{"line_number":480,"context_line":"                    ip.ensure_namespace.side_effect \u003d (ProcessExecutionError)"},{"line_number":481,"context_line":"                    ovs.plug_new(\u002701234567-1234-1234-99\u0027,"},{"line_number":482,"context_line":"                         \u0027port-1234\u0027,"},{"line_number":483,"context_line":"                         \u0027tap0\u0027,"},{"line_number":484,"context_line":"                         \u0027aa:bb:cc:dd:ee:ff\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_39052cc3","line":481,"range":{"start_line":481,"start_character":33,"end_line":481,"end_character":56},"in_reply_to":"9f91af0f_99b55834","updated":"2018-01-03 08:59:48.000000000","message":"Done","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"408d0bd1166917dada1542f6063e8ed32d8c5894","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            ns_dev.assert_has_calls([mock.call.link.set_up()])"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def test_plug_new(self, bridge\u003dNone, namespace\u003dNone):"},{"line_number":568,"context_line":"        #The purpose of test_plug_new in parent class(TestOVSInterfaceDriver)"},{"line_number":569,"context_line":"        #is to test exception(utils.ProcessExecutionError), method here would"},{"line_number":570,"context_line":"        #not go through that code, So just pass"},{"line_number":571,"context_line":"        pass"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def test_unplug(self, bridge\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_f96fc4c2","line":570,"range":{"start_line":568,"start_character":0,"end_line":570,"end_character":47},"updated":"2018-01-03 08:33:29.000000000","message":"please add spaces after #","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e05a6cda99c2117ccfe1dae99468a824dff86494","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            ns_dev.assert_has_calls([mock.call.link.set_up()])"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def test_plug_new(self, bridge\u003dNone, namespace\u003dNone):"},{"line_number":568,"context_line":"        #The purpose of test_plug_new in parent class(TestOVSInterfaceDriver)"},{"line_number":569,"context_line":"        #is to test exception(utils.ProcessExecutionError), method here would"},{"line_number":570,"context_line":"        #not go through that code, So just pass"},{"line_number":571,"context_line":"        pass"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def test_unplug(self, bridge\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_7902d4b6","line":570,"range":{"start_line":568,"start_character":0,"end_line":570,"end_character":47},"in_reply_to":"9f91af0f_f96fc4c2","updated":"2018-01-03 08:59:48.000000000","message":"Done","commit_id":"355ce1543478f70038cb22c5bcb8ae5bd14a5864"}]}
