)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5f4eb9abcd05c640012695fe0271f0294aae0067","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roee Agiman \u003cragiman@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-01 18:02:27 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added a new test case to \u0027test_security_groups\u0027 suite"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new test added is a negative test that verifies"},{"line_number":10,"context_line":"the inability of deleting in-use security group."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_711f3470","line":7,"updated":"2017-11-01 18:55:08.000000000","message":"This is not specific, titles should be specific. Try f.e.: \u0027Add deleting in-use security group\u0027","commit_id":"187fb1c8ad4f22ce2430c90d7ea388a31a5afacc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f55854d3808719053f6c559a6a2a941f6f738fb0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roee Agiman \u003cragiman@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-09 16:39:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add deleting in-use security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The new test added is a negative test that verifies"},{"line_number":10,"context_line":"the inability of deleting in-use security group."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f485f77_e5cced62","line":7,"updated":"2017-11-09 17:25:42.000000000","message":"the title doesn\u0027t explain it\u0027s about tests. Use: \u0027tests: delete in-use security group\u0027.","commit_id":"a269a20df30624caa86a67485a59e1437182ca1a"}],"neutron/tests/tempest/scenario/test_security_groups.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f893f9c558c9cdcf7c6f2e6bd6a0b7979fa4451d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        # make sure ICMP connectivity works after update"},{"line_number":164,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @decorators.idempotent_id(\u00273200b1a8-d73b-48e9-b03f-e891a4abe2d3\u0027)"},{"line_number":167,"context_line":"    def test_delete_in_use_sec_group(self):"},{"line_number":168,"context_line":"        # add a sec groups to VM and negative test if we can remove it"},{"line_number":169,"context_line":"        sgroup \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_82f4a888","line":166,"updated":"2017-11-01 15:57:56.000000000","message":"Should this also have:\n\n@decorators.attr(type\u003d\u0027negative\u0027)","commit_id":"5548dc5d2ca9e5bad4dd63f3186a4defd23e6318"},{"author":{"_account_id":26899,"name":"Roee Agiman","email":"ragiman@redhat.com","username":"ragiman"},"change_message_id":"d179f2782bead641cc3a3a7a6fcec71fe597a2a1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        # make sure ICMP connectivity works after update"},{"line_number":164,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @decorators.idempotent_id(\u00273200b1a8-d73b-48e9-b03f-e891a4abe2d3\u0027)"},{"line_number":167,"context_line":"    def test_delete_in_use_sec_group(self):"},{"line_number":168,"context_line":"        # add a sec groups to VM and negative test if we can remove it"},{"line_number":169,"context_line":"        sgroup \u003d self.os_primary.network_client.create_security_group("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_02c1d8e4","line":166,"in_reply_to":"3f4b6375_82f4a888","updated":"2017-11-01 16:03:50.000000000","message":"Added.","commit_id":"5548dc5d2ca9e5bad4dd63f3186a4defd23e6318"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f893f9c558c9cdcf7c6f2e6bd6a0b7979fa4451d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertRaises(exceptions.Conflict,"},{"line_number":175,"context_line":"                          self.os_primary.network_client.delete_security_group,"},{"line_number":176,"context_line":"                          security_group_id\u003dsgroup[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":177,"context_line":"                          )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a227a412","line":177,"updated":"2017-11-01 15:57:56.000000000","message":"super nit: ) can be on previous line","commit_id":"5548dc5d2ca9e5bad4dd63f3186a4defd23e6318"},{"author":{"_account_id":26899,"name":"Roee Agiman","email":"ragiman@redhat.com","username":"ragiman"},"change_message_id":"d179f2782bead641cc3a3a7a6fcec71fe597a2a1","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertRaises(exceptions.Conflict,"},{"line_number":175,"context_line":"                          self.os_primary.network_client.delete_security_group,"},{"line_number":176,"context_line":"                          security_group_id\u003dsgroup[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":177,"context_line":"                          )"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_82aca835","line":177,"in_reply_to":"3f4b6375_a227a412","updated":"2017-11-01 16:03:50.000000000","message":"Super corrected ;)","commit_id":"5548dc5d2ca9e5bad4dd63f3186a4defd23e6318"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5f4eb9abcd05c640012695fe0271f0294aae0067","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        # make sure ICMP connectivity works after update"},{"line_number":164,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @decorators.attr(type\u003d\u0027negative\u0027)"},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u00273200b1a8-d73b-48e9-b03f-e891a4abe2d3\u0027)"},{"line_number":168,"context_line":"    def test_delete_in_use_sec_group(self):"},{"line_number":169,"context_line":"        # add a sec group to VM and negative test if we can remove it"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_7108542c","line":166,"updated":"2017-11-01 18:55:08.000000000","message":"I don\u0027t get why it should be a scenario test since it purely validates API layer. We have neutron/tests/tempest/api/... for that. (Scenario tests are more complex and require actual compute service working etc.) Instead of booting a VM, you could just create a port, assign a SG to it, then try to delete SG.\n\nI think the right place for the test case is: neutron/tests/tempest/api/test_security_groups_negative.py.","commit_id":"187fb1c8ad4f22ce2430c90d7ea388a31a5afacc"}]}