)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2cfa9d37cdc47378c1d903c16f3cd2b3b915fd5c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    # order to ensure it is qualified by class"},{"line_number":139,"context_line":"    __native_bulk_support \u003d True"},{"line_number":140,"context_line":"    __native_pagination_support \u003d True"},{"line_number":141,"context_line":"    __native_sorting_support \u003d True"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def has_native_datastore(self):"},{"line_number":144,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_49473c1f","line":141,"updated":"2017-11-12 15:20:27.000000000","message":"should we consider a flag here:\n__native_datastore?","commit_id":"69d0047cfe969da02d44c036fc3c97a1bfdffc19"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1923e18bc18c84502b3cbb6038d98dfaced10005","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    # order to ensure it is qualified by class"},{"line_number":139,"context_line":"    __native_bulk_support \u003d True"},{"line_number":140,"context_line":"    __native_pagination_support \u003d True"},{"line_number":141,"context_line":"    __native_sorting_support \u003d True"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def has_native_datastore(self):"},{"line_number":144,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_09fa6441","line":141,"in_reply_to":"1f485f77_49473c1f","updated":"2017-11-12 16:43:31.000000000","message":"I thought about it but I despise the use of getattr when we can use OOP concepts to express behavior.","commit_id":"69d0047cfe969da02d44c036fc3c97a1bfdffc19"}],"neutron/neutron_plugin_base_v2.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8890e02b88cd0c2c73f9fa4ff24ebac112665b7b","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        .. note:: plugins like ML2 should override this method and return True."},{"line_number":418,"context_line":"        \"\"\""},{"line_number":419,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_a940f008","line":419,"updated":"2017-11-12 15:19:24.000000000","message":"This was slightly confusing to me as its returning True in\nhttps://review.openstack.org/#/c/518788/2/neutron/db/db_base_plugin_v2.py\nMaybe it should be True here and those who want to not use a native datastore should override to False","commit_id":"69d0047cfe969da02d44c036fc3c97a1bfdffc19"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1923e18bc18c84502b3cbb6038d98dfaced10005","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        .. note:: plugins like ML2 should override this method and return True."},{"line_number":418,"context_line":"        \"\"\""},{"line_number":419,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_89ee5486","line":419,"in_reply_to":"1f485f77_a940f008","updated":"2017-11-12 16:43:31.000000000","message":"There\u0027s a couple of reasons why I chose False rather than True:\n\n1) there\u0027s no datastore concept in this class and thus consumers may choose not to add any (e.g. contrail), thus it\u0027s better to assume False (no datastore)\n\n2) I didn\u0027t want to add burden to out of tree consumers that needed to flip the bit in order to exploit the new logic.\n\n3) Every consumer of the db base plugin v2 or ML2 mech driver would have the right logic because of the override.","commit_id":"69d0047cfe969da02d44c036fc3c97a1bfdffc19"}]}