)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"79a4ef0ecee18d94591d1a9136fc4a311a31105b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the correct DNS records are generated for"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- floating IP created with dns_(domain|name) attributes"},{"line_number":13,"context_line":"- instances that are assigned a floating IP"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a3fb7ae702cf06fbb8e7e3fb2a143bada05836d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f485f77_a2167054","line":13,"updated":"2017-11-15 15:55:03.000000000","message":"I\u0027m not native speaker but shouldn\u0027t be \"have assigned\"?","commit_id":"ff25e1a090b2193ad27b2698d24e7766db0907e3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"da129e9c856df25cbc729bdb7bdcda6159358d53","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the correct DNS records are generated for"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- floating IP created with dns_(domain|name) attributes"},{"line_number":13,"context_line":"- instances that are assigned a floating IP"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a3fb7ae702cf06fbb8e7e3fb2a143bada05836d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f485f77_ff207aae","line":13,"in_reply_to":"1f485f77_a2167054","updated":"2017-11-15 19:17:05.000000000","message":"I think is fine. Maybe adding \u0027:\u0027 at the end of L10 will make it clearer","commit_id":"ff25e1a090b2193ad27b2698d24e7766db0907e3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"59d6f0717636ad73706c81b83cb057dbbd86d330","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the correct DNS records are generated for"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- floating IP created with dns_(domain|name) attributes"},{"line_number":13,"context_line":"- instances that are assigned a floating IP"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a3fb7ae702cf06fbb8e7e3fb2a143bada05836d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f485f77_72204149","line":13,"in_reply_to":"1f485f77_a2167054","updated":"2017-11-15 18:27:31.000000000","message":"What I meant to say was that the DNS record is generated while the instance is getting assigned the FIP, i.e. refer to the process instead of the status that results from it, but maybe that is overdoing it","commit_id":"ff25e1a090b2193ad27b2698d24e7766db0907e3"}],"neutron/tests/tempest/scenario/test_dns_integration.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"79a4ef0ecee18d94591d1a9136fc4a311a31105b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        if not (\u0027designate\u0027 in CONF.service_available and"},{"line_number":57,"context_line":"                CONF.service_available.designate):"},{"line_number":58,"context_line":"            raise cls.skipException(\"Designate support is required\")"},{"line_number":59,"context_line":"        if not (dns_base and dns_waiters):"},{"line_number":60,"context_line":"            raise cls.skipException(\"Designate tempest plugin is missing\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_820ff435","line":59,"updated":"2017-11-15 15:55:03.000000000","message":"so it\u0027s enough to have only one of those modules loaded to perform tests?","commit_id":"ff25e1a090b2193ad27b2698d24e7766db0907e3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"59d6f0717636ad73706c81b83cb057dbbd86d330","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        if not (\u0027designate\u0027 in CONF.service_available and"},{"line_number":57,"context_line":"                CONF.service_available.designate):"},{"line_number":58,"context_line":"            raise cls.skipException(\"Designate support is required\")"},{"line_number":59,"context_line":"        if not (dns_base and dns_waiters):"},{"line_number":60,"context_line":"            raise cls.skipException(\"Designate tempest plugin is missing\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_52c78565","line":59,"in_reply_to":"1f485f77_820ff435","updated":"2017-11-15 18:27:31.000000000","message":"No, both have to be present, otherwise\n\nnot (None and True) \u003d not (True and None) \u003d not (False) \u003d True\n\nand the raise clause is triggered.","commit_id":"ff25e1a090b2193ad27b2698d24e7766db0907e3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"da129e9c856df25cbc729bdb7bdcda6159358d53","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        name \u003d data_utils.rand_name(\u0027server-test\u0027)"},{"line_number":115,"context_line":"        server \u003d self._create_server(name\u003dname)"},{"line_number":116,"context_line":"        server_ip \u003d server[\u0027fip\u0027][\u0027floating_ip_address\u0027]"},{"line_number":117,"context_line":"        self._verify_dns_records(server_ip, name)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @decorators.idempotent_id(\u0027a8f2fade-8d5c-40f9-80f0-3de4b8d91985\u0027)"},{"line_number":120,"context_line":"    def test_fip(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_302ac17e","line":117,"updated":"2017-11-15 19:17:05.000000000","message":"Why not disassociate the port and assert corresponding records were deleted from zone?","commit_id":"ff25e1a090b2193ad27b2698d24e7766db0907e3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"da129e9c856df25cbc729bdb7bdcda6159358d53","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    def test_fip(self):"},{"line_number":121,"context_line":"        name \u003d data_utils.rand_name(\u0027fip-test\u0027)"},{"line_number":122,"context_line":"        fip \u003d self._create_floatingip_with_dns(name)"},{"line_number":123,"context_line":"        self._verify_dns_records(fip[\u0027floating_ip_address\u0027], name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_750cab40","line":123,"updated":"2017-11-15 19:17:05.000000000","message":"Why not delete the fip and assert corresponding records were deleted from zone?","commit_id":"ff25e1a090b2193ad27b2698d24e7766db0907e3"}]}