)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9974460573dfef52135094e7de85dd237d9167d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zachary \u003cmazengxie@126.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-14 15:48:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurte."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_b0549f22","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":51},"updated":"2017-11-14 13:40:21.000000000","message":"typo","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"960c6e25c4a0fafe010de53acff37238be8ce79e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zachary \u003cmazengxie@126.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-14 15:48:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurte."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_fba8ba8c","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":51},"in_reply_to":"1f485f77_9004ec4b","updated":"2017-11-27 03:00:26.000000000","message":"Done","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9a1e02a3805d2005ec434908df1d33d6fc41dd26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zachary \u003cmazengxie@126.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-14 15:48:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurte."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_9004ec4b","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":51},"in_reply_to":"1f485f77_b0549f22","updated":"2017-11-15 04:10:18.000000000","message":"+1","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"868f819732559563d4d1ad1fdb006aa00822033e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurte."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id937216a724fbf776298efd11f74ac71056cfe06"},{"line_number":13,"context_line":"Closes-Bug: #1730605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_d1ea73aa","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":56},"updated":"2017-11-14 21:26:49.000000000","message":"accurate. Same as L7","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"960c6e25c4a0fafe010de53acff37238be8ce79e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurte."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id937216a724fbf776298efd11f74ac71056cfe06"},{"line_number":13,"context_line":"Closes-Bug: #1730605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_1baebe97","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":56},"in_reply_to":"1f485f77_70ff3034","updated":"2017-11-27 03:00:26.000000000","message":"Done","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9a1e02a3805d2005ec434908df1d33d6fc41dd26","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurte."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id937216a724fbf776298efd11f74ac71056cfe06"},{"line_number":13,"context_line":"Closes-Bug: #1730605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f485f77_70ff3034","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":56},"in_reply_to":"1f485f77_d1ea73aa","updated":"2017-11-15 04:10:18.000000000","message":"+1","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c3f5d7c8f0913a5ed7cbad7220a332a7c03cb8e6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurate."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id937216a724fbf776298efd11f74ac71056cfe06"},{"line_number":13,"context_line":"Closes-Bug: #1730605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff82abbf_001b5e72","line":10,"updated":"2017-11-29 12:17:03.000000000","message":"Can You maybe provide little bit more details about why it solves problem and why max-rate in qos table should also be set? Maybe some link to ovs docs would be enough?","commit_id":"d67ffc53606ad2cb051d559b16cfbd524e18bf22"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1d6abc3e81fb0c92649c2aa73c6349f5aea411f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Qos] ingress bandwidth limit by ovs is not accurate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set ovs qos max-rate in other_config parameter to"},{"line_number":10,"context_line":"solve the problem that ingress bw-limiter is not accurate."},{"line_number":11,"context_line":"How to configure egress traffic shaping(ingress direction for vms),"},{"line_number":12,"context_line":"please refer to http://docs.openvswitch.org/en/latest/faq/qos/."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This part of code doesn\u0027t have unit tests. But the modification is"},{"line_number":15,"context_line":"covered by functional tests in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_6d07b3cb","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":63},"updated":"2017-12-12 12:38:59.000000000","message":"I would say something like:\n\nAccording to Open vSwitch FAQ [1], max-rate value which is set for all queues in qos is set as link speed in case when it is not specified.\nThis can lead to inaccurate ingress bandwidth limits in case when QoS is applied e.g. directly on tapXXX port (which is \"tun\" interface type) and configured bandwidth limit is higher than interface\u0027s link_speed.\n\nThis patch set max-rate parameter in qos\u0027 other_config table to not use default value determined by Open vSwitch and to make rate limits more accurate.\n\n[1] http://docs.openvswitch.org/en/latest/faq/qos/","commit_id":"87536de8b1791aefeb81821140c60bc7526ace81"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1d6abc3e81fb0c92649c2aa73c6349f5aea411f6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"How to configure egress traffic shaping(ingress direction for vms),"},{"line_number":12,"context_line":"please refer to http://docs.openvswitch.org/en/latest/faq/qos/."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This part of code doesn\u0027t have unit tests. But the modification is"},{"line_number":15,"context_line":"covered by functional tests in"},{"line_number":16,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/tests/"},{"line_number":17,"context_line":"functional/agent/test_ovs_lib.py#L384."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_6d3013a0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":42},"updated":"2017-12-12 12:38:59.000000000","message":"This is IMHO not necessary. It would be enough to mention that it is covered by functional tests","commit_id":"87536de8b1791aefeb81821140c60bc7526ace81"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1d6abc3e81fb0c92649c2aa73c6349f5aea411f6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This part of code doesn\u0027t have unit tests. But the modification is"},{"line_number":15,"context_line":"covered by functional tests in"},{"line_number":16,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/tests/"},{"line_number":17,"context_line":"functional/agent/test_ovs_lib.py#L384."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id937216a724fbf776298efd11f74ac71056cfe06"},{"line_number":20,"context_line":"Closes-Bug: #1730605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"df87a7cf_2d268b69","line":17,"range":{"start_line":17,"start_character":32,"end_line":17,"end_character":37},"updated":"2017-12-12 12:38:59.000000000","message":"IMHO it shouldn\u0027t point to specified line number as it can change in future and then it will be confusing","commit_id":"87536de8b1791aefeb81821140c60bc7526ace81"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"084d8cfebfd1f3475aab0b6c02d9d0f16ad03669","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":752,"context_line":"        qos_other_config \u003d {"},{"line_number":753,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits"},{"line_number":754,"context_line":"        }"},{"line_number":755,"context_line":"        queue_other_config \u003d {"},{"line_number":756,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits,"},{"line_number":757,"context_line":"            \u0027burst\u0027: max_burst_in_bits,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_9ad30239","line":754,"updated":"2017-11-14 11:42:09.000000000","message":"what if values in qos other_config and queue other_config will be different?\nIn get_ingress_bw_limit_for_port it looks first for value in queue and then if it\u0027s not set it also checks in qos. Maybe now You should somehow modify it and check if max-rate in qos and queue\u0027s other config is the same?","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"960c6e25c4a0fafe010de53acff37238be8ce79e","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":752,"context_line":"        qos_other_config \u003d {"},{"line_number":753,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits"},{"line_number":754,"context_line":"        }"},{"line_number":755,"context_line":"        queue_other_config \u003d {"},{"line_number":756,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits,"},{"line_number":757,"context_line":"            \u0027burst\u0027: max_burst_in_bits,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_5b91a64d","line":754,"in_reply_to":"1f485f77_9ad30239","updated":"2017-11-27 03:00:26.000000000","message":"I don\u0027t know why qos and queue\u0027s other config is different.","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d0c07a7f1f7afc04c2b003fd0a9440b9fd2f9e8e","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":752,"context_line":"        qos_other_config \u003d {"},{"line_number":753,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits"},{"line_number":754,"context_line":"        }"},{"line_number":755,"context_line":"        queue_other_config \u003d {"},{"line_number":756,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits,"},{"line_number":757,"context_line":"            \u0027burst\u0027: max_burst_in_bits,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_d470200b","line":754,"in_reply_to":"ff82abbf_54b410d1","updated":"2017-11-27 09:33:11.000000000","message":"Because I think that it should be covered by functional/fullstack tests. Currently it only checks if proper values are set in queue\u0027s other_config and not in qos\u0027 other_config.","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"72e0e50cd8f9cc9a094ed70b938503a080068eaa","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":752,"context_line":"        qos_other_config \u003d {"},{"line_number":753,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits"},{"line_number":754,"context_line":"        }"},{"line_number":755,"context_line":"        queue_other_config \u003d {"},{"line_number":756,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits,"},{"line_number":757,"context_line":"            \u0027burst\u0027: max_burst_in_bits,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_718b661e","line":754,"in_reply_to":"ff82abbf_5b91a64d","updated":"2017-11-27 08:47:39.000000000","message":"I also don\u0027t know exactly how it can happen but if You are configuring same value in two places IMHO You should be sure that same value is configured in both places, not only in one of them.\nPlease also not that if You will change get_ingress_bw_limit_for_port method to check if both values are the same, then You should have it tested e.g. in fullstack: https://github.com/openstack/neutron/blob/master/neutron/tests/fullstack/test_qos.py#L210 and functional tests: https://github.com/openstack/neutron/blob/master/neutron/tests/functional/agent/l2/extensions/test_ovs_agent_qos_extension.py#L117","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"a1d85bdc5b18b5e862cd9e6a8a2eca68f19dc763","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        max_burst_in_bits \u003d str(max_burst_kbps * 1000)"},{"line_number":752,"context_line":"        qos_other_config \u003d {"},{"line_number":753,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits"},{"line_number":754,"context_line":"        }"},{"line_number":755,"context_line":"        queue_other_config \u003d {"},{"line_number":756,"context_line":"            \u0027max-rate\u0027: max_bw_in_bits,"},{"line_number":757,"context_line":"            \u0027burst\u0027: max_burst_in_bits,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_54b410d1","line":754,"in_reply_to":"ff82abbf_718b661e","updated":"2017-11-27 09:26:59.000000000","message":"If you don\u0027t kwon how it can happen, Why do you want to add code? A\u003dB\u003dmax-rate, we can get max-rate by A. Why do you can max-rate by B again ??","commit_id":"19733cf29b5b5a1d8c3dae0403fba9c01211e443"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"93fe4523063ba2f18813bb66c1d9a130464ea7ba","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                qos_max_kbps \u003d int(max_bw_in_bits) / 1000"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        queue_res \u003d self._find_queue(port_name, QOS_DEFAULT_QUEUE)"},{"line_number":790,"context_line":"        if res:"},{"line_number":791,"context_line":"            other_config \u003d queue_res[\u0027other_config\u0027]"},{"line_number":792,"context_line":"            max_bw_in_bits \u003d other_config.get(\u0027max-rate\u0027)"},{"line_number":793,"context_line":"            if max_bw_in_bits is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_57117203","line":790,"range":{"start_line":790,"start_character":11,"end_line":790,"end_character":14},"updated":"2017-11-27 09:57:38.000000000","message":"queue_res","commit_id":"bfc811dd1288f3f8618ab14f61c4bd741bdbf2b8"},{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"80f99e200a102128f039c9578a28c1eee0803eb8","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                qos_max_kbps \u003d int(max_bw_in_bits) / 1000"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"        queue_res \u003d self._find_queue(port_name, QOS_DEFAULT_QUEUE)"},{"line_number":790,"context_line":"        if res:"},{"line_number":791,"context_line":"            other_config \u003d queue_res[\u0027other_config\u0027]"},{"line_number":792,"context_line":"            max_bw_in_bits \u003d other_config.get(\u0027max-rate\u0027)"},{"line_number":793,"context_line":"            if max_bw_in_bits is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_77a276b0","line":790,"range":{"start_line":790,"start_character":11,"end_line":790,"end_character":14},"in_reply_to":"ff82abbf_57117203","updated":"2017-11-27 10:44:44.000000000","message":"Done","commit_id":"bfc811dd1288f3f8618ab14f61c4bd741bdbf2b8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"33d71e9dee37ea16731691229294225ba409c345","unresolved":false,"context_lines":[{"line_number":799,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        if qos_max_kbps \u003d\u003d queue_max_kbps:"},{"line_number":802,"context_line":"            max_kbps \u003d qos_max_kbps"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_223f6e88","line":802,"updated":"2017-11-30 09:05:09.000000000","message":"nit: maybe You could log here if those two values are not the same","commit_id":"2b6babb79de0ee77f2bf6c5fc53892e16a7a346a"},{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"c6c09fd765441d43327c2060ff4c2a47355e3af7","unresolved":false,"context_lines":[{"line_number":799,"context_line":"                max_burst_kbit \u003d int(max_burst_in_bits) / 1000"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        if qos_max_kbps \u003d\u003d queue_max_kbps:"},{"line_number":802,"context_line":"            max_kbps \u003d qos_max_kbps"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        return max_kbps, max_burst_kbit"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_36db3050","line":802,"in_reply_to":"ff82abbf_223f6e88","updated":"2017-11-30 12:47:23.000000000","message":"Done","commit_id":"2b6babb79de0ee77f2bf6c5fc53892e16a7a346a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0326489098a4522db12311200a359a6db57454bd","unresolved":false,"context_lines":[{"line_number":801,"context_line":"        if qos_max_kbps \u003d\u003d queue_max_kbps:"},{"line_number":802,"context_line":"            max_kbps \u003d qos_max_kbps"},{"line_number":803,"context_line":"        else:"},{"line_number":804,"context_line":"            LOG.warning(\"qos max-rate %(qos_max_kbps)s is not equal to\""},{"line_number":805,"context_line":"                        \"queue max-rate %(queue_max_kbps)s\","},{"line_number":806,"context_line":"                        {\u0027qos_max_kbps\u0027: qos_max_kbps,"},{"line_number":807,"context_line":"                         \u0027queue_max_kbps\u0027: queue_max_kbps})"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_28414b3a","line":804,"range":{"start_line":804,"start_character":68,"end_line":804,"end_character":71},"updated":"2017-12-05 06:47:05.000000000","message":"missing space","commit_id":"9adb693733c19a542323d7ce0410c8b455777423"},{"author":{"_account_id":25943,"name":"Zachary Ma","email":"mazengxie@126.com","username":"Zachary"},"change_message_id":"98c087a698b38ce764c81c8f71df058db9da5795","unresolved":false,"context_lines":[{"line_number":801,"context_line":"        if qos_max_kbps \u003d\u003d queue_max_kbps:"},{"line_number":802,"context_line":"            max_kbps \u003d qos_max_kbps"},{"line_number":803,"context_line":"        else:"},{"line_number":804,"context_line":"            LOG.warning(\"qos max-rate %(qos_max_kbps)s is not equal to\""},{"line_number":805,"context_line":"                        \"queue max-rate %(queue_max_kbps)s\","},{"line_number":806,"context_line":"                        {\u0027qos_max_kbps\u0027: qos_max_kbps,"},{"line_number":807,"context_line":"                         \u0027queue_max_kbps\u0027: queue_max_kbps})"}],"source_content_type":"text/x-python","patch_set":7,"id":"df87a7cf_68b673fd","line":804,"range":{"start_line":804,"start_character":68,"end_line":804,"end_character":71},"in_reply_to":"df87a7cf_28414b3a","updated":"2017-12-05 10:37:49.000000000","message":"Done","commit_id":"9adb693733c19a542323d7ce0410c8b455777423"}]}
