)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"053ae87a3c6760a700359ee368c55c6a3539b0a8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It avoids problems with loading wrong OVO objects from"},{"line_number":11,"context_line":"different projects (like os_vif) when names are the same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I11db449965199ee4a8fd4b026d8da0bb676d85c0"},{"line_number":14,"context_line":"Change-Id: I9d4fab591fbe52271c613251321a6d03078976f7"},{"line_number":15,"context_line":"Closes-Bug: #1731948"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff82abbf_9d75749b","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2017-11-20 12:32:48.000000000","message":"i don\u0027t think depends-on works in this case as we use released versions.","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f281991d14b043c03979e77388756b7778e00f81","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It avoids problems with loading wrong OVO objects from"},{"line_number":11,"context_line":"different projects (like os_vif) when names are the same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I11db449965199ee4a8fd4b026d8da0bb676d85c0"},{"line_number":14,"context_line":"Change-Id: I9d4fab591fbe52271c613251321a6d03078976f7"},{"line_number":15,"context_line":"Closes-Bug: #1731948"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff82abbf_c1120a59","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"in_reply_to":"ff82abbf_678fa4cc","updated":"2017-11-21 18:49:09.000000000","message":"Yes, but first it has to be merged in oslo.versionedobject repo :)","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cba4bc36509e38c2801661a03775bc19e3bd7ec0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It avoids problems with loading wrong OVO objects from"},{"line_number":11,"context_line":"different projects (like os_vif) when names are the same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I11db449965199ee4a8fd4b026d8da0bb676d85c0"},{"line_number":14,"context_line":"Change-Id: I9d4fab591fbe52271c613251321a6d03078976f7"},{"line_number":15,"context_line":"Closes-Bug: #1731948"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff82abbf_f8f92e4d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"in_reply_to":"ff82abbf_9d75749b","updated":"2017-11-20 13:51:36.000000000","message":"hmm, so we should just wait with this patch until patch to Oslo.versionedobjects repo will be merged and new version will be released, right?","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"cfd48f74e3163a4cfdd8a44f07fc48d1568269a6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"It avoids problems with loading wrong OVO objects from"},{"line_number":11,"context_line":"different projects (like os_vif) when names are the same."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I11db449965199ee4a8fd4b026d8da0bb676d85c0"},{"line_number":14,"context_line":"Change-Id: I9d4fab591fbe52271c613251321a6d03078976f7"},{"line_number":15,"context_line":"Closes-Bug: #1731948"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff82abbf_678fa4cc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"in_reply_to":"ff82abbf_f8f92e4d","updated":"2017-11-21 07:48:29.000000000","message":"AFAIK, We can request for new release at any time that we need.","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bea9d50ffd6a95cd8855808dd6988d91f2f729ad","unresolved":false,"context_lines":[{"line_number":109,"context_line":"class BaseOVS(object):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def __init__(self):"},{"line_number":112,"context_line":"        self.vsctl_timeout \u003d cfg.CONF.ovs_vsctl_timeout"},{"line_number":113,"context_line":"        self.ovsdb \u003d ovsdb_api.from_config(self)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def add_manager(self, connection_uri, timeout\u003d_SENTINEL):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_da54dacc","line":112,"updated":"2017-11-14 11:38:08.000000000","message":"seems to contain a lot of unrelated changes","commit_id":"43aa114f7feb8cde58def33ab0b41636c3b31b80"}],"neutron/objects/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3f1e4dac74aefe9eb2b17d9479ac0ef0564f9e9d","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    _registry \u003d None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def __new__(cls, *args, **kwargs):"},{"line_number":107,"context_line":"        if not NeutronObjectRegistry._registry:"},{"line_number":108,"context_line":"            NeutronObjectRegistry._registry \u003d object.__new__("},{"line_number":109,"context_line":"                NeutronObjectRegistry, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_2d53473b","line":106,"updated":"2017-11-17 20:47:53.000000000","message":"since you copy paste, please add a comment explaining where the code came from, and why we need to override.","commit_id":"a5caca9b122bcf479c7e93847c21e539d5759c72"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6040104067ab393a7d55e515b600f1915b79db58","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    _registry \u003d None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def __new__(cls, *args, **kwargs):"},{"line_number":107,"context_line":"        if not NeutronObjectRegistry._registry:"},{"line_number":108,"context_line":"            NeutronObjectRegistry._registry \u003d object.__new__("},{"line_number":109,"context_line":"                NeutronObjectRegistry, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_7048f42b","line":106,"in_reply_to":"1f485f77_2d53473b","updated":"2017-11-17 21:17:34.000000000","message":"Done","commit_id":"a5caca9b122bcf479c7e93847c21e539d5759c72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3f1e4dac74aefe9eb2b17d9479ac0ef0564f9e9d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        return (isinstance(cls.fields[field], obj_fields.ListOfObjectsField) or"},{"line_number":166,"context_line":"                isinstance(cls.fields[field], obj_fields.ObjectField))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @classmethod"},{"line_number":169,"context_line":"    def obj_class_from_name(cls, objname, objver):"},{"line_number":170,"context_line":"        \"\"\"Returns a class from the registry based on a name and version.\"\"\""},{"line_number":171,"context_line":"        if objname not in NeutronObjectRegistry.obj_classes():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_0d340bfb","line":168,"updated":"2017-11-17 20:47:53.000000000","message":"same here","commit_id":"a5caca9b122bcf479c7e93847c21e539d5759c72"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6040104067ab393a7d55e515b600f1915b79db58","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        return (isinstance(cls.fields[field], obj_fields.ListOfObjectsField) or"},{"line_number":166,"context_line":"                isinstance(cls.fields[field], obj_fields.ObjectField))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @classmethod"},{"line_number":169,"context_line":"    def obj_class_from_name(cls, objname, objver):"},{"line_number":170,"context_line":"        \"\"\"Returns a class from the registry based on a name and version.\"\"\""},{"line_number":171,"context_line":"        if objname not in NeutronObjectRegistry.obj_classes():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_9024905f","line":168,"in_reply_to":"1f485f77_0d340bfb","updated":"2017-11-17 21:17:34.000000000","message":"Done","commit_id":"a5caca9b122bcf479c7e93847c21e539d5759c72"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"38d8cb25027b959c4fd9e37203e3ec2077bd2788","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    _registry \u003d None"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def __new__(cls, *args, **kwargs):"},{"line_number":107,"context_line":"        # NOTE(slaweq): it is override method"},{"line_number":108,"context_line":"        # oslo_versionedobjects.base.VersionedObjectRegistry.__new__"},{"line_number":109,"context_line":"        # We need to override it to use separate registry for Neutron\u0027s"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_89bc2806","line":106,"updated":"2017-11-21 20:58:04.000000000","message":"please add a TODO here to move the functionality to oslo.versionedobjects library.","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"053ae87a3c6760a700359ee368c55c6a3539b0a8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        # objects."},{"line_number":111,"context_line":"        # This is necessary to avoid clash in naming objects between Neutron"},{"line_number":112,"context_line":"        # and e.g. os-vif (for example Route or Subnet objects are used in"},{"line_number":113,"context_line":"        # both)"},{"line_number":114,"context_line":"        if not NeutronObjectRegistry._registry:"},{"line_number":115,"context_line":"            NeutronObjectRegistry._registry \u003d object.__new__("},{"line_number":116,"context_line":"                NeutronObjectRegistry, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_5df28c08","line":113,"updated":"2017-11-20 12:32:48.000000000","message":"i suspect it makes more sense to make oslo.versionedobjects provide some easier-to-understand api than having this override in every consumer projects. how do you think?","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cba4bc36509e38c2801661a03775bc19e3bd7ec0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        # objects."},{"line_number":111,"context_line":"        # This is necessary to avoid clash in naming objects between Neutron"},{"line_number":112,"context_line":"        # and e.g. os-vif (for example Route or Subnet objects are used in"},{"line_number":113,"context_line":"        # both)"},{"line_number":114,"context_line":"        if not NeutronObjectRegistry._registry:"},{"line_number":115,"context_line":"            NeutronObjectRegistry._registry \u003d object.__new__("},{"line_number":116,"context_line":"                NeutronObjectRegistry, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_58e93a7e","line":113,"in_reply_to":"ff82abbf_5df28c08","updated":"2017-11-20 13:51:36.000000000","message":"maybe You\u0027re right, but it was discussed with Dan Smith and Ihar: http://eavesdrop.openstack.org/irclogs/%23openstack-oslo/%23openstack-oslo.2017-11-17.log.html#t2017-11-17T20:33:09 and they decided that this is better solution (at least now) :/","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"82eb3706ad6316594a6f2491bcc3c08436a0d402","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.db import models_v2"},{"line_number":27,"context_line":"from neutron.db.qos import models as qos_db_model"},{"line_number":28,"context_line":"from neutron.db.rbac_db_models import QosPolicyRBAC"},{"line_number":29,"context_line":"from neutron.objects import base as base_db"},{"line_number":30,"context_line":"from neutron.objects import common_types"},{"line_number":31,"context_line":"from neutron.objects.db import api as obj_db_api"},{"line_number":32,"context_line":"from neutron.objects.qos import binding"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_bc4b4529","line":29,"range":{"start_line":29,"start_character":36,"end_line":29,"end_character":43},"updated":"2017-11-23 01:59:52.000000000","message":"Any reason we have to use custom name here? If not, I think it\u0027s better to use original one for consistence with others.","commit_id":"5e08a9b0e7d4f99d217ca73c6aa37e52a13c5d5a"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"00e44910ee2d3177f4fcd2f8bbb13547cd69d8ef","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.db import models_v2"},{"line_number":27,"context_line":"from neutron.db.qos import models as qos_db_model"},{"line_number":28,"context_line":"from neutron.db.rbac_db_models import QosPolicyRBAC"},{"line_number":29,"context_line":"from neutron.objects import base as base_db"},{"line_number":30,"context_line":"from neutron.objects import common_types"},{"line_number":31,"context_line":"from neutron.objects.db import api as obj_db_api"},{"line_number":32,"context_line":"from neutron.objects.qos import binding"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_851dc067","line":29,"range":{"start_line":29,"start_character":36,"end_line":29,"end_character":43},"in_reply_to":"ff82abbf_6abc0bbb","updated":"2017-11-23 04:08:45.000000000","message":"Oops, yes (my misleading through the review). Please ignore this comment and consider it later.","commit_id":"5e08a9b0e7d4f99d217ca73c6aa37e52a13c5d5a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"da6b268183976e424fe7367f56dad19e816e0b0f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.db import models_v2"},{"line_number":27,"context_line":"from neutron.db.qos import models as qos_db_model"},{"line_number":28,"context_line":"from neutron.db.rbac_db_models import QosPolicyRBAC"},{"line_number":29,"context_line":"from neutron.objects import base as base_db"},{"line_number":30,"context_line":"from neutron.objects import common_types"},{"line_number":31,"context_line":"from neutron.objects.db import api as obj_db_api"},{"line_number":32,"context_line":"from neutron.objects.qos import binding"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_6abc0bbb","line":29,"range":{"start_line":29,"start_character":36,"end_line":29,"end_character":43},"in_reply_to":"ff82abbf_bc4b4529","updated":"2017-11-23 03:41:20.000000000","message":"huh? it\u0027s not part of this patch.","commit_id":"5e08a9b0e7d4f99d217ca73c6aa37e52a13c5d5a"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"38d8cb25027b959c4fd9e37203e3ec2077bd2788","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            return"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"class TestNeutronRegistry(obj_test.TestRegistry):"},{"line_number":685,"context_line":"    # NOTE(slaweq): this test class makes all tests from"},{"line_number":686,"context_line":"    # oslo_versionedobjects.tests.test_objects.TestRegistry"},{"line_number":687,"context_line":"    # but it tests registry class overriten by Neutron"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_497b808b","line":684,"updated":"2017-11-21 20:58:04.000000000","message":"I am not sure I am happy about using their internal unit test class in our unit tests suite. It\u0027s very prone to breakage, even more than the __new__ overridden for the registry class.\n\nThe right way to approach it would be adding support for custom registries in the library, and keep test coverage for the feature there, not in neutron. But if for some reason we can\u0027t do it, then I prefer to not have this test class here to having it. It\u0027s a breakage vector.","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"96090b14c808faaba26521059c01eee4298e212b","unresolved":false,"context_lines":[{"line_number":681,"context_line":"            return"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"class TestNeutronRegistry(obj_test.TestRegistry):"},{"line_number":685,"context_line":"    # NOTE(slaweq): this test class makes all tests from"},{"line_number":686,"context_line":"    # oslo_versionedobjects.tests.test_objects.TestRegistry"},{"line_number":687,"context_line":"    # but it tests registry class overriten by Neutron"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_67c54b3c","line":684,"in_reply_to":"ff82abbf_497b808b","updated":"2017-11-21 23:21:48.000000000","message":"ok, I copied UT from oslo for now.","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"38d8cb25027b959c4fd9e37203e3ec2077bd2788","unresolved":false,"context_lines":[{"line_number":684,"context_line":"class TestNeutronRegistry(obj_test.TestRegistry):"},{"line_number":685,"context_line":"    # NOTE(slaweq): this test class makes all tests from"},{"line_number":686,"context_line":"    # oslo_versionedobjects.tests.test_objects.TestRegistry"},{"line_number":687,"context_line":"    # but it tests registry class overriten by Neutron"},{"line_number":688,"context_line":"    _test_registry_class \u003d base.NeutronObjectRegistry"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_8932e8f0","line":687,"range":{"start_line":687,"start_character":33,"end_line":687,"end_character":43},"updated":"2017-11-21 20:58:04.000000000","message":"overridden","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"96090b14c808faaba26521059c01eee4298e212b","unresolved":false,"context_lines":[{"line_number":684,"context_line":"class TestNeutronRegistry(obj_test.TestRegistry):"},{"line_number":685,"context_line":"    # NOTE(slaweq): this test class makes all tests from"},{"line_number":686,"context_line":"    # oslo_versionedobjects.tests.test_objects.TestRegistry"},{"line_number":687,"context_line":"    # but it tests registry class overriten by Neutron"},{"line_number":688,"context_line":"    _test_registry_class \u003d base.NeutronObjectRegistry"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_82607dd0","line":687,"range":{"start_line":687,"start_character":33,"end_line":687,"end_character":43},"in_reply_to":"ff82abbf_8932e8f0","updated":"2017-11-21 23:21:48.000000000","message":"changed","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"053ae87a3c6760a700359ee368c55c6a3539b0a8","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    # NOTE(slaweq): this test class makes all tests from"},{"line_number":686,"context_line":"    # oslo_versionedobjects.tests.test_objects.TestRegistry"},{"line_number":687,"context_line":"    # but it tests registry class overriten by Neutron"},{"line_number":688,"context_line":"    _test_registry_class \u003d base.NeutronObjectRegistry"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"class BaseObjectIfaceTestCase(_BaseObjectTestCase, test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_fdb4c037","line":688,"updated":"2017-11-20 12:32:48.000000000","message":"do we want to wait for an oslo release with the patch?\notherwise it\u0027s better to have a copy-and-pasted copy for now.","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"96090b14c808faaba26521059c01eee4298e212b","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    # NOTE(slaweq): this test class makes all tests from"},{"line_number":686,"context_line":"    # oslo_versionedobjects.tests.test_objects.TestRegistry"},{"line_number":687,"context_line":"    # but it tests registry class overriten by Neutron"},{"line_number":688,"context_line":"    _test_registry_class \u003d base.NeutronObjectRegistry"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"class BaseObjectIfaceTestCase(_BaseObjectTestCase, test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_27dd0314","line":688,"in_reply_to":"ff82abbf_c7d0f0cc","updated":"2017-11-21 23:21:48.000000000","message":"Done","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"cfd48f74e3163a4cfdd8a44f07fc48d1568269a6","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    # NOTE(slaweq): this test class makes all tests from"},{"line_number":686,"context_line":"    # oslo_versionedobjects.tests.test_objects.TestRegistry"},{"line_number":687,"context_line":"    # but it tests registry class overriten by Neutron"},{"line_number":688,"context_line":"    _test_registry_class \u003d base.NeutronObjectRegistry"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"class BaseObjectIfaceTestCase(_BaseObjectTestCase, test_base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_c7d0f0cc","line":688,"in_reply_to":"ff82abbf_fdb4c037","updated":"2017-11-21 07:48:29.000000000","message":"+1","commit_id":"e973bccba5a622b28b4eac379bc269bfef5c2f73"}]}
