)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cd338d457a888eca0e629b39c40b66f279fd995","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user both specify floating-ip-address and subnet in CLI, we"},{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_2d0addd1","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":57},"updated":"2017-11-21 08:56:48.000000000","message":"We are changing it in Neutron, not CLI.\nSo I think this is possible evenm with a direct API curl request","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cd338d457a888eca0e629b39c40b66f279fd995","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user both specify floating-ip-address and subnet in CLI, we"},{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_0d6039a5","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":20},"updated":"2017-11-21 08:56:48.000000000","message":"nit: specifies both","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1643a55e03b99bb5f14fd6ad3f85ce7be8823c64","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user both specify floating-ip-address and subnet in CLI, we"},{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_b8c2ad84","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":20},"in_reply_to":"ff82abbf_0d6039a5","updated":"2017-11-21 10:16:14.000000000","message":"Done","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1643a55e03b99bb5f14fd6ad3f85ce7be8823c64","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user both specify floating-ip-address and subnet in CLI, we"},{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_78e3c534","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":57},"in_reply_to":"ff82abbf_2d0addd1","updated":"2017-11-21 10:16:14.000000000","message":"Done","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cd338d457a888eca0e629b39c40b66f279fd995","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user both specify floating-ip-address and subnet in CLI, we"},{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_8df8c9c4","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":18},"updated":"2017-11-21 08:56:48.000000000","message":"chose","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1643a55e03b99bb5f14fd6ad3f85ce7be8823c64","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user both specify floating-ip-address and subnet in CLI, we"},{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_18d2b95d","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":18},"in_reply_to":"ff82abbf_8df8c9c4","updated":"2017-11-21 10:16:14.000000000","message":"Done","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cd338d457a888eca0e629b39c40b66f279fd995","unresolved":false,"context_lines":[{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"},{"line_number":14,"context_line":"will raise InvalidIpForSubnet exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_2d33bdad","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":48},"updated":"2017-11-21 08:56:48.000000000","message":"is not","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b70fac66348e43fae6716b305169cfbfea39929","unresolved":false,"context_lines":[{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"},{"line_number":14,"context_line":"will raise InvalidIpForSubnet exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_0dd2795d","line":13,"updated":"2017-11-21 08:45:48.000000000","message":"is not in the subnet","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1643a55e03b99bb5f14fd6ad3f85ce7be8823c64","unresolved":false,"context_lines":[{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"},{"line_number":14,"context_line":"will raise InvalidIpForSubnet exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_38d77d4e","line":13,"in_reply_to":"ff82abbf_0dd2795d","updated":"2017-11-21 10:16:14.000000000","message":"Done","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1643a55e03b99bb5f14fd6ad3f85ce7be8823c64","unresolved":false,"context_lines":[{"line_number":10,"context_line":"will always chosen the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"},{"line_number":14,"context_line":"will raise InvalidIpForSubnet exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_d8cbf1a2","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":48},"in_reply_to":"ff82abbf_2d33bdad","updated":"2017-11-21 10:16:14.000000000","message":"Done","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7b70fac66348e43fae6716b305169cfbfea39929","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"},{"line_number":14,"context_line":"will raise InvalidIpForSubnet exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"},{"line_number":17,"context_line":"Closes-Bug: #1732890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_2dd73d4e","line":14,"updated":"2017-11-21 08:45:48.000000000","message":"IMO better would be: \"InvalidIpForSubnet exception will be raised\"","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cd338d457a888eca0e629b39c40b66f279fd995","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"},{"line_number":14,"context_line":"will raise InvalidIpForSubnet exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"},{"line_number":17,"context_line":"Closes-Bug: #1732890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_8d21a950","line":14,"in_reply_to":"ff82abbf_2dd73d4e","updated":"2017-11-21 08:56:48.000000000","message":"+1","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1643a55e03b99bb5f14fd6ad3f85ce7be8823c64","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address not in the subnet,"},{"line_number":14,"context_line":"will raise InvalidIpForSubnet exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"},{"line_number":17,"context_line":"Closes-Bug: #1732890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_f8d03553","line":14,"in_reply_to":"ff82abbf_2dd73d4e","updated":"2017-11-21 10:16:14.000000000","message":"Done","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dongcan Ye \u003chellochosen@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-21 18:43:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always chose the subnet creating fip port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_209ae813","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"updated":"2017-12-04 03:32:52.000000000","message":"How about \"Honor both floating_ip_address and subnet_id when creating FIP\" ?","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dongcan Ye \u003chellochosen@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-21 18:43:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always chose the subnet creating fip port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_a6e37005","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"in_reply_to":"df87a7cf_209ae813","updated":"2017-12-04 05:51:29.000000000","message":"Done","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always chose the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_3d88d4c4","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":17},"updated":"2017-12-04 03:32:52.000000000","message":"choose","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add floating_ip_address and subnet_id while creating fip port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always chose the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_46f064ca","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":17},"in_reply_to":"df87a7cf_3d88d4c4","updated":"2017-12-04 05:51:29.000000000","message":"Done","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always chose the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"},{"line_number":14,"context_line":"InvalidIpForSubnet exception will be raised."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_5d8598ac","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":14},"updated":"2017-12-04 03:32:52.000000000","message":"adds","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always chose the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch add floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"},{"line_number":14,"context_line":"InvalidIpForSubnet exception will be raised."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_66ed68ee","line":12,"range":{"start_line":12,"start_character":11,"end_line":12,"end_character":14},"in_reply_to":"df87a7cf_5d8598ac","updated":"2017-12-04 05:51:29.000000000","message":"Done","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1189b50c52cec36fcfd996772b80b8bf8c1e86d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Honor both floating_ip_address and subnet_id when creating FIP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always choose the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_76e29f03","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"updated":"2017-12-06 22:39:32.000000000","message":"This paragraph refers to the current situation that you propose to fix (I think) but it is not very clear. To enforce the fact that we are referring to the current situation, let\u0027s stick to the present tense. How about:\n\nIn the current code, if user specifies floating-ip-address and subnet, we only process the subnet when creating  the fip port.","commit_id":"f747aeb6d103c402e6fd07311b17bd40beec29ef"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"126d740d8c7dc9c2c3d75ebf99ec1bdfd8c8f069","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Honor both floating_ip_address and subnet_id when creating FIP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If user specifies floating-ip-address and subnet, we"},{"line_number":10,"context_line":"will always choose the subnet creating fip port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds floating_ip_address and subnet_id to"},{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_5440b2a5","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"df87a7cf_76e29f03","updated":"2017-12-07 01:47:28.000000000","message":"Done","commit_id":"f747aeb6d103c402e6fd07311b17bd40beec29ef"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1189b50c52cec36fcfd996772b80b8bf8c1e86d2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"},{"line_number":14,"context_line":"InvalidIpForSubnet exception will be raised."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch also fix a default value error in tests."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"},{"line_number":19,"context_line":"Closes-Bug: #1732890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_f6bf8fcd","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":19},"updated":"2017-12-06 22:39:32.000000000","message":"fixes","commit_id":"f747aeb6d103c402e6fd07311b17bd40beec29ef"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"126d740d8c7dc9c2c3d75ebf99ec1bdfd8c8f069","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fip port\u0027s fixed_ips, if floating_ip_address is not in the subnet,"},{"line_number":14,"context_line":"InvalidIpForSubnet exception will be raised."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch also fix a default value error in tests."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I436353690839281ca7e13eaf792249306b71dd4b"},{"line_number":19,"context_line":"Closes-Bug: #1732890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_743db629","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":19},"in_reply_to":"df87a7cf_f6bf8fcd","updated":"2017-12-07 01:47:28.000000000","message":"Done","commit_id":"f747aeb6d103c402e6fd07311b17bd40beec29ef"}],"neutron/db/l3_db.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cd338d457a888eca0e629b39c40b66f279fd995","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        if fip.get(\u0027subnet_id\u0027) and fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1269,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1270,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027],"},{"line_number":1271,"context_line":"                 \u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        elif fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1275,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]}]"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        elif fip.get(\u0027subnet_id\u0027):"},{"line_number":1278,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1279,"context_line":"                {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"        # \u0027status\u0027 in port dict could not be updated by default, use"},{"line_number":1282,"context_line":"        # check_allow_post to stop the verification of system"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_6dc22536","line":1279,"range":{"start_line":1268,"start_character":1,"end_line":1279,"end_character":48},"updated":"2017-11-21 08:56:48.000000000","message":"Why??\nCant we do something like this:\n \n temp_port \u003d {} \n if fip.get(\u0027subnet_id\u0027):\n     temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}\n if fip.get(\u0027floating_ip_address\u0027):\n     temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})\n port[\u0027fixed_ips\u0027] \u003d [temp_port]","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2858a931ec54450f05dd2aa48a79dcbd155020e7","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        if fip.get(\u0027subnet_id\u0027) and fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1269,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1270,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027],"},{"line_number":1271,"context_line":"                 \u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        elif fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1275,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]}]"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        elif fip.get(\u0027subnet_id\u0027):"},{"line_number":1278,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1279,"context_line":"                {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"        # \u0027status\u0027 in port dict could not be updated by default, use"},{"line_number":1282,"context_line":"        # check_allow_post to stop the verification of system"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_85e3bd05","line":1279,"range":{"start_line":1268,"start_character":1,"end_line":1279,"end_character":48},"in_reply_to":"ff82abbf_05d7ad4d","updated":"2017-11-21 10:29:02.000000000","message":"I agree with Reedip here. It would be more readable IMHO.\nbut IMHO last line if reedit\u0027s change should be changed to something like:\n\nif temp_port:\n    port[\u0027fixed_ips\u0027] \u003d [temp_port]","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"1643a55e03b99bb5f14fd6ad3f85ce7be8823c64","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        if fip.get(\u0027subnet_id\u0027) and fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1269,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1270,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027],"},{"line_number":1271,"context_line":"                 \u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        elif fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1275,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]}]"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        elif fip.get(\u0027subnet_id\u0027):"},{"line_number":1278,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1279,"context_line":"                {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"        # \u0027status\u0027 in port dict could not be updated by default, use"},{"line_number":1282,"context_line":"        # check_allow_post to stop the verification of system"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_93246ac8","line":1279,"range":{"start_line":1268,"start_character":1,"end_line":1279,"end_character":48},"in_reply_to":"ff82abbf_6dc22536","updated":"2017-11-21 10:16:14.000000000","message":"Hi, Reedip. Any benefit of this change?","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"79a1486281b881a977c0cadf83f8e3d31e8ec812","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        if fip.get(\u0027subnet_id\u0027) and fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1269,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1270,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027],"},{"line_number":1271,"context_line":"                 \u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        elif fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1275,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]}]"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        elif fip.get(\u0027subnet_id\u0027):"},{"line_number":1278,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1279,"context_line":"                {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"        # \u0027status\u0027 in port dict could not be updated by default, use"},{"line_number":1282,"context_line":"        # check_allow_post to stop the verification of system"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_85009d36","line":1279,"range":{"start_line":1268,"start_character":1,"end_line":1279,"end_character":48},"in_reply_to":"ff82abbf_85e3bd05","updated":"2017-11-21 10:43:13.000000000","message":"Thanks, Reedip and Slawek, I will update in next PS.","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9adc8a1fe14b55be0f09a3e5c0c842c3e0eaf56d","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        if fip.get(\u0027subnet_id\u0027) and fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1269,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1270,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027],"},{"line_number":1271,"context_line":"                 \u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"        elif fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1275,"context_line":"                {\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]}]"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"        elif fip.get(\u0027subnet_id\u0027):"},{"line_number":1278,"context_line":"            port[\u0027fixed_ips\u0027] \u003d ["},{"line_number":1279,"context_line":"                {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}]"},{"line_number":1280,"context_line":""},{"line_number":1281,"context_line":"        # \u0027status\u0027 in port dict could not be updated by default, use"},{"line_number":1282,"context_line":"        # check_allow_post to stop the verification of system"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_05d7ad4d","line":1279,"range":{"start_line":1268,"start_character":1,"end_line":1279,"end_character":48},"in_reply_to":"ff82abbf_93246ac8","updated":"2017-11-21 10:24:09.000000000","message":"Not much, but the readability is improved and we do not need to  compare multiple cases.","commit_id":"96b3120fbff5b87ad4064c4f8a4bd0ac03f6f4ed"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_0062443f","line":1268,"range":{"start_line":1268,"start_character":8,"end_line":1268,"end_character":17},"updated":"2017-12-04 03:32:52.000000000","message":"\u0027fixed_ip\u0027 is a better name.","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":1265,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_e645f818","line":1268,"range":{"start_line":1268,"start_character":8,"end_line":1268,"end_character":17},"in_reply_to":"df87a7cf_0062443f","updated":"2017-12-04 05:51:29.000000000","message":"Done","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_20cc2834","line":1269,"range":{"start_line":1269,"start_character":11,"end_line":1269,"end_character":32},"updated":"2017-12-04 03:32:52.000000000","message":"Could you change it to:\n\n  if \u0027subnet_id\u0027 in fip","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d6bb874c1e047b3dd9c2370796b7bb3b20eac1ed","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_c5553852","line":1269,"range":{"start_line":1269,"start_character":11,"end_line":1269,"end_character":32},"in_reply_to":"df87a7cf_174cc89c","updated":"2017-12-05 06:09:03.000000000","message":"There are many fails like:\n\n\n{0} neutron.tests.unit.extensions.test_l3.L3AgentDbIntTestCase.test_l3_agent_routers_query_floatingips [2.549354s] ... FAILED\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n      File \"neutron/tests/base.py\", line 132, in func\n        return f(self, *args, **kwargs)\n      File \"neutron/tests/unit/extensions/test_l3.py\", line 3560, in test_l3_agent_routers_query_floatingips\n        with self.floatingip_with_assoc() as fip:\n      File \"/usr/lib/python2.7/contextlib.py\", line 17, in __enter__\n        return self.gen.next()\n      File \"neutron/tests/unit/extensions/test_l3.py\", line 518, in floatingip_with_assoc\n        **kwargs)\n      File \"neutron/tests/unit/extensions/test_l3.py\", line 470, in _make_floatingip\n        self.assertEqual(http_status, res.status_int)\n      File \"/root/neutron/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py\", line 411, in assertEqual\n        self.assertThat(observed, matcher, message)\n      File \"/root/neutron/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py\", line 498, in assertThat\n        raise mismatch_error\n    testtools.matchers._impl.MismatchError: 201 !\u003d 400\n\n\nI will investigate it.","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_c60eb4e4","line":1269,"range":{"start_line":1269,"start_character":11,"end_line":1269,"end_character":32},"in_reply_to":"df87a7cf_20cc2834","updated":"2017-12-04 05:51:29.000000000","message":"It will break other tests.","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"938ebd5d3b5081f4e2ff947adb8d8bb2b3b7bbdb","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_25e31ba6","line":1269,"range":{"start_line":1269,"start_character":11,"end_line":1269,"end_character":32},"in_reply_to":"df87a7cf_ae4c839e","updated":"2017-12-11 17:49:03.000000000","message":"Sorry for late. I misunderstood the default value when I wrote this comment. The default value of subnet_id and floating_ip_address is None, so you are right.\n\nMy motivation of the comment is to try to check a field existence a bit strictly. In this case I think \u0027subnet_id\u0027 or \u0027floating_ip_address\u0027 always exists, so it is better to use fip[\u0027subnet_id\u0027] rather than .get().\n\n  if fip[\u0027subnet_id\u0027]:","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e8ed5d275b455f1b59e66df7a1d02df4c3e60d30","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_ae4c839e","line":1269,"range":{"start_line":1269,"start_character":11,"end_line":1269,"end_character":32},"in_reply_to":"df87a7cf_c5553852","updated":"2017-12-05 09:12:22.000000000","message":"Maybe it is because in Your test fip[\u0027subnet_id\u0027] is None. That is the case when Your and Amotoki\u0027s logic will work differently and still IMHO You should change it to what Amotoki proposed.","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3c1aaabeb3440c3ef46f8a19cbd8271c0fbe2d2","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_174cc89c","line":1269,"range":{"start_line":1269,"start_character":11,"end_line":1269,"end_character":32},"in_reply_to":"df87a7cf_c60eb4e4","updated":"2017-12-04 08:27:08.000000000","message":"Can You explain how and which tests will it break?","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"},{"line_number":1273,"context_line":"        if temp_port:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_00c7a414","line":1270,"range":{"start_line":1270,"start_character":12,"end_line":1270,"end_character":55},"updated":"2017-12-04 03:32:52.000000000","message":"It is better to use:\n\n  temp_port[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":1267,"context_line":""},{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"},{"line_number":1273,"context_line":"        if temp_port:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_86f8acc4","line":1270,"range":{"start_line":1270,"start_character":12,"end_line":1270,"end_character":55},"in_reply_to":"df87a7cf_00c7a414","updated":"2017-12-04 05:51:29.000000000","message":"Done","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"        temp_port \u003d {}"},{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"},{"line_number":1273,"context_line":"        if temp_port:"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d [temp_port]"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_c0d0dccc","line":1271,"updated":"2017-12-04 03:32:52.000000000","message":"Same as for L.1269","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"},{"line_number":1273,"context_line":"        if temp_port:"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d [temp_port]"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_80dad4e6","line":1272,"updated":"2017-12-04 03:32:52.000000000","message":"Same as fro L.1270","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"},{"line_number":1273,"context_line":"        if temp_port:"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d [temp_port]"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_e62c1849","line":1272,"in_reply_to":"df87a7cf_80dad4e6","updated":"2017-12-04 05:51:29.000000000","message":"We should update the dict if subnet_id and floating_ip_address are both specified.","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d6bb874c1e047b3dd9c2370796b7bb3b20eac1ed","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"},{"line_number":1273,"context_line":"        if temp_port:"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d [temp_port]"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_25d664c7","line":1272,"in_reply_to":"df87a7cf_d76c200a","updated":"2017-12-05 06:09:03.000000000","message":"Done","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b3c1aaabeb3440c3ef46f8a19cbd8271c0fbe2d2","unresolved":false,"context_lines":[{"line_number":1269,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1270,"context_line":"            temp_port \u003d {\u0027subnet_id\u0027: fip[\u0027subnet_id\u0027]}"},{"line_number":1271,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1272,"context_line":"            temp_port.update({\u0027ip_address\u0027: fip[\u0027floating_ip_address\u0027]})"},{"line_number":1273,"context_line":"        if temp_port:"},{"line_number":1274,"context_line":"            port[\u0027fixed_ips\u0027] \u003d [temp_port]"},{"line_number":1275,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_d76c200a","line":1272,"in_reply_to":"df87a7cf_e62c1849","updated":"2017-12-04 08:27:08.000000000","message":"But solution proposed by Akihiro should works also. If You do:\n\nfixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]\n\nit will not override \u0027subnet_id\u0027 key if it already exists.","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"18f137e5d557676f64226e227416dc453210108a","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"        fixed_ip \u003d {}"},{"line_number":1280,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1281,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1282,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1283,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_45109e4e","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":32},"updated":"2017-12-11 17:54:04.000000000","message":"My comment in patch set 3 was wrong as I replied in patch set 3. You are right. The default value of subnet_id is None, so \u0027subnet_id\u0027 always exists in fip dict.\n\nPerhaps I misunderstood the content of \u0027fip\u0027 dict because the previous logic uses .get(). .get() is usually used to check/extract optional key. However, it looks like there is no case where the key \u0027subnet_id\u0027 does not exist.\n\nMy minor suggestion is to use fip[\u0027subnet_id\u0027] and fip[\u0027floating_ip_address\u0027] below.","commit_id":"e9203ba22cf98ae52d3444b507a8462399d2ccfd"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"bd8fbdada652fefd64d922a82d329c6726a73296","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"        fixed_ip \u003d {}"},{"line_number":1280,"context_line":"        if fip.get(\u0027subnet_id\u0027):"},{"line_number":1281,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1282,"context_line":"        if fip.get(\u0027floating_ip_address\u0027):"},{"line_number":1283,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_07c851a3","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":32},"in_reply_to":"df87a7cf_45109e4e","updated":"2017-12-12 01:55:45.000000000","message":"Never Mind. Thanks for your suggestion, I will update in next PS.","commit_id":"e9203ba22cf98ae52d3444b507a8462399d2ccfd"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3b3e05d829078e4fc1f2d68bf3a3792b70b37027","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1284,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"        fixed_ip \u003d {}"},{"line_number":1287,"context_line":"        if fip[\u0027subnet_id\u0027]:"},{"line_number":1288,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1289,"context_line":"        if fip[\u0027floating_ip_address\u0027]:"},{"line_number":1290,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":1291,"context_line":"        if fixed_ip:"},{"line_number":1292,"context_line":"            port[\u0027fixed_ips\u0027] \u003d [fixed_ip]"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        # \u0027status\u0027 in port dict could not be updated by default, use"},{"line_number":1295,"context_line":"        # check_allow_post to stop the verification of system"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_16794a2e","line":1292,"range":{"start_line":1286,"start_character":0,"end_line":1292,"end_character":42},"updated":"2017-12-13 02:05:03.000000000","message":"This changes the original behavior, better add a NOTE comment for this.","commit_id":"db84a182e002f8fd8486b3c7bf7db5b34589e7c6"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"a7ce6aeeed6fc22de4a7406d225fffb5970481fa","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"                \u0027status\u0027: constants.PORT_STATUS_NOTAPPLICABLE,"},{"line_number":1284,"context_line":"                \u0027name\u0027: \u0027\u0027}"},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"        fixed_ip \u003d {}"},{"line_number":1287,"context_line":"        if fip[\u0027subnet_id\u0027]:"},{"line_number":1288,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1289,"context_line":"        if fip[\u0027floating_ip_address\u0027]:"},{"line_number":1290,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"},{"line_number":1291,"context_line":"        if fixed_ip:"},{"line_number":1292,"context_line":"            port[\u0027fixed_ips\u0027] \u003d [fixed_ip]"},{"line_number":1293,"context_line":""},{"line_number":1294,"context_line":"        # \u0027status\u0027 in port dict could not be updated by default, use"},{"line_number":1295,"context_line":"        # check_allow_post to stop the verification of system"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_4382ad02","line":1292,"range":{"start_line":1286,"start_character":0,"end_line":1292,"end_character":42},"in_reply_to":"df87a7cf_16794a2e","updated":"2017-12-13 05:29:06.000000000","message":"Done","commit_id":"db84a182e002f8fd8486b3c7bf7db5b34589e7c6"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6e477db7457e67b31cc1fb418e80b9daa04c22","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"        self.assertEqual(\u002710.10.10.100\u0027,"},{"line_number":2685,"context_line":"                         fip[\u0027floatingip\u0027][\u0027floating_ip_address\u0027])"},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"    def test_create_floatingip_with_subnet_id_and_fip_address_fails(self,"},{"line_number":2688,"context_line":"            expected_error\u003d\u0027InvalidIpForSubnet\u0027):"},{"line_number":2689,"context_line":"        with self.network() as ext_net:"},{"line_number":2690,"context_line":"            self._set_net_external(ext_net[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_e0ee4087","line":2687,"range":{"start_line":2687,"start_character":8,"end_line":2687,"end_character":67},"updated":"2017-12-04 03:32:52.000000000","message":"How about test_create_floatingip_with_unmatched_subnet_and_fip_address ?","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b5a1fe658989fb9351845e14d122eebfabb58ca","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"        self.assertEqual(\u002710.10.10.100\u0027,"},{"line_number":2685,"context_line":"                         fip[\u0027floatingip\u0027][\u0027floating_ip_address\u0027])"},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"    def test_create_floatingip_with_subnet_id_and_fip_address_fails(self,"},{"line_number":2688,"context_line":"            expected_error\u003d\u0027InvalidIpForSubnet\u0027):"},{"line_number":2689,"context_line":"        with self.network() as ext_net:"},{"line_number":2690,"context_line":"            self._set_net_external(ext_net[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_86218c50","line":2687,"range":{"start_line":2687,"start_character":8,"end_line":2687,"end_character":67},"in_reply_to":"df87a7cf_e0ee4087","updated":"2017-12-04 05:51:29.000000000","message":"Done","commit_id":"1d2f872ee9390887458410dd38ecb5dd8b43a7c2"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1189b50c52cec36fcfd996772b80b8bf8c1e86d2","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"        self.assertEqual(\u002710.10.10.100\u0027,"},{"line_number":2685,"context_line":"                         fip[\u0027floatingip\u0027][\u0027floating_ip_address\u0027])"},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"    def test_create_floatingip_with_unmatched_subnet_and_fip_address(self,"},{"line_number":2688,"context_line":"            expected_error\u003d\u0027InvalidIpForSubnet\u0027):"},{"line_number":2689,"context_line":"        with self.network() as ext_net:"},{"line_number":2690,"context_line":"            self._set_net_external(ext_net[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_f63a2f96","line":2687,"range":{"start_line":2687,"start_character":31,"end_line":2687,"end_character":68},"updated":"2017-12-06 22:39:32.000000000","message":"how about changing this to\n\nwith_subnet_and_invalid_fip_address\n\nThe way it is named now conveys the impression that the subnet is also invalid, which is not the case","commit_id":"f747aeb6d103c402e6fd07311b17bd40beec29ef"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"126d740d8c7dc9c2c3d75ebf99ec1bdfd8c8f069","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"        self.assertEqual(\u002710.10.10.100\u0027,"},{"line_number":2685,"context_line":"                         fip[\u0027floatingip\u0027][\u0027floating_ip_address\u0027])"},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"    def test_create_floatingip_with_unmatched_subnet_and_fip_address(self,"},{"line_number":2688,"context_line":"            expected_error\u003d\u0027InvalidIpForSubnet\u0027):"},{"line_number":2689,"context_line":"        with self.network() as ext_net:"},{"line_number":2690,"context_line":"            self._set_net_external(ext_net[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"df87a7cf_94815afe","line":2687,"range":{"start_line":2687,"start_character":31,"end_line":2687,"end_character":68},"in_reply_to":"df87a7cf_f63a2f96","updated":"2017-12-07 01:47:28.000000000","message":"Done, it seems much suitable.","commit_id":"f747aeb6d103c402e6fd07311b17bd40beec29ef"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3b3e05d829078e4fc1f2d68bf3a3792b70b37027","unresolved":false,"context_lines":[{"line_number":2685,"context_line":"                         fip[\u0027floatingip\u0027][\u0027floating_ip_address\u0027])"},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"    def test_create_floatingip_with_subnet_and_invalid_fip_address(self,"},{"line_number":2688,"context_line":"            expected_error\u003d\u0027InvalidIpForSubnet\u0027):"},{"line_number":2689,"context_line":"        with self.network() as ext_net:"},{"line_number":2690,"context_line":"            self._set_net_external(ext_net[\u0027network\u0027][\u0027id\u0027])"},{"line_number":2691,"context_line":"            with self.subnet(ext_net, cidr\u003d\u002710.10.10.0/24\u0027) as ext_subnet:"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_36a9ee8f","line":2688,"range":{"start_line":2688,"start_character":12,"end_line":2688,"end_character":47},"updated":"2017-12-13 02:05:03.000000000","message":"Seems no other test case call this, so this param looks redundant.","commit_id":"db84a182e002f8fd8486b3c7bf7db5b34589e7c6"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"a7ce6aeeed6fc22de4a7406d225fffb5970481fa","unresolved":false,"context_lines":[{"line_number":2685,"context_line":"                         fip[\u0027floatingip\u0027][\u0027floating_ip_address\u0027])"},{"line_number":2686,"context_line":""},{"line_number":2687,"context_line":"    def test_create_floatingip_with_subnet_and_invalid_fip_address(self,"},{"line_number":2688,"context_line":"            expected_error\u003d\u0027InvalidIpForSubnet\u0027):"},{"line_number":2689,"context_line":"        with self.network() as ext_net:"},{"line_number":2690,"context_line":"            self._set_net_external(ext_net[\u0027network\u0027][\u0027id\u0027])"},{"line_number":2691,"context_line":"            with self.subnet(ext_net, cidr\u003d\u002710.10.10.0/24\u0027) as ext_subnet:"}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_a392994a","line":2688,"range":{"start_line":2688,"start_character":12,"end_line":2688,"end_character":47},"in_reply_to":"df87a7cf_36a9ee8f","updated":"2017-12-13 05:29:06.000000000","message":"Good catch, thanks.","commit_id":"db84a182e002f8fd8486b3c7bf7db5b34589e7c6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c18bd52ff47657abaf9fe629c0a88782c42330ba","unresolved":false,"context_lines":[{"line_number":2696,"context_line":"                        floating_ip\u003d\u002720.20.20.200\u0027)"},{"line_number":2697,"context_line":"                    data \u003d self.deserialize(self.fmt, res)"},{"line_number":2698,"context_line":"        self.assertEqual(exc.HTTPBadRequest.code, res.status_int)"},{"line_number":2699,"context_line":"        msg \u003d str(n_exc.InvalidIpForSubnet(ip_address\u003d\u002720.20.20.200\u0027))"},{"line_number":2700,"context_line":"        self.assertEqual(\u0027InvalidIpForSubnet\u0027, data[\u0027NeutronError\u0027][\u0027type\u0027])"},{"line_number":2701,"context_line":"        self.assertEqual(msg, data[\u0027NeutronError\u0027][\u0027message\u0027])"},{"line_number":2702,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_c3e0f4cf","line":2699,"updated":"2017-12-13 11:45:30.000000000","message":"nit: I would name it expected_msg but please do not respin only because of that :)","commit_id":"088e317cd2dd8488feb29a4fa6600227d1810479"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9305caea0d6d7e59b15ab6efe9017bc3cb69cf12","unresolved":false,"context_lines":[{"line_number":947,"context_line":"                    {\u0027floatingip\u0027: {\u0027floating_network_id\u0027: n[\u0027network\u0027][\u0027id\u0027],"},{"line_number":948,"context_line":"                                    \u0027tenant_id\u0027: n[\u0027network\u0027][\u0027tenant_id\u0027],"},{"line_number":949,"context_line":"                                    \u0027subnet_id\u0027: \u0027\u0027,"},{"line_number":950,"context_line":"                                    \u0027floating_ip_address\u0027: \u0027\u0027,"},{"line_number":951,"context_line":"                                    \u0027dns_name\u0027: \u0027\u0027, \u0027dns_domain\u0027: \u0027\u0027}}"},{"line_number":952,"context_line":"                )"},{"line_number":953,"context_line":"        self._delete(\u0027networks\u0027, n[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_e7d20400","line":950,"updated":"2017-12-12 11:06:19.000000000","message":"In the past discussion, the default value for these fields are None. How about passing None instead?","commit_id":"f94d4b9461d5366d4339fbfa6e7ed4b67a7fe53b"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"392152e890e54d5184d1d45572b4d2621e59aa27","unresolved":false,"context_lines":[{"line_number":947,"context_line":"                    {\u0027floatingip\u0027: {\u0027floating_network_id\u0027: n[\u0027network\u0027][\u0027id\u0027],"},{"line_number":948,"context_line":"                                    \u0027tenant_id\u0027: n[\u0027network\u0027][\u0027tenant_id\u0027],"},{"line_number":949,"context_line":"                                    \u0027subnet_id\u0027: \u0027\u0027,"},{"line_number":950,"context_line":"                                    \u0027floating_ip_address\u0027: \u0027\u0027,"},{"line_number":951,"context_line":"                                    \u0027dns_name\u0027: \u0027\u0027, \u0027dns_domain\u0027: \u0027\u0027}}"},{"line_number":952,"context_line":"                )"},{"line_number":953,"context_line":"        self._delete(\u0027networks\u0027, n[\u0027network\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_27330c64","line":950,"in_reply_to":"df87a7cf_e7d20400","updated":"2017-12-12 11:09:24.000000000","message":"Done","commit_id":"f94d4b9461d5366d4339fbfa6e7ed4b67a7fe53b"}]}
