)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2967,"name":"ljjjustin","email":"iamljj@gmail.com","username":"ljjjustin"},"change_message_id":"de1a8fe08dae78f970bb19330ed4002911e748f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Preserve floating ips when initializing l3 gateway interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5a88225d291538cb9db0f8f4afa348192b8b984d"},{"line_number":10,"context_line":"Fixes bug 1233271"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F%2FXfc%3D","line":9,"updated":"2013-11-08 04:24:59.000000000","message":"change id should be the last line in commit message.","commit_id":"4df6b6a0f74d9c5f7bb38c0f705ca1b60dd78765"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"dbab4944f7aa17072bb33d83122937ba6c81bb4c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.root_helper \u003d config.get_root_helper(conf)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def init_l3(self, device_name, ip_cidrs, namespace\u003dNone,"},{"line_number":74,"context_line":"                preserve_ips\u003d[]):"},{"line_number":75,"context_line":"        \"\"\"Set the L3 settings for the interface using data from the port."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        ip_cidrs: list of \u0027X.X.X.X/YY\u0027 strings"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Btb0%3D","line":74,"updated":"2013-11-21 09:18:46.000000000","message":"I would add comment to this code that preserve_ips mustn\u0027t be modified in the body of this method.\n\nOr maybe for preventing future potential issues set preserve_ips to None by default and change line 99 to \n\n if preserve_ips is None or ip_cidr not in preserve_ips\n\nThe reason is that if in the future someone decides to add something to preserve_ips in this method without explicitly defining preserve_ips, constructor for implicit list will be called just once.\n\nMy comment is just a suggestion for future uses :)","commit_id":"521598101013f2f8a745fb65cc7393e358249dc0"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"40917046e71f47ae8dbc71ab6b8e2a4e845e7197","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                preserve_ips\u003d[]):"},{"line_number":75,"context_line":"        \"\"\"Set the L3 settings for the interface using data from the port."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        ip_cidrs: list of \u0027X.X.X.X/YY\u0027 strings"},{"line_number":78,"context_line":"        \"\"\""},{"line_number":79,"context_line":"        device \u003d ip_lib.IPDevice(device_name,"},{"line_number":80,"context_line":"                                 self.root_helper,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2Bgac%3D","line":77,"updated":"2013-11-25 11:37:37.000000000","message":"Add a docstring to explain the new parameter \u0027preserve_ips\u0027","commit_id":"521598101013f2f8a745fb65cc7393e358249dc0"}]}