)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"9f38037a6fd133c52ae505319b5fb8a9ec1d6b0e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sylvain Afchain \u003csylvain.afchain@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-17 02:36:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix L2pop sends fdb updates for unrelated networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With this patch L2 population mechanism driver"},{"line_number":10,"context_line":"sends updates only with ports related to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FXzc%3D","line":7,"updated":"2013-10-17 02:43:09.000000000","message":"Minor nit: Maybe modify this to be:\n\nFix L2pop to not send fdb updates for unrelated networks","commit_id":"5101bf92492bb8fbc10b381344ba53fc505521f9"}],"neutron/plugins/ml2/drivers/l2pop/db.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"0b05bbbb06637195acd0ab8ddfb48a1daf82ff3f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            query \u003d query.join(agents_db.Agent,"},{"line_number":61,"context_line":"                               agents_db.Agent.host \u003d\u003d"},{"line_number":62,"context_line":"                               ml2_models.PortBinding.host)"},{"line_number":63,"context_line":"            query \u003d query.join(models_v2.Port)"},{"line_number":64,"context_line":"            query \u003d query.filter(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":65,"context_line":"                                 models_v2.Port.admin_state_up \u003d\u003d True,"},{"line_number":66,"context_line":"                                 agents_db.Agent.agent_type.in_("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FWys%3D","line":63,"updated":"2013-10-17 09:59:50.000000000","message":"why is it needed? I see ml2_models.PortBinding has relationship with Port using joined load","commit_id":"de24799696a8199b13223c2ca3820a9ef015bbe0"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"ae69e3cc3e7853f9396f3deac97ee59de8fb6ffe","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            query \u003d query.join(agents_db.Agent,"},{"line_number":61,"context_line":"                               agents_db.Agent.host \u003d\u003d"},{"line_number":62,"context_line":"                               ml2_models.PortBinding.host)"},{"line_number":63,"context_line":"            query \u003d query.join(models_v2.Port)"},{"line_number":64,"context_line":"            query \u003d query.filter(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":65,"context_line":"                                 models_v2.Port.admin_state_up \u003d\u003d True,"},{"line_number":66,"context_line":"                                 agents_db.Agent.agent_type.in_("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FWoI%3D","line":63,"in_reply_to":"AAAATH%2F%2FWvw%3D","updated":"2013-10-17 10:50:20.000000000","message":"Ok, I see why it is happening.\nIn fact the joined load appears for PortBinding, when you load Port, but not vice versa. While it could be fixed in model definition, loading whole Port model is expensive, so I think this fix is reasonable.\n\nAnother option is to just add another filter:\n models_v2.Port.id \u003d\u003d ml2_models.PortBinding.port_id\nThat should also help","commit_id":"de24799696a8199b13223c2ca3820a9ef015bbe0"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"47c6db381deef31cb551658676b41075872b0339","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            query \u003d query.join(agents_db.Agent,"},{"line_number":61,"context_line":"                               agents_db.Agent.host \u003d\u003d"},{"line_number":62,"context_line":"                               ml2_models.PortBinding.host)"},{"line_number":63,"context_line":"            query \u003d query.join(models_v2.Port)"},{"line_number":64,"context_line":"            query \u003d query.filter(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":65,"context_line":"                                 models_v2.Port.admin_state_up \u003d\u003d True,"},{"line_number":66,"context_line":"                                 agents_db.Agent.agent_type.in_("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FWvw%3D","line":63,"in_reply_to":"AAAATH%2F%2FWys%3D","updated":"2013-10-17 10:15:18.000000000","message":"Without this line, the join between Port and PortBinding doesn\u0027t appear in the final sql query.","commit_id":"de24799696a8199b13223c2ca3820a9ef015bbe0"}]}