)]}'
{"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"922f015299899fc7f4b7679681b3a40934606fc7","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def wait_until_env_is_up(self):"},{"line_number":337,"context_line":"        common_utils.wait_until_true("},{"line_number":338,"context_line":"            self._processes_are_ready,"},{"line_number":339,"context_line":"            timeout\u003d180,"},{"line_number":340,"context_line":"            sleep\u003d10)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _processes_are_ready(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_7554bc21","line":339,"updated":"2017-11-26 10:14:43.000000000","message":"as I read in bug report in environment with 3 dhcp and 3 ovs agents (so one of \"biggest\" cases in fullstack test) agent was started after 67 seconds so why not set it here e.g. to 90 seconds?","commit_id":"89e0ed9e3d1630197545280ef6c11828d0f2b1dc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1e9ec67f9aad2bb003997e43664738f895de6044","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def wait_until_env_is_up(self):"},{"line_number":337,"context_line":"        common_utils.wait_until_true("},{"line_number":338,"context_line":"            self._processes_are_ready,"},{"line_number":339,"context_line":"            timeout\u003d180,"},{"line_number":340,"context_line":"            sleep\u003d10)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _processes_are_ready(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_75a7dca8","line":339,"updated":"2017-11-26 07:53:37.000000000","message":"why not add a configuration or enviroinment variable here. i feel that this is just guessing","commit_id":"89e0ed9e3d1630197545280ef6c11828d0f2b1dc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2b90bdad34306a26ff1d47d043301695e15ff50b","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def wait_until_env_is_up(self):"},{"line_number":337,"context_line":"        common_utils.wait_until_true("},{"line_number":338,"context_line":"            self._processes_are_ready,"},{"line_number":339,"context_line":"            timeout\u003d180,"},{"line_number":340,"context_line":"            sleep\u003d10)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _processes_are_ready(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_f4220452","line":339,"in_reply_to":"ff82abbf_7554bc21","updated":"2017-11-27 09:21:15.000000000","message":"@Slawek: I\u0027d rather set higher value to avoid such failures in the future. The worst case means test will take 3 minutes before it fails and we are sure there is an issue in building environment. Best case is that waiting loop stops as soon as the env is ready and that is not influenced by the timeout value.","commit_id":"89e0ed9e3d1630197545280ef6c11828d0f2b1dc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2b90bdad34306a26ff1d47d043301695e15ff50b","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def wait_until_env_is_up(self):"},{"line_number":337,"context_line":"        common_utils.wait_until_true("},{"line_number":338,"context_line":"            self._processes_are_ready,"},{"line_number":339,"context_line":"            timeout\u003d180,"},{"line_number":340,"context_line":"            sleep\u003d10)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _processes_are_ready(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_f4f9a4c7","line":339,"in_reply_to":"ff82abbf_75a7dca8","updated":"2017-11-27 09:21:15.000000000","message":"@garyk: We want to set the cap for environment to be built. The waiting loop stops once environment is ready, so it\u0027s better to set higher value. Introducing configurable timeout imho makes it more complex with low value. The value is set on empiric experience - see the bug report.","commit_id":"89e0ed9e3d1630197545280ef6c11828d0f2b1dc"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"603112b049825b5be1d7d9fbdfb7280e878d63c4","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def wait_until_env_is_up(self):"},{"line_number":337,"context_line":"        common_utils.wait_until_true("},{"line_number":338,"context_line":"            self._processes_are_ready,"},{"line_number":339,"context_line":"            timeout\u003d180,"},{"line_number":340,"context_line":"            sleep\u003d10)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _processes_are_ready(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_b038f69f","line":339,"in_reply_to":"ff82abbf_d4d4a0eb","updated":"2017-11-27 22:02:06.000000000","message":"let\u0027s see how long 180 will no longer be enough :)","commit_id":"89e0ed9e3d1630197545280ef6c11828d0f2b1dc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ae799fd4364c33112d9315c5429b017e3d9fe12d","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    def wait_until_env_is_up(self):"},{"line_number":337,"context_line":"        common_utils.wait_until_true("},{"line_number":338,"context_line":"            self._processes_are_ready,"},{"line_number":339,"context_line":"            timeout\u003d180,"},{"line_number":340,"context_line":"            sleep\u003d10)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _processes_are_ready(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_d4d4a0eb","line":339,"in_reply_to":"ff82abbf_f4f9a4c7","updated":"2017-11-27 09:28:46.000000000","message":"Ok, thx. that is fine for me if it makes fullstack more stable :)","commit_id":"89e0ed9e3d1630197545280ef6c11828d0f2b1dc"}]}
