)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4f93a1beb2a7e010905b0bb12636b1de758ae704","unresolved":false,"context_lines":[{"line_number":11,"context_line":"that arrive before the filter metadata redirect rule is"},{"line_number":12,"context_line":"installed will just be dropped."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Think there might already be a bug for this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8982523dbb94a7c5b8a4db88a196fabc4dd2873f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_f50ce043","line":14,"updated":"2017-12-01 17:11:38.000000000","message":"The bug is 1735724.\n\nRegarding this change, I think we should always install these marking rules regardless of the setting of enable_metadata_proxy, and just let that control the other two rules that actually deal with intercepting packets.\n\nI\u0027ll work on moving the other rule creation as well.","commit_id":"1f0f251d2a2883fe0c19471a3af8bf15cc9d6ae5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"25993ba4496ea259998777ca505fefff5500b260","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Move the iptables metadata marking rule earlier in"},{"line_number":10,"context_line":"router init, that way any stray metadata requests"},{"line_number":11,"context_line":"that arrive before the filter metadata redirect rule is"},{"line_number":12,"context_line":"installed will just be dropped.  We do this irregardless"},{"line_number":13,"context_line":"of whether we will be running the metadata proxy."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-bug: #1735724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_d55e7c11","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":56},"updated":"2017-12-12 23:04:56.000000000","message":"First time I see this. But yeah, it is a word: https://www.merriam-webster.com/dictionary/irregardless","commit_id":"7818c72f548ee4aa0f27de902f448473664c1fb3"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"13ebb4f54669aa342ab8d4d89ae27e25ab0b5cac","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Move the iptables metadata marking rule earlier in"},{"line_number":10,"context_line":"router init, that way any stray metadata requests"},{"line_number":11,"context_line":"that arrive before the filter metadata redirect rule is"},{"line_number":12,"context_line":"installed will just be dropped.  We do this irregardless"},{"line_number":13,"context_line":"of whether we will be running the metadata proxy."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-bug: #1735724"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_ecf552cc","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":56},"in_reply_to":"df87a7cf_d55e7c11","updated":"2017-12-19 16:53:32.000000000","message":"It is, in that people-mistakenly-said-it-instead-of-regardless-enough-that-it-became-a-word kind of way. :p","commit_id":"7818c72f548ee4aa0f27de902f448473664c1fb3"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4f93a1beb2a7e010905b0bb12636b1de758ae704","unresolved":false,"context_lines":[{"line_number":951,"context_line":"                \u0027-j MARK --set-xmark %(value)s/%(mask)s\u0027 %"},{"line_number":952,"context_line":"                {\u0027interface_name\u0027: INTERNAL_DEV_PREFIX + \u0027+\u0027,"},{"line_number":953,"context_line":"                 \u0027value\u0027: self.agent_conf.metadata_access_mark,"},{"line_number":954,"context_line":"                 \u0027mask\u0027: n_const.ROUTER_MARK_MASK})"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"    def initialize_address_scope_iptables(self):"},{"line_number":957,"context_line":"        self._initialize_address_scope_iptables(self.iptables_manager)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_956474bb","line":954,"updated":"2017-12-01 17:11:38.000000000","message":"I suppose this whole thing can just go to L979...","commit_id":"1f0f251d2a2883fe0c19471a3af8bf15cc9d6ae5"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6bca38a1327a0524e1949eb2b06a6815230c3678","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            \u0027-m connmark --mark 0x0/0xffff0000 \u0027"},{"line_number":974,"context_line":"            \u0027-j CONNMARK --save-mark \u0027"},{"line_number":975,"context_line":"            \u0027--nfmask 0xffff0000 --ctmask 0xffff0000\u0027)"},{"line_number":976,"context_line":"        mark_metadata_for_internal_interfaces \u003d ("},{"line_number":977,"context_line":"            \u0027-d 169.254.169.254/32 \u0027"},{"line_number":978,"context_line":"            \u0027-i %(interface_name)s \u0027"},{"line_number":979,"context_line":"            \u0027-p tcp -m tcp --dport 80 \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_ace4130e","line":976,"range":{"start_line":976,"start_character":8,"end_line":976,"end_character":45},"updated":"2017-12-09 15:53:41.000000000","message":"Maybe _initialize_address_scope_iptables is not the best place for this? Perhaps a separate method would be more clear.","commit_id":"d4952e92ae10f4b94626f91e031c8a4e58901f16"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1997bb9433984d719edbc8ac16a2545e18dfa988","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            \u0027-m connmark --mark 0x0/0xffff0000 \u0027"},{"line_number":974,"context_line":"            \u0027-j CONNMARK --save-mark \u0027"},{"line_number":975,"context_line":"            \u0027--nfmask 0xffff0000 --ctmask 0xffff0000\u0027)"},{"line_number":976,"context_line":"        mark_metadata_for_internal_interfaces \u003d ("},{"line_number":977,"context_line":"            \u0027-d 169.254.169.254/32 \u0027"},{"line_number":978,"context_line":"            \u0027-i %(interface_name)s \u0027"},{"line_number":979,"context_line":"            \u0027-p tcp -m tcp --dport 80 \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_25ceba62","line":976,"range":{"start_line":976,"start_character":8,"end_line":976,"end_character":45},"in_reply_to":"df87a7cf_ace4130e","updated":"2017-12-11 18:31:07.000000000","message":"Yeah, that might be better, plus having it here will install the rule in both the qrouter and snat namespaces, and it\u0027s only needed in the qrouter.","commit_id":"d4952e92ae10f4b94626f91e031c8a4e58901f16"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"f41d03755537254f056c2320e005c06e1de5148a","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        # rules need to override the mark from CONNMARK to cross scopes."},{"line_number":993,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_rule("},{"line_number":994,"context_line":"            \u0027PREROUTING\u0027, mark_new_ingress_address_scope_by_floatingip)"},{"line_number":995,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_rule("},{"line_number":996,"context_line":"            \u0027PREROUTING\u0027, mark_metadata_for_internal_interfaces)"},{"line_number":997,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_rule("},{"line_number":998,"context_line":"            \u0027float-snat\u0027, save_mark_to_connmark)"},{"line_number":999,"context_line":"        iptables_manager.ipv6[\u0027mangle\u0027].add_rule("}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_9ece1161","line":996,"range":{"start_line":995,"start_character":0,"end_line":996,"end_character":64},"updated":"2017-12-10 12:23:32.000000000","message":"Just a nic, it would be great that can add some descritions","commit_id":"d4952e92ae10f4b94626f91e031c8a4e58901f16"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1997bb9433984d719edbc8ac16a2545e18dfa988","unresolved":false,"context_lines":[{"line_number":992,"context_line":"        # rules need to override the mark from CONNMARK to cross scopes."},{"line_number":993,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_rule("},{"line_number":994,"context_line":"            \u0027PREROUTING\u0027, mark_new_ingress_address_scope_by_floatingip)"},{"line_number":995,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_rule("},{"line_number":996,"context_line":"            \u0027PREROUTING\u0027, mark_metadata_for_internal_interfaces)"},{"line_number":997,"context_line":"        iptables_manager.ipv4[\u0027mangle\u0027].add_rule("},{"line_number":998,"context_line":"            \u0027float-snat\u0027, save_mark_to_connmark)"},{"line_number":999,"context_line":"        iptables_manager.ipv6[\u0027mangle\u0027].add_rule("}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_45865ebb","line":996,"range":{"start_line":995,"start_character":0,"end_line":996,"end_character":64},"in_reply_to":"df87a7cf_9ece1161","updated":"2017-12-11 18:31:07.000000000","message":"Done","commit_id":"d4952e92ae10f4b94626f91e031c8a4e58901f16"}]}