)]}'
{"neutron/tests/fullstack/resources/machine.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f5b961045cf8d9e206934fb42b26e96f8399c7dc","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # If VM is connected to Linuxbridge it hasn\u0027t got \"delete_port\" method"},{"line_number":202,"context_line":"        # and it is not necessary to delete tap port connected to this bridge."},{"line_number":203,"context_line":"        # It is veth pair and will be removed together with VM namespace"},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            self.bridge.delete_port(self.port.name)"},{"line_number":206,"context_line":"        except AttributeError:"},{"line_number":207,"context_line":"            pass"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        ip_lib.delete_network_namespace(self.namespace)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_b3f5ee85","line":207,"range":{"start_line":204,"start_character":0,"end_line":207,"end_character":16},"updated":"2017-12-01 12:52:14.000000000","message":"I\u0027d suggest to use\n\n if hasattr(self.bridge, \u0027delete_port\u0027):\n     self.bridge.delete_port(self.port.name)\n\nor implement a noop method to Linuxbridge. Catching AttributeError may hide actual different AtttributeErrors coming from delete_port()","commit_id":"b9fbec203b2466a1795c4ba6b8ee2d7244ea68d3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e8ee3fd43024231b886c4ccc6aee9dcb85b45461","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        # If VM is connected to Linuxbridge it hasn\u0027t got \"delete_port\" method"},{"line_number":202,"context_line":"        # and it is not necessary to delete tap port connected to this bridge."},{"line_number":203,"context_line":"        # It is veth pair and will be removed together with VM namespace"},{"line_number":204,"context_line":"        try:"},{"line_number":205,"context_line":"            self.bridge.delete_port(self.port.name)"},{"line_number":206,"context_line":"        except AttributeError:"},{"line_number":207,"context_line":"            pass"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        ip_lib.delete_network_namespace(self.namespace)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_61d1f657","line":207,"range":{"start_line":204,"start_character":0,"end_line":207,"end_character":16},"in_reply_to":"ff82abbf_b3f5ee85","updated":"2017-12-01 13:55:59.000000000","message":"Ok, I changed it. I don\u0027t want to add noop method to Linuxbridge class because there is already delif() method there which is doing same thing.\nBut it don\u0027t need to be called here for linuxbridge bridge","commit_id":"b9fbec203b2466a1795c4ba6b8ee2d7244ea68d3"}]}
