)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b8c4b544b59660b08754f4e8a3a6e1ace684541d","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        # and \u0027allocation_pools\u0027 fields."},{"line_number":837,"context_line":"        s[\u0027ip_version\u0027] \u003d subnet_obj.ip_version"},{"line_number":838,"context_line":"        # TODO(slaweq): convert cidr to str will not be necessary when we"},{"line_number":839,"context_line":"        # will switch to use subnet OVO in ipam module"},{"line_number":840,"context_line":"        s[\u0027cidr\u0027] \u003d str(subnet_obj.cidr)"},{"line_number":841,"context_line":"        s[\u0027id\u0027] \u003d subnet_obj.id"},{"line_number":842,"context_line":"        s[\u0027project_id\u0027] \u003d subnet_obj.project_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_d610ef02","side":"PARENT","line":839,"updated":"2017-12-11 15:23:45.000000000","message":"Whats interesting is that you change CIDR into STR in the next file.\nWhy ?","commit_id":"259eedaaba209215ff2235c539d79a209e1d044d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b61be76377170a48ffbd6c65945c41d3c14f1789","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        # and \u0027allocation_pools\u0027 fields."},{"line_number":837,"context_line":"        s[\u0027ip_version\u0027] \u003d subnet_obj.ip_version"},{"line_number":838,"context_line":"        # TODO(slaweq): convert cidr to str will not be necessary when we"},{"line_number":839,"context_line":"        # will switch to use subnet OVO in ipam module"},{"line_number":840,"context_line":"        s[\u0027cidr\u0027] \u003d str(subnet_obj.cidr)"},{"line_number":841,"context_line":"        s[\u0027id\u0027] \u003d subnet_obj.id"},{"line_number":842,"context_line":"        s[\u0027project_id\u0027] \u003d subnet_obj.project_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_56493fb4","side":"PARENT","line":839,"in_reply_to":"df87a7cf_d610ef02","updated":"2017-12-11 15:34:39.000000000","message":"It is like that because here this value is then passed to update_subnet and it will be used in subnet OVO object. That requires to pass netaddr.IPNetwork() object as cidr.\nIn next file netaddr.IPNetwork object is converted to string because it is compared with constant value const.PROVISIONAL_IPV6_PD_PREFIX which is string and is used in many other places also.","commit_id":"259eedaaba209215ff2235c539d79a209e1d044d"}],"neutron/tests/unit/api/rpc/handlers/test_l3_rpc.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b8c4b544b59660b08754f4e8a3a6e1ace684541d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                             \u0027end\u0027: \u00272001:db8::ffff:ffff:ffff:ffff\u0027}]"},{"line_number":66,"context_line":"        res \u003d self.callbacks.process_prefix_update(self.ctx, subnets\u003ddata)"},{"line_number":67,"context_line":"        updated_subnet \u003d res[0]"},{"line_number":68,"context_line":"        self.assertEqual(str(data[subnet[\u0027id\u0027]]), updated_subnet[\u0027cidr\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_b6b44bf3","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":28},"updated":"2017-12-11 15:23:45.000000000","message":"Again, why do we need to change str here when it has been changed in the first file ?","commit_id":"7332b8bd7132918dcfffef9adec6342c224d6aa6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2d680bc83b2fa8da39f8c761bc86232913d68d3e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                             \u0027end\u0027: \u00272001:db8::ffff:ffff:ffff:ffff\u0027}]"},{"line_number":66,"context_line":"        res \u003d self.callbacks.process_prefix_update(self.ctx, subnets\u003ddata)"},{"line_number":67,"context_line":"        updated_subnet \u003d res[0]"},{"line_number":68,"context_line":"        self.assertEqual(str(data[subnet[\u0027id\u0027]]), updated_subnet[\u0027cidr\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_19ef681e","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":28},"in_reply_to":"df87a7cf_7679e3c5","updated":"2017-12-11 15:40:00.000000000","message":"No, I dont think it matters too much because you are converting  either one of the data sets.","commit_id":"7332b8bd7132918dcfffef9adec6342c224d6aa6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b61be76377170a48ffbd6c65945c41d3c14f1789","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                             \u0027end\u0027: \u00272001:db8::ffff:ffff:ffff:ffff\u0027}]"},{"line_number":66,"context_line":"        res \u003d self.callbacks.process_prefix_update(self.ctx, subnets\u003ddata)"},{"line_number":67,"context_line":"        updated_subnet \u003d res[0]"},{"line_number":68,"context_line":"        self.assertEqual(str(data[subnet[\u0027id\u0027]]), updated_subnet[\u0027cidr\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_7679e3c5","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":28},"in_reply_to":"df87a7cf_b6b44bf3","updated":"2017-12-11 15:34:39.000000000","message":"Again, I it needs to be set as netaddr.IPNetwork object because it is used to create/update subnet OVO object but it\u0027s then compared to str as updated_subnet[\u0027cidr\u0027] contains string value.\nI can do opposite conversion and change string value to netaddr.IPNetwork() object to compare it. Do You think it will be better?","commit_id":"7332b8bd7132918dcfffef9adec6342c224d6aa6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"dcf510d17ca96df9bfdd147d4b87fffcaaead519","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":"from neutron_lib import context"},{"line_number":20,"context_line":"from neutron_lib.plugins import directory"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_e00c003d","line":17,"updated":"2017-12-13 19:22:23.000000000","message":"nit, no action required: I think we don\u0027t leave a newline between 3party libraries, and neutron-lib is considered a 3party.","commit_id":"72ae41b578d49971e4080a8a9d58bf98704227db"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bcb5d452351a3b88169337686d847c5d946e9aff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron_lib import constants"},{"line_number":19,"context_line":"from neutron_lib import context"},{"line_number":20,"context_line":"from neutron_lib.plugins import directory"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_1defa61e","line":17,"in_reply_to":"df87a7cf_e00c003d","updated":"2017-12-18 14:17:30.000000000","message":"yes, You\u0027re right. Fixed","commit_id":"72ae41b578d49971e4080a8a9d58bf98704227db"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"dcf510d17ca96df9bfdd147d4b87fffcaaead519","unresolved":false,"context_lines":[{"line_number":1934,"context_line":"            # update subnet with new prefix"},{"line_number":1935,"context_line":"            prefix \u003d netaddr.IPNetwork(\u00272001::/64\u0027)"},{"line_number":1936,"context_line":"            data \u003d {\u0027subnet\u0027: {\u0027cidr\u0027: prefix}}"},{"line_number":1937,"context_line":"            self.plugin.update_subnet(context.get_admin_context(),"},{"line_number":1938,"context_line":"                                      subnet_id, data)"},{"line_number":1939,"context_line":"            kwargs \u003d {\"fixed_ips\": [{\u0027subnet_id\u0027: subnet_id,"},{"line_number":1940,"context_line":"                                     \u0027ip_address\u0027: \u00272001::2\u0027}]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_803ad4ca","line":1937,"updated":"2017-12-13 19:22:23.000000000","message":"I don\u0027t we should change format of data passed into plugin. So you shouldn\u0027t need to convert to IPNetwork.","commit_id":"72ae41b578d49971e4080a8a9d58bf98704227db"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bcb5d452351a3b88169337686d847c5d946e9aff","unresolved":false,"context_lines":[{"line_number":1934,"context_line":"            # update subnet with new prefix"},{"line_number":1935,"context_line":"            prefix \u003d netaddr.IPNetwork(\u00272001::/64\u0027)"},{"line_number":1936,"context_line":"            data \u003d {\u0027subnet\u0027: {\u0027cidr\u0027: prefix}}"},{"line_number":1937,"context_line":"            self.plugin.update_subnet(context.get_admin_context(),"},{"line_number":1938,"context_line":"                                      subnet_id, data)"},{"line_number":1939,"context_line":"            kwargs \u003d {\"fixed_ips\": [{\u0027subnet_id\u0027: subnet_id,"},{"line_number":1940,"context_line":"                                     \u0027ip_address\u0027: \u00272001::2\u0027}]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_dd15be4a","line":1937,"in_reply_to":"df87a7cf_803ad4ca","updated":"2017-12-18 14:17:30.000000000","message":"Right, changed","commit_id":"72ae41b578d49971e4080a8a9d58bf98704227db"}]}