)]}'
{"neutron/db/migration/alembic_migrations/versions/128e042a2b68_ext_gw_mode.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0251876ba74f84bb56f4de461ca8e0a9e111192f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    op.add_column(\u0027routers\u0027, sa.Column(\u0027enable_snat\u0027, sa.Boolean(),"},{"line_number":55,"context_line":"                                       nullable\u003dFalse, server_default\u003d\u00271\u0027))"},{"line_number":56,"context_line":"    # Set enable_snat to True for existing routers"},{"line_number":57,"context_line":"    op.execute(\"UPDATE routers SET enable_snat\u003d\u0027True\u0027\")"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Fz5o%3D","line":55,"updated":"2013-10-28 17:12:04.000000000","message":"any reason why here you didn\u0027t follow the same course of action as the other two migrations (i.e. making the migration logic dependent on the engine name)? If that was the case, it looks like this patch would be pretty harmless. That said, I agree with Salvatore\u0027s and Mark\u0027s comments, let\u0027s get an agreement on how to handle sqlite quirks first, so that we can enforce the right practice in the future.","commit_id":"42cee9111f863703d99f5c647e57172d728bab70"}]}
