)]}'
{"neutron/tests/tools.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"78295d3ae756144212100a5eef5560c73d49f5bf","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def setUp(self):"},{"line_number":48,"context_line":"        super(TempConfigFile, self).setUp()"},{"line_number":49,"context_line":"        self.cfg_file \u003d tempfile.mktemp()"},{"line_number":50,"context_line":"        with open(self.cfg_file, \u0027w\u0027) as f:"},{"line_number":51,"context_line":"            for group in self.configs:"},{"line_number":52,"context_line":"                f.write(\u0027[%s]\\n\u0027 % group)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F3OM%3D","line":49,"updated":"2013-10-26 10:20:13.000000000","message":"mktemp has been deprecated since 2.3 - please use mkstemp instead.\n\nReference: http://docs.python.org/2/library/tempfile.html#tempfile.mktemp","commit_id":"ac32978b59379cf916b5092575047fe96b71bd4f"}],"neutron/tests/unit/linuxbridge/test_lb_db.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"c6258ffa6b1e2c5c965fd78b742121bc0998c545","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class NetworkBindingsTest(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":154,"context_line":"    def _setup_config(self):"},{"line_number":155,"context_line":"        self.cfg_file \u003d self.useFixture(fixtures.TempDir()).join(\"lb.ini\")"},{"line_number":156,"context_line":"        with open(self.cfg_file, \u0027w\u0027) as f:"},{"line_number":157,"context_line":"            f.write(\u0027[vlans]\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATX%2F%2F8qc%3D","line":154,"updated":"2013-10-23 19:57:40.000000000","message":"Are these setup changes required due to the proper plugin actually being exercised?\n\nAlso, the setup changes look almost identical for the ovs and lb tests.   Would it make sense to add it as a helper method to the common parent class?","commit_id":"c2c8c51ba1c9fc9391e1463cdf0e5b609146c7a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5ebfc2366fdf71f56f5274480819bae97163fa07","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"class NetworkBindingsTest(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":154,"context_line":"    def _setup_config(self):"},{"line_number":155,"context_line":"        self.cfg_file \u003d self.useFixture(fixtures.TempDir()).join(\"lb.ini\")"},{"line_number":156,"context_line":"        with open(self.cfg_file, \u0027w\u0027) as f:"},{"line_number":157,"context_line":"            f.write(\u0027[vlans]\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F%2Faw%3D","line":154,"in_reply_to":"AAAATX%2F%2F8qc%3D","updated":"2013-10-25 15:18:00.000000000","message":"yes. It is required because this test requires different provider network configurations different from the default.\nWhen setUp() at L.169 is called, cfg.CONF is not initialized, so we need to use --config-file option.\n\nI will try more general and simpler approach.","commit_id":"c2c8c51ba1c9fc9391e1463cdf0e5b609146c7a1"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"c88a84dcedad1b77d18ef25af0b5f8e5d0e8148e","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def setUp(self):"},{"line_number":167,"context_line":"        self._setup_config()"},{"line_number":168,"context_line":"        self.addCleanup(self._clean_config)"},{"line_number":169,"context_line":"        super(NetworkBindingsTest, self).setUp(plugin\u003dPLUGIN_NAME)"},{"line_number":170,"context_line":"        lb_db.initialize()"},{"line_number":171,"context_line":"        self.session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FL28%3D","line":168,"updated":"2013-10-21 19:31:32.000000000","message":"Just a question: do we not use tearDown?","commit_id":"c2c8c51ba1c9fc9391e1463cdf0e5b609146c7a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"abe1deaf20dfeeec8d4982650021f2d1930f14ac","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def setUp(self):"},{"line_number":167,"context_line":"        self._setup_config()"},{"line_number":168,"context_line":"        self.addCleanup(self._clean_config)"},{"line_number":169,"context_line":"        super(NetworkBindingsTest, self).setUp(plugin\u003dPLUGIN_NAME)"},{"line_number":170,"context_line":"        lb_db.initialize()"},{"line_number":171,"context_line":"        self.session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FKc0%3D","line":168,"in_reply_to":"AAAATH%2F%2FL28%3D","updated":"2013-10-22 08:10:49.000000000","message":"addCleanup is recommended over. It is more robust against errors. For more detail, please see Monty\u0027s post: \nhttp://lists.openstack.org/pipermail/openstack-dev/2013-October/016203.html","commit_id":"c2c8c51ba1c9fc9391e1463cdf0e5b609146c7a1"}],"neutron/tests/unit/openvswitch/test_ovs_db.py":[{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"c88a84dcedad1b77d18ef25af0b5f8e5d0e8148e","unresolved":false,"context_lines":[{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def setUp(self):"},{"line_number":315,"context_line":"        self._setup_config()"},{"line_number":316,"context_line":"        self.addCleanup(self._clean_config)"},{"line_number":317,"context_line":"        super(NetworkBindingsTest, self).setUp(plugin\u003dPLUGIN_NAME)"},{"line_number":318,"context_line":"        ovs_db_v2.initialize()"},{"line_number":319,"context_line":"        self.session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FL20%3D","line":316,"updated":"2013-10-21 19:31:32.000000000","message":"Same, not using tearDown?","commit_id":"c2c8c51ba1c9fc9391e1463cdf0e5b609146c7a1"}]}