)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8c832836f18c6b86a8653633c0bf80ad2f18bd8d","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        # floating_ip_address is not in the subnet,"},{"line_number":1291,"context_line":"        # InvalidIpForSubnet exception will be raised."},{"line_number":1292,"context_line":"        fixed_ip \u003d {}"},{"line_number":1293,"context_line":"        if \u0027subnet_id\u0027 in fip and fip[\u0027subnet_id\u0027]:"},{"line_number":1294,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1295,"context_line":"        if \u0027floating_ip_address\u0027 in fip and fip[\u0027floating_ip_address\u0027]:"},{"line_number":1296,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_c3dc1848","line":1293,"range":{"start_line":1293,"start_character":8,"end_line":1293,"end_character":51},"updated":"2017-12-18 02:04:56.000000000","message":"So the better way is using get method here?","commit_id":"df482f0e5722f1877218cb255dc191cce5d48507"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"4fce7eb932c5c3afe60cbb2a336bd55da8425219","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        # floating_ip_address is not in the subnet,"},{"line_number":1291,"context_line":"        # InvalidIpForSubnet exception will be raised."},{"line_number":1292,"context_line":"        fixed_ip \u003d {}"},{"line_number":1293,"context_line":"        if \u0027subnet_id\u0027 in fip and fip[\u0027subnet_id\u0027]:"},{"line_number":1294,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1295,"context_line":"        if \u0027floating_ip_address\u0027 in fip and fip[\u0027floating_ip_address\u0027]:"},{"line_number":1296,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_f489c674","line":1293,"range":{"start_line":1293,"start_character":8,"end_line":1293,"end_character":51},"in_reply_to":"df87a7cf_1419ca78","updated":"2017-12-18 07:03:05.000000000","message":"Thanks, not sure the validation is necessary, we had\nalready defined the default value of subnet_id and floating_ip_address in l3 extension.","commit_id":"df482f0e5722f1877218cb255dc191cce5d48507"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"51442a829baae8a09d66f120dcbd9bfc248c6cb5","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        # floating_ip_address is not in the subnet,"},{"line_number":1291,"context_line":"        # InvalidIpForSubnet exception will be raised."},{"line_number":1292,"context_line":"        fixed_ip \u003d {}"},{"line_number":1293,"context_line":"        if \u0027subnet_id\u0027 in fip and fip[\u0027subnet_id\u0027]:"},{"line_number":1294,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1295,"context_line":"        if \u0027floating_ip_address\u0027 in fip and fip[\u0027floating_ip_address\u0027]:"},{"line_number":1296,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_1419ca78","line":1293,"range":{"start_line":1293,"start_character":8,"end_line":1293,"end_character":51},"in_reply_to":"df87a7cf_c3dc1848","updated":"2017-12-18 06:54:11.000000000","message":"i have added in a validation checking that the value is actually valid. Cause if its set as ATTR_NOT_SPECIFIED then we are hosed.","commit_id":"df482f0e5722f1877218cb255dc191cce5d48507"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e360f92b4638418c471f3180ca903716247b1807","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        # floating_ip_address is not in the subnet,"},{"line_number":1291,"context_line":"        # InvalidIpForSubnet exception will be raised."},{"line_number":1292,"context_line":"        fixed_ip \u003d {}"},{"line_number":1293,"context_line":"        if validators.is_attr_set(fip.get(\u0027subnet_id\u0027)):"},{"line_number":1294,"context_line":"            fixed_ip[\u0027subnet_id\u0027] \u003d fip[\u0027subnet_id\u0027]"},{"line_number":1295,"context_line":"        if validators.is_attr_set(fip.get(\u0027floating_ip_address\u0027)):"},{"line_number":1296,"context_line":"            fixed_ip[\u0027ip_address\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_a40bff27","line":1293,"updated":"2017-12-18 17:45:13.000000000","message":"I think using is_attr_set is better as it is more robust than assuming None.","commit_id":"e3488f451ecf6e76ccbd001255fcd7f5e8d48b37"}]}
