)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"65445caadc6382003a8f6d400006ba5e65588237","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            if \u0027\u003c\u0027 not in line:"},{"line_number":94,"context_line":"                continue"},{"line_number":95,"context_line":"            tokens \u003d line.split(\u0027:\u0027, 2)"},{"line_number":96,"context_line":"            if len(tokens) \u003e\u003d 3:"},{"line_number":97,"context_line":"                name \u003d tokens[1].split(\u0027@\u0027, 1)[0].strip()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                if exclude_loopback and name \u003d\u003d LOOPBACK_DEVNAME:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FJr0%3D","line":96,"updated":"2013-10-22 12:56:06.000000000","message":"Nit: Length cannot be \u003e 3.","commit_id":"8a843796c57ec66ce24c692c57cbfce271fcb36d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"05dc605359151e0b3420ba5ac0bfb54088446d8b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            if \u0027\u003c\u0027 not in line:"},{"line_number":94,"context_line":"                continue"},{"line_number":95,"context_line":"            tokens \u003d line.split(\u0027:\u0027, 2)"},{"line_number":96,"context_line":"            if len(tokens) \u003e\u003d 3:"},{"line_number":97,"context_line":"                name \u003d tokens[1].split(\u0027@\u0027, 1)[0].strip()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                if exclude_loopback and name \u003d\u003d LOOPBACK_DEVNAME:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F9CE%3D","line":96,"in_reply_to":"AAAATH%2F%2FJr0%3D","updated":"2013-10-24 17:11:54.000000000","message":"The comment from Paul It is right, but it is a backport for stable release. \"\u003e\u003d 3\" is harmless, so IMO the patch itself is ready to go and fix issues pointed out should be fixed in master branch.","commit_id":"8a843796c57ec66ce24c692c57cbfce271fcb36d"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"bb45701e4f1dff53447fa5ddee8abea684961bcf","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            if len(tokens) \u003e\u003d 3:"},{"line_number":97,"context_line":"                name \u003d tokens[1].split(\u0027@\u0027, 1)[0].strip()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                if exclude_loopback and name \u003d\u003d LOOPBACK_DEVNAME:"},{"line_number":100,"context_line":"                    continue"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"                retval.append(IPDevice(name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F81g%3D","line":99,"updated":"2013-10-24 17:56:14.000000000","message":"In fact, I found another bug.\nIt\u0027s possible to create interface (veth or tap) with \u0027@\u0027 in name. So, the \u0027@\u0027 is not exclusively used for VLAN interfaces. And it\u0027s possible to create interface with name \u0027lo@deadbeef\u0027, for example.\n\nI don\u0027t find a way to distinguish VLAN interfaces to interfaces with \u0027@\u0027 in their names.","commit_id":"8a843796c57ec66ce24c692c57cbfce271fcb36d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"65445caadc6382003a8f6d400006ba5e65588237","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            if len(tokens) \u003e\u003d 3:"},{"line_number":97,"context_line":"                name \u003d tokens[1].split(\u0027@\u0027, 1)[0].strip()"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"                if exclude_loopback and name \u003d\u003d LOOPBACK_DEVNAME:"},{"line_number":100,"context_line":"                    continue"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"                retval.append(IPDevice(name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FJrk%3D","line":99,"updated":"2013-10-22 12:56:06.000000000","message":"Not part of the change set, but is there a test cases that checks when we have  a name with the @ sign, but it is a loopback (and exclude_loopback is true)?","commit_id":"8a843796c57ec66ce24c692c57cbfce271fcb36d"}]}
