)]}'
{"neutron/db/metering/metering_db.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1830b739a12b4d92528205435b48d9e590c1cfd2","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        for label in labels:"},{"line_number":187,"context_line":"            if label.shared:"},{"line_number":188,"context_line":"                if not routers:"},{"line_number":189,"context_line":"                    routers \u003d l3_obj.Router.get_objects(context)"},{"line_number":190,"context_line":"            else:"},{"line_number":191,"context_line":"                routers \u003d label.routers"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_896ae87d","line":189,"updated":"2017-12-23 01:16:42.000000000","message":"The router you are returning here doesń´t have the router extra attributes: https://github.com/openstack/neutron/blob/master/neutron/objects/router.py#L71. As a consequence, L170 above fails","commit_id":"56c5fd3d7d56c8aadb96be41af682717d740ee1f"},{"author":{"_account_id":26072,"name":"Van Hung Pham","email":"vanhung.pham@outlook.com","username":"hungpv"},"change_message_id":"9a6b14dfab3f301607737dc8ccbe852bf79bae5f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        for label in labels:"},{"line_number":187,"context_line":"            if label.shared:"},{"line_number":188,"context_line":"                if not routers:"},{"line_number":189,"context_line":"                    routers \u003d l3_obj.Router.get_objects(context)"},{"line_number":190,"context_line":"            else:"},{"line_number":191,"context_line":"                routers \u003d label.routers"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_aaf3fe72","line":189,"in_reply_to":"bf8cb3f7_896ae87d","updated":"2017-12-27 05:21:35.000000000","message":"Done","commit_id":"56c5fd3d7d56c8aadb96be41af682717d740ee1f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1830b739a12b4d92528205435b48d9e590c1cfd2","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                rule[\u0027metering_label_id\u0027])"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        if label.shared:"},{"line_number":215,"context_line":"            routers \u003d l3_obj.Router.get_objects(context)"},{"line_number":216,"context_line":"        else:"},{"line_number":217,"context_line":"            routers \u003d label.routers"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_2905dcc2","line":215,"updated":"2017-12-23 01:16:42.000000000","message":"Ditto","commit_id":"56c5fd3d7d56c8aadb96be41af682717d740ee1f"}],"neutron/objects/router.py":[{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"65a3e684fcdd951acdbf67541afcd294c0a19c48","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \u0027gw_port_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":205,"context_line":"        \u0027enable_snat\u0027: obj_fields.BooleanField(default\u003dTrue),"},{"line_number":206,"context_line":"        \u0027flavor_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":207,"context_line":"        \u0027extra_attributes\u0027: obj_fields.ObjectField("},{"line_number":208,"context_line":"            \u0027RouterExtraAttributes\u0027, nullable\u003dTrue),"},{"line_number":209,"context_line":"    }"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_d63067eb","line":207,"updated":"2017-12-27 08:50:52.000000000","message":"Wonder how this is related to the change in metering_db.","commit_id":"79cb924e66b3eb03779f58e43cbdabd1e01c59ae"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"390884184baf7f4e5191644834ea2a3fa65a949f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \u0027gw_port_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":205,"context_line":"        \u0027enable_snat\u0027: obj_fields.BooleanField(default\u003dTrue),"},{"line_number":206,"context_line":"        \u0027flavor_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":207,"context_line":"        \u0027extra_attributes\u0027: obj_fields.ObjectField("},{"line_number":208,"context_line":"            \u0027RouterExtraAttributes\u0027, nullable\u003dTrue),"},{"line_number":209,"context_line":"    }"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_82f43c5d","line":207,"in_reply_to":"9f91af0f_c2c5645d","updated":"2017-12-28 03:50:26.000000000","message":"Got it. Thanks","commit_id":"79cb924e66b3eb03779f58e43cbdabd1e01c59ae"},{"author":{"_account_id":26072,"name":"Van Hung Pham","email":"vanhung.pham@outlook.com","username":"hungpv"},"change_message_id":"eb6cc68d0503ae122e18d18eb8c5a5c6569dd98b","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \u0027gw_port_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":205,"context_line":"        \u0027enable_snat\u0027: obj_fields.BooleanField(default\u003dTrue),"},{"line_number":206,"context_line":"        \u0027flavor_id\u0027: common_types.UUIDField(nullable\u003dTrue),"},{"line_number":207,"context_line":"        \u0027extra_attributes\u0027: obj_fields.ObjectField("},{"line_number":208,"context_line":"            \u0027RouterExtraAttributes\u0027, nullable\u003dTrue),"},{"line_number":209,"context_line":"    }"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f91af0f_c2c5645d","line":207,"in_reply_to":"bf8cb3f7_d63067eb","updated":"2017-12-28 03:05:07.000000000","message":"Hi Hunt Xu,\nIn [1] L189, the router we return needs extra_attributes as \"_make_router_dict\" func in L169 requires \"distributed\" attr.\n\n[1]https://review.openstack.org/#/c/529551/4/neutron/db/metering/metering_db.py","commit_id":"79cb924e66b3eb03779f58e43cbdabd1e01c59ae"}]}