)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2ff2169555334449ffbb7c14c3fc277e89dd7fa7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Backwards compatability is preserved by setting the mode to"},{"line_number":10,"context_line":"\u0027static\u0027 when the attribute is not defined."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements bp dnsmasq-mode-keyword"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5b2313fff5dca1c16ff939fdc4397d7f95ba3ba5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FKIs%3D","line":12,"updated":"2013-10-22 10:24:10.000000000","message":"If the changes addresses a blueprint, be sure to mention them in the commit message using the following syntax:\nblueprint BLUEPRINT\nMore detail can refer https://wiki.openstack.org/wiki/Gerrit_Workflow","commit_id":"c08c707bc858f217d4e6c9e3da65d3a79c6c06c5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     03bea60c (Merge \"NVP: propagate net-gw update to backend\")"},{"line_number":2,"context_line":"Author:     Sean M. Collins \u003csean@coreitpro.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2013-10-16 11:55:24 -0400"},{"line_number":4,"context_line":"Commit:     Sean M. Collins \u003csean_collins2@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-31 01:49:20 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create a new attribute for subnets, to store v6 dhcp options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"AAAAT3%2F%2Ft6o%3D","line":4,"updated":"2014-01-03 00:53:39.000000000","message":"Did you mean to commit with a different email address here?  Probably not a big deal.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"51a1576a6ef50504cbd25cbd165b2878860138aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     03bea60c (Merge \"NVP: propagate net-gw update to backend\")"},{"line_number":2,"context_line":"Author:     Sean M. Collins \u003csean@coreitpro.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2013-10-16 11:55:24 -0400"},{"line_number":4,"context_line":"Commit:     Sean M. Collins \u003csean_collins2@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-31 01:49:20 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create a new attribute for subnets, to store v6 dhcp options"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"AAAAT3%2F%2Fsyg%3D","line":4,"in_reply_to":"AAAAT3%2F%2Ft6o%3D","updated":"2014-01-27 17:37:37.000000000","message":"The work was done while I was still a contractor for Comcast, and subsequent amendments were done after I started as a FTE.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"010958c3815438e69dd28b283665a929392d6785","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":335,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":336,"context_line":"                        cidr.network,"},{"line_number":337,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_mode)[:-1],"},{"line_number":338,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":339,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FKlc%3D","line":337,"updated":"2013-10-22 07:02:10.000000000","message":"I think this need more consider about this implementation, if mode is ra-only/ra-stateless/ra-names, I think we need also to \u0027enable-ra\u0027 in dnsmasq server, so cmd need to add \u0027--enable-ra\u0027 when the mode is  ra-only/ra-stateless/ra-names.","commit_id":"c08c707bc858f217d4e6c9e3da65d3a79c6c06c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"e7d1525caf32aa67e9e5ae549143bbf40968bb7d","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":335,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":336,"context_line":"                        cidr.network,"},{"line_number":337,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_mode)[:-1],"},{"line_number":338,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":339,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FJBA%3D","line":337,"in_reply_to":"AAAATH%2F%2FKlc%3D","updated":"2013-10-22 15:52:09.000000000","message":"Thanks, I will do more research","commit_id":"c08c707bc858f217d4e6c9e3da65d3a79c6c06c5"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"18713d72a2eabd0c1e9abb2e3a0915e2b89fb2e9","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        cmd.append(\u0027--dhcp-lease-max\u003d%d\u0027 %"},{"line_number":344,"context_line":"                   min(possible_leases, self.conf.dnsmasq_lease_max))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        cmd.append(\u0027--conf-file\u003d%s\u0027 % self.conf.dnsmasq_config_file)"},{"line_number":347,"context_line":"        if self.conf.dnsmasq_dns_server:"},{"line_number":348,"context_line":"            cmd.append(\u0027--server\u003d%s\u0027 % self.conf.dnsmasq_dns_server)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F7kA%3D","line":346,"updated":"2013-10-25 02:09:26.000000000","message":"Hi Sean,\nAs I said in Patch 1, need to add \"cmd.append(\u0027--enable-ra\u0027)\" when the mode is ra-only/ra-names/ra-stateless. Please confirm it.","commit_id":"b7433c02451c1417beeb87438f3e816536c5b954"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7123271a6b8721f9c263528457c174692caaaca4","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        cmd.append(\u0027--dhcp-lease-max\u003d%d\u0027 %"},{"line_number":344,"context_line":"                   min(possible_leases, self.conf.dnsmasq_lease_max))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        cmd.append(\u0027--conf-file\u003d%s\u0027 % self.conf.dnsmasq_config_file)"},{"line_number":347,"context_line":"        if self.conf.dnsmasq_dns_server:"},{"line_number":348,"context_line":"            cmd.append(\u0027--server\u003d%s\u0027 % self.conf.dnsmasq_dns_server)"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F7hg%3D","line":346,"in_reply_to":"AAAATn%2F%2F7kA%3D","updated":"2013-10-25 02:34:23.000000000","message":"Will do.","commit_id":"b7433c02451c1417beeb87438f3e816536c5b954"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"d874f82ae27bbb636b2b39a9164f941f7d786804","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":349,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":350,"context_line":"                        cidr.network,"},{"line_number":351,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_modes)[:-1],"},{"line_number":352,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":353,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9inM%3D","line":351,"updated":"2013-12-10 15:07:39.000000000","message":"\u0027,\u0027.join(subnet.dhcp_modes),\n\nwill do the same.","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f327a945913e50b4c37adf994edf3f193ada63a6","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":349,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":350,"context_line":"                        cidr.network,"},{"line_number":351,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_modes)[:-1],"},{"line_number":352,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":353,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9UEc%3D","line":351,"in_reply_to":"AAAATn%2F9inM%3D","updated":"2013-12-12 18:46:40.000000000","message":"Done","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":349,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":350,"context_line":"                        cidr.network,"},{"line_number":351,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_modes)[:-1],"},{"line_number":352,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":353,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2Ft3E%3D","line":351,"updated":"2014-01-03 00:53:39.000000000","message":"Joining with a comma in python is never pretty but maybe something like the following would be a bit more readable:\n\n\u0027,\u0027.join(subnet.dhcp_modes)","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3fcafbcc329649f96884b72b060211eafa0a3aff","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":349,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":350,"context_line":"                        cidr.network,"},{"line_number":351,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_modes)[:-1],"},{"line_number":352,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":353,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FbcY%3D","line":351,"in_reply_to":"AAAAT3%2F%2Ft3E%3D","updated":"2014-01-13 22:33:48.000000000","message":"+1","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"7dca1cd5989d235b16ac90ddba5d66bd207d835f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":349,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":350,"context_line":"                        cidr.network,"},{"line_number":351,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_modes)[:-1],"},{"line_number":352,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":353,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FrUY%3D","line":351,"in_reply_to":"AAAAT3%2F%2Ft3E%3D","updated":"2014-01-09 18:12:27.000000000","message":"+1","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"51a1576a6ef50504cbd25cbd165b2878860138aa","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%ss\u0027 %"},{"line_number":349,"context_line":"                       (set_tag, self._TAG_PREFIX % i,"},{"line_number":350,"context_line":"                        cidr.network,"},{"line_number":351,"context_line":"                        \u0027\u0027.join(\"%s,\" % i for i in subnet.dhcp_modes)[:-1],"},{"line_number":352,"context_line":"                        self.conf.dhcp_lease_duration))"},{"line_number":353,"context_line":"            possible_leases +\u003d cidr.size"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2F7dQ%3D","line":351,"in_reply_to":"AAAAT3%2F%2Ft3E%3D","updated":"2014-01-27 17:37:37.000000000","message":"Done","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        for mode in subnet.dhcp_modes:"},{"line_number":356,"context_line":"            if mode in constants.RA_MODES:"},{"line_number":357,"context_line":"                cmd.append(\u0027--enable-ra\u0027)"},{"line_number":358,"context_line":"                break"},{"line_number":359,"context_line":"        # Cap the limit because creating lots of subnets can inflate"},{"line_number":360,"context_line":"        # this possible lease cap."},{"line_number":361,"context_line":"        cmd.append(\u0027--dhcp-lease-max\u003d%d\u0027 %"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2Ftzk%3D","line":358,"updated":"2014-01-03 00:53:39.000000000","message":"Just throwing this out there.  Take it or leave it:\n\nif any(mode in subnet.dhcp_modes if mode in constants.RA_MODES):\n    cmd.append(\u0027--enable-ra\u0027)\n\nThe any function will stop iteration once one has been found.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"7015f2afa7785a7fd30fc790c9823c852ac371cf","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        for mode in subnet.dhcp_modes:"},{"line_number":356,"context_line":"            if mode in constants.RA_MODES:"},{"line_number":357,"context_line":"                cmd.append(\u0027--enable-ra\u0027)"},{"line_number":358,"context_line":"                break"},{"line_number":359,"context_line":"        # Cap the limit because creating lots of subnets can inflate"},{"line_number":360,"context_line":"        # this possible lease cap."},{"line_number":361,"context_line":"        cmd.append(\u0027--dhcp-lease-max\u003d%d\u0027 %"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2Fo3A%3D","line":358,"in_reply_to":"AAAAT3%2F%2Ftzk%3D","updated":"2014-01-10 08:03:08.000000000","message":"You mean use the following method?\n\nif any(mode in subnet.dhcp_modes for mode in constants.RA_MODES):\ncmd.append(\u0027--enable-ra\u0027)","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3fcafbcc329649f96884b72b060211eafa0a3aff","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        for mode in subnet.dhcp_modes:"},{"line_number":356,"context_line":"            if mode in constants.RA_MODES:"},{"line_number":357,"context_line":"                cmd.append(\u0027--enable-ra\u0027)"},{"line_number":358,"context_line":"                break"},{"line_number":359,"context_line":"        # Cap the limit because creating lots of subnets can inflate"},{"line_number":360,"context_line":"        # this possible lease cap."},{"line_number":361,"context_line":"        cmd.append(\u0027--dhcp-lease-max\u003d%d\u0027 %"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2Fbas%3D","line":358,"in_reply_to":"AAAAT3%2F%2Ftzk%3D","updated":"2014-01-13 22:33:48.000000000","message":"any() is much better choice here","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"51a1576a6ef50504cbd25cbd165b2878860138aa","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        for mode in subnet.dhcp_modes:"},{"line_number":356,"context_line":"            if mode in constants.RA_MODES:"},{"line_number":357,"context_line":"                cmd.append(\u0027--enable-ra\u0027)"},{"line_number":358,"context_line":"                break"},{"line_number":359,"context_line":"        # Cap the limit because creating lots of subnets can inflate"},{"line_number":360,"context_line":"        # this possible lease cap."},{"line_number":361,"context_line":"        cmd.append(\u0027--dhcp-lease-max\u003d%d\u0027 %"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2BXX4%3D","line":358,"in_reply_to":"AAAAUH%2F%2Fbas%3D","updated":"2014-01-27 17:37:37.000000000","message":"Done","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"fb218ec874186346801fc1d0be3698214f94da4c","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":233,"context_line":"    msg \u003d _(\"Invalid DHCP mode: %s\") % \u0027\u0027.join(\u0027,\u0027 % d for d in data)"},{"line_number":234,"context_line":"    for d in data.split(\u0027,\u0027):"},{"line_number":235,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":236,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BzD4%3D","line":233,"updated":"2013-11-20 02:34:06.000000000","message":"you mean the \u0027data\u0027 type should be array? \nFrom neutronclient code change for it in #54250, I just set the data value as string, such as \u0027ra-only, ra-stateless\u0027","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"d874f82ae27bbb636b2b39a9164f941f7d786804","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    msg \u003d _(\"Invalid DHCP mode: %s\") % \u0027\u0027.join(\u0027,\u0027 % d for d in data)"},{"line_number":239,"context_line":"    for d in data.split(\u0027,\u0027):"},{"line_number":240,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9iOA%3D","line":238,"updated":"2013-12-10 15:07:39.000000000","message":"I don\u0027t understand this line - the syntax looks wrong? Is data a list? But the next line it looks like a string. There are no unit tests for this.","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"26cccdd67a55bc0735eefa91d9229417f6f60294","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    msg \u003d _(\"Invalid DHCP mode: %s\") % \u0027\u0027.join(\u0027,\u0027 % d for d in data)"},{"line_number":239,"context_line":"    for d in data.split(\u0027,\u0027):"},{"line_number":240,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9Dww%3D","line":238,"in_reply_to":"AAAATn%2F9OV8%3D","updated":"2013-12-17 08:05:06.000000000","message":"Then why not just pass data to the %s?","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"5982845ad450d2cad90a1c0f753f37e5e1553e4e","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    msg \u003d _(\"Invalid DHCP mode: %s\") % \u0027\u0027.join(\u0027,\u0027 % d for d in data)"},{"line_number":239,"context_line":"    for d in data.split(\u0027,\u0027):"},{"line_number":240,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9OV8%3D","line":238,"in_reply_to":"AAAATn%2F9RS4%3D","updated":"2013-12-13 20:09:30.000000000","message":"python-neutronclient should send it as a JSON array:\n\ndhcp_modes: [\"ra-stateless\", \"ra-names\"]","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"4994f0ebd37c6c43cc4b2ee08830c3f6ea441369","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    msg \u003d _(\"Invalid DHCP mode: %s\") % \u0027\u0027.join(\u0027,\u0027 % d for d in data)"},{"line_number":239,"context_line":"    for d in data.split(\u0027,\u0027):"},{"line_number":240,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9RS4%3D","line":238,"in_reply_to":"AAAATn%2F9UEA%3D","updated":"2013-12-13 09:10:30.000000000","message":"Yes, we can mix multiple V6 modes together, so from neutron client, or rest client, we need to consider the type for this value, from client, for dhcp mode value, is \"[ra-statelss, ra-names]\" is OK, or just \"ra-stateless, ra-names\" is right.","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f327a945913e50b4c37adf994edf3f193ada63a6","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    msg \u003d _(\"Invalid DHCP mode: %s\") % \u0027\u0027.join(\u0027,\u0027 % d for d in data)"},{"line_number":239,"context_line":"    for d in data.split(\u0027,\u0027):"},{"line_number":240,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9UEA%3D","line":238,"in_reply_to":"AAAATn%2F9esU%3D","updated":"2013-12-12 18:46:40.000000000","message":"The model I have was that you could pass in multiple configuration values, because the documentation for dnsmasq states that you can mix multiple V6 modes together.","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"fbcd3b0d617a09ae00ff9da0beb4c1aceaa0957e","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    msg \u003d _(\"Invalid DHCP mode: %s\") % \u0027\u0027.join(\u0027,\u0027 % d for d in data)"},{"line_number":239,"context_line":"    for d in data.split(\u0027,\u0027):"},{"line_number":240,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9esU%3D","line":238,"in_reply_to":"AAAATn%2F9iOA%3D","updated":"2013-12-11 03:50:52.000000000","message":"Yes? Agree with Darragh. \nRebase this codes for support dhcp mode in neutronclient, I found this log will throw error. I think just set this type as string, more clear","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"d43d73677e6bd5b9e5450215cd0e3ab016ee9997","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    if not isinstance(data, list):"},{"line_number":239,"context_line":"        msg \u003d _(\"Invalid data format for dhcp_modes: \u0027%s\u0027\") % data"},{"line_number":240,"context_line":"    msg \u003d _(\"Invalid DHCP modes: %s\") % data"},{"line_number":241,"context_line":"    for d in data:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2Fo90%3D","line":238,"updated":"2014-01-10 07:30:06.000000000","message":"Hi Sean,\nWhen I enabled this function in Neutron Client, I encountered some problem.\nIf set the dhcp-modes type as list in Neutron Client, in db_base_plugin_v2.py, line 1140, it will throw \u0027list not have split method\u0027 error\n\nAlso if set the dhcp-modes type as string(only in Neutron Client)\nthe line 238, it also will throw error\n\nBase on test, I prefer we should set the dhcp-modes type as string in neutron client, not is list. Just like: \u0027ra-stateless, ra-names\u0027 or \u0027ra-only\u0027. \nWhat do you think? I have tested it","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    if not isinstance(data, list):"},{"line_number":239,"context_line":"        msg \u003d _(\"Invalid data format for dhcp_modes: \u0027%s\u0027\") % data"},{"line_number":240,"context_line":"    msg \u003d _(\"Invalid DHCP modes: %s\") % data"},{"line_number":241,"context_line":"    for d in data:"},{"line_number":242,"context_line":"        if d not in constants.DHCP_MODES:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2FtzI%3D","line":239,"updated":"2014-01-03 00:53:39.000000000","message":"Shouldn\u0027t this return right here?  You set msg and then you set it again in the next line.\n\nAlso, why not just return _(\"...\") % data directly.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"51a1576a6ef50504cbd25cbd165b2878860138aa","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    if not isinstance(data, list):"},{"line_number":239,"context_line":"        msg \u003d _(\"Invalid data format for dhcp_modes: \u0027%s\u0027\") % data"},{"line_number":240,"context_line":"    msg \u003d _(\"Invalid DHCP modes: %s\") % data"},{"line_number":241,"context_line":"    for d in data:"},{"line_number":242,"context_line":"        if d not in constants.DHCP_MODES:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2BXWM%3D","line":239,"in_reply_to":"AAAAT3%2F%2FtzI%3D","updated":"2014-01-27 17:37:37.000000000","message":"Done","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    if not isinstance(data, list):"},{"line_number":239,"context_line":"        msg \u003d _(\"Invalid data format for dhcp_modes: \u0027%s\u0027\") % data"},{"line_number":240,"context_line":"    msg \u003d _(\"Invalid DHCP modes: %s\") % data"},{"line_number":241,"context_line":"    for d in data:"},{"line_number":242,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":243,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2Fty8%3D","line":240,"updated":"2014-01-03 00:53:39.000000000","message":"Don\u0027t construct this string until you know you need to return it.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"51a1576a6ef50504cbd25cbd165b2878860138aa","unresolved":false,"context_lines":[{"line_number":237,"context_line":"def _validate_dhcp_modes(data, valid_values\u003dNone):"},{"line_number":238,"context_line":"    if not isinstance(data, list):"},{"line_number":239,"context_line":"        msg \u003d _(\"Invalid data format for dhcp_modes: \u0027%s\u0027\") % data"},{"line_number":240,"context_line":"    msg \u003d _(\"Invalid DHCP modes: %s\") % data"},{"line_number":241,"context_line":"    for d in data:"},{"line_number":242,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":243,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2BXWQ%3D","line":240,"in_reply_to":"AAAAT3%2F%2Fty8%3D","updated":"2014-01-27 17:37:37.000000000","message":"Done","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"1521daa87335d96b893a9a3d5742385590d40792","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    for d in data:"},{"line_number":242,"context_line":"        if d not in constants.DHCP_MODES:"},{"line_number":243,"context_line":"            return msg"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"def _validate_hostroutes(data, valid_values\u003dNone):"},{"line_number":247,"context_line":"    if not isinstance(data, list):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2F%2BBs%3D","line":244,"updated":"2014-01-06 03:18:33.000000000","message":"I think we should also validate if the combination of dhcp modes makes sense. For example: ra-only and ra-stateless should not be passed to dnsmasq at the same time. ra-names can be combined with ra-stateless and slaac, etc.. \n\nWe haven\u0027t test which exact combinations work or not, but just want to point out it will be good to have such kind of validation to prevent unknown state of dnsmasq.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"8ebbdf042684b5a51c97ec01d4d0aa9b6c86e86d","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def _validate_ipv6_modes(data, valid_values\u003dNone):"},{"line_number":251,"context_line":"    msg \u003d _validate_string(data, valid_values)"},{"line_number":252,"context_line":"    if msg:"},{"line_number":253,"context_line":"        return msg"},{"line_number":254,"context_line":"    if data not in constants.IPV6_MODES:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F95HY%3D","line":251,"updated":"2014-02-02 07:01:45.000000000","message":"We should not pass validate_values to _validate_string since the second parameter is max_len\n\n\tdef _validate_string(data, max_len\u003dNone):\n\nMaybe just passing None?","commit_id":"89fd3a7561f771fa0e567307b39a33dc5c64cbcc"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"fe610097d8f1ef256b33eb4b95e80697a0ab8d52","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def _validate_ipv6_modes(data, valid_values\u003dNone):"},{"line_number":251,"context_line":"    msg \u003d _validate_string(data, valid_values)"},{"line_number":252,"context_line":"    if msg:"},{"line_number":253,"context_line":"        return msg"},{"line_number":254,"context_line":"    if data not in constants.IPV6_MODES:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F90g4%3D","line":251,"in_reply_to":"AAAAUH%2F95HY%3D","updated":"2014-02-03 16:38:35.000000000","message":"Good catch - thanks.","commit_id":"89fd3a7561f771fa0e567307b39a33dc5c64cbcc"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"8ebbdf042684b5a51c97ec01d4d0aa9b6c86e86d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    if msg:"},{"line_number":253,"context_line":"        return msg"},{"line_number":254,"context_line":"    if data not in constants.IPV6_MODES:"},{"line_number":255,"context_line":"        return _(\"Invalid IPv6 attribute: %s\") % data"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"def _validate_hostroutes(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F95HQ%3D","line":255,"updated":"2014-02-02 07:01:45.000000000","message":"should add log the return message in debug mode.","commit_id":"89fd3a7561f771fa0e567307b39a33dc5c64cbcc"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"fe610097d8f1ef256b33eb4b95e80697a0ab8d52","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    if msg:"},{"line_number":253,"context_line":"        return msg"},{"line_number":254,"context_line":"    if data not in constants.IPV6_MODES:"},{"line_number":255,"context_line":"        return _(\"Invalid IPv6 attribute: %s\") % data"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"def _validate_hostroutes(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F90go%3D","line":255,"in_reply_to":"AAAAUH%2F95HQ%3D","updated":"2014-02-03 16:38:35.000000000","message":"Done","commit_id":"89fd3a7561f771fa0e567307b39a33dc5c64cbcc"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"cd100aa7e47c0bbbafb8bde16debc1412aa80959","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    if data not in constants.IPV6_MODES:"},{"line_number":255,"context_line":"        msg \u003d _(\"Invalid IPv6 attribute: %s\") % data"},{"line_number":256,"context_line":"        LOG.debug(msg)"},{"line_number":257,"context_line":"        return msg"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"def _validate_hostroutes(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUX%2F%2F13U%3D","line":257,"updated":"2014-02-10 13:36:11.000000000","message":"As we talked in last meeting, may need to add other mode validations besides the invalid attribute check. \nFor example, if enable_dhcp is set to false at the same time as ipv6 modes are specified, it will be a better user experience to prompt some error messages saying this is not a valid combination or at least log it. \n\nI remember we need an email discussion on this topic from last meeting.","commit_id":"ab2ce1d72aeffe2268be5d23368eb833f01b0371"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7e0c6c53f4981b37303080dd92f70757a70282a0","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    if data not in constants.IPV6_MODES:"},{"line_number":255,"context_line":"        msg \u003d _(\"Invalid IPv6 attribute: %s\") % data"},{"line_number":256,"context_line":"        LOG.debug(msg)"},{"line_number":257,"context_line":"        return msg"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"def _validate_hostroutes(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUX%2F%2FXcE%3D","line":257,"in_reply_to":"AAAAUX%2F%2F13U%3D","updated":"2014-02-13 17:37:25.000000000","message":"I\u0027ll start a thread on the ML - the one thing about using enable_dhcp as a kill switch is that we have provider networks that announce RAs, so we\u0027d have enable_dhcp set to false, addressing set to SLAAC and ra_mode probably not set.","commit_id":"ab2ce1d72aeffe2268be5d23368eb833f01b0371"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                        \u0027default\u0027: True,"},{"line_number":709,"context_line":"                        \u0027convert_to\u0027: convert_to_boolean,"},{"line_number":710,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":711,"context_line":"        \u0027ipv6_ra_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":712,"context_line":"                         \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":713,"context_line":"                         \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":714,"context_line":"                         \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Bvk8%3D","line":711,"updated":"2014-02-19 11:46:13.000000000","message":"I could not find a reason for allow_put\u003dFalse\n\nCan you elaborate?","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":711,"context_line":"        \u0027ipv6_ra_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":712,"context_line":"                         \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":713,"context_line":"                         \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":714,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":715,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":716,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2BvkA%3D","line":713,"updated":"2014-02-19 11:46:13.000000000","message":"From the design discussion it seems that it should be possible to set both the new attributes to OFF.\nIt seems that we are assuming that a missing attribute in the request means it will be set to off (or to be more precise, Null in the DB). However, this won\u0027t play well with neutron API update semantics if PUTs will be eventually enabled, so I\u0027d allow also the null value to be passed to the API (currently the code will fail to validate if either attribute is null)","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bfe2b5c35b05059cd7b1d0c57c29ff670ffcdc0a","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":711,"context_line":"        \u0027ipv6_ra_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":712,"context_line":"                         \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":713,"context_line":"                         \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":714,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":715,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":716,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAU3%2F%2F0M8%3D","line":713,"in_reply_to":"AAAAUX%2F%2BvkA%3D","updated":"2014-02-24 17:00:46.000000000","message":"Yes - there has been some miscommunication. When people say \"OFF\" they mean that the attributes are not set.","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"b611e587ae3e7bd79ec99f8f7b5707e794f092fb","unresolved":false,"context_lines":[{"line_number":712,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":713,"context_line":"        \u0027ipv6_ra_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":714,"context_line":"                         \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":715,"context_line":"                         \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":716,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":717,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":718,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2Fo9k%3D","line":715,"updated":"2014-03-04 22:18:13.000000000","message":"\u0027validate\u0027: {\u0027type:values\u0027: constants.IPV6_MODES}","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"b611e587ae3e7bd79ec99f8f7b5707e794f092fb","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":717,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":718,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":719,"context_line":"                              \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":720,"context_line":"                              \u0027is_visible\u0027: True},"},{"line_number":721,"context_line":"        SHARED: {\u0027allow_post\u0027: False,"},{"line_number":722,"context_line":"                 \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2Fo9I%3D","line":719,"updated":"2014-03-04 22:18:13.000000000","message":"(Draft)\t\tDraft saved at 5:15 PM\n\u0027validate\u0027: {\u0027type:values\u0027: constants.IPV6_MODES}","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    if data not in constants.IPV6_MODES:"},{"line_number":261,"context_line":"        msg \u003d _(\"Invalid IPv6 attribute: %s\") % data"},{"line_number":262,"context_line":"        LOG.debug(msg)"},{"line_number":263,"context_line":"        return msg"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def _validate_hostroutes(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa4I%3D","line":263,"updated":"2014-03-06 07:22:37.000000000","message":"I think we don\u0027t need to define a new validator.\nwe can use _validate_values() above. Please see my comment below too.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    if data not in constants.IPV6_MODES:"},{"line_number":261,"context_line":"        msg \u003d _(\"Invalid IPv6 attribute: %s\") % data"},{"line_number":262,"context_line":"        LOG.debug(msg)"},{"line_number":263,"context_line":"        return msg"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def _validate_hostroutes(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTyU%3D","line":263,"in_reply_to":"AAAAVn%2F%2Fa4I%3D","updated":"2014-03-06 22:33:16.000000000","message":"Done","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":733,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":734,"context_line":"        \u0027ipv6_ra_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":735,"context_line":"                         \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":736,"context_line":"                         \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":737,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":738,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":739,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa38%3D","line":736,"updated":"2014-03-06 07:22:37.000000000","message":"We can use type:values instead:\n\n  {\u0027type:values\u0027: constants.IPV6_MODES}","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":733,"context_line":"                        \u0027is_visible\u0027: True},"},{"line_number":734,"context_line":"        \u0027ipv6_ra_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":735,"context_line":"                         \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":736,"context_line":"                         \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":737,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":738,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":739,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTyA%3D","line":736,"in_reply_to":"AAAAVn%2F%2Fa38%3D","updated":"2014-03-06 22:33:16.000000000","message":"Done","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":738,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":739,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":740,"context_line":"                              \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":741,"context_line":"                              \u0027is_visible\u0027: True},"},{"line_number":742,"context_line":"        SHARED: {\u0027allow_post\u0027: False,"},{"line_number":743,"context_line":"                 \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa3w%3D","line":740,"updated":"2014-03-06 07:22:37.000000000","message":"Same as the above.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":738,"context_line":"        \u0027ipv6_address_mode\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":739,"context_line":"                              \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":740,"context_line":"                              \u0027validate\u0027: {\u0027type:ipv6_modes\u0027: None},"},{"line_number":741,"context_line":"                              \u0027is_visible\u0027: True},"},{"line_number":742,"context_line":"        SHARED: {\u0027allow_post\u0027: False,"},{"line_number":743,"context_line":"                 \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTx4%3D","line":740,"in_reply_to":"AAAAVn%2F%2Fa3w%3D","updated":"2014-03-06 22:33:16.000000000","message":"Done","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"}],"neutron/common/constants.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"010958c3815438e69dd28b283665a929392d6785","unresolved":false,"context_lines":[{"line_number":96,"context_line":"DHCP_MODE_STATIC \u003d \u0027static\u0027"},{"line_number":97,"context_line":"DHCP_V6_MODE_RAONLY \u003d \u0027ra-only\u0027"},{"line_number":98,"context_line":"DHCP_V6_MODE_SLAAC \u003d \u0027slaac\u0027"},{"line_number":99,"context_line":"DHCP_V6_MODE_RANAME \u003d \u0027ra-nameservers\u0027"},{"line_number":100,"context_line":"DHCP_V6_MODE_RASTATELESS \u003d \u0027ra-stateless\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"DHCP_MODES \u003d [DHCP_MODE_STATIC, DHCP_V6_MODE_RAONLY,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FKlE%3D","line":99,"updated":"2013-10-22 07:02:10.000000000","message":"Should be \u0027ra-names\u0027, base on http://www.thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html","commit_id":"c08c707bc858f217d4e6c9e3da65d3a79c6c06c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"e7d1525caf32aa67e9e5ae549143bbf40968bb7d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"DHCP_MODE_STATIC \u003d \u0027static\u0027"},{"line_number":97,"context_line":"DHCP_V6_MODE_RAONLY \u003d \u0027ra-only\u0027"},{"line_number":98,"context_line":"DHCP_V6_MODE_SLAAC \u003d \u0027slaac\u0027"},{"line_number":99,"context_line":"DHCP_V6_MODE_RANAME \u003d \u0027ra-nameservers\u0027"},{"line_number":100,"context_line":"DHCP_V6_MODE_RASTATELESS \u003d \u0027ra-stateless\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"DHCP_MODES \u003d [DHCP_MODE_STATIC, DHCP_V6_MODE_RAONLY,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FI%2Fo%3D","line":99,"in_reply_to":"AAAATH%2F%2FKlE%3D","updated":"2013-10-22 15:52:09.000000000","message":"Oops. Thanks for the double check.","commit_id":"c08c707bc858f217d4e6c9e3da65d3a79c6c06c5"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"9e54b4b39fd96b33e5f4e93571b23b9a937627b4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"PROTO_NUM_ICMP_V6 \u003d 58"},{"line_number":94,"context_line":"PROTO_NUM_UDP \u003d 17"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"DHCP_MODE_STATIC \u003d \u0027static\u0027"},{"line_number":97,"context_line":"DHCP_V6_MODE_RAONLY \u003d \u0027ra-only\u0027"},{"line_number":98,"context_line":"DHCP_V6_MODE_SLAAC \u003d \u0027slaac\u0027"},{"line_number":99,"context_line":"DHCP_V6_MODE_RANAME \u003d \u0027ra-names\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B0Do%3D","line":96,"updated":"2013-11-19 19:58:37.000000000","message":"Should a comment be added here to indicate that static will be the default mode?\n\nMaybe something as simple as\n# DHCP modes for the Subnet.  If not specified, defaults to static.\n\nI believe this will also need a change to this document once this is integrated: http://docs.openstack.org/api/openstack-network/2.0/content/Concepts-d1e369.html#subnet","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"d874f82ae27bbb636b2b39a9164f941f7d786804","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              DHCP_V6_MODE_RAONLY, DHCP_V6_MODE_RANAME,"},{"line_number":114,"context_line":"              DHCP_V6_MODE_RASTATELESS]"},{"line_number":115,"context_line":"DHCP_v6_MODES \u003d DHCP_MODES[1:]"},{"line_number":116,"context_line":"RA_MODES \u003d DHCP_v6_MODES[1:]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9h9s%3D","line":116,"updated":"2013-12-10 15:07:39.000000000","message":"should this be DHCP_RA_MODES as it is specific to dhcp.","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f327a945913e50b4c37adf994edf3f193ada63a6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              DHCP_V6_MODE_RAONLY, DHCP_V6_MODE_RANAME,"},{"line_number":114,"context_line":"              DHCP_V6_MODE_RASTATELESS]"},{"line_number":115,"context_line":"DHCP_v6_MODES \u003d DHCP_MODES[1:]"},{"line_number":116,"context_line":"RA_MODES \u003d DHCP_v6_MODES[1:]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9UD0%3D","line":116,"in_reply_to":"AAAATn%2F9h9s%3D","updated":"2013-12-12 18:46:40.000000000","message":"Done","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              DHCP_V6_MODE_RAONLY, DHCP_V6_MODE_RANAME,"},{"line_number":114,"context_line":"              DHCP_V6_MODE_RASTATELESS]"},{"line_number":115,"context_line":"DHCP_v6_MODES \u003d DHCP_MODES[1:]"},{"line_number":116,"context_line":"RA_MODES \u003d DHCP_v6_MODES[1:]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2FtyQ%3D","line":116,"updated":"2014-01-03 00:53:39.000000000","message":"Suggestion for readability and maintainability:\n\nRA_MODES \u003d [DHCP_V6_MODE_RAONLY,\n            DHCP_V6_MODE_RANAME,\n            DHCP_V6_MODE_RASTATELESS]\nDHCP_v6_MODES \u003d [DHCP_V6_MODE_SLAAC] + RA_MODES\nDHCP_MODES \u003d [DHCP_MODE_STATIC] + DHCP_v6_MODES","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"51a1576a6ef50504cbd25cbd165b2878860138aa","unresolved":false,"context_lines":[{"line_number":113,"context_line":"              DHCP_V6_MODE_RAONLY, DHCP_V6_MODE_RANAME,"},{"line_number":114,"context_line":"              DHCP_V6_MODE_RASTATELESS]"},{"line_number":115,"context_line":"DHCP_v6_MODES \u003d DHCP_MODES[1:]"},{"line_number":116,"context_line":"RA_MODES \u003d DHCP_v6_MODES[1:]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2BXWI%3D","line":116,"in_reply_to":"AAAAT3%2F%2FtyQ%3D","updated":"2014-01-27 17:37:37.000000000","message":"Done","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"1354b40786b61564b2b06426e614e6725614e9d0","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"DHCPV6_STATEFUL \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":107,"context_line":"DHCPV6_STATELESS \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":108,"context_line":"IPV6_SLAAC \u003d \u0027slaac\u0027"},{"line_number":109,"context_line":"IPV6_MODES \u003d [DHCPV6_STATEFUL, DHCPV6_STATELESS, IPV6_SLAAC]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUX%2F%2FGiQ%3D","line":108,"updated":"2014-02-17 05:30:57.000000000","message":"Should have \"off\" keyword for dhcpv6 property","commit_id":"ab2ce1d72aeffe2268be5d23368eb833f01b0371"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"a8d885f7641e07e98eff22defa90109565408d9a","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"DHCPV6_STATEFUL \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":107,"context_line":"DHCPV6_STATELESS \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":108,"context_line":"IPV6_SLAAC \u003d \u0027slaac\u0027"},{"line_number":109,"context_line":"IPV6_MODES \u003d [DHCPV6_STATEFUL, DHCPV6_STATELESS, IPV6_SLAAC]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUX%2F%2FC0A%3D","line":108,"in_reply_to":"AAAAUX%2F%2FGfI%3D","updated":"2014-02-17 13:31:58.000000000","message":"+1 for ATTR_NOT_SPECIFIED means \"off\" - we save it a NULL in the database.","commit_id":"ab2ce1d72aeffe2268be5d23368eb833f01b0371"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"e5d15968d77be4b5f2471f2366f4daf4eeded13b","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"DHCPV6_STATEFUL \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":107,"context_line":"DHCPV6_STATELESS \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":108,"context_line":"IPV6_SLAAC \u003d \u0027slaac\u0027"},{"line_number":109,"context_line":"IPV6_MODES \u003d [DHCPV6_STATEFUL, DHCPV6_STATELESS, IPV6_SLAAC]"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAUX%2F%2FGfI%3D","line":108,"in_reply_to":"AAAAUX%2F%2FGiQ%3D","updated":"2014-02-17 05:40:05.000000000","message":"Da Zhao, I think the default ATTR_NOT_SPECIFIED equals \"off\"","commit_id":"ab2ce1d72aeffe2268be5d23368eb833f01b0371"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"08f7b0d07886e9868c195eb72ea09a05fd8c25c7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"DHCPV6_STATEFUL \u003d \u0027dhcpv6-stateful\u0027"},{"line_number":114,"context_line":"DHCPV6_STATELESS \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":115,"context_line":"IPV6_SLAAC \u003d \u0027slaac\u0027"},{"line_number":116,"context_line":"IPV6_MODES \u003d [DHCPV6_STATEFUL, DHCPV6_STATELESS, IPV6_SLAAC]"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2FCUs%3D","line":116,"updated":"2014-03-10 14:38:33.000000000","message":"The specification also included a possible \u0027off\u0027 state for ra_mode and address_mode. Is this translated as ATTR_NOT_SPECIFIED?\n\nIf the above is correct then something like\n\n\u0027ipv6_address_mode\u0027 : null\n\nshould case the same effect as \u0027off\u0027 in the spec, and should be allowed when enable_dhcp is set to False (see other comments on validation routines)","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"010958c3815438e69dd28b283665a929392d6785","unresolved":false,"context_lines":[{"line_number":1120,"context_line":"                                               s[\u0027allocation_pools\u0027])"},{"line_number":1121,"context_line":"        if (s[\u0027ip_version\u0027] \u003d\u003d 4 or"},{"line_number":1122,"context_line":"                s[\u0027dhcp_mode\u0027] is attributes.ATTR_NOT_SPECIFIED):"},{"line_number":1123,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode(mode\u003dconstants.DHCP_MODE_STATIC)]"},{"line_number":1124,"context_line":"        else:"},{"line_number":1125,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode(mode\u003dmode_s) for"},{"line_number":1126,"context_line":"                              mode_s in s[\u0027dhcp_mode\u0027].split(\u0027,\u0027)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FKmE%3D","line":1123,"updated":"2013-10-22 07:02:10.000000000","message":"E501 line too long and cause pep8 failed","commit_id":"c08c707bc858f217d4e6c9e3da65d3a79c6c06c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"e7d1525caf32aa67e9e5ae549143bbf40968bb7d","unresolved":false,"context_lines":[{"line_number":1120,"context_line":"                                               s[\u0027allocation_pools\u0027])"},{"line_number":1121,"context_line":"        if (s[\u0027ip_version\u0027] \u003d\u003d 4 or"},{"line_number":1122,"context_line":"                s[\u0027dhcp_mode\u0027] is attributes.ATTR_NOT_SPECIFIED):"},{"line_number":1123,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode(mode\u003dconstants.DHCP_MODE_STATIC)]"},{"line_number":1124,"context_line":"        else:"},{"line_number":1125,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode(mode\u003dmode_s) for"},{"line_number":1126,"context_line":"                              mode_s in s[\u0027dhcp_mode\u0027].split(\u0027,\u0027)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FI%2Fk%3D","line":1123,"in_reply_to":"AAAATH%2F%2FKmE%3D","updated":"2013-10-22 15:52:09.000000000","message":"Done","commit_id":"c08c707bc858f217d4e6c9e3da65d3a79c6c06c5"},{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"fb218ec874186346801fc1d0be3698214f94da4c","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                                               s[\u0027allocation_pools\u0027])"},{"line_number":1132,"context_line":"        if not s[\u0027enable_dhcp\u0027]:"},{"line_number":1133,"context_line":"            # No need to populate dhcp_mode if dhcp is disabled"},{"line_number":1134,"context_line":"            pass"},{"line_number":1135,"context_line":"        elif (s[\u0027ip_version\u0027] \u003d\u003d 4 and s[\u0027enable_dhcp\u0027] or"},{"line_number":1136,"context_line":"                s[\u0027dhcp_mode\u0027] is attributes.ATTR_NOT_SPECIFIED):"},{"line_number":1137,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BzEM%3D","line":1134,"updated":"2013-11-20 02:34:06.000000000","message":"Hi Sean,\n\nI don\u0027t think dhcp_mode should be impacted by enable_dhcp. when \u0027enable_dhcp\u0027 is false, it just mean the dhcp service is disabled, we can also set dhcp_mode value. So when the dhcp service is up, we still can use dhcp_mode.","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"3de21320ea57b253e6bec37e6a24bd3579b37ad7","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                                               s[\u0027allocation_pools\u0027])"},{"line_number":1132,"context_line":"        if not s[\u0027enable_dhcp\u0027]:"},{"line_number":1133,"context_line":"            # No need to populate dhcp_mode if dhcp is disabled"},{"line_number":1134,"context_line":"            pass"},{"line_number":1135,"context_line":"        elif (s[\u0027ip_version\u0027] \u003d\u003d 4 and s[\u0027enable_dhcp\u0027] or"},{"line_number":1136,"context_line":"                s[\u0027dhcp_mode\u0027] is attributes.ATTR_NOT_SPECIFIED):"},{"line_number":1137,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2ByXc%3D","line":1134,"in_reply_to":"AAAATn%2F%2BzEM%3D","updated":"2013-11-20 08:00:28.000000000","message":"If we are not populate dhcp_mode if dhcp is disabled, at least we should let the user know about this. e.g. prompting an error message.","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"9e54b4b39fd96b33e5f4e93571b23b9a937627b4","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode(mode\u003dmode_s) for"},{"line_number":1141,"context_line":"                              mode_s in s[\u0027dhcp_mode\u0027].split(\u0027,\u0027)]"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        self._validate_subnet(context, s)"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, s)"},{"line_number":1146,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B0Ak%3D","line":1143,"updated":"2013-11-19 19:58:37.000000000","message":"I\u0027m thinking that a check should be added to _validate_subnet to verify that the dhcp_mode is correct for the IP Address type.  \n\nExample: We do not want to allow users of IPv4 address types to be able to specify a IPv6 DHCP mode (and vice versa)","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"13d67c5555c5e35ed32ce4a056033f5c07a3cd59","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode(mode\u003dmode_s) for"},{"line_number":1141,"context_line":"                              mode_s in s[\u0027dhcp_mode\u0027].split(\u0027,\u0027)]"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        self._validate_subnet(context, s)"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, s)"},{"line_number":1146,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Bz8Q%3D","line":1143,"in_reply_to":"AAAATn%2F%2B0Ak%3D","updated":"2013-11-19 20:30:37.000000000","message":"The logic on L1132 is a bit.... awkward, but I was planning to just assign static, regardless of what the user tries to specify, when it\u0027s a v4 subnet. Keep an eye on this space, when I clean up the logic to make it less WTF.","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"3de21320ea57b253e6bec37e6a24bd3579b37ad7","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"            s[\u0027dhcp_mode\u0027] \u003d [models_v2.DhcpMode(mode\u003dmode_s) for"},{"line_number":1141,"context_line":"                              mode_s in s[\u0027dhcp_mode\u0027].split(\u0027,\u0027)]"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"        self._validate_subnet(context, s)"},{"line_number":1144,"context_line":""},{"line_number":1145,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, s)"},{"line_number":1146,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2ByXw%3D","line":1143,"in_reply_to":"AAAATn%2F%2Bz8Q%3D","updated":"2013-11-20 08:00:28.000000000","message":"I would prefer Drew\u0027s comment to prompt some kind of error to the end user when mode other than static is specified for IPv6 address. It\u0027s more user friendly from usage perspective.","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"d874f82ae27bbb636b2b39a9164f941f7d786804","unresolved":false,"context_lines":[{"line_number":903,"context_line":"                                    for pool in subnet[\u0027allocation_pools\u0027]],"},{"line_number":904,"context_line":"               \u0027gateway_ip\u0027: subnet[\u0027gateway_ip\u0027],"},{"line_number":905,"context_line":"               \u0027enable_dhcp\u0027: subnet[\u0027enable_dhcp\u0027],"},{"line_number":906,"context_line":"               \u0027dhcp_modes\u0027: [mode[\u0027mode\u0027] for mode in subnet[\u0027dhcp_modes\u0027]],"},{"line_number":907,"context_line":"               \u0027dns_nameservers\u0027: [dns[\u0027address\u0027]"},{"line_number":908,"context_line":"                                   for dns in subnet[\u0027dns_nameservers\u0027]],"},{"line_number":909,"context_line":"               \u0027host_routes\u0027: [{\u0027destination\u0027: route[\u0027destination\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9iKM%3D","line":906,"updated":"2013-12-10 15:07:39.000000000","message":"I though subnet[\u0027dhcp_modes\u0027] was a list of strings, not a list of dicts.","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f327a945913e50b4c37adf994edf3f193ada63a6","unresolved":false,"context_lines":[{"line_number":903,"context_line":"                                    for pool in subnet[\u0027allocation_pools\u0027]],"},{"line_number":904,"context_line":"               \u0027gateway_ip\u0027: subnet[\u0027gateway_ip\u0027],"},{"line_number":905,"context_line":"               \u0027enable_dhcp\u0027: subnet[\u0027enable_dhcp\u0027],"},{"line_number":906,"context_line":"               \u0027dhcp_modes\u0027: [mode[\u0027mode\u0027] for mode in subnet[\u0027dhcp_modes\u0027]],"},{"line_number":907,"context_line":"               \u0027dns_nameservers\u0027: [dns[\u0027address\u0027]"},{"line_number":908,"context_line":"                                   for dns in subnet[\u0027dns_nameservers\u0027]],"},{"line_number":909,"context_line":"               \u0027host_routes\u0027: [{\u0027destination\u0027: route[\u0027destination\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9UCc%3D","line":906,"in_reply_to":"AAAATn%2F9iKM%3D","updated":"2013-12-12 18:46:40.000000000","message":"In this part of the code, subnet is a SQLAlchemy object, and dhcp_modes is a collection of DhcpMode objects.","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"26cccdd67a55bc0735eefa91d9229417f6f60294","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"                                   mode\u003dconstants.DHCP_MODE_STATIC)]"},{"line_number":1138,"context_line":"            elif s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1139,"context_line":"                s[\u0027dhcp_modes\u0027] \u003d [models_v2.DhcpMode(mode\u003dmode_s) for"},{"line_number":1140,"context_line":"                                   mode_s in s[\u0027dhcp_modes\u0027].split(\u0027,\u0027)]"},{"line_number":1141,"context_line":"        else:"},{"line_number":1142,"context_line":"            s[\u0027dhcp_modes\u0027] \u003d []"},{"line_number":1143,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9DoE%3D","line":1140,"updated":"2013-12-17 08:05:06.000000000","message":"Need unit test with multiple dhcp_modes to cover this path. \nFor example: dhcp_modes \u003d \"ra-stateless, ra-names\" in test_linux_dhcp.py","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7c822b2ecda0f08d4fde9811bdff86c392735cdc","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"                                   mode\u003dconstants.DHCP_MODE_STATIC)]"},{"line_number":1138,"context_line":"            elif s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1139,"context_line":"                s[\u0027dhcp_modes\u0027] \u003d [models_v2.DhcpMode(mode\u003dmode_s) for"},{"line_number":1140,"context_line":"                                   mode_s in s[\u0027dhcp_modes\u0027].split(\u0027,\u0027)]"},{"line_number":1141,"context_line":"        else:"},{"line_number":1142,"context_line":"            s[\u0027dhcp_modes\u0027] \u003d []"},{"line_number":1143,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F8%2F8c%3D","line":1140,"updated":"2013-12-17 21:22:51.000000000","message":"Will be updating this to take a JSON array from the client","commit_id":"e8f37087c50d6f10d7532c922caf133275c31175"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3fcafbcc329649f96884b72b060211eafa0a3aff","unresolved":false,"context_lines":[{"line_number":903,"context_line":"                                    for pool in subnet[\u0027allocation_pools\u0027]],"},{"line_number":904,"context_line":"               \u0027gateway_ip\u0027: subnet[\u0027gateway_ip\u0027],"},{"line_number":905,"context_line":"               \u0027enable_dhcp\u0027: subnet[\u0027enable_dhcp\u0027],"},{"line_number":906,"context_line":"               \u0027dhcp_modes\u0027: [mode[\u0027mode\u0027] for mode in subnet[\u0027dhcp_modes\u0027]],"},{"line_number":907,"context_line":"               \u0027dns_nameservers\u0027: [dns[\u0027address\u0027]"},{"line_number":908,"context_line":"                                   for dns in subnet[\u0027dns_nameservers\u0027]],"},{"line_number":909,"context_line":"               \u0027host_routes\u0027: [{\u0027destination\u0027: route[\u0027destination\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FbJA%3D","line":906,"updated":"2014-01-13 22:33:48.000000000","message":"Not sure why this should be a list.  Seems like we\u0027re setting ourselves up for trouble down the road.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f08f1941c7e6f00c5720d75fa6b2167599c38d87","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1156,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1157,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1158,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"},{"line_number":1159,"context_line":"            subnet \u003d models_v2.Subnet(**args)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"            context.session.add(subnet)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F9%2Fr4%3D","line":1158,"updated":"2014-01-31 07:52:39.000000000","message":"Why do you put this defaults here, instead of up, where the s[\u0027gateway_ip\u0027] s[\u0027allocation_pools\u0027] defaults are set outside the transaction block?.\n\nThis function is growing too much, may be the block above can also be refactored, setting the gw validation logic to _validate_subnet and the subnet default settings to _set_subnet_defaults or equivalent.","commit_id":"49b7edfdc7eb84641396418981d7dafed7ccf372"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"923b13b8b7813b4a0fcd919eea76b5ccb572cf02","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1156,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1157,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1158,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"},{"line_number":1159,"context_line":"            subnet \u003d models_v2.Subnet(**args)"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"            context.session.add(subnet)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F99xE%3D","line":1158,"in_reply_to":"AAAAUH%2F9%2Fr4%3D","updated":"2014-01-31 15:51:26.000000000","message":"The default value for these attributes in the API is ATTR_NOT_SPECIFIED and NULL in the database, so it\u0027s only in the case where the attributes have been set that we need to populate them in the Subnet object, and hence the database.\n\nI will look into the possibility of refactoring to keep this function from growing.","commit_id":"49b7edfdc7eb84641396418981d7dafed7ccf372"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1123,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1124,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1125,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"},{"line_number":1126,"context_line":"            subnet \u003d models_v2.Subnet(**args)"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"            context.session.add(subnet)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Bvmc%3D","line":1125,"updated":"2014-02-19 11:46:13.000000000","message":"Is there a need for checking invalid combination of address_mode and ra_mode.\nI\u0027m Far from being an expert on the matter.\nHowever, in the design information exchanged over the mailing list it seems that, for instance, when using SLAAC both ra_mode and address_mode should be set to SLAAC, and perhaps it should not be combined with DHCP_V6 stateful or stateless","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"1a97a9e0577f1b7d5fd890eaf6a9ed5abae238a3","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1123,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1124,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1125,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"},{"line_number":1126,"context_line":"            subnet \u003d models_v2.Subnet(**args)"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"            context.session.add(subnet)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2BdO0%3D","line":1125,"in_reply_to":"AAAAUX%2F%2Bvmc%3D","updated":"2014-02-21 03:16:34.000000000","message":"Salvatore, yes, this has been discussed in IPv6 sub team meeting. And I think Sean is going to add this validation soon.","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53277771eb3b7a49ef0c86aa0290993d2110fbaa","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":836,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":837,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":838,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def _make_network_dict(self, network, fields\u003dNone,"},{"line_number":841,"context_line":"                           process_extensions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2FrsQ%3D","line":838,"updated":"2014-03-01 04:50:57.000000000","message":"Need to raise an exception here. It is different from validator definitions in attributes.py.\n\n   raise q_exc.InvalidInput(msg % ....)","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b1d53395f9d6e28a69f9ec6c79ec8e3673d3d76a","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":836,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":837,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":838,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def _make_network_dict(self, network, fields\u003dNone,"},{"line_number":841,"context_line":"                           process_extensions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2F%2FiI%3D","line":838,"in_reply_to":"AAAAVX%2F%2FrsQ%3D","updated":"2014-03-02 21:06:00.000000000","message":"Right... This is not an API-level validator.\nEither raise here or raise in the caller if the return value is not None, even if I\u0027d prefer doing as Akihiro suggests.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53277771eb3b7a49ef0c86aa0290993d2110fbaa","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"           attributes.is_attr_set(s.get(\u0027ipv6_address_mode\u0027))):"},{"line_number":1077,"context_line":"            #IPv6 Attributes are set - validate the combinations"},{"line_number":1078,"context_line":"            self._validate_ipv6_mode_combination(s.get(\u0027ipv6_ra_mode\u0027),"},{"line_number":1079,"context_line":"                                                 s.get(\u0027ipv6_address_mode\u0027))"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"    def _validate_gw_out_of_pools(self, gateway_ip, pools):"},{"line_number":1082,"context_line":"        for allocation_pool in pools:"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2FrsA%3D","line":1079,"updated":"2014-03-01 04:50:57.000000000","message":"Can we move if-clause to _validate_ipv6_mode_combination? It looks more simple.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53277771eb3b7a49ef0c86aa0290993d2110fbaa","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                    \u0027gateway_ip\u0027: s[\u0027gateway_ip\u0027],"},{"line_number":1123,"context_line":"                    \u0027shared\u0027: network.shared}"},{"line_number":1124,"context_line":"            if s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1125,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1126,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1127,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1128,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Frp4%3D","line":1125,"updated":"2014-03-01 04:50:57.000000000","message":"Can we use is_attr_set() here? The default value will be None if the field is not specified, so there is no difference.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53277771eb3b7a49ef0c86aa0290993d2110fbaa","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"            if s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1125,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1126,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1127,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1128,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"},{"line_number":1129,"context_line":"            subnet \u003d models_v2.Subnet(**args)"},{"line_number":1130,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Frpw%3D","line":1127,"updated":"2014-03-01 04:50:57.000000000","message":"Ditto.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":836,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":837,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":838,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    def _validate_ipv6_mode_combination(self, ra_mode, address_mode):"},{"line_number":841,"context_line":"        # If both attributes are set, they must be the same."}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fazc%3D","line":838,"updated":"2014-03-06 07:22:37.000000000","message":"(same comments as patch set 27)\n\n(from me) Need to raise an exception here. It is different from validator definitions in attributes.py.\n\n   raise q_exc.InvalidInput(msg % ....)\n\n(from salvatore)\nRight... This is not an API-level validator. Either raise here or raise in the caller if the return value is not None, even if I\u0027d prefer doing as Akihiro suggests.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":842,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":843,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":844,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":845,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    def _make_network_dict(self, network, fields\u003dNone,"},{"line_number":848,"context_line":"                           process_extensions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa2o%3D","line":845,"updated":"2014-03-06 07:22:37.000000000","message":"L.833-838 and L.840-845 looks exactly same. Please remove either.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":842,"context_line":"        if ra_mode !\u003d address_mode:"},{"line_number":843,"context_line":"            msg \u003d _(\"IPV6_RA_MODE of \u0027%(ra_mode)s\u0027 and IPV6_ADDRESS_MODE of \""},{"line_number":844,"context_line":"                    \"\u0027%(addr_mode)s\u0027 is not a valid combination.\")"},{"line_number":845,"context_line":"            return msg % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    def _make_network_dict(self, network, fields\u003dNone,"},{"line_number":848,"context_line":"                           process_extensions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTv4%3D","line":845,"in_reply_to":"AAAAVn%2F%2Fa2o%3D","updated":"2014-03-06 22:33:16.000000000","message":"Rebased, don\u0027t see these duplicate lines in the new patchset I\u0027m working on. Very odd - will make sure this isn\u0027t repeated.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"        # Check if both IPv6 attributes are not ATTR_NOT_SPECIFIED."},{"line_number":1081,"context_line":"        # Having one attribute set but not the other is considered valid."},{"line_number":1082,"context_line":"        if (attributes.is_attr_set(s.get(\u0027ipv6_ra_mode\u0027)) and"},{"line_number":1083,"context_line":"           attributes.is_attr_set(s.get(\u0027ipv6_address_mode\u0027))):"},{"line_number":1084,"context_line":"            #IPv6 Attributes are set - validate the combinations"},{"line_number":1085,"context_line":"            self._validate_ipv6_mode_combination(s.get(\u0027ipv6_ra_mode\u0027),"},{"line_number":1086,"context_line":"                                                 s.get(\u0027ipv6_address_mode\u0027))"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FazI%3D","line":1083,"updated":"2014-03-06 07:22:37.000000000","message":"Can we move if-clause to _validate_ipv6_mode_combination? It looks more simple.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"        # Check if both IPv6 attributes are not ATTR_NOT_SPECIFIED."},{"line_number":1081,"context_line":"        # Having one attribute set but not the other is considered valid."},{"line_number":1082,"context_line":"        if (attributes.is_attr_set(s.get(\u0027ipv6_ra_mode\u0027)) and"},{"line_number":1083,"context_line":"           attributes.is_attr_set(s.get(\u0027ipv6_address_mode\u0027))):"},{"line_number":1084,"context_line":"            #IPv6 Attributes are set - validate the combinations"},{"line_number":1085,"context_line":"            self._validate_ipv6_mode_combination(s.get(\u0027ipv6_ra_mode\u0027),"},{"line_number":1086,"context_line":"                                                 s.get(\u0027ipv6_address_mode\u0027))"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTvw%3D","line":1083,"in_reply_to":"AAAAVn%2F%2FazI%3D","updated":"2014-03-06 22:33:16.000000000","message":"Done","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"           attributes.is_attr_set(s.get(\u0027ipv6_address_mode\u0027))):"},{"line_number":1084,"context_line":"            #IPv6 Attributes are set - validate the combinations"},{"line_number":1085,"context_line":"            self._validate_ipv6_mode_combination(s.get(\u0027ipv6_ra_mode\u0027),"},{"line_number":1086,"context_line":"                                                 s.get(\u0027ipv6_address_mode\u0027))"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"    def _validate_gw_out_of_pools(self, gateway_ip, pools):"},{"line_number":1089,"context_line":"        for allocation_pool in pools:"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa0Q%3D","line":1086,"updated":"2014-03-06 07:22:37.000000000","message":"(question) Do we need to check the combination of enable_dhcp and there IPv6 modes? Or can we use any combination of enable_dhcp and the IPv6 modes?\n\nPerhaps it was already discussed but it seems I cannot follow it.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"           attributes.is_attr_set(s.get(\u0027ipv6_address_mode\u0027))):"},{"line_number":1084,"context_line":"            #IPv6 Attributes are set - validate the combinations"},{"line_number":1085,"context_line":"            self._validate_ipv6_mode_combination(s.get(\u0027ipv6_ra_mode\u0027),"},{"line_number":1086,"context_line":"                                                 s.get(\u0027ipv6_address_mode\u0027))"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"    def _validate_gw_out_of_pools(self, gateway_ip, pools):"},{"line_number":1089,"context_line":"        for allocation_pool in pools:"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTuI%3D","line":1086,"in_reply_to":"AAAAVn%2F%2Fa0Q%3D","updated":"2014-03-06 22:33:16.000000000","message":"Yes - sorry I missed that piece - enable_dhcp must be True for backwards compatibility. Adding that check now.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                    \u0027gateway_ip\u0027: s[\u0027gateway_ip\u0027],"},{"line_number":1130,"context_line":"                    \u0027shared\u0027: network.shared}"},{"line_number":1131,"context_line":"            if s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1132,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1133,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1134,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1135,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa2Q%3D","line":1132,"updated":"2014-03-06 07:22:37.000000000","message":"Can we use is_attr_set() here? The default value will be None if the field is not specified, so there is no difference.\n\nOtherwise, please use \"is not\" instead of !\u003d. We need to compare them as object.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"                    \u0027gateway_ip\u0027: s[\u0027gateway_ip\u0027],"},{"line_number":1130,"context_line":"                    \u0027shared\u0027: network.shared}"},{"line_number":1131,"context_line":"            if s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1132,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1133,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1134,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1135,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTuE%3D","line":1132,"in_reply_to":"AAAAVn%2F%2Fa2Q%3D","updated":"2014-03-06 22:33:16.000000000","message":"Done","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"            if s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1132,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1133,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1134,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1135,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"},{"line_number":1136,"context_line":"            subnet \u003d models_v2.Subnet(**args)"},{"line_number":1137,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa2M%3D","line":1134,"updated":"2014-03-06 07:22:37.000000000","message":"Ditto","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"            if s[\u0027ip_version\u0027] \u003d\u003d 6:"},{"line_number":1132,"context_line":"                if s[\u0027ipv6_ra_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1133,"context_line":"                    args[\u0027ipv6_ra_mode\u0027] \u003d s[\u0027ipv6_ra_mode\u0027]"},{"line_number":1134,"context_line":"                if s[\u0027ipv6_address_mode\u0027] !\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":1135,"context_line":"                    args[\u0027ipv6_address_mode\u0027] \u003d s[\u0027ipv6_address_mode\u0027]"},{"line_number":1136,"context_line":"            subnet \u003d models_v2.Subnet(**args)"},{"line_number":1137,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTuA%3D","line":1134,"in_reply_to":"AAAAVn%2F%2Fa2M%3D","updated":"2014-03-06 22:33:16.000000000","message":"Done","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"caf0b4766d8e26e51f09756ae577dca1528b892d","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"            for rt in s[\u0027host_routes\u0027]:"},{"line_number":1050,"context_line":"                self._validate_host_route(rt, ip_ver)"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        if ip_ver \u003d\u003d 6 and s[\u0027enable_dhcp\u0027]:"},{"line_number":1053,"context_line":"            self._validate_ipv6_mode_combination(s[\u0027ipv6_ra_mode\u0027],"},{"line_number":1054,"context_line":"                                                 s[\u0027ipv6_address_mode\u0027])"},{"line_number":1055,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"AAAAVn%2F%2FR1Q%3D","line":1052,"updated":"2014-03-07 04:07:53.000000000","message":"_validate_subnet is called from both create and update subnet. When called from subnet-update, enable_dhcp is not set in a request. We need to use the existing enable_dhcp for this case.\n\nThis is the reason of the failure of tempest.","commit_id":"e67fcd36ddfa255615d1e4f28a42ac40a4ef5fbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0afc7bb63d507a1e2fb7436bc6d735e887311829","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"            for rt in s[\u0027host_routes\u0027]:"},{"line_number":1050,"context_line":"                self._validate_host_route(rt, ip_ver)"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"        if ip_ver \u003d\u003d 6 and s[\u0027enable_dhcp\u0027]:"},{"line_number":1053,"context_line":"            self._validate_ipv6_mode_combination(s[\u0027ipv6_ra_mode\u0027],"},{"line_number":1054,"context_line":"                                                 s[\u0027ipv6_address_mode\u0027])"},{"line_number":1055,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"AAAAVn%2F%2FRzM%3D","line":1052,"in_reply_to":"AAAAVn%2F%2FR1Q%3D","updated":"2014-03-07 04:32:46.000000000","message":"Question about the relationship between enable_dhcp and IPv6 mode. Let me clarify.\n\nenable_dhcp for IPv6 is taken into account for backward compatibility. This means if enable_dhcp is set for IPv6 subnet DHCP-like behavior will be eanbled for the subnet and if unset DHCP-like behavior will disabled. In addition, a user can specify only IPv6 modes and leave enable_dhcp unspecified (enable_dhcp is boolean, so we might need to set enable_dhcp based on IPv6 modes for such case).\n\nIs my understanding correct?\n\nThe default value of enable_dhcp is True, so this logic seems correct, but I am not sure. I believe it was discussed in IPv6 subteam.","commit_id":"e67fcd36ddfa255615d1e4f28a42ac40a4ef5fbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e745c89b3afab0eabd686be37bd193690d612101","unresolved":false,"context_lines":[{"line_number":807,"context_line":"            tenant_ids.pop() !\u003d original.tenant_id):"},{"line_number":808,"context_line":"            raise n_exc.InvalidSharedSetting(network\u003doriginal.name)"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"    def _validate_ipv6_attributes(self, subnet, cur_subnet):"},{"line_number":811,"context_line":"        ra_mode_set \u003d attributes.is_attr_set(subnet.get(\u0027ipv6_ra_mode\u0027))"},{"line_number":812,"context_line":"        address_mode_set \u003d attributes.is_attr_set("},{"line_number":813,"context_line":"            subnet.get(\u0027ipv6_address_mode\u0027))"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2F2PE%3D","line":810,"updated":"2014-03-13 12:24:45.000000000","message":"After reading comments from Salvatore, I think it would be better to split the validation logic to _validate_ipv6_attrs_for_create and _update. It should make the logic simpler and we can avoid duplicate is_attr_set call.\n\n- remove _validate_ipv6_update_dhcp\n- remove _validate_ipv6_dhcp\n- move all logics with cur_subnet to _validate_ipv6_attr_for_update\n- move all logis witthout cur_subnet to _valiadte_ipv6_attr_create\n\nIn addition, it looks better to define exception classes which inherit InvalidInput.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e745c89b3afab0eabd686be37bd193690d612101","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":814,"context_line":"        if cur_subnet:"},{"line_number":815,"context_line":"            self._validate_ipv6_update_dhcp(subnet, cur_subnet)"},{"line_number":816,"context_line":"            # Check that updated subnet ipv6 attributes do not conflict"},{"line_number":817,"context_line":"            if address_mode_set and ra_mode_set:"},{"line_number":818,"context_line":"                self._validate_ipv6_combination(subnet[\u0027ipv6_ra_mode\u0027],"},{"line_number":819,"context_line":"                                                subnet[\u0027ipv6_address_mode\u0027])"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2F2TY%3D","line":816,"updated":"2014-03-13 12:24:45.000000000","message":"Nit: how about the following? It think it is a bit simple.\n\n  ra_mode \u003d (subnet[\u0027ipv6_ra_mode\u0027] if ra_mode_set\n             else cur_subnet[\u0027ipv6_ra_mode\u0027])\n  addr_mode \u003d (subnet[\u0027ipv6_address_mode\u0027] if address_mode_set\n               else cur_subnet[\u0027ipv6_address_mode\u0027])\n  if ra_mode_set or address_mode_set:\n    self._validate_ipv6_combination(ra_mode, addr_mode)","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"cbac372c69a1a16cad5bf12c44d761aa1baa6fd0","unresolved":false,"context_lines":[{"line_number":813,"context_line":"            subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":814,"context_line":"        if cur_subnet:"},{"line_number":815,"context_line":"            self._validate_ipv6_update_dhcp(subnet, cur_subnet)"},{"line_number":816,"context_line":"            # Check that updated subnet ipv6 attributes do not conflict"},{"line_number":817,"context_line":"            if address_mode_set and ra_mode_set:"},{"line_number":818,"context_line":"                self._validate_ipv6_combination(subnet[\u0027ipv6_ra_mode\u0027],"},{"line_number":819,"context_line":"                                                subnet[\u0027ipv6_address_mode\u0027])"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2Fn48%3D","line":816,"in_reply_to":"AAAAWH%2F%2F2TY%3D","updated":"2014-03-14 22:38:25.000000000","message":"Great suggestion","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"08f7b0d07886e9868c195eb72ea09a05fd8c25c7","unresolved":false,"context_lines":[{"line_number":837,"context_line":"                    \"set to \u0027%(addr_mode)s\u0027 is not valid. \""},{"line_number":838,"context_line":"                    \"If both attributes are set, they must be the same value\""},{"line_number":839,"context_line":"                    ) % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":840,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def _validate_ipv6_dhcp(self, ra_mode_set, address_mode_set, enable_dhcp):"},{"line_number":843,"context_line":"        if (ra_mode_set or address_mode_set) and not enable_dhcp:"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2FCXM%3D","line":840,"updated":"2014-03-10 14:38:33.000000000","message":"It seems the only purpose for defining this method is the lengthy error message. Consider then defining a literal for it.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e745c89b3afab0eabd686be37bd193690d612101","unresolved":false,"context_lines":[{"line_number":837,"context_line":"                    \"set to \u0027%(addr_mode)s\u0027 is not valid. \""},{"line_number":838,"context_line":"                    \"If both attributes are set, they must be the same value\""},{"line_number":839,"context_line":"                    ) % {\u0027ra_mode\u0027: ra_mode, \u0027addr_mode\u0027: address_mode}"},{"line_number":840,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def _validate_ipv6_dhcp(self, ra_mode_set, address_mode_set, enable_dhcp):"},{"line_number":843,"context_line":"        if (ra_mode_set or address_mode_set) and not enable_dhcp:"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2F2ZI%3D","line":840,"in_reply_to":"AAAAVn%2F%2FCXM%3D","updated":"2014-03-13 12:24:45.000000000","message":"Or another choice is to define an exception class for this.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"08f7b0d07886e9868c195eb72ea09a05fd8c25c7","unresolved":false,"context_lines":[{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def _validate_ipv6_dhcp(self, ra_mode_set, address_mode_set, enable_dhcp):"},{"line_number":843,"context_line":"        if (ra_mode_set or address_mode_set) and not enable_dhcp:"},{"line_number":844,"context_line":"            msg \u003d _(\"ipv6_ra_mode or ipv6_address_mode cannot be set when \""},{"line_number":845,"context_line":"                    \"enable_dhcp is set to False.\")"},{"line_number":846,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":847,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2FCUE%3D","line":844,"updated":"2014-03-10 14:38:33.000000000","message":"Same as above regarding the function being defined only because of the lengthy error message.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"08f7b0d07886e9868c195eb72ea09a05fd8c25c7","unresolved":false,"context_lines":[{"line_number":842,"context_line":"    def _validate_ipv6_dhcp(self, ra_mode_set, address_mode_set, enable_dhcp):"},{"line_number":843,"context_line":"        if (ra_mode_set or address_mode_set) and not enable_dhcp:"},{"line_number":844,"context_line":"            msg \u003d _(\"ipv6_ra_mode or ipv6_address_mode cannot be set when \""},{"line_number":845,"context_line":"                    \"enable_dhcp is set to False.\")"},{"line_number":846,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def _validate_ipv6_update_dhcp(self, subnet, cur_subnet):"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2FCW0%3D","line":845,"updated":"2014-03-10 14:38:33.000000000","message":"not even to \u0027off\u0027? That\u0027s the bit I\u0027m currently not understanding (see below)","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"08f7b0d07886e9868c195eb72ea09a05fd8c25c7","unresolved":false,"context_lines":[{"line_number":852,"context_line":""},{"line_number":853,"context_line":"            ra_mode_set \u003d attributes.is_attr_set(subnet.get(\u0027ipv6_ra_mode\u0027))"},{"line_number":854,"context_line":"            address_mode_set \u003d attributes.is_attr_set("},{"line_number":855,"context_line":"                subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"            if ra_mode_set or address_mode_set:"},{"line_number":858,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2FCao%3D","line":855,"updated":"2014-03-10 14:38:33.000000000","message":"Minor nit: you already retrieved ra_mode_set and address_mode_set in the caller. Perhaps it might be better to pass them here. This method is called only once indeed and it does not look like it\u0027s going to be called from other parts.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"08f7b0d07886e9868c195eb72ea09a05fd8c25c7","unresolved":false,"context_lines":[{"line_number":860,"context_line":"            old_ra_mode_set \u003d attributes.is_attr_set("},{"line_number":861,"context_line":"                cur_subnet.get(\u0027ipv6_ra_mode\u0027))"},{"line_number":862,"context_line":"            old_address_mode_set \u003d attributes.is_attr_set("},{"line_number":863,"context_line":"                cur_subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"            if old_ra_mode_set or old_address_mode_set:"},{"line_number":866,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2FCYI%3D","line":863,"updated":"2014-03-10 14:38:33.000000000","message":"I think it should be ok to disable dhcp, ipv6_ra_mode and ipv6_address_mode at the same time?\n\nIn other words, I think the following input would be legit:\n{ \u0027enable_dhcp\u0027: \u0027False\u0027,\n  \u0027ipv6_ra_mode\u0027: \u0027off\u0027,\n  \u0027ipv6_address_mode\u0027: \u0027off\u0027}\n\nFrom what I gather this should a configuration in which VMs get their IPs from an external router using SLAAC. However I think the above input would not pass the above validation routine. Is that correct? If yes, why the above input cannot be considered valid?","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e745c89b3afab0eabd686be37bd193690d612101","unresolved":false,"context_lines":[{"line_number":860,"context_line":"            old_ra_mode_set \u003d attributes.is_attr_set("},{"line_number":861,"context_line":"                cur_subnet.get(\u0027ipv6_ra_mode\u0027))"},{"line_number":862,"context_line":"            old_address_mode_set \u003d attributes.is_attr_set("},{"line_number":863,"context_line":"                cur_subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"            if old_ra_mode_set or old_address_mode_set:"},{"line_number":866,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2F2Ko%3D","line":863,"in_reply_to":"AAAAVn%2F%2B2Uo%3D","updated":"2014-03-13 12:24:45.000000000","message":"Question: https://www.dropbox.com/s/9bojvv9vywsz8sd/IPv6%20Two%20Modes%20v3.0.pdf needs to be updated?\nIt says if VM obtains IPv6 address from external router using SLAAC both ra_mode and address_mode should be set to off.\nA case with ra_mode \u003d\u003d off and address_mode \u003d\u003d SLAAC is not covered in the above document.\n\nIn my understanding, enable_dhcp for IPv4 and ra_mode/address_mode for IPv6 control whether Neutron provides its functionality or not. From this point of view, using ra_mode\u003doff and address_mode\u003doff for external router SLAAC case sounds reasonable.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"579039914b0e32829cc63ea38757870df7ae7247","unresolved":false,"context_lines":[{"line_number":860,"context_line":"            old_ra_mode_set \u003d attributes.is_attr_set("},{"line_number":861,"context_line":"                cur_subnet.get(\u0027ipv6_ra_mode\u0027))"},{"line_number":862,"context_line":"            old_address_mode_set \u003d attributes.is_attr_set("},{"line_number":863,"context_line":"                cur_subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"            if old_ra_mode_set or old_address_mode_set:"},{"line_number":866,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2B2Uo%3D","line":863,"in_reply_to":"AAAAVn%2F%2B43I%3D","updated":"2014-03-11 18:54:02.000000000","message":"To be more specific - it would really be \n\n{\n\u0027enable_dhcp\u0027: \u0027True\u0027,\n\u0027ipv6_ra_mode\u0027: attributes.ATTR_ NOT_SPECIFIED\n}\n\nAnd when we check the value of ipv6_ra_mode it will be ATTR_NOT_SPECIFIED","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"450cffbe043d9ae0fa415b63f732ffe22c4783e1","unresolved":false,"context_lines":[{"line_number":860,"context_line":"            old_ra_mode_set \u003d attributes.is_attr_set("},{"line_number":861,"context_line":"                cur_subnet.get(\u0027ipv6_ra_mode\u0027))"},{"line_number":862,"context_line":"            old_address_mode_set \u003d attributes.is_attr_set("},{"line_number":863,"context_line":"                cur_subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"            if old_ra_mode_set or old_address_mode_set:"},{"line_number":866,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAVn%2F%2B43I%3D","line":863,"in_reply_to":"AAAAVn%2F%2FCYI%3D","updated":"2014-03-11 14:40:32.000000000","message":"The case of IPs from an external router using SLAAC would be:\n\n{\n \u0027enable_dhcp\u0027: \u0027True\u0027,\n \u0027ipv6_ra_mode\u0027: attributes.ATTR_ NOT_SPECIFIED,\n \u0027ipv6_address_mode\u0027: \u0027SLAAC\u0027\n}\n\nIf my memory is correct - we are supposed to have backwards compatibility with enable_dhcp by only having the V6 attributes when enable_dhcp is set to true. This does make for a slightly unusual setting when you are doing the above - but if we wish to loosen the backwards compatability and not treat enable_dhcp as a killswitch for the extra attributes (when enable_dhcp is false) - the above usecase could be made a little easier to understand.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"},{"author":{"_account_id":9411,"name":"Anthony Veiga","email":"anthony_veiga@cable.comcast.com","username":"aveiga"},"change_message_id":"594273c18f39f18e6894a0384e98963820bed1d2","unresolved":false,"context_lines":[{"line_number":860,"context_line":"            old_ra_mode_set \u003d attributes.is_attr_set("},{"line_number":861,"context_line":"                cur_subnet.get(\u0027ipv6_ra_mode\u0027))"},{"line_number":862,"context_line":"            old_address_mode_set \u003d attributes.is_attr_set("},{"line_number":863,"context_line":"                cur_subnet.get(\u0027ipv6_address_mode\u0027))"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"            if old_ra_mode_set or old_address_mode_set:"},{"line_number":866,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":34,"id":"AAAAWH%2F%2F13M%3D","line":863,"in_reply_to":"AAAAWH%2F%2F2Ko%3D","updated":"2014-03-13 13:25:02.000000000","message":"Akihiro,\nIn that case, it\u0027s not entirely correct.  If your external router is issuing RAs for a SLAAC-configured subnet, you want ra_mode\u003doff (or rather ATTR_NOT_SPECIFIED) but you want address_mode\u003dslaac so that Neutron can have the subnet scope defined and can use Xuhan\u0027s patch to derive the EUI-64 address.","commit_id":"7970e359e480d2dde9797fe5877f778cd4d1cc7f"}],"neutron/db/migration/alembic_migrations/versions/2447ad0e9585_add_ipv6_mode_props.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53277771eb3b7a49ef0c86aa0290993d2110fbaa","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# revision identifiers, used by Alembic."},{"line_number":26,"context_line":"revision \u003d \u00272447ad0e9585\u0027"},{"line_number":27,"context_line":"down_revision \u003d \u00273d2585038b95\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Frsg%3D","line":27,"updated":"2014-03-01 04:50:57.000000000","message":"Note: down_revision needs to be updated","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b1d53395f9d6e28a69f9ec6c79ec8e3673d3d76a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# revision identifiers, used by Alembic."},{"line_number":26,"context_line":"revision \u003d \u00272447ad0e9585\u0027"},{"line_number":27,"context_line":"down_revision \u003d \u00273d2585038b95\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2F%2Fhk%3D","line":27,"in_reply_to":"AAAAVX%2F%2Frsg%3D","updated":"2014-03-02 21:06:00.000000000","message":"though luck.\nThis has to be checked often in the final crunch as many patches with db migrations are being approved.\n\nTip: always rebase from origin/master and then do neutron-db-manage check_migration before pushing.\n\nAlso, it might be worth giving a quick look at zuul to see if any patch with db migrations is already about to merge. In that case, perhaps wait for it to merge and then rebase again.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"0dd74d74040a6dd6a1cfd66995da11fcf83cebf5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# revision identifiers, used by Alembic."},{"line_number":26,"context_line":"revision \u003d \u00272447ad0e9585\u0027"},{"line_number":27,"context_line":"down_revision \u003d \u00273d2585038b95\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2F4VQ%3D","line":27,"in_reply_to":"AAAAVn%2F%2F%2Fhk%3D","updated":"2014-03-03 16:59:53.000000000","message":"I usually do \n\ngit log --stat --no-merges neutron/db/migration/alembic_migrations/versions\n\nand then a \"git grep \u003crevision\u003e\" to confirm the latest migration.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6f63da7310bc5e5bf5f4e94de658b890cf0a8d59","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# revision identifiers, used by Alembic."},{"line_number":26,"context_line":"revision \u003d \u00272447ad0e9585\u0027"},{"line_number":27,"context_line":"down_revision \u003d \u00273d2585038b95\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2F8Xw%3D","line":27,"in_reply_to":"AAAAVn%2F%2F%2Fhk%3D","updated":"2014-03-03 09:22:01.000000000","message":"Salvatore: Thanks for the tip.\n\nI never thought of the implications in db-migrations id\u0027s vs patches going into the gate.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"73fb5fcfc16e5f65e1769b7e5526c5000c762bf9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# revision identifiers, used by Alembic."},{"line_number":26,"context_line":"revision \u003d \u00272447ad0e9585\u0027"},{"line_number":27,"context_line":"down_revision \u003d \u00273d2585038b95\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2F1WQ%3D","line":27,"in_reply_to":"AAAAVn%2F%2F4VQ%3D","updated":"2014-03-03 21:43:57.000000000","message":"yeah that works.\n\nneutron-db-manage history | less\n\nis even better ;)","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53277771eb3b7a49ef0c86aa0290993d2110fbaa","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from neutron.common import constants"},{"line_number":40,"context_line":"from neutron.db import migration"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Frqs%3D","line":39,"updated":"2014-03-01 04:50:57.000000000","message":"Importing from neutron codes except migration direction should be avoided. It is to avoid to change db migrations even when the main code is changed.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"6d7f40e0c32b88cabe8e0f81c50b155ea2bf196e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from neutron.common import constants"},{"line_number":40,"context_line":"from neutron.db import migration"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2F1O8%3D","line":39,"in_reply_to":"AAAAVX%2F%2Frqs%3D","updated":"2014-03-03 21:58:07.000000000","message":"Agreed - will change.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53277771eb3b7a49ef0c86aa0290993d2110fbaa","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                   % tuple(constants.IPV6_MODES))"},{"line_number":53,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":54,"context_line":"                  sa.Column(\u0027ipv6_ra_mode\u0027,"},{"line_number":55,"context_line":"                            sa.Enum(constants.IPV6_SLAAC,"},{"line_number":56,"context_line":"                                    constants.DHCPV6_STATEFUL,"},{"line_number":57,"context_line":"                                    constants.DHCPV6_STATELESS,"},{"line_number":58,"context_line":"                                    name\u003d\u0027ipv6_modes\u0027),"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Frqo%3D","line":55,"updated":"2014-03-01 04:50:57.000000000","message":"As commented above, please use a string rather than referring to a constant.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"6d7f40e0c32b88cabe8e0f81c50b155ea2bf196e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                   % tuple(constants.IPV6_MODES))"},{"line_number":53,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":54,"context_line":"                  sa.Column(\u0027ipv6_ra_mode\u0027,"},{"line_number":55,"context_line":"                            sa.Enum(constants.IPV6_SLAAC,"},{"line_number":56,"context_line":"                                    constants.DHCPV6_STATEFUL,"},{"line_number":57,"context_line":"                                    constants.DHCPV6_STATELESS,"},{"line_number":58,"context_line":"                                    name\u003d\u0027ipv6_modes\u0027),"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVn%2F%2F1Ow%3D","line":55,"in_reply_to":"AAAAVX%2F%2Frqo%3D","updated":"2014-03-03 21:58:07.000000000","message":"Done","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"87e387165f52a453a80262e5e0afaaca37cae728","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# revision identifiers, used by Alembic."},{"line_number":26,"context_line":"revision \u003d \u00272447ad0e9585\u0027"},{"line_number":27,"context_line":"down_revision \u003d \u0027492a106273f8\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2Fa1o%3D","line":27,"updated":"2014-03-06 07:22:37.000000000","message":"Please update the down revision once the current gate queue is cleared.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bd2011908a3d38c27e7a06190ab4c3a741286454","unresolved":false,"context_lines":[{"line_number":36,"context_line":"import sqlalchemy as sa"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from neutron.common import constants"},{"line_number":40,"context_line":"from neutron.db import migration"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAVn%2F%2FTxI%3D","line":39,"updated":"2014-03-06 22:33:16.000000000","message":"\u003eAkihiro Motoki\t\tFeb 28\n\n\u003eImporting from neutron codes except migration direction should be avoided.\n\nFixed.","commit_id":"3d8423b77c29ce3990e03657ef4e4a90c1e40715"}],"neutron/db/migration/alembic_migrations/versions/2447ad0e9585_add_subnet_mode_prop.py":[{"author":{"_account_id":8278,"name":"Dazhao Yu","email":"dazhaoyu@gmail.com","username":"Dazhao"},"change_message_id":"18713d72a2eabd0c1e9abb2e3a0915e2b89fb2e9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from neutron.db import migration"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":46,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":47,"context_line":"        return"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F7jU%3D","line":45,"updated":"2013-10-25 02:09:26.000000000","message":"I think maybe we can only add one new column-\u0027dhcp-mode\u0027 in \u0027subnet\u0027 table to support it, the default value is \u0027static\u0027, so we do not need create one new table.","commit_id":"b7433c02451c1417beeb87438f3e816536c5b954"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7123271a6b8721f9c263528457c174692caaaca4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from neutron.db import migration"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":46,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":47,"context_line":"        return"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2F7hk%3D","line":45,"in_reply_to":"AAAATn%2F%2F7jU%3D","updated":"2013-10-25 02:34:23.000000000","message":"Dnsmasq\u0027s manpage for the IPv6 modes is worded in such a way that some of the options can appear in combinations. We\u0027ll have to stick some validation in to see which ones can be put together, I have to do some more research.","commit_id":"b7433c02451c1417beeb87438f3e816536c5b954"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"860e7f07b3c64ed1a2cd047f291ba69eeb8dee2f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":47,"context_line":"        return"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    op.create_table(\u0027dhcp_modes\u0027,"},{"line_number":50,"context_line":"                    sa.Column(\u0027id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":51,"context_line":"                    sa.Column(\u0027subnet_id\u0027, sa.String(36),"},{"line_number":52,"context_line":"                              sa.ForeignKey(\u0027subnets.id\u0027, ondelete\u003d\u0027CASCADE\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B3yU%3D","line":49,"updated":"2013-11-19 06:07:03.000000000","message":"Primary key should be added according to the model","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"344d4d95936722496992326fec87fd6aa07ecb56","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if not migration.should_run(active_plugins, migration_for_plugins):"},{"line_number":47,"context_line":"        return"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    op.create_table(\u0027dhcp_modes\u0027,"},{"line_number":50,"context_line":"                    sa.Column(\u0027id\u0027, sa.String(36), nullable\u003dFalse),"},{"line_number":51,"context_line":"                    sa.Column(\u0027subnet_id\u0027, sa.String(36),"},{"line_number":52,"context_line":"                              sa.ForeignKey(\u0027subnets.id\u0027, ondelete\u003d\u0027CASCADE\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B0y4%3D","line":49,"in_reply_to":"AAAATn%2F%2B3yU%3D","updated":"2013-11-19 17:16:39.000000000","message":"Done","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"860e7f07b3c64ed1a2cd047f291ba69eeb8dee2f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    )"},{"line_number":62,"context_line":"    ## Insert rows into dhcp_modes for existing subnets"},{"line_number":63,"context_line":"    op.execute(\"INSERT INTO dhcp_modes SELECT id, id as subnet_id,\""},{"line_number":64,"context_line":"               \"\u0027static\u0027 as mode from subnets\")"},{"line_number":65,"context_line":"    pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B30g%3D","line":64,"updated":"2013-11-19 06:07:03.000000000","message":"nit: from -\u003e FROM","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"344d4d95936722496992326fec87fd6aa07ecb56","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    )"},{"line_number":62,"context_line":"    ## Insert rows into dhcp_modes for existing subnets"},{"line_number":63,"context_line":"    op.execute(\"INSERT INTO dhcp_modes SELECT id, id as subnet_id,\""},{"line_number":64,"context_line":"               \"\u0027static\u0027 as mode from subnets\")"},{"line_number":65,"context_line":"    pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B0y0%3D","line":64,"in_reply_to":"AAAATn%2F%2B30g%3D","updated":"2013-11-19 17:16:39.000000000","message":"Done","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2BvnY%3D","line":1,"updated":"2014-02-19 11:46:13.000000000","message":"while this patch was under review, there was a change in code conventions which required to remove vim headers.","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Bvnk%3D","line":3,"updated":"2014-02-19 11:46:13.000000000","message":"This proves that it\u0027s been our fault as reviewers to keep this patch for such a long time on gerrit!\n\nIf you don\u0027t mind, please set the year to 2014","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\"Add subnet_mode property"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Revision ID: 2447ad0e9585"},{"line_number":22,"context_line":"Revises: 49f5e553f61f"},{"line_number":23,"context_line":"Create Date: 2013-10-23 16:36:44.188904"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Bvn4%3D","line":22,"updated":"2014-02-19 11:46:13.000000000","message":"looks like you need another update here.\n\nI\u0027m sorry DB migrations can be a real PITA, especially after we had the gate blocked for two weeks and a lot of patches with db migrations under review","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bfe2b5c35b05059cd7b1d0c57c29ff670ffcdc0a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\"Add subnet_mode property"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Revision ID: 2447ad0e9585"},{"line_number":22,"context_line":"Revises: 49f5e553f61f"},{"line_number":23,"context_line":"Create Date: 2013-10-23 16:36:44.188904"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAU3%2F%2F0O0%3D","line":22,"in_reply_to":"AAAAUX%2F%2Bvn4%3D","updated":"2014-02-24 17:00:46.000000000","message":"I\u0027m used to it by now :)","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"}],"neutron/db/models_v2.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"860e7f07b3c64ed1a2cd047f291ba69eeb8dee2f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                              backref\u003d\u0027subnet\u0027,"},{"line_number":166,"context_line":"                              cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":167,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":168,"context_line":"    dhcp_mode \u003d orm.relationship(\u0027DhcpMode\u0027,"},{"line_number":169,"context_line":"                                 cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B3vk%3D","line":168,"updated":"2013-11-19 06:07:03.000000000","message":"from the code and from migration it seem unclear whether it will be 1 related dhcp mode or a list of them.","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"344d4d95936722496992326fec87fd6aa07ecb56","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                              backref\u003d\u0027subnet\u0027,"},{"line_number":166,"context_line":"                              cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":167,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":168,"context_line":"    dhcp_mode \u003d orm.relationship(\u0027DhcpMode\u0027,"},{"line_number":169,"context_line":"                                 cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2B0yg%3D","line":168,"in_reply_to":"AAAATn%2F%2B3vk%3D","updated":"2013-11-19 17:16:39.000000000","message":"Agreed -  will change to plural form","commit_id":"f65674ddce032c1d85ae378d091dd6407f8b9f9d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"3fcafbcc329649f96884b72b060211eafa0a3aff","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                              backref\u003d\u0027subnet\u0027,"},{"line_number":166,"context_line":"                              cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":167,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":168,"context_line":"    dhcp_modes \u003d orm.relationship(\u0027DhcpMode\u0027,"},{"line_number":169,"context_line":"                                  cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FbG0%3D","line":168,"updated":"2014-01-13 22:33:48.000000000","message":"I\u0027d prefer for this enum attribute to be on the model vs related.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"}],"neutron/tests/unit/test_attributes.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            msg \u003d attributes._validate_nameservers(ns, None)"},{"line_number":263,"context_line":"            self.assertIsNone(msg)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_validate_dhcp_modes(self):"},{"line_number":266,"context_line":"        dhcp_modes \u003d [\u0027ra-stateless\u0027, \u0027ra-names\u0027]"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        msg \u003d attributes._validate_dhcp_modes(dhcp_modes, None)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2FtvY%3D","line":265,"updated":"2014-01-03 00:53:39.000000000","message":"Test doesn\u0027t cover invalid data format.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        dhcp_modes \u003d [\u0027ra-stateless\u0027, \u0027ra-names\u0027]"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        msg \u003d attributes._validate_dhcp_modes(dhcp_modes, None)"},{"line_number":269,"context_line":"        self.assertIsNone(msg)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        dhcp_modes \u003d [\u0027invalid-mode\u0027]"},{"line_number":272,"context_line":"        msg \u003d attributes._validate_dhcp_modes(dhcp_modes)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2FtvA%3D","line":269,"updated":"2014-01-03 00:53:39.000000000","message":"Even if you add a test for invalid data format it won\u0027t find the problem that I pointed out in _validate_dhcp_modes.  Consider testing for something a little more specific than NotNone.","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            msg \u003d attributes._validate_ipv6_modes(mode, None)"},{"line_number":287,"context_line":"            self.assertIsNone(msg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        modes \u003d \u0027invalid-mode\u0027"},{"line_number":290,"context_line":"        msg \u003d attributes._validate_ipv6_modes(modes)"},{"line_number":291,"context_line":"        self.assertIsNotNone(msg)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Bvpc%3D","line":289,"updated":"2014-02-19 11:46:13.000000000","message":"pedantry: modes -\u003e mode or invalid_mode","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"345d1cd94ccc89c16521b1372ed83ac3a5e46bad","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            msg \u003d attributes._validate_ipv6_modes(mode, None)"},{"line_number":287,"context_line":"            self.assertIsNone(msg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        mode \u003d \u0027invalid-mode\u0027"},{"line_number":290,"context_line":"        msg \u003d attributes._validate_ipv6_modes(mode)"},{"line_number":291,"context_line":"        self.assertIsNotNone(msg)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Fy4s%3D","line":289,"updated":"2014-02-28 08:53:14.000000000","message":"nitpicking suggestion: invalid_modes\nor even, feeding it directly to _validate_ipv6_modes if we don\u0027t cross the line length limit.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"c2d13d1e4931032e4eb89e44e8b3f8d5e51475f9","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            msg \u003d attributes._validate_ipv6_modes(mode, None)"},{"line_number":287,"context_line":"            self.assertIsNone(msg)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        mode \u003d \u0027invalid-mode\u0027"},{"line_number":290,"context_line":"        msg \u003d attributes._validate_ipv6_modes(mode)"},{"line_number":291,"context_line":"        self.assertIsNotNone(msg)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Frzk%3D","line":289,"in_reply_to":"AAAAVX%2F%2Fy4s%3D","updated":"2014-03-01 03:12:50.000000000","message":"Agree - the temporary variables is only used once.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"345d1cd94ccc89c16521b1372ed83ac3a5e46bad","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.assertIsNotNone(msg)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        invalid_type \u003d [\u0027ra-stateless\u0027]"},{"line_number":294,"context_line":"        msg \u003d attributes._validate_ipv6_modes(invalid_type)"},{"line_number":295,"context_line":"        self.assertIsNotNone(msg)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_validate_hostroutes(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAVX%2F%2Fyn4%3D","line":294,"updated":"2014-02-28 08:53:14.000000000","message":"same suggestion above.","commit_id":"4ab2b55b33f7b0ca7ca7abc9a02e6df53341859c"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2a269a48db7c626df4a27ca44f134234dbfb66dc","unresolved":false,"context_lines":[{"line_number":2920,"context_line":"            res \u003d subnet_req.get_response(self.api)"},{"line_number":2921,"context_line":"            self.assertEqual(res.status_int, webob.exc.HTTPClientError.code)"},{"line_number":2922,"context_line":""},{"line_number":2923,"context_line":"    def test_create_subnet_ipv6_attributes(self):"},{"line_number":2924,"context_line":"        gateway_ip \u003d \u0027fe80::1\u0027"},{"line_number":2925,"context_line":"        cidr \u003d \u0027fe80::/80\u0027"},{"line_number":2926,"context_line":"        for mode in constants.IPV6_MODES:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2BvoI%3D","line":2923,"updated":"2014-02-19 11:46:13.000000000","message":"Is this test covering all the possible valid combinations of ra_mode and address_mode?","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"bfe2b5c35b05059cd7b1d0c57c29ff670ffcdc0a","unresolved":false,"context_lines":[{"line_number":2920,"context_line":"            res \u003d subnet_req.get_response(self.api)"},{"line_number":2921,"context_line":"            self.assertEqual(res.status_int, webob.exc.HTTPClientError.code)"},{"line_number":2922,"context_line":""},{"line_number":2923,"context_line":"    def test_create_subnet_ipv6_attributes(self):"},{"line_number":2924,"context_line":"        gateway_ip \u003d \u0027fe80::1\u0027"},{"line_number":2925,"context_line":"        cidr \u003d \u0027fe80::/80\u0027"},{"line_number":2926,"context_line":"        for mode in constants.IPV6_MODES:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAU3%2F%2F0OA%3D","line":2923,"in_reply_to":"AAAAUX%2F%2BvoI%3D","updated":"2014-02-24 17:00:46.000000000","message":"No - I plan on adding unit tests to exercise the valid and invalid combos, once I implement that validation","commit_id":"ef1759d764ee2e9637bb7f52ca42ae0808fa989a"}],"neutron/tests/unit/test_linux_dhcp.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"d874f82ae27bbb636b2b39a9164f941f7d786804","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                              % i for i in s.dhcp_modes)[:-1])"},{"line_number":633,"context_line":"            for i, s in enumerate(network.subnets)"},{"line_number":634,"context_line":"        )"},{"line_number":635,"context_line":"        for i, s in enumerate(network.subnets):"},{"line_number":636,"context_line":"            for mode in s.dhcp_modes:"},{"line_number":637,"context_line":"                if mode in constants.RA_MODES:"},{"line_number":638,"context_line":"                    expected.extend([\u0027--enable-ra\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9h80%3D","line":635,"updated":"2013-12-10 15:07:39.000000000","message":"why enumerate here?","commit_id":"7f918597cb568c77526b3818582d5dd64974c0c5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        expected.extend("},{"line_number":630,"context_line":"            \u0027--dhcp-range\u003dset:tag%d,%s,%s,86400s\u0027 %"},{"line_number":631,"context_line":"            (i, s.cidr.split(\u0027/\u0027)[0], \u0027\u0027.join(\"%s,\""},{"line_number":632,"context_line":"                                              % i for i in s.dhcp_modes)[:-1])"},{"line_number":633,"context_line":"            for i, s in enumerate(network.subnets)"},{"line_number":634,"context_line":"        )"},{"line_number":635,"context_line":"        for i, s in enumerate(network.subnets):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2FtwM%3D","line":632,"updated":"2014-01-03 00:53:39.000000000","message":"See comment about join in dhcp.py","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"57677bc0221272fc4f5593aea0d819ca3e1388b4","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                              % i for i in s.dhcp_modes)[:-1])"},{"line_number":633,"context_line":"            for i, s in enumerate(network.subnets)"},{"line_number":634,"context_line":"        )"},{"line_number":635,"context_line":"        for i, s in enumerate(network.subnets):"},{"line_number":636,"context_line":"            for mode in s.dhcp_modes:"},{"line_number":637,"context_line":"                if mode in constants.RA_MODES:"},{"line_number":638,"context_line":"                    expected.extend([\u0027--enable-ra\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAT3%2F%2Ftvs%3D","line":635,"updated":"2014-01-03 00:53:39.000000000","message":"i should be _i to indicate it is unused.\n\nWait, why use enumerate at all if i is unused?","commit_id":"4e73fac0d260749805b8a95f50f70913527d3a6a"}]}
