)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"f6ca2ca72f93341a354567e518d922dc358f6e75","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change to ACCEPT, so it immediately gets passed through."},{"line_number":10,"context_line":"The RETURN statement means the RA packets hit the default DROP rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This fixes bug 1242933"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I517c66a470296141c0024a64e39b6d40b0c0d581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FKss%3D","line":12,"updated":"2013-10-22 05:51:05.000000000","message":"Use \u0027Closes-Bug\u0027 if the commit is intended to fully fix and close the bug being referenced. can refer the link https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"5c6f8d11ff08d69f96ea24c1478054a75dabd186"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"752521ec88393d4d1b171993c372f48f0a9d9ef4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Change to ACCEPT, so it immediately gets passed through."},{"line_number":10,"context_line":"The RETURN statement means the RA packets hit the default DROP rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This fixes bug 1242933"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I517c66a470296141c0024a64e39b6d40b0c0d581"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FJK4%3D","line":12,"in_reply_to":"AAAATH%2F%2FKss%3D","updated":"2013-10-22 15:17:59.000000000","message":"Ah, guess it doesn\u0027t have the same syntax as GitHub. Thanks for the link.","commit_id":"5c6f8d11ff08d69f96ea24c1478054a75dabd186"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e2248e91cd521377cd47c5123d9a34f11c983a7e","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    def _spoofing_rule(self, port, ipv4_rules, ipv6_rules):"},{"line_number":217,"context_line":"        #Note(nati) allow dhcp or RA packet"},{"line_number":218,"context_line":"        ipv4_rules +\u003d [\u0027-p udp -m udp --sport 68 --dport 67 -j RETURN\u0027]"},{"line_number":219,"context_line":"        ipv6_rules +\u003d [\u0027-p icmpv6 -j ACCEPT\u0027]"},{"line_number":220,"context_line":"        mac_ipv4_pairs \u003d []"},{"line_number":221,"context_line":"        mac_ipv6_pairs \u003d []"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATX%2F%2F8RE%3D","line":219,"updated":"2013-10-23 21:53:02.000000000","message":"I don\u0027t think this is correct.  If you want to allow RA only, you should be specifying the type here, something like:\n\n\u0027 -p ipv6-icmp -m icmp6 --icmpv6-type 134 -j RETURN\u0027\n\n(that icmpv6 -\u003e ipv6-icmp change might be necessary for iptables_manager)\n\nAnd shouldn\u0027t it still be RETURN?","commit_id":"5c6f8d11ff08d69f96ea24c1478054a75dabd186"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"3ed3b17747b0213d2756c5e33397c225727c6ef4","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    def _spoofing_rule(self, port, ipv4_rules, ipv6_rules):"},{"line_number":217,"context_line":"        #Note(nati) allow dhcp or RA packet"},{"line_number":218,"context_line":"        ipv4_rules +\u003d [\u0027-p udp -m udp --sport 68 --dport 67 -j RETURN\u0027]"},{"line_number":219,"context_line":"        ipv6_rules +\u003d [\u0027-p icmpv6 -j ACCEPT\u0027]"},{"line_number":220,"context_line":"        mac_ipv4_pairs \u003d []"},{"line_number":221,"context_line":"        mac_ipv6_pairs \u003d []"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FpZI%3D","line":219,"in_reply_to":"AAAATX%2F%2F8RE%3D","updated":"2013-10-30 22:52:55.000000000","message":"I suspect that it\u0027s being dropped by another rule somewhere else after the RETURN is processed, since only by changing to an ACCEPT does the VM see any RAs","commit_id":"5c6f8d11ff08d69f96ea24c1478054a75dabd186"},{"author":{"_account_id":7314,"name":"John Jason Brzozowski","email":"jjmb@jjmb.com","username":"jjmb"},"change_message_id":"9f68e340cb4a6f35c151b4bfbfac045b8a0d808f","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    def _spoofing_rule(self, port, ipv4_rules, ipv6_rules):"},{"line_number":217,"context_line":"        #Note(nati) allow dhcp or RA packet"},{"line_number":218,"context_line":"        ipv4_rules +\u003d [\u0027-p udp -m udp --sport 68 --dport 67 -j RETURN\u0027]"},{"line_number":219,"context_line":"        ipv6_rules +\u003d [\u0027-p icmpv6 -j ACCEPT\u0027]"},{"line_number":220,"context_line":"        mac_ipv4_pairs \u003d []"},{"line_number":221,"context_line":"        mac_ipv6_pairs \u003d []"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Ft%2BM%3D","line":219,"in_reply_to":"AAAATX%2F%2F8RE%3D","updated":"2013-10-30 23:37:44.000000000","message":"The time may be right to also add DHCPv6 rules here as well.  DNS over IPv6 should be fine.  If we are going to specify specific message types we should consider the following as well:\n\nType 128 - Echo Request\nType 129 - Echo Reply\nType 130 - Multicast Listener Query\nType 131 - Multicast Listener Report\nType 132 - Multicast Listener Done\nType 133 - Router Solicitation\nType 134 - Router Advertisement\nType 135 - Neighbor Solicitation\nType 136 - Neighbor Advertisement","commit_id":"5c6f8d11ff08d69f96ea24c1478054a75dabd186"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0bf7828e1b69bc0fadea3f718d23ec99fa82d9d5","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    def _spoofing_rule(self, port, ipv4_rules, ipv6_rules):"},{"line_number":217,"context_line":"        #Note(nati) allow dhcp or RA packet"},{"line_number":218,"context_line":"        ipv4_rules +\u003d [\u0027-p udp -m udp --sport 68 --dport 67 -j RETURN\u0027]"},{"line_number":219,"context_line":"        ipv6_rules +\u003d [\u0027-p icmpv6 -j ACCEPT\u0027]"},{"line_number":220,"context_line":"        mac_ipv4_pairs \u003d []"},{"line_number":221,"context_line":"        mac_ipv6_pairs \u003d []"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fb%2BM%3D","line":219,"in_reply_to":"AAAATn%2F%2FpZI%3D","updated":"2013-11-06 07:41:02.000000000","message":"Perhaps this is dropping because the default action (at least on my network node is DROP:\n\n:INPUT DROP [0:0]\n:FORWARD DROP [0:0]\n:OUTPUT DROP [0:0]\n\nAnd if there\u0027s nothing before that in your security group chain to allow it will get dropped.\n\nI will admit I have IPv6 turned-off on my system, so might be a red herring.","commit_id":"5c6f8d11ff08d69f96ea24c1478054a75dabd186"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2879bc9563a0fa7c80008ec88d6d92e678fdcbe5","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        return [\u0027-p udp -m udp --sport 67 --dport 68 -j DROP\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def _accept_inbound_icmpv6(self):"},{"line_number":247,"context_line":"        ## Allow router advertisements, multicast listener"},{"line_number":248,"context_line":"        ## and neighbor advertisement into the instance"},{"line_number":249,"context_line":"        icmpv6_input_allowed_types \u003d [130, 131, 132, 134, 135, 136]"},{"line_number":250,"context_line":"        icmpv6_rules \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BV9c%3D","line":247,"updated":"2013-11-27 06:18:22.000000000","message":"## -\u003e #, keep the consistant with other parts.","commit_id":"5692ad72f769cd9bced69d8ffb619dd0a87fed33"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"2879bc9563a0fa7c80008ec88d6d92e678fdcbe5","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    def _accept_inbound_icmpv6(self):"},{"line_number":247,"context_line":"        ## Allow router advertisements, multicast listener"},{"line_number":248,"context_line":"        ## and neighbor advertisement into the instance"},{"line_number":249,"context_line":"        icmpv6_input_allowed_types \u003d [130, 131, 132, 134, 135, 136]"},{"line_number":250,"context_line":"        icmpv6_rules \u003d []"},{"line_number":251,"context_line":"        for icmp6_type in icmpv6_input_allowed_types:"},{"line_number":252,"context_line":"            icmpv6_rules +\u003d [\u0027-p icmpv6 --icmpv6-type %s -j RETURN\u0027 %"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2BV98%3D","line":249,"updated":"2013-11-27 06:18:22.000000000","message":"suggest define those icmpv6 types as the constants, and point out what does it mean in the comment based on http://www.iana.org/assignments/icmpv6-parameters/icmpv6-parameters.xhtml","commit_id":"5692ad72f769cd9bced69d8ffb619dd0a87fed33"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b77be74d5265b8b19f702328a73f824a76c3631b","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        return [\u0027-p udp -m udp --sport 67 --dport 68 -j DROP\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def _accept_inbound_icmpv6(self):"},{"line_number":247,"context_line":"        ## Allow router advertisements, multicast listener"},{"line_number":248,"context_line":"        ## and neighbor advertisement into the instance"},{"line_number":249,"context_line":"        icmpv6_rules \u003d []"},{"line_number":250,"context_line":"        for icmp6_type in constants.ICMPV6_ALLOWED_TYPES:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BJjY%3D","line":247,"updated":"2013-12-01 20:28:40.000000000","message":"nit: we don\u0027t need the double # just one is fine.","commit_id":"6fd1e602bcd164eed35a7aeffcd087b4a530d377"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"6088ac96614b15a0635dc34a407747004e213f3d","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        return [\u0027-p udp -m udp --sport 67 --dport 68 -j DROP\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def _accept_inbound_icmpv6(self):"},{"line_number":247,"context_line":"        ## Allow router advertisements, multicast listener"},{"line_number":248,"context_line":"        ## and neighbor advertisement into the instance"},{"line_number":249,"context_line":"        icmpv6_rules \u003d []"},{"line_number":250,"context_line":"        for icmp6_type in constants.ICMPV6_ALLOWED_TYPES:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BJiw%3D","line":247,"in_reply_to":"AAAATn%2F%2BJjY%3D","updated":"2013-12-01 20:33:05.000000000","message":"Doh! Zhang pointed it out in patch 7 but I missed it when amending. Will re-do.","commit_id":"6fd1e602bcd164eed35a7aeffcd087b4a530d377"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"799a1ef4376fc517373510be9aef61e6b0243f4c","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def _accept_inbound_icmpv6(self):"},{"line_number":247,"context_line":"        # Allow router advertisements, multicast listener"},{"line_number":248,"context_line":"        # and neighbor advertisement into the instance"},{"line_number":249,"context_line":"        icmpv6_rules \u003d []"},{"line_number":250,"context_line":"        for icmp6_type in constants.ICMPV6_ALLOWED_TYPES:"},{"line_number":251,"context_line":"            icmpv6_rules +\u003d [\u0027-p icmpv6 --icmpv6-type %s -j RETURN\u0027 %"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2BEwo%3D","line":248,"updated":"2013-12-02 20:07:23.000000000","message":"Nit: and Neighbor Solicitations","commit_id":"cecd7591533e2c046aedba3b8e5d14a5b2fa7fe9"}]}
