)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"8be0a1541cd3381bf5aa8974c2d731f4afde4dee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix downgrade in migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For downgrade with posgres is not enough to just drop_table if"},{"line_number":10,"context_line":"table contains enums. They should be removed separately after"},{"line_number":11,"context_line":"deleting the table."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATH%2F%2FJlU%3D","line":9,"updated":"2013-10-22 13:27:25.000000000","message":"typo: postgres","commit_id":"febb139dd1ab543372e42f9a312fc0513f9b4b20"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8b28cd0d249ff762cb762b00dfe96390b2c6054","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix enums usage for postgres in migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For downgrade with postgres it is not enough to just drop_table if"},{"line_number":10,"context_line":"table contains enums. They should be removed separately after"},{"line_number":11,"context_line":"deleting the table."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also if some migration use the same enums in postgres work with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baada198_605bb42e","line":10,"updated":"2014-07-16 18:21:04.000000000","message":"Nit: for clarity: s/They/The enums/","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6fb2a26209d6cc3b434a18d891ece2c5f068899b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix enums usage for postgres in migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For downgrade with postgres it is not enough to just drop_table if"},{"line_number":10,"context_line":"table contains enums. They should be removed separately after"},{"line_number":11,"context_line":"deleting the table."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also if some migration use the same enums in postgres work with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baada198_71eb6fdc","line":10,"in_reply_to":"baada198_605bb42e","updated":"2014-07-17 08:00:18.000000000","message":"Done","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8b28cd0d249ff762cb762b00dfe96390b2c6054","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deleting the table."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also if some migration use the same enums in postgres work with"},{"line_number":14,"context_line":"them should be organized differently."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1243213"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baada198_7ba1a594","line":14,"updated":"2014-07-16 18:21:04.000000000","message":"English grammar: \"Also, if a migration uses an existing enum then postgresql needs specific code to re-use the enum.\"","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6fb2a26209d6cc3b434a18d891ece2c5f068899b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deleting the table."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also if some migration use the same enums in postgres work with"},{"line_number":14,"context_line":"them should be organized differently."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1243213"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baada198_d1b35b08","line":14,"in_reply_to":"baada198_7ba1a594","updated":"2014-07-17 08:00:18.000000000","message":"Done","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"}],"neutron/db/migration/alembic_migrations/versions/1341ed32cc1e_nvp_netbinding_update.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a3e4fe571524875d7de64d84e1c6c5f42e85e1a9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                   name\u003d\u0027_nvp_network_type\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def alter_enum(old_enum, new_enum, table, column, bind):"},{"line_number":50,"context_line":"    values \u003d {\u0027table\u0027: table,"},{"line_number":51,"context_line":"              \u0027column\u0027: column,"},{"line_number":52,"context_line":"              \u0027tmp_name\u0027: tmp_type.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fnv4%3D","line":49,"updated":"2013-10-31 10:13:19.000000000","message":"fwiw function like this might be useful for other migrations too.\nTherefore I would put them in the same module where migration.should_run is","commit_id":"8a6470b9439f632438486ccc14310ec3538e2eba"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5cfd5602e227b52a264cd7bef040a1bfeb650126","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                   name\u003d\u0027_nvp_network_type\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def alter_enum(old_enum, new_enum, table, column, bind):"},{"line_number":50,"context_line":"    values \u003d {\u0027table\u0027: table,"},{"line_number":51,"context_line":"              \u0027column\u0027: column,"},{"line_number":52,"context_line":"              \u0027tmp_name\u0027: tmp_type.name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fnpk%3D","line":49,"in_reply_to":"AAAATn%2F%2Fnv4%3D","updated":"2013-10-31 10:44:41.000000000","message":"ok, I will do this.","commit_id":"8a6470b9439f632438486ccc14310ec3538e2eba"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a3e4fe571524875d7de64d84e1c6c5f42e85e1a9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                   \u0027binding_type\u0027, bind)"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        op.alter_column(\u0027nvp_network_bindings\u0027, \u0027binding_type\u0027,"},{"line_number":81,"context_line":"                        type_\u003dold_binding_type, existing_nullable\u003dTrue)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def downgrade(active_plugins\u003dNone, options\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fnvg%3D","line":81,"updated":"2013-10-31 10:13:19.000000000","message":"I think we\u0027ve been striving to avoid engine-specific paths in migrations.\n\nOne way to avoid the issue would be monkey patching alembic, but that would amount to magic..\n\nI think we might try and push a patch into alembic for ensuring proper support for enums in postgres.\nAssuming that is feasible, would that sound reasonable too?","commit_id":"8a6470b9439f632438486ccc14310ec3538e2eba"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5cfd5602e227b52a264cd7bef040a1bfeb650126","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                   \u0027binding_type\u0027, bind)"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        op.alter_column(\u0027nvp_network_bindings\u0027, \u0027binding_type\u0027,"},{"line_number":81,"context_line":"                        type_\u003dold_binding_type, existing_nullable\u003dTrue)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def downgrade(active_plugins\u003dNone, options\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2Fnp0%3D","line":81,"in_reply_to":"AAAATn%2F%2Fnvg%3D","updated":"2013-10-31 10:44:41.000000000","message":"The problem is not in alembic, SQLAlchemy does not support updating enum types. I don\u0027t have enough expertise in SQLAlchemy internals to fix this.","commit_id":"8a6470b9439f632438486ccc14310ec3538e2eba"}],"neutron/db/migration/alembic_migrations/versions/39cf3f799352_fwaas_havana_2_model.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"fdc1d69131de993155ac3ec7634dce8882e0d3b1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        sa.Column(\u0027firewall_policy_id\u0027, sa.String(length\u003d36), nullable\u003dTrue),"},{"line_number":90,"context_line":"        sa.Column(\u0027shared\u0027, sa.Boolean(), autoincrement\u003dFalse,"},{"line_number":91,"context_line":"                  nullable\u003dTrue),"},{"line_number":92,"context_line":"        sa.Column(\u0027protocol\u0027, sa.String(length\u003d40), nullable\u003dTrue),"},{"line_number":93,"context_line":"        sa.Column(\u0027ip_version\u0027, sa.Integer(), autoincrement\u003dFalse,"},{"line_number":94,"context_line":"                  nullable\u003dFalse),"},{"line_number":95,"context_line":"        sa.Column(\u0027source_ip_address\u0027, sa.String(length\u003d46), nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2F3t8%3D","line":92,"updated":"2013-10-25 21:38:14.000000000","message":"Sorry for nit picking, but perhaps we should do this as a separate patch since it\u0027s not related to this patch. Good catch though...","commit_id":"148e09f952dd8347560e039f7d0125ef4866ae86"}],"neutron/db/migration/alembic_migrations/versions/3c6e57a23db4_add_multiprovider.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"d4f99324425d506d5952b1e191993778477d555d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from neutron.db import migration"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def get_enum():"},{"line_number":47,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":48,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":49,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad9bd40_485f9ce5","line":46,"updated":"2014-05-02 22:35:14.000000000","message":"why is this done here and not in other migrations?","commit_id":"a2f88771626d8827aea404e52b4fb08ad2fd0bba"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c69637b95a42d0aee7a049881f825cb2f65cce6f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from neutron.db import migration"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def get_enum():"},{"line_number":47,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":48,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":49,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad9bd40_0bf577ed","line":46,"in_reply_to":"9ad9bd40_485f9ce5","updated":"2014-05-05 06:47:11.000000000","message":"In what other migrations? The problem here is because this migration tried to use the same type as was already created in 1341ed32cc1e_nvp_netbinding_update (the same name and the same content). As far as I checked it is the only case of such error.","commit_id":"a2f88771626d8827aea404e52b4fb08ad2fd0bba"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"71361780ffeb7502341358be4a87b8a7e5970979","unresolved":false,"context_lines":[{"line_number":46,"context_line":"def get_enum():"},{"line_number":47,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":48,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":49,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":50,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":51,"context_line":"                    create_type\u003dFalse)"},{"line_number":52,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_be7d711e","line":49,"updated":"2014-06-04 09:12:18.000000000","message":"Why is it necessary to use the postgres version explicitly?  Unknown kwargs passed to sa.Enum are ignored by backends that do not support them. See:\nhttp://docs.sqlalchemy.org/en/rel_0_8/core/types.html#sqlalchemy.types.Enum","commit_id":"732bdbb75b54575488e3407262fa04674fb8e84d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d4e55d85a3b03330d9f48ff6a49f5dcba7ff7b5a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"def get_enum():"},{"line_number":47,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":48,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":49,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":50,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":51,"context_line":"                    create_type\u003dFalse)"},{"line_number":52,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_b0ae427f","line":49,"in_reply_to":"1ae5cdf2_818c5581","updated":"2014-06-13 15:39:17.000000000","message":"this paste appears to have been removed. Can you publish again the error you get?\n\nIt\u0027s sad that we need to make DB migrations backend-aware.","commit_id":"732bdbb75b54575488e3407262fa04674fb8e84d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"5abe88fcd92ed4878bd0e4f6f8e1ecf9a139a91c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"def get_enum():"},{"line_number":47,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":48,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":49,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":50,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":51,"context_line":"                    create_type\u003dFalse)"},{"line_number":52,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_47a9f87a","line":49,"in_reply_to":"1ae5cdf2_b0ae427f","updated":"2014-06-19 11:42:02.000000000","message":"http://paste.openstack.org/show/84486/ there is a new paste with the same error","commit_id":"732bdbb75b54575488e3407262fa04674fb8e84d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c877604437d5d075ba5294619f2d5c9485452637","unresolved":false,"context_lines":[{"line_number":46,"context_line":"def get_enum():"},{"line_number":47,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":48,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":49,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":50,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":51,"context_line":"                    create_type\u003dFalse)"},{"line_number":52,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1ae5cdf2_818c5581","line":49,"in_reply_to":"1ae5cdf2_be7d711e","updated":"2014-06-09 09:53:05.000000000","message":"Because this does not work in this way.\nTo check this run downgrade for this migration you will get error http://pastebin.com/Rs31dnSx. Just adding create_type\u003dFalse also don\u0027t help.","commit_id":"732bdbb75b54575488e3407262fa04674fb8e84d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c96bb14372afb1c0da881c9d1ddba8f97e59155e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from alembic import op"},{"line_number":38,"context_line":"import sqlalchemy as sa"},{"line_number":39,"context_line":"from sqlalchemy.dialects.postgres import ENUM"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from neutron.db import migration"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_3b3e5cb9","line":39,"range":{"start_line":39,"start_character":25,"end_line":39,"end_character":33},"updated":"2014-07-01 12:14:30.000000000","message":"s/postgres/postgresql/\n\n\"postgres\" dialect was renamed to \"postgresql\".","commit_id":"36a8375dcfd4bbb41d43958ca9ad164e35c5199f"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1e53b4dbddc780a4e240cbcbc2338072e37fb571","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from alembic import op"},{"line_number":38,"context_line":"import sqlalchemy as sa"},{"line_number":39,"context_line":"from sqlalchemy.dialects.postgres import ENUM"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from neutron.db import migration"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_fbce80b3","line":39,"in_reply_to":"baada198_3b3e5cb9","updated":"2014-07-02 08:11:12.000000000","message":"Thanks, done","commit_id":"36a8375dcfd4bbb41d43958ca9ad164e35c5199f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8b28cd0d249ff762cb762b00dfe96390b2c6054","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from alembic import op"},{"line_number":38,"context_line":"import sqlalchemy as sa"},{"line_number":39,"context_line":"from sqlalchemy.dialects.postgresql import ENUM"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from neutron.db import migration"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_2009bcdd","line":39,"updated":"2014-07-16 18:21:04.000000000","message":"Please import the module, not the class.","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6fb2a26209d6cc3b434a18d891ece2c5f068899b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from alembic import op"},{"line_number":38,"context_line":"import sqlalchemy as sa"},{"line_number":39,"context_line":"from sqlalchemy.dialects.postgresql import ENUM"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from neutron.db import migration"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_514aeb55","line":39,"in_reply_to":"baada198_2009bcdd","updated":"2014-07-17 08:00:18.000000000","message":"Done","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8b28cd0d249ff762cb762b00dfe96390b2c6054","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def get_enum():"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":47,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":48,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":49,"context_line":"                    create_type\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_a0c94c7b","line":46,"updated":"2014-07-16 18:21:04.000000000","message":"I think a comment should go here explaining why this is needed for postgresql:\n\n# In PostgreSQL we should not create a new enum type, but instead use the existing one already created in migration 1341ed32cc1e_nvp_netbinding_update","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6fb2a26209d6cc3b434a18d891ece2c5f068899b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def get_enum():"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":47,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":48,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":49,"context_line":"                    create_type\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_9173a3b3","line":46,"in_reply_to":"baada198_a0c94c7b","updated":"2014-07-17 08:00:18.000000000","message":"Done","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d8b28cd0d249ff762cb762b00dfe96390b2c6054","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def get_enum():"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":47,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":48,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":49,"context_line":"                    create_type\u003dFalse)"},{"line_number":50,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_40dcf046","line":47,"updated":"2014-07-16 18:21:04.000000000","message":"postgresql.ENUM","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6fb2a26209d6cc3b434a18d891ece2c5f068899b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def get_enum():"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":47,"context_line":"        return ENUM(\u0027flat\u0027, \u0027vlan\u0027, \u0027stt\u0027, \u0027gre\u0027, \u0027l3_ext\u0027,"},{"line_number":48,"context_line":"                    name\u003d\u0027nvp_network_bindings_binding_type\u0027,"},{"line_number":49,"context_line":"                    create_type\u003dFalse)"},{"line_number":50,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"baada198_b176e7a1","line":47,"in_reply_to":"baada198_40dcf046","updated":"2014-07-17 08:00:18.000000000","message":"Done","commit_id":"f5d920d6bfc492932d8d32d23bbccc967753201d"}],"neutron/db/migration/alembic_migrations/versions/f489cf14a79c_lbaas_havana.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"aab7448a9fc55e5b8ce76f80bf8616b4ad4c83d3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"pools_lb_method \u003d sa.Enum(\"ROUND_ROBIN\", \"LEAST_CONNECTIONS\", \"SOURCE_IP\","},{"line_number":42,"context_line":"                          name\u003d\"pools_lb_method\")"},{"line_number":43,"context_line":"healthmontiors_type \u003d sa.Enum(\"PING\", \"TCP\", \"HTTP\", \"HTTPS\","},{"line_number":44,"context_line":"                              name\u003d\"healthmontiors_type\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_e7cabe6c","line":44,"updated":"2014-07-15 11:56:39.000000000","message":"I know you have to keep the typo here because the enum name had a typo in the original migration. However, you should not feel forced to use a variable name with a typo in it as well!","commit_id":"030ae9feca1fd21a6d575a1edabd3f57404b4296"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"3871b6b7508eb29af19e1d7c0344979ecd3fdf2a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"pools_lb_method \u003d sa.Enum(\"ROUND_ROBIN\", \"LEAST_CONNECTIONS\", \"SOURCE_IP\","},{"line_number":42,"context_line":"                          name\u003d\"pools_lb_method\")"},{"line_number":43,"context_line":"healthmontiors_type \u003d sa.Enum(\"PING\", \"TCP\", \"HTTP\", \"HTTPS\","},{"line_number":44,"context_line":"                              name\u003d\"healthmontiors_type\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_c7405aa7","line":44,"in_reply_to":"baada198_e7cabe6c","updated":"2014-07-15 12:01:46.000000000","message":"Thanks for pointing this. I\u0027ll correct the variable name.","commit_id":"030ae9feca1fd21a6d575a1edabd3f57404b4296"}]}
