)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"c6e4e4996ed25a91a73e63522e371c79e527ccb0","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                    msg \u003d \"cannot use \u0027strict\u0027 with \u0027add\u0027 action\""},{"line_number":422,"context_line":"                    raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        addl_param \u003d [\"--strict\"] if strict else []"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":427,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_d8f8a77d","line":424,"range":{"start_line":424,"start_character":8,"end_line":424,"end_character":12},"updated":"2018-01-23 07:38:52.000000000","message":"I guess you meant an abbrev for additional here, which wasn\u0027t clear for me. I guess extra_param would be less confusing.","commit_id":"3c7b9bda9f53ab230539f95ac0e7d1827d4d5444"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5160a5fab2b945fdddf19e96eb585066a15bed56","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                    msg \u003d \"cannot use \u0027strict\u0027 with \u0027add\u0027 action\""},{"line_number":422,"context_line":"                    raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        addl_param \u003d [\"--strict\"] if strict else []"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        if action \u003d\u003d \u0027del\u0027 and {} in kwargs_list:"},{"line_number":427,"context_line":"            # the \u0027del\u0027 case simplifies itself if kwargs_list has at least"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_996221d8","line":424,"range":{"start_line":424,"start_character":8,"end_line":424,"end_character":12},"in_reply_to":"7f96bb07_d8f8a77d","updated":"2018-01-23 08:59:41.000000000","message":"Done, I picked addl as it\u0027s used on multiple places in Neutron codebase but extra_param sounds really better.","commit_id":"3c7b9bda9f53ab230539f95ac0e7d1827d4d5444"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"c6e4e4996ed25a91a73e63522e371c79e527ccb0","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action, strict)"},{"line_number":432,"context_line":"                         for kw in kwargs_list]"},{"line_number":433,"context_line":"            if action \u003d\u003d \u0027add\u0027 and use_bundle:"},{"line_number":434,"context_line":"                addl_param.append(\u0027--bundle\u0027)"},{"line_number":435,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, addl_param + [\u0027-\u0027],"},{"line_number":436,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_f866c355","line":434,"updated":"2018-01-23 07:38:52.000000000","message":"ovs-ofctl(8) says --bundle can be used for mod-flows and del-flows too. Why do you restrict --bundle to add-flows only?","commit_id":"3c7b9bda9f53ab230539f95ac0e7d1827d4d5444"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"5160a5fab2b945fdddf19e96eb585066a15bed56","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            flow_strs \u003d [_build_flow_expr_str(kw, action, strict)"},{"line_number":432,"context_line":"                         for kw in kwargs_list]"},{"line_number":433,"context_line":"            if action \u003d\u003d \u0027add\u0027 and use_bundle:"},{"line_number":434,"context_line":"                addl_param.append(\u0027--bundle\u0027)"},{"line_number":435,"context_line":"            self.run_ofctl(\u0027%s-flows\u0027 % action, addl_param + [\u0027-\u0027],"},{"line_number":436,"context_line":"                           \u0027\\n\u0027.join(flow_strs))"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_f96325dc","line":434,"in_reply_to":"7f96bb07_f866c355","updated":"2018-01-23 08:59:41.000000000","message":"We won\u0027t use it for mod-flows and del-flows so I considered those two a YAGNI. Maybe we can use it for del-flows though, I\u0027ll do some testing. Thanks for pointing it out.","commit_id":"3c7b9bda9f53ab230539f95ac0e7d1827d4d5444"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5e8490900f35c07ced8bb9102da30b2de7aa9a8","unresolved":false,"context_lines":[{"line_number":924,"context_line":"    ALLOWED_PASSTHROUGHS \u003d \u0027add_port\u0027, \u0027add_tunnel_port\u0027, \u0027delete_port\u0027"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def __init__(self, br, full_ordered\u003dFalse,"},{"line_number":927,"context_line":"                 order\u003d(\u0027add\u0027, \u0027mod\u0027, \u0027del\u0027), use_bundle\u003dFalse):"},{"line_number":928,"context_line":"        \u0027\u0027\u0027Constructor."},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        :param br: wrapped bridge"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f9dbf25_94c53691","line":927,"updated":"2018-03-01 09:02:42.000000000","message":"if it is so much faster why it is still possible to not use it and why it is not used by default? Can it breaks anything?","commit_id":"908175e8b6fcb6387519a5f488bafc847b9f9489"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9143f9fefad0b591f478c14d26470c2a60283a7c","unresolved":false,"context_lines":[{"line_number":924,"context_line":"    ALLOWED_PASSTHROUGHS \u003d \u0027add_port\u0027, \u0027add_tunnel_port\u0027, \u0027delete_port\u0027"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"    def __init__(self, br, full_ordered\u003dFalse,"},{"line_number":927,"context_line":"                 order\u003d(\u0027add\u0027, \u0027mod\u0027, \u0027del\u0027), use_bundle\u003dFalse):"},{"line_number":928,"context_line":"        \u0027\u0027\u0027Constructor."},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        :param br: wrapped bridge"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff6b8bd7_4f888d1e","line":927,"in_reply_to":"1f9dbf25_94c53691","updated":"2018-03-05 13:14:10.000000000","message":"You mean in our code? I\u0027d rather keep it backward compatible than forcing everyone to use bundled actions.","commit_id":"908175e8b6fcb6387519a5f488bafc847b9f9489"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5e8490900f35c07ced8bb9102da30b2de7aa9a8","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        :param br: wrapped bridge"},{"line_number":931,"context_line":"        :param full_ordered: Optional, disable flow reordering (slower)"},{"line_number":932,"context_line":"        :param order: Optional, define in which order flow are applied"},{"line_number":933,"context_line":"        \u0027\u0027\u0027"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        self.br \u003d br"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f9dbf25_748e6a79","line":932,"updated":"2018-03-01 09:02:42.000000000","message":"You should add description for this new parameter in docstring","commit_id":"908175e8b6fcb6387519a5f488bafc847b9f9489"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9143f9fefad0b591f478c14d26470c2a60283a7c","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"        :param br: wrapped bridge"},{"line_number":931,"context_line":"        :param full_ordered: Optional, disable flow reordering (slower)"},{"line_number":932,"context_line":"        :param order: Optional, define in which order flow are applied"},{"line_number":933,"context_line":"        \u0027\u0027\u0027"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        self.br \u003d br"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff6b8bd7_ef7c0122","line":932,"in_reply_to":"1f9dbf25_748e6a79","updated":"2018-03-05 13:14:10.000000000","message":"Done","commit_id":"908175e8b6fcb6387519a5f488bafc847b9f9489"}]}