)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"eca71e3ea7a3feb56f403b0c862c15a922216644","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbhaley@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-20 15:42:52 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use constant IP_VERSION_4/6 in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I54bec2c06940b0b1362fecacef7860361d081601"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f6a8fd7_98997a7a","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":36},"updated":"2018-04-20 21:01:47.000000000","message":"why not entire neutron ?\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L166 too ?","commit_id":"9a3adc43695c0783e5f7a768494079c163ab0b72"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c84fbe9c40c7bc9c4cfa55082e63fcebd15f08ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbhaley@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-20 15:42:52 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use constant IP_VERSION_4/6 in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I54bec2c06940b0b1362fecacef7860361d081601"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f6a8fd7_bb29c18a","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":36},"in_reply_to":"9f6a8fd7_98997a7a","updated":"2018-04-23 12:52:06.000000000","message":"Manjeet - One reason is that this patch is already very large, we could have almost split it up in sections - unit, functional, etc. to make it more reviewable.  The other reason I\u0027d leave the \"dev\" side of the tree out for now is that it makes back-porting a little harder, even this change will be disruptive.  But I think we could do it separately.","commit_id":"9a3adc43695c0783e5f7a768494079c163ab0b72"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"818c300ebf3a3781a092756525dab18eb742e08a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbhaley@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-20 15:42:52 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use constant IP_VERSION_4/6 in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I54bec2c06940b0b1362fecacef7860361d081601"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_6b5e1313","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":36},"in_reply_to":"9f6a8fd7_bb29c18a","updated":"2018-08-10 19:28:16.000000000","message":"Split out the functional test into another patch: https://review.openstack.org/#/c/591059/ . This patch will focus on unit test.","commit_id":"9a3adc43695c0783e5f7a768494079c163ab0b72"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6d441390bbc75d46b71b4f6e678d8d4248f4eb18","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbhaley@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-20 15:42:52 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use constant IP_VERSION_4/6 in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I54bec2c06940b0b1362fecacef7860361d081601"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f6a8fd7_17751964","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":36},"in_reply_to":"9f6a8fd7_bb29c18a","updated":"2018-04-23 17:54:03.000000000","message":"ohk, I thought its better to be done everywhere, the way I grepped I could find that https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L166 only left so thought why not that too","commit_id":"9a3adc43695c0783e5f7a768494079c163ab0b72"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1600c922604af956f3b52625d96ecd30a53df109","unresolved":false,"context_lines":[{"line_number":72,"context_line":"fake_subnet3 \u003d dhcp.DictModel(dict(id\u003d\u0027bbbbbbbb-1111-2222-bbbbbbbbbbbb\u0027,"},{"line_number":73,"context_line":"                              network_id\u003dFAKE_NETWORK_UUID,"},{"line_number":74,"context_line":"                              cidr\u003d\u0027192.168.1.1/24\u0027, enable_dhcp\u003dTrue,"},{"line_number":75,"context_line":"                              ip_version\u003d4))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"fake_ipv6_subnet \u003d dhcp.DictModel(dict(id\u003d\u0027bbbbbbbb-1111-2222-bbbbbbbbbbbb\u0027,"},{"line_number":78,"context_line":"                              network_id\u003dFAKE_NETWORK_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_ddbbc4c1","line":75,"range":{"start_line":75,"start_character":41,"end_line":75,"end_character":42},"updated":"2018-01-12 20:30:13.000000000","message":"If you\u0027re going to do IPv6 you should do IPv4 for parity.","commit_id":"9099d867c2ed9267f11c8b5b2c6aff8c67f025d7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9b7074d82b98f3cd9de548b06a028915ea2d9e49","unresolved":false,"context_lines":[{"line_number":72,"context_line":"fake_subnet3 \u003d dhcp.DictModel(dict(id\u003d\u0027bbbbbbbb-1111-2222-bbbbbbbbbbbb\u0027,"},{"line_number":73,"context_line":"                              network_id\u003dFAKE_NETWORK_UUID,"},{"line_number":74,"context_line":"                              cidr\u003d\u0027192.168.1.1/24\u0027, enable_dhcp\u003dTrue,"},{"line_number":75,"context_line":"                              ip_version\u003d4))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"fake_ipv6_subnet \u003d dhcp.DictModel(dict(id\u003d\u0027bbbbbbbb-1111-2222-bbbbbbbbbbbb\u0027,"},{"line_number":78,"context_line":"                              network_id\u003dFAKE_NETWORK_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_616e6996","line":75,"range":{"start_line":75,"start_character":41,"end_line":75,"end_character":42},"in_reply_to":"7f96bb07_ddbbc4c1","updated":"2018-01-15 12:04:21.000000000","message":"I agree that it should be done in same patch for both versions","commit_id":"9099d867c2ed9267f11c8b5b2c6aff8c67f025d7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b5d0997a8ccbaabfaee5dd4dd131a9adf8c831f8","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"class FakeV4Subnet(object):"},{"line_number":1342,"context_line":"    def __init__(self):"},{"line_number":1343,"context_line":"        self.id \u003d \u0027dddddddd-dddd-dddd-dddd-dddddddddddd\u0027"},{"line_number":1344,"context_line":"        self.ip_version \u003d 4"},{"line_number":1345,"context_line":"        self.cidr \u003d \u0027192.168.0.0/24\u0027"},{"line_number":1346,"context_line":"        self.gateway_ip \u003d \u0027192.168.0.1\u0027"},{"line_number":1347,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_483970f0","line":1344,"range":{"start_line":1344,"start_character":26,"end_line":1344,"end_character":27},"updated":"2018-01-19 13:51:40.000000000","message":"what about here?","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"class FakeV4Subnet(object):"},{"line_number":1342,"context_line":"    def __init__(self):"},{"line_number":1343,"context_line":"        self.id \u003d \u0027dddddddd-dddd-dddd-dddd-dddddddddddd\u0027"},{"line_number":1344,"context_line":"        self.ip_version \u003d 4"},{"line_number":1345,"context_line":"        self.cidr \u003d \u0027192.168.0.0/24\u0027"},{"line_number":1346,"context_line":"        self.gateway_ip \u003d \u0027192.168.0.1\u0027"},{"line_number":1347,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_7082d8ca","line":1344,"range":{"start_line":1344,"start_character":26,"end_line":1344,"end_character":27},"in_reply_to":"7f96bb07_483970f0","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b5d0997a8ccbaabfaee5dd4dd131a9adf8c831f8","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"class FakeV6Subnet(object):"},{"line_number":1351,"context_line":"    def __init__(self):"},{"line_number":1352,"context_line":"        self.id \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":1353,"context_line":"        self.ip_version \u003d 6"},{"line_number":1354,"context_line":"        self.cidr \u003d \u00272001:db8:0:1::/64\u0027"},{"line_number":1355,"context_line":"        self.gateway_ip \u003d \u00272001:db8:0:1::1\u0027"},{"line_number":1356,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_082368c0","line":1353,"range":{"start_line":1353,"start_character":26,"end_line":1353,"end_character":27},"updated":"2018-01-19 13:51:40.000000000","message":"what about here?","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"class FakeV6Subnet(object):"},{"line_number":1351,"context_line":"    def __init__(self):"},{"line_number":1352,"context_line":"        self.id \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":1353,"context_line":"        self.ip_version \u003d 6"},{"line_number":1354,"context_line":"        self.cidr \u003d \u00272001:db8:0:1::/64\u0027"},{"line_number":1355,"context_line":"        self.gateway_ip \u003d \u00272001:db8:0:1::1\u0027"},{"line_number":1356,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_908524d2","line":1353,"range":{"start_line":1353,"start_character":26,"end_line":1353,"end_character":27},"in_reply_to":"7f96bb07_082368c0","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b5d0997a8ccbaabfaee5dd4dd131a9adf8c831f8","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"class FakeV4SubnetNoGateway(object):"},{"line_number":1372,"context_line":"    def __init__(self):"},{"line_number":1373,"context_line":"        self.id \u003d \u0027eeeeeeee-eeee-eeee-eeee-eeeeeeeeeeee\u0027"},{"line_number":1374,"context_line":"        self.ip_version \u003d 4"},{"line_number":1375,"context_line":"        self.cidr \u003d \u0027192.168.1.0/24\u0027"},{"line_number":1376,"context_line":"        self.gateway_ip \u003d None"},{"line_number":1377,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_8818d884","line":1374,"range":{"start_line":1374,"start_character":26,"end_line":1374,"end_character":27},"updated":"2018-01-19 13:51:40.000000000","message":"same","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"class FakeV4SubnetNoGateway(object):"},{"line_number":1372,"context_line":"    def __init__(self):"},{"line_number":1373,"context_line":"        self.id \u003d \u0027eeeeeeee-eeee-eeee-eeee-eeeeeeeeeeee\u0027"},{"line_number":1374,"context_line":"        self.ip_version \u003d 4"},{"line_number":1375,"context_line":"        self.cidr \u003d \u0027192.168.1.0/24\u0027"},{"line_number":1376,"context_line":"        self.gateway_ip \u003d None"},{"line_number":1377,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_50679c52","line":1374,"range":{"start_line":1374,"start_character":26,"end_line":1374,"end_character":27},"in_reply_to":"7f96bb07_8818d884","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b5d0997a8ccbaabfaee5dd4dd131a9adf8c831f8","unresolved":false,"context_lines":[{"line_number":1380,"context_line":"class FakeV6SubnetNoGateway(object):"},{"line_number":1381,"context_line":"    def __init__(self):"},{"line_number":1382,"context_line":"        self.id \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":1383,"context_line":"        self.ip_version \u003d 6"},{"line_number":1384,"context_line":"        self.cidr \u003d \u00272001:db8:1:0::/64\u0027"},{"line_number":1385,"context_line":"        self.gateway_ip \u003d None"},{"line_number":1386,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_a81d9474","line":1383,"range":{"start_line":1383,"start_character":26,"end_line":1383,"end_character":27},"updated":"2018-01-19 13:51:40.000000000","message":"same","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":1380,"context_line":"class FakeV6SubnetNoGateway(object):"},{"line_number":1381,"context_line":"    def __init__(self):"},{"line_number":1382,"context_line":"        self.id \u003d \u0027ffffffff-ffff-ffff-ffff-ffffffffffff\u0027"},{"line_number":1383,"context_line":"        self.ip_version \u003d 6"},{"line_number":1384,"context_line":"        self.cidr \u003d \u00272001:db8:1:0::/64\u0027"},{"line_number":1385,"context_line":"        self.gateway_ip \u003d None"},{"line_number":1386,"context_line":"        self.enable_dhcp \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_f07588fb","line":1383,"range":{"start_line":1383,"start_character":26,"end_line":1383,"end_character":27},"in_reply_to":"7f96bb07_a81d9474","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"211bff8feacb22941885228548a16e7dae5b1b00","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class DhcpOpt(object):"},{"line_number":55,"context_line":"    def __init__(self, **kwargs):"},{"line_number":56,"context_line":"        self.__dict__.update(ip_version\u003d4)"},{"line_number":57,"context_line":"        self.__dict__.update(kwargs)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_61b6d0df","line":56,"updated":"2018-01-19 08:33:45.000000000","message":"please change also here","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class DhcpOpt(object):"},{"line_number":55,"context_line":"    def __init__(self, **kwargs):"},{"line_number":56,"context_line":"        self.__dict__.update(ip_version\u003d4)"},{"line_number":57,"context_line":"        self.__dict__.update(kwargs)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_b061403c","line":56,"in_reply_to":"7f96bb07_61b6d0df","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"211bff8feacb22941885228548a16e7dae5b1b00","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.extra_dhcp_opts \u003d ["},{"line_number":189,"context_line":"            DhcpOpt(opt_name\u003dedo_ext.DHCP_OPT_CLIENT_ID,"},{"line_number":190,"context_line":"                    opt_value\u003d\u0027test6\u0027,"},{"line_number":191,"context_line":"                    ip_version\u003d4),"},{"line_number":192,"context_line":"            DhcpOpt(opt_name\u003d\u0027dns-server\u0027,"},{"line_number":193,"context_line":"                    opt_value\u003d\u0027123.123.123.45\u0027,"},{"line_number":194,"context_line":"                    ip_version\u003d4)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_41b5d4cc","line":191,"updated":"2018-01-19 08:33:45.000000000","message":"please change also here","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.extra_dhcp_opts \u003d ["},{"line_number":189,"context_line":"            DhcpOpt(opt_name\u003dedo_ext.DHCP_OPT_CLIENT_ID,"},{"line_number":190,"context_line":"                    opt_value\u003d\u0027test6\u0027,"},{"line_number":191,"context_line":"                    ip_version\u003d4),"},{"line_number":192,"context_line":"            DhcpOpt(opt_name\u003d\u0027dns-server\u0027,"},{"line_number":193,"context_line":"                    opt_value\u003d\u0027123.123.123.45\u0027,"},{"line_number":194,"context_line":"                    ip_version\u003d4)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_d0640c4c","line":191,"in_reply_to":"7f96bb07_41b5d4cc","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"211bff8feacb22941885228548a16e7dae5b1b00","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                    ip_version\u003d4),"},{"line_number":192,"context_line":"            DhcpOpt(opt_name\u003d\u0027dns-server\u0027,"},{"line_number":193,"context_line":"                    opt_value\u003d\u0027123.123.123.45\u0027,"},{"line_number":194,"context_line":"                    ip_version\u003d4)]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class FakeV6Port(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_e1c9805a","line":194,"updated":"2018-01-19 08:33:45.000000000","message":"ditto","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                    ip_version\u003d4),"},{"line_number":192,"context_line":"            DhcpOpt(opt_name\u003d\u0027dns-server\u0027,"},{"line_number":193,"context_line":"                    opt_value\u003d\u0027123.123.123.45\u0027,"},{"line_number":194,"context_line":"                    ip_version\u003d4)]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class FakeV6Port(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_705bb886","line":194,"in_reply_to":"7f96bb07_e1c9805a","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"211bff8feacb22941885228548a16e7dae5b1b00","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"            prefix6 \u003d \u0027--dhcp-range\u003dset:tag%d,%s,%s,%s%s\u0027"},{"line_number":1221,"context_line":"        possible_leases \u003d 0"},{"line_number":1222,"context_line":"        for i, s in enumerate(network.subnets):"},{"line_number":1223,"context_line":"            if (s.ip_version !\u003d 6"},{"line_number":1224,"context_line":"                or s.ipv6_address_mode \u003d\u003d constants.DHCPV6_STATEFUL):"},{"line_number":1225,"context_line":"                if s.ip_version \u003d\u003d 4:"},{"line_number":1226,"context_line":"                    expected.extend([prefix % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_a1aa986e","line":1223,"updated":"2018-01-19 08:33:45.000000000","message":"shouldn\u0027t You change also here?","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"            prefix6 \u003d \u0027--dhcp-range\u003dset:tag%d,%s,%s,%s%s\u0027"},{"line_number":1221,"context_line":"        possible_leases \u003d 0"},{"line_number":1222,"context_line":"        for i, s in enumerate(network.subnets):"},{"line_number":1223,"context_line":"            if (s.ip_version !\u003d 6"},{"line_number":1224,"context_line":"                or s.ipv6_address_mode \u003d\u003d constants.DHCPV6_STATEFUL):"},{"line_number":1225,"context_line":"                if s.ip_version \u003d\u003d 4:"},{"line_number":1226,"context_line":"                    expected.extend([prefix % ("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_5050fc5e","line":1223,"in_reply_to":"7f96bb07_a1aa986e","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"211bff8feacb22941885228548a16e7dae5b1b00","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"        for i, s in enumerate(network.subnets):"},{"line_number":1223,"context_line":"            if (s.ip_version !\u003d 6"},{"line_number":1224,"context_line":"                or s.ipv6_address_mode \u003d\u003d constants.DHCPV6_STATEFUL):"},{"line_number":1225,"context_line":"                if s.ip_version \u003d\u003d 4:"},{"line_number":1226,"context_line":"                    expected.extend([prefix % ("},{"line_number":1227,"context_line":"                        i, s.cidr.split(\u0027/\u0027)[0],"},{"line_number":1228,"context_line":"                        netaddr.IPNetwork(s.cidr).netmask, lease_duration,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_c1a7a4a7","line":1225,"updated":"2018-01-19 08:33:45.000000000","message":"and here","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d070440515f8af4b5f1ac8df029a01ad4f9d28a","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"        for i, s in enumerate(network.subnets):"},{"line_number":1223,"context_line":"            if (s.ip_version !\u003d 6"},{"line_number":1224,"context_line":"                or s.ipv6_address_mode \u003d\u003d constants.DHCPV6_STATEFUL):"},{"line_number":1225,"context_line":"                if s.ip_version \u003d\u003d 4:"},{"line_number":1226,"context_line":"                    expected.extend([prefix % ("},{"line_number":1227,"context_line":"                        i, s.cidr.split(\u0027/\u0027)[0],"},{"line_number":1228,"context_line":"                        netaddr.IPNetwork(s.cidr).netmask, lease_duration,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_f04ee8bf","line":1225,"in_reply_to":"7f96bb07_c1a7a4a7","updated":"2018-01-22 21:19:11.000000000","message":"Done","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"211bff8feacb22941885228548a16e7dae5b1b00","unresolved":false,"context_lines":[{"line_number":5028,"context_line":"                                gateway_ip\u003d\u002710.0.1.1\u0027,"},{"line_number":5029,"context_line":"                                cidr\u003d\u002710.0.1.0/24\u0027) as v2:"},{"line_number":5030,"context_line":"                subnets \u003d (v1, v2)"},{"line_number":5031,"context_line":"                query_params \u003d \u0027ip_version\u003d4\u0026ip_version\u003d6\u0027"},{"line_number":5032,"context_line":"                self._test_list_resources(\u0027subnet\u0027, subnets,"},{"line_number":5033,"context_line":"                                          query_params\u003dquery_params)"},{"line_number":5034,"context_line":"                query_params \u003d \u0027ip_version\u003d6\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_41eab4ac","line":5031,"updated":"2018-01-19 08:33:45.000000000","message":"IMHO You can use constants also here","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"211bff8feacb22941885228548a16e7dae5b1b00","unresolved":false,"context_lines":[{"line_number":5031,"context_line":"                query_params \u003d \u0027ip_version\u003d4\u0026ip_version\u003d6\u0027"},{"line_number":5032,"context_line":"                self._test_list_resources(\u0027subnet\u0027, subnets,"},{"line_number":5033,"context_line":"                                          query_params\u003dquery_params)"},{"line_number":5034,"context_line":"                query_params \u003d \u0027ip_version\u003d6\u0027"},{"line_number":5035,"context_line":"                self._test_list_resources(\u0027subnet\u0027, [],"},{"line_number":5036,"context_line":"                                          query_params\u003dquery_params)"},{"line_number":5037,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_e1ce605a","line":5034,"updated":"2018-01-19 08:33:45.000000000","message":"ditto","commit_id":"cd958f71e4e65cc8c08228bb37027b9deb264980"}]}