)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"94b72edc44f8b24e4f8f7e03b1fde14787ca9a1d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Today neutron.common.rpc has a handful of public constants and functions"},{"line_number":10,"context_line":"that are not used outside of neutron. This patch removes those not"},{"line_number":11,"context_line":"externally used and enhances the rpc.init function to accept extra"},{"line_number":12,"context_line":"RPC exception modules (though it\u0027s not used today) to still support"},{"line_number":13,"context_line":"the notion of \"extra mods\" for RPC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch also paves the way for easier rehoming the module to"},{"line_number":16,"context_line":"neutron-lib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_bc78e8c3","line":13,"range":{"start_line":12,"start_character":51,"end_line":13,"end_character":35},"updated":"2018-01-16 17:13:37.000000000","message":"what\u0027s the actual use case behind it? I am sorry it\u0027s probably a dumb question, but if it\u0027s not used right now, then why do we need it?","commit_id":"9699e62247a2ddd5770e7db6ec9ebdd1a057a4ae"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b21c897d14fa475b836c606fd17aacdb09dfb04c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Today neutron.common.rpc has a handful of public constants and functions"},{"line_number":10,"context_line":"that are not used outside of neutron. This patch removes those not"},{"line_number":11,"context_line":"externally used and enhances the rpc.init function to accept extra"},{"line_number":12,"context_line":"RPC exception modules (though it\u0027s not used today) to still support"},{"line_number":13,"context_line":"the notion of \"extra mods\" for RPC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch also paves the way for easier rehoming the module to"},{"line_number":16,"context_line":"neutron-lib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_25fb22be","line":13,"range":{"start_line":12,"start_character":51,"end_line":13,"end_character":35},"in_reply_to":"7f96bb07_75382e9f","updated":"2018-02-23 16:42:51.000000000","message":"I would cut it off if it\u0027s not used anywhere, but ok.","commit_id":"9699e62247a2ddd5770e7db6ec9ebdd1a057a4ae"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e575751066d80ad83ed8b2e292316b79a04f21f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Today neutron.common.rpc has a handful of public constants and functions"},{"line_number":10,"context_line":"that are not used outside of neutron. This patch removes those not"},{"line_number":11,"context_line":"externally used and enhances the rpc.init function to accept extra"},{"line_number":12,"context_line":"RPC exception modules (though it\u0027s not used today) to still support"},{"line_number":13,"context_line":"the notion of \"extra mods\" for RPC."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch also paves the way for easier rehoming the module to"},{"line_number":16,"context_line":"neutron-lib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_75382e9f","line":13,"range":{"start_line":12,"start_character":51,"end_line":13,"end_character":35},"in_reply_to":"7f96bb07_bc78e8c3","updated":"2018-01-16 20:35:33.000000000","message":"It\u0027s a good point.\n\nToday we only have 1 consumer [1] and they are just using it generically for tests (it can be removed IMO).\n\nHowever based on the docs for the allowed_remote_exmods [1] that we should continue to expose this notion of consumers passing in the extra mods (in some form) as they could want to deserialize their own exceptions. Please correct me if you think we should in fact remove this notion in neutron.\n\n\n[1] http://git.openstack.org/cgit/openstack/networking-vsphere/tree/networking_vsphere/tests/base.py#n67\n[2] https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/transport.py","commit_id":"9699e62247a2ddd5770e7db6ec9ebdd1a057a4ae"}],"neutron/common/rpc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"94b72edc44f8b24e4f8f7e03b1fde14787ca9a1d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def init(conf, rpc_ext_mods\u003dNone):"},{"line_number":49,"context_line":"    global TRANSPORT, NOTIFICATION_TRANSPORT, NOTIFIER"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    rpc_ext_mods \u003d rpc_ext_mods or _DFT_EXMODS"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_dc02943d","line":48,"updated":"2018-01-16 17:13:37.000000000","message":"where is the new argument supposed to be used?","commit_id":"9699e62247a2ddd5770e7db6ec9ebdd1a057a4ae"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e575751066d80ad83ed8b2e292316b79a04f21f6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def init(conf, rpc_ext_mods\u003dNone):"},{"line_number":49,"context_line":"    global TRANSPORT, NOTIFICATION_TRANSPORT, NOTIFIER"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    rpc_ext_mods \u003d rpc_ext_mods or _DFT_EXMODS"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_1568cab6","line":48,"in_reply_to":"7f96bb07_dc02943d","updated":"2018-01-16 20:35:33.000000000","message":"The rpc_ext_mods arg is used in place of code that used to call add_extra_exmods(); they instead now just pass in the exmods to the init() rather than having to first setup with add_extra_exmods. Also see my response to the commit msg.","commit_id":"9699e62247a2ddd5770e7db6ec9ebdd1a057a4ae"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"94b72edc44f8b24e4f8f7e03b1fde14787ca9a1d","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            server.wait()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"def create_connection():"},{"line_number":327,"context_line":"    return Connection()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_7ca90022","line":327,"range":{"start_line":326,"start_character":0,"end_line":327,"end_character":23},"updated":"2018-01-16 17:13:37.000000000","message":"nit: create_connection \u003d Connection","commit_id":"9699e62247a2ddd5770e7db6ec9ebdd1a057a4ae"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e575751066d80ad83ed8b2e292316b79a04f21f6","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            server.wait()"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"def create_connection():"},{"line_number":327,"context_line":"    return Connection()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_f598bec0","line":327,"range":{"start_line":326,"start_character":0,"end_line":327,"end_character":23},"in_reply_to":"7f96bb07_7ca90022","updated":"2018-01-16 20:35:33.000000000","message":"I added a TODO. We need to clean up consumer uses first. I figured that could come separately.","commit_id":"9699e62247a2ddd5770e7db6ec9ebdd1a057a4ae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"de43361e3d767dcdf9e863c994dfc686746e20cb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    global TRANSPORT, NOTIFICATION_TRANSPORT, NOTIFIER"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    rpc_ext_mods \u003d rpc_ext_mods or _DFT_EXMODS"},{"line_number":52,"context_line":"    for exmod in _DFT_EXMODS:"},{"line_number":53,"context_line":"        if exmod not in rpc_ext_mods:"},{"line_number":54,"context_line":"            rpc_ext_mods.append(exmod)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    TRANSPORT \u003d oslo_messaging.get_rpc_transport("}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa0c359_3cb8f1e3","line":53,"range":{"start_line":52,"start_character":4,"end_line":53,"end_character":37},"updated":"2018-02-27 07:14:22.000000000","message":"I guess that it\u0027s no good check because the rpc_ext_mods is not passed in most cases. If you want to avoid overlap ext mods, why not following?\n\n  if rpc_ext_mods is None:\n      rpc_ext_mods \u003d _DFT_EXMODS\n  else:\n      rpc_ext_mods \u003d list(set(rpc_ext_mods + _DFT_EXMODS))","commit_id":"64376629e325d833a482be7828d27d9db83adac7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a4838461934aa5f0f8a7dc30b67af3730d165cac","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    global TRANSPORT, NOTIFICATION_TRANSPORT, NOTIFIER"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    rpc_ext_mods \u003d rpc_ext_mods or _DFT_EXMODS"},{"line_number":52,"context_line":"    for exmod in _DFT_EXMODS:"},{"line_number":53,"context_line":"        if exmod not in rpc_ext_mods:"},{"line_number":54,"context_line":"            rpc_ext_mods.append(exmod)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    TRANSPORT \u003d oslo_messaging.get_rpc_transport("}],"source_content_type":"text/x-python","patch_set":7,"id":"df7087c5_12613037","line":53,"range":{"start_line":52,"start_character":4,"end_line":53,"end_character":37},"in_reply_to":"3fa0c359_3cb8f1e3","updated":"2018-03-08 18:37:27.000000000","message":"Actually I do think your code is better/correct. This version actually updates a callers rpc_ext_mods which is probably not what we want.","commit_id":"64376629e325d833a482be7828d27d9db83adac7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a8deda8ac421f65d3cb1f083b2f185e0616d4da3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    global TRANSPORT, NOTIFICATION_TRANSPORT, NOTIFIER"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    rpc_ext_mods \u003d rpc_ext_mods or _DFT_EXMODS"},{"line_number":52,"context_line":"    for exmod in _DFT_EXMODS:"},{"line_number":53,"context_line":"        if exmod not in rpc_ext_mods:"},{"line_number":54,"context_line":"            rpc_ext_mods.append(exmod)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    TRANSPORT \u003d oslo_messaging.get_rpc_transport("}],"source_content_type":"text/x-python","patch_set":7,"id":"df7087c5_d2241810","line":53,"range":{"start_line":52,"start_character":4,"end_line":53,"end_character":37},"in_reply_to":"3fa0c359_3cb8f1e3","updated":"2018-03-08 18:35:22.000000000","message":"Technically rpc_ext_mods is not passed anywhere today; this is a new param to account for the change in EXTRA_EXMODS and maintaining that behavior\u0027s functionality. In either case, I\u0027m not seeing a change the end result here, but agree your code is cleaner... I\u0027ll update.","commit_id":"64376629e325d833a482be7828d27d9db83adac7"}],"neutron/tests/unit/common/test_rpc.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b96fca0c8d1ee1de2ae30b8b92912751b396846d","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        rpc.init(conf, rpc_ext_mods\u003d[\u0027foo\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        expected_mods \u003d [\u0027foo\u0027] + rpc._DFT_EXMODS"},{"line_number":71,"context_line":"        mock_trans.assert_called_once_with("},{"line_number":72,"context_line":"            conf, allowed_remote_exmods\u003dexpected_mods)"},{"line_number":73,"context_line":"        mock_noti_trans.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_20d3b53a","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":49},"updated":"2018-03-09 01:58:18.000000000","message":"list(set([\u0027foo\u0027] + rpc._DFT_EXMODS)) because this patch uses set() on L54 of rpc.py and it occurs UT error about order.","commit_id":"267856fecbbd5424f7cae2c7c56f66d78c7c0a8a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"de9470c748d5bec51e60242545892dbd66a5ab3a","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        rpc.init(conf, rpc_ext_mods\u003d[\u0027foo\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        expected_mods \u003d [\u0027foo\u0027] + rpc._DFT_EXMODS"},{"line_number":71,"context_line":"        mock_trans.assert_called_once_with("},{"line_number":72,"context_line":"            conf, allowed_remote_exmods\u003dexpected_mods)"},{"line_number":73,"context_line":"        mock_noti_trans.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_2f69508a","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":49},"in_reply_to":"df7087c5_20d3b53a","updated":"2018-03-09 19:14:08.000000000","message":"thanks","commit_id":"267856fecbbd5424f7cae2c7c56f66d78c7c0a8a"}]}