)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c93ed452672b46df02002eb76c688ba3eb9c101a","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                # The port disappeared and cannot be processed"},{"line_number":1530,"context_line":"                LOG.info(\"Port %s was not found on the integration bridge \""},{"line_number":1531,"context_line":"                         \"and will therefore not be processed\", device)"},{"line_number":1532,"context_line":"                self.ext_manager.delete_port(self.context, {\u0027port_id\u0027: device})"},{"line_number":1533,"context_line":"                skipped_devices.append(device)"},{"line_number":1534,"context_line":"                continue"},{"line_number":1535,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_d70fffde","line":1532,"updated":"2018-01-15 13:12:58.000000000","message":"What if any extension needs the vif from e.g. ovsdb but it\u0027s already gone? Perhaps we should wrap it with try-except?","commit_id":"a8271e978a1c540ae9888f568cf14b4c40ea1b6d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"71f94de1f028aa51c8238c0d7fdd8ed993a1ae8e","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                # The port disappeared and cannot be processed"},{"line_number":1530,"context_line":"                LOG.info(\"Port %s was not found on the integration bridge \""},{"line_number":1531,"context_line":"                         \"and will therefore not be processed\", device)"},{"line_number":1532,"context_line":"                self.ext_manager.delete_port(self.context, {\u0027port_id\u0027: device})"},{"line_number":1533,"context_line":"                skipped_devices.append(device)"},{"line_number":1534,"context_line":"                continue"},{"line_number":1535,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_1ab90ecb","line":1532,"in_reply_to":"7f96bb07_b7c7d345","updated":"2018-01-15 13:56:22.000000000","message":"Maybe handling such exceptions should be done in separate patch in all places where extension drivers are used.\n\nAccording to Your second question. Yes, usually it is handled by ovsdb monitor and then processed as removed port. But as I found in logs of such failed tests it looks like there is quite rare case when it fails. What happens then:\n\n- agent receive info about port update (because port is set to unbound) so it adds it to ports_info[\u0027updated\u0027] and start processing it in treat_devices_added_updated() method\n- in meantime our test (or it could be nova-compute also) removes port from integration bridge, so ovsdb monitor tells it to ovs agent and agent stores such info to process this port as removed in next iteration of rpc loop,\n\n- port is then not found in integration bridge (it\u0027s in treat_devices_added_updated) and is added to list of skipped devices which is fine,\n\n- ovs agent updates (in process_network_ports) list of current ports and removes from this list port which was already skipped (so it\u0027s port which we actually removed),\n\n- rpc loop iteration finishes and our port is not in \"current\" ports anymore, agent knows that ovsdb monitor signaled some changes in ovs so it starts scanning ports BUT there is nothing wrong as our port is not in current ports and it is also not in integration bridge SO agent will not perform it as \"removed\" in this iteration :)\n\n\nI hope it\u0027s clear for You why I want to call this ext_manager also for skipped ports here to clean for such ports everything which is added by L2 extensions.","commit_id":"a8271e978a1c540ae9888f568cf14b4c40ea1b6d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"42f15b5c9e2d4173f5c4ae5162952e173c5b0a69","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                # The port disappeared and cannot be processed"},{"line_number":1530,"context_line":"                LOG.info(\"Port %s was not found on the integration bridge \""},{"line_number":1531,"context_line":"                         \"and will therefore not be processed\", device)"},{"line_number":1532,"context_line":"                self.ext_manager.delete_port(self.context, {\u0027port_id\u0027: device})"},{"line_number":1533,"context_line":"                skipped_devices.append(device)"},{"line_number":1534,"context_line":"                continue"},{"line_number":1535,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_f7e0fbfc","line":1532,"in_reply_to":"7f96bb07_d70fffde","updated":"2018-01-15 13:14:36.000000000","message":"I think that extension should handle it. Please note that it is already done like that when ports are removed. Also e.g. qos extension driver can handle such case.","commit_id":"a8271e978a1c540ae9888f568cf14b4c40ea1b6d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c9bc6384a0f29c437f5e37688c32890e49093400","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                # The port disappeared and cannot be processed"},{"line_number":1530,"context_line":"                LOG.info(\"Port %s was not found on the integration bridge \""},{"line_number":1531,"context_line":"                         \"and will therefore not be processed\", device)"},{"line_number":1532,"context_line":"                self.ext_manager.delete_port(self.context, {\u0027port_id\u0027: device})"},{"line_number":1533,"context_line":"                skipped_devices.append(device)"},{"line_number":1534,"context_line":"                continue"},{"line_number":1535,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_b7c7d345","line":1532,"in_reply_to":"7f96bb07_f7e0fbfc","updated":"2018-01-15 13:20:05.000000000","message":"Generally thinking the extension implementation can be anything. Looking at extension manager code, it doesn\u0027t handle any exceptions coming from the implemented method: https://github.com/openstack/neutron/blob/master/neutron/agent/l2/l2_agent_extensions_manager.py#L54\n\nMaybe current delete_port in extension manager is wrong as if one extension raises an exception then it stops calling to other exceptions and it\u0027s out of the scope of this patch?\n\nOne more question - if vif disappears, it should be discovered by ip monitor and later processed by ovs-agent as deleted port, that calls into ext_manager, no?","commit_id":"a8271e978a1c540ae9888f568cf14b4c40ea1b6d"}]}
