)]}'
{"neutron/plugins/nicira/nvplib.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"cf521ff0a0a9a9a868230a46ed88edf7024a4a7c","unresolved":false,"context_lines":[{"line_number":383,"context_line":"def create_lrouter(cluster, *args, **kwargs):"},{"line_number":384,"context_line":"    if kwargs.get(\u0027distributed\u0027, None):"},{"line_number":385,"context_line":"        v \u003d cluster.api_client.get_nvp_version()"},{"line_number":386,"context_line":"        if (v.major \u003c 3) or (v.major \u003d\u003d 3 and v.minor \u003c 1):"},{"line_number":387,"context_line":"            raise nvp_exc.NvpInvalidVersion(version\u003dv)"},{"line_number":388,"context_line":"        return v"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F4Uw%3D","line":386,"updated":"2013-10-25 19:04:02.000000000","message":"FYI... python tuple can do some cool things...this works too:\n\nif (v.major, v.minor) \u003c\u003d (3, 1):","commit_id":"9eb06332f0292ed4db7b322e483167cb40740d6e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ea64cdfa48d756002fcf758f5326fa675fc9f29f","unresolved":false,"context_lines":[{"line_number":383,"context_line":"def create_lrouter(cluster, *args, **kwargs):"},{"line_number":384,"context_line":"    if kwargs.get(\u0027distributed\u0027, None):"},{"line_number":385,"context_line":"        v \u003d cluster.api_client.get_nvp_version()"},{"line_number":386,"context_line":"        if (v.major \u003c 3) or (v.major \u003d\u003d 3 and v.minor \u003c 1):"},{"line_number":387,"context_line":"            raise nvp_exc.NvpInvalidVersion(version\u003dv)"},{"line_number":388,"context_line":"        return v"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F7uw%3D","line":386,"updated":"2013-10-24 01:14:23.000000000","message":"wouldn\u0027t this work too: \n\nif(int(v) \u003c 3.2)","commit_id":"9eb06332f0292ed4db7b322e483167cb40740d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b3074bbd18bcf1c2c6b50d18b16c52e5da7fea12","unresolved":false,"context_lines":[{"line_number":383,"context_line":"def create_lrouter(cluster, *args, **kwargs):"},{"line_number":384,"context_line":"    if kwargs.get(\u0027distributed\u0027, None):"},{"line_number":385,"context_line":"        v \u003d cluster.api_client.get_nvp_version()"},{"line_number":386,"context_line":"        if (v.major \u003c 3) or (v.major \u003d\u003d 3 and v.minor \u003c 1):"},{"line_number":387,"context_line":"            raise nvp_exc.NvpInvalidVersion(version\u003dv)"},{"line_number":388,"context_line":"        return v"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F8SE%3D","line":386,"in_reply_to":"AAAATX%2F%2F7uw%3D","updated":"2013-10-24 20:48:34.000000000","message":"no it wouldn\u0027t because int(v) is not a valid int as the full version may contain the build number.","commit_id":"9eb06332f0292ed4db7b322e483167cb40740d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ba92d62f0e49b00598225bad09e0f8209c13dfdd","unresolved":false,"context_lines":[{"line_number":383,"context_line":"def create_lrouter(cluster, *args, **kwargs):"},{"line_number":384,"context_line":"    if kwargs.get(\u0027distributed\u0027, None):"},{"line_number":385,"context_line":"        v \u003d cluster.api_client.get_nvp_version()"},{"line_number":386,"context_line":"        if (v.major \u003c 3) or (v.major \u003d\u003d 3 and v.minor \u003c 1):"},{"line_number":387,"context_line":"            raise nvp_exc.NvpInvalidVersion(version\u003dv)"},{"line_number":388,"context_line":"        return v"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F4Mc%3D","line":386,"in_reply_to":"AAAATn%2F%2F4Uw%3D","updated":"2013-10-25 19:38:04.000000000","message":"nice! Thanks for the tip!","commit_id":"9eb06332f0292ed4db7b322e483167cb40740d6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"67bb751c0d0cb08b8f747e5c42a5eb2396860797","unresolved":false,"context_lines":[{"line_number":383,"context_line":"def create_lrouter(cluster, *args, **kwargs):"},{"line_number":384,"context_line":"    if kwargs.get(\u0027distributed\u0027, None):"},{"line_number":385,"context_line":"        v \u003d cluster.api_client.get_nvp_version()"},{"line_number":386,"context_line":"        if (v.major \u003c 3) or (v.major \u003d\u003d 3 and v.minor \u003c 1):"},{"line_number":387,"context_line":"            raise nvp_exc.NvpInvalidVersion(version\u003dv)"},{"line_number":388,"context_line":"        return v"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F4iU%3D","line":386,"in_reply_to":"AAAATn%2F%2F4kA%3D","updated":"2013-10-25 18:01:13.000000000","message":"that said, your input is valid; the version class could expose a method like \u0027greater_than\u0027,  \u0027less_than\u0027 to simplify the bool condition.","commit_id":"9eb06332f0292ed4db7b322e483167cb40740d6e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"4d59aa0881e039abea6f8c023abf16f6301ada58","unresolved":false,"context_lines":[{"line_number":383,"context_line":"def create_lrouter(cluster, *args, **kwargs):"},{"line_number":384,"context_line":"    if kwargs.get(\u0027distributed\u0027, None):"},{"line_number":385,"context_line":"        v \u003d cluster.api_client.get_nvp_version()"},{"line_number":386,"context_line":"        if (v.major \u003c 3) or (v.major \u003d\u003d 3 and v.minor \u003c 1):"},{"line_number":387,"context_line":"            raise nvp_exc.NvpInvalidVersion(version\u003dv)"},{"line_number":388,"context_line":"        return v"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F4kA%3D","line":386,"in_reply_to":"AAAATn%2F%2F8SE%3D","updated":"2013-10-25 17:58:16.000000000","message":"doh right.","commit_id":"9eb06332f0292ed4db7b322e483167cb40740d6e"}]}