)]}'
{"neutron/agent/metadata/driver.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8c8a510ec0f83ee2a52f4b1c623331d2263ef90","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.pidfile \u003d pid_file"},{"line_number":88,"context_line":"        self.log_level \u003d ("},{"line_number":89,"context_line":"            \u0027debug\u0027 if logging.is_debug_enabled(cfg.CONF) else \u0027info\u0027)"},{"line_number":90,"context_line":"        # If the tag starts with \"haproxy\" then things should get logged"},{"line_number":91,"context_line":"        # to /var/log/haproxy.log, pre-pended with this tag"},{"line_number":92,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":93,"context_line":"        self.log_tag \u003d \"haproxy\" + \"-\" + METADATA_SERVICE_NAME + \"-\" + uuid"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_e6ee60ec","line":91,"range":{"start_line":90,"start_character":7,"end_line":91,"end_character":35},"updated":"2018-01-19 21:21:42.000000000","message":"it really depends on platform. not sure we can assume it. maybe reword so that it suggests that SOME platforms MAY do it.","commit_id":"48c3ce895a83caacd5d66dc45905cddd6048c627"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"840a6d64da196aead91de63cabb096a7f3c4bebb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # starts with \"haproxy\" then things will get logged to"},{"line_number":93,"context_line":"        # /var/log/haproxy.log on Debian distros, instead of to syslog."},{"line_number":94,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":95,"context_line":"        self.log_tag \u003d \"haproxy\" + \"-\" + METADATA_SERVICE_NAME + \"-\" + uuid"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def create_config_file(self):"},{"line_number":98,"context_line":"        \"\"\"Create the config file for haproxy.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_aa731d4d","line":95,"range":{"start_line":95,"start_character":23,"end_line":95,"end_character":38},"updated":"2018-01-22 12:34:08.000000000","message":"nit: this could be directly \"haproxy-\"","commit_id":"e96a978bd031e31eb51c92f0fb0f107cd2421d71"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"aa8da654e50306419024dfa58376c0a06b661d8c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # starts with \"haproxy\" then things will get logged to"},{"line_number":93,"context_line":"        # /var/log/haproxy.log on Debian distros, instead of to syslog."},{"line_number":94,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":95,"context_line":"        self.log_tag \u003d \"haproxy\" + \"-\" + METADATA_SERVICE_NAME + \"-\" + uuid"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def create_config_file(self):"},{"line_number":98,"context_line":"        \"\"\"Create the config file for haproxy.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_d772d1e3","line":95,"range":{"start_line":95,"start_character":23,"end_line":95,"end_character":38},"in_reply_to":"7f96bb07_aa731d4d","updated":"2018-01-22 14:07:52.000000000","message":"Yeah, it needs a recheck so I might as well re-spin","commit_id":"e96a978bd031e31eb51c92f0fb0f107cd2421d71"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0afb787517de906a5ff9b077347ec87a1138180e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # starts with \"haproxy\" then things will get logged to"},{"line_number":93,"context_line":"        # /var/log/haproxy.log on Debian distros, instead of to syslog."},{"line_number":94,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":95,"context_line":"        self.log_tag \u003d \"haproxy\" + \"-\" + METADATA_SERVICE_NAME + \"-\" + uuid"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def create_config_file(self):"},{"line_number":98,"context_line":"        \"\"\"Create the config file for haproxy.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_cb30dda1","line":95,"range":{"start_line":95,"start_character":23,"end_line":95,"end_character":38},"in_reply_to":"7f96bb07_d772d1e3","updated":"2018-01-22 21:49:09.000000000","message":"Or it could be \u0027-\u0027.join([...])","commit_id":"e96a978bd031e31eb51c92f0fb0f107cd2421d71"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45dcc7d4e971008b29d3ba8fbf96c68ff0ef7d8a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # starts with \"haproxy\" then things will get logged to"},{"line_number":93,"context_line":"        # /var/log/haproxy.log on Debian distros, instead of to syslog."},{"line_number":94,"context_line":"        uuid \u003d network_id or router_id"},{"line_number":95,"context_line":"        self.log_tag \u003d \"haproxy-\" + METADATA_SERVICE_NAME + \"-\" + uuid"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def create_config_file(self):"},{"line_number":98,"context_line":"        \"\"\"Create the config file for haproxy.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_dacbd86f","line":95,"range":{"start_line":95,"start_character":23,"end_line":95,"end_character":33},"updated":"2018-01-22 14:20:30.000000000","message":"nit - could have done this as a constant or even better a config var that would give you better flexibility. but not importnat","commit_id":"703ff85b8262997f209e7666396c5d430d3baa34"}]}
