)]}'
{"neutron/plugins/mlnx/agent/eswitch_neutron_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d28c1dfb1c1ce26902b2f11933cc95cef5bcd645","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                    dev_details[\u0027network_id\u0027],"},{"line_number":344,"context_line":"                                    dev_details[\u0027network_type\u0027],"},{"line_number":345,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":346,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":348,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":349,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FTMw%3D","line":346,"updated":"2013-11-11 12:55:30.000000000","message":"It is better to add a description on this change in the commit message.","commit_id":"20f277555060f38f25290dabdb614e80a7ce6abb"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7ab711c7b53f9465ebabdf6e2725e941c6b8838a","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                                    dev_details[\u0027network_id\u0027],"},{"line_number":344,"context_line":"                                    dev_details[\u0027network_type\u0027],"},{"line_number":345,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":346,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":348,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":349,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FQKI%3D","line":346,"in_reply_to":"AAAATn%2F%2FTMw%3D","updated":"2013-11-12 11:30:27.000000000","message":"Done","commit_id":"20f277555060f38f25290dabdb614e80a7ce6abb"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"924381e39e4298d7cf0363db27b9d4056d14cc87","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                    dev_details[\u0027network_id\u0027],"},{"line_number":345,"context_line":"                                    dev_details[\u0027network_type\u0027],"},{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2FwcQ%3D","line":347,"updated":"2014-01-02 09:25:24.000000000","message":"question: have it ever worked? I don\u0027t see any corresponding change on the plugin side.","commit_id":"981dab4dd2085a0d6044a85be31d41394c4145b0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"368c0c3f171d055a75a1dede9d604620ff391908","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                    dev_details[\u0027network_id\u0027],"},{"line_number":345,"context_line":"                                    dev_details[\u0027network_type\u0027],"},{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2Fwag%3D","line":347,"in_reply_to":"AAAAT3%2F%2FwcQ%3D","updated":"2014-01-02 09:37:07.000000000","message":"Yes it worked with config: rpc_support_old_agents \u003d True on plugin side. Plugin stores it with segmentation_id starting commit: https://github.com/openstack/neutron/commit/58ca4c40b93c8eb3701001ffaa42e19c127d7aad","commit_id":"981dab4dd2085a0d6044a85be31d41394c4145b0"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"fff3741df0795d869eb7e3090ceda2e5c2649a93","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FtoQ%3D","line":349,"updated":"2014-01-09 10:06:28.000000000","message":"I think we should not add this piece of \u0027admin_state_up\u0027 judgement just as other agents did because the devices comes crom \u0027update_ports\u0027 funtion must be \u0027UP\u0027 state, we should use actual physical device as the criterion, rather than database.","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5cf218f8c33a8348daffff95b6ba649cfc499d44","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B4t0%3D","line":349,"in_reply_to":"AAAAUH%2F%2FatQ%3D","updated":"2014-01-21 03:41:22.000000000","message":"got it , thanks for clarifying.","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e79858eb2a336a712865e3cfcf1289aee118ad8b","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FatQ%3D","line":349,"in_reply_to":"AAAAUH%2F%2FiOk%3D","updated":"2014-01-13 23:27:56.000000000","message":"Synced up with Irena on this. There was misunderstanding that the admin_state_up is being used as the status, but that is not seem to be the case.\n\nThanks Irena for clarifying.","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"928d3bf60783f5f9928404eda30f45a7a4cd9c68","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FiOk%3D","line":349,"in_reply_to":"AAAAUH%2F%2FjDc%3D","updated":"2014-01-12 13:53:07.000000000","message":"Sumit, thank you for your response.\nAs for your question,by admin I meant neutron admin. I am using the  \u0027admin_state_up\u0027 for the logical port state. When neutron agent treats VIF port configuration, it brings the device up only is admin_state_up is True. When neutron agent reports back the operational status of the device, it updates device to be \u0027ACTIVE\u0027 only in it was previously configured to be Up, which was only if admin_state_up was True. On the neutron plugin side, the port\u0027s status attribute is updates. \n\nAs a reference I looked at the LinuxBridge agent: https://github.com/openstack/neutron/blob/master/neutron/plugins/linuxbridge/agent/linuxbridge_neutron_agent.py#treat_devices_added implementation.\n\nDo you agree with the above explanation?","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ab0717a1bf22867dd6f97ad37084ae58e2115beb","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FjDc%3D","line":349,"in_reply_to":"AAAAUH%2F%2FkKc%3D","updated":"2014-01-11 19:56:46.000000000","message":"Thanks. When you say - \"admin decides that the port should be disabled\" - I guess you are referring to the physical port, and the network admin (not the OpenStack user), right? If so, effectively you are using admin_state_up for the logical port (neutron representation) as well as the physical port. Shouldn\u0027t the state of the physical port (which you refer to as regards to the traffic forwarding) be treated as the operational state as far as the Neutron port is concerned? If so, are you better off modifying the \"status\" as opposed to the admin_state_up?","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"67063bddbdd23e68e069740fb4c27535a954f1c6","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FkKc%3D","line":349,"in_reply_to":"AAAAUH%2F%2FrPw%3D","updated":"2014-01-11 01:23:52.000000000","message":"If the admin decides that the port should be disabled (admin_state_up \u003d False) \u003d\u003e no traffic should get to the port even though it may actually be up. Therefor the update for device being up refers to the status with regards to the traffic and not to device being active.  If OpenStack/Neutron user overrides this admin_state and sets it to True, agent will deal with port-update RPC notification and eventually update the device status to be Active","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"c2fc90c72488e986107884d4aa71c7d0df7c14b3","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FrPw%3D","line":349,"in_reply_to":"AAAAUH%2F%2FtMU%3D","updated":"2014-01-09 18:32:35.000000000","message":"I believe, the issue being pointed out is that, admin_state_up is typically set by the OpenStack/Neutron user, whereas the operational port status is set by the agent. In this case you seem to be accounting for the case where the admin_state of the backend realization of the port is set outside of OpenStack/Neutron, and you are trying to propagate that information back to Neutron? Is that understanding correct? If so, what if the OpenStack/Neutron user overrides this admin_state and again sets it?","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"857e0dc4affc26ec31e0c96e0c00b32bc21e92d6","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                                    dev_details[\u0027physical_network\u0027],"},{"line_number":347,"context_line":"                                    dev_details[\u0027segmentation_id\u0027],"},{"line_number":348,"context_line":"                                    dev_details[\u0027admin_state_up\u0027])"},{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2FtMU%3D","line":349,"in_reply_to":"AAAAUH%2F%2FtoQ%3D","updated":"2014-01-09 11:32:39.000000000","message":"I am not sure I follow this comment. The reason of admin_state_up state is to enable or disable traffic for this vNIC. Can you elaborate?","commit_id":"889f0048d22eda5679e384f15c03ca6739c131a9"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"3a05681a4f484ca2c0455ce235898f3406b49239","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"},{"line_number":353,"context_line":"            else:"},{"line_number":354,"context_line":"                LOG.debug(_(\"Device with mac_address %s not defined \""},{"line_number":355,"context_line":"                          \"on Neutron Plugin\"), device)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2FdOE%3D","line":352,"updated":"2014-02-13 03:20:39.000000000","message":"So now device up is reported when a device is added and the admin_state_up is True. What happen if a port is updated with admin_state_up is changed to False? Referencing ovs_neutron_agent implementation, we should update device down here with adding a \"else\" branch to the \"if\" branch in line 349. \n\nGoing through the code in more detail, it seems like process_network_ports only treat \"added\" and \"removed\" ports but not the \"updated\" port. So I think more code is needed to support this. For example, changing \"treat_devices_added\" to \"treat_devices_added_updated\" like ovs_neutron_agent or adding a new \"treat_devices_updated\" method.","commit_id":"92515fbca1ca70f1001debadf38ab91a6852c1ef"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"e32d6631728871670247aad0571c199616a98e69","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                if dev_details.get(\u0027admin_state_up\u0027):"},{"line_number":350,"context_line":"                    self.plugin_rpc.update_device_up(self.context,"},{"line_number":351,"context_line":"                                                     device,"},{"line_number":352,"context_line":"                                                     self.agent_id)"},{"line_number":353,"context_line":"            else:"},{"line_number":354,"context_line":"                LOG.debug(_(\"Device with mac_address %s not defined \""},{"line_number":355,"context_line":"                          \"on Neutron Plugin\"), device)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2FcuI%3D","line":352,"in_reply_to":"AAAAUX%2F%2FdOE%3D","updated":"2014-02-13 05:57:55.000000000","message":"Currently, port updates are handled by separate method.\nFollowing changes in OVS and LinuxBridge agents: https://review.openstack.org/#/c/62875/, plan to change the logic accordingly via separate bug fix : bug 1279655","commit_id":"92515fbca1ca70f1001debadf38ab91a6852c1ef"}],"neutron/plugins/mlnx/agent/utils.py":[{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"74f16a208020807f8edcd5fe30a43f8c34326c4c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.plugins.mlnx.common import exceptions"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"zmq \u003d importutils.try_import(\u0027eventlet.green.zmq\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9XEo%3D","line":24,"updated":"2013-12-12 09:07:29.000000000","message":"IMHO, If you use try_import you should raise an exception somewhere in the case of the import fails. Probably an ImportError exception near line #37","commit_id":"f4c2a32619fbf2ea2a14a72ac46bab81c62ffeaf"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"57cbe2cc52f4c27c7657baf9b262a6b3273f2cd8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.plugins.mlnx.common import exceptions"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"zmq \u003d importutils.try_import(\u0027eventlet.green.zmq\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9WsU%3D","line":24,"in_reply_to":"AAAATn%2F9XEo%3D","updated":"2013-12-17 05:48:29.000000000","message":"Done","commit_id":"f4c2a32619fbf2ea2a14a72ac46bab81c62ffeaf"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d7e328d6fb6ad19e854255ac9b58ed9a64563acc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _conn(self):"},{"line_number":37,"context_line":"        if self.__conn is None:"},{"line_number":38,"context_line":"            if not zmq:"},{"line_number":39,"context_line":"                raise ImportError(\"Failed to import eventlet.green.zmq\")"},{"line_number":40,"context_line":"            context \u003d zmq.Context()"},{"line_number":41,"context_line":"            socket \u003d context.socket(zmq.REQ)"},{"line_number":42,"context_line":"            socket.setsockopt(zmq.LINGER, 0)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9CVs%3D","line":39,"updated":"2013-12-17 13:11:43.000000000","message":"please use the i18n format _(\"Failed ...\")","commit_id":"b6bf18d359f6a3da1448036b081eaf3f605af3b2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"628f304958a0987b8f87880fd34daa21b002dd1a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _conn(self):"},{"line_number":37,"context_line":"        if self.__conn is None:"},{"line_number":38,"context_line":"            if not zmq:"},{"line_number":39,"context_line":"                raise ImportError(\"Failed to import eventlet.green.zmq\")"},{"line_number":40,"context_line":"            context \u003d zmq.Context()"},{"line_number":41,"context_line":"            socket \u003d context.socket(zmq.REQ)"},{"line_number":42,"context_line":"            socket.setsockopt(zmq.LINGER, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8rQ4%3D","line":39,"updated":"2013-12-23 11:34:28.000000000","message":"this should be raise ImportError(_(\"Failed to import eventlet.green.zmq\"))","commit_id":"ef2666ac3c073c78690e84cda550d9224b269401"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a7ab5c7111aef8042b10b0433e3062d4218f9b05","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _conn(self):"},{"line_number":37,"context_line":"        if self.__conn is None:"},{"line_number":38,"context_line":"            if not zmq:"},{"line_number":39,"context_line":"                raise ImportError(\"Failed to import eventlet.green.zmq\")"},{"line_number":40,"context_line":"            context \u003d zmq.Context()"},{"line_number":41,"context_line":"            socket \u003d context.socket(zmq.REQ)"},{"line_number":42,"context_line":"            socket.setsockopt(zmq.LINGER, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8rME%3D","line":39,"in_reply_to":"AAAATn%2F8rQ4%3D","updated":"2013-12-23 11:55:05.000000000","message":"Done","commit_id":"ef2666ac3c073c78690e84cda550d9224b269401"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"924381e39e4298d7cf0363db27b9d4056d14cc87","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.plugins.mlnx.common.comm_utils import RetryDecorator"},{"line_number":22,"context_line":"from neutron.plugins.mlnx.common import exceptions"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"zmq \u003d importutils.try_import(\u0027eventlet.green.zmq\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2Fwc0%3D","line":24,"updated":"2014-01-02 09:25:24.000000000","message":"why these changes are needed and how are they related to the patch?","commit_id":"981dab4dd2085a0d6044a85be31d41394c4145b0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"368c0c3f171d055a75a1dede9d604620ff391908","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.plugins.mlnx.common.comm_utils import RetryDecorator"},{"line_number":22,"context_line":"from neutron.plugins.mlnx.common import exceptions"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"zmq \u003d importutils.try_import(\u0027eventlet.green.zmq\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2FwaI%3D","line":24,"in_reply_to":"AAAAT3%2F%2Fwc0%3D","updated":"2014-01-02 09:37:07.000000000","message":"It was required to enable agent unit tests. Please see the comment by Salvatore on patch 4.","commit_id":"981dab4dd2085a0d6044a85be31d41394c4145b0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5a341c05298b2c138ed925b1bab5ec9eb0cd8b38","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _conn(self):"},{"line_number":37,"context_line":"        if self.__conn is None:"},{"line_number":38,"context_line":"            if not zmq:"},{"line_number":39,"context_line":"                raise ImportError(_(\"Failed to import eventlet.green.zmq\"))"},{"line_number":40,"context_line":"            context \u003d zmq.Context()"},{"line_number":41,"context_line":"            socket \u003d context.socket(zmq.REQ)"},{"line_number":42,"context_line":"            socket.setsockopt(zmq.LINGER, 0)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2F3PE%3D","line":39,"updated":"2014-02-10 10:23:02.000000000","message":"Can\u0027t we check it in __init__? If it is checked in _conn, I think the same error will be raised multiple times.","commit_id":"92515fbca1ca70f1001debadf38ab91a6852c1ef"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"f96c4deacfc3dcb8d71c824ac9d5419d1abf5624","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _conn(self):"},{"line_number":37,"context_line":"        if self.__conn is None:"},{"line_number":38,"context_line":"            if not zmq:"},{"line_number":39,"context_line":"                raise ImportError(_(\"Failed to import eventlet.green.zmq\"))"},{"line_number":40,"context_line":"            context \u003d zmq.Context()"},{"line_number":41,"context_line":"            socket \u003d context.socket(zmq.REQ)"},{"line_number":42,"context_line":"            socket.setsockopt(zmq.LINGER, 0)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2Fdsw%3D","line":39,"in_reply_to":"AAAAUX%2F%2F3Kk%3D","updated":"2014-02-13 01:11:04.000000000","message":"The value of zmq is not changed after it is set in line 24, so we should check it in the __init__().  If it is not available by the __init__, we should raise SystemExit because we\u0027ll never be able to connect.","commit_id":"92515fbca1ca70f1001debadf38ab91a6852c1ef"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"2c39bafb513180fdca5e91e82f217b377953ceb2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _conn(self):"},{"line_number":37,"context_line":"        if self.__conn is None:"},{"line_number":38,"context_line":"            if not zmq:"},{"line_number":39,"context_line":"                raise ImportError(_(\"Failed to import eventlet.green.zmq\"))"},{"line_number":40,"context_line":"            context \u003d zmq.Context()"},{"line_number":41,"context_line":"            socket \u003d context.socket(zmq.REQ)"},{"line_number":42,"context_line":"            socket.setsockopt(zmq.LINGER, 0)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2F3Kk%3D","line":39,"in_reply_to":"AAAAUX%2F%2F3PE%3D","updated":"2014-02-10 10:35:38.000000000","message":"Just moving the check to __init__ is not enough, still need to check that zmq is available for connect.\nIf you do not have strong objection, I prefer to leave it this way, and consider  to raise SystemExit  for missing import as following fix.","commit_id":"92515fbca1ca70f1001debadf38ab91a6852c1ef"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"e32d6631728871670247aad0571c199616a98e69","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def _conn(self):"},{"line_number":37,"context_line":"        if self.__conn is None:"},{"line_number":38,"context_line":"            if not zmq:"},{"line_number":39,"context_line":"                raise ImportError(_(\"Failed to import eventlet.green.zmq\"))"},{"line_number":40,"context_line":"            context \u003d zmq.Context()"},{"line_number":41,"context_line":"            socket \u003d context.socket(zmq.REQ)"},{"line_number":42,"context_line":"            socket.setsockopt(zmq.LINGER, 0)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2Fcu0%3D","line":39,"in_reply_to":"AAAAUX%2F%2Fdsw%3D","updated":"2014-02-13 05:57:55.000000000","message":"Already dealing with it, need to verity and will post the fix soon.","commit_id":"92515fbca1ca70f1001debadf38ab91a6852c1ef"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"4f30fa84fb21d2f5d1d1ba32617f994555dd2d96","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class EswitchUtils(object):"},{"line_number":30,"context_line":"    def __init__(self, daemon_endpoint, timeout):"},{"line_number":31,"context_line":"        if not zmq:"},{"line_number":32,"context_line":"            LOG.exception(_(\"Failed to import eventlet.green.zmq. \""},{"line_number":33,"context_line":"                            \"Won\u0027t connect to eSwitchD - exiting...\"))"},{"line_number":34,"context_line":"            raise SystemExit(1)"},{"line_number":35,"context_line":"        self.__conn \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FJF0%3D","line":32,"updated":"2014-02-16 07:46:23.000000000","message":"Maybe LOG.error is better here since no exception is actually caught.","commit_id":"1b1364838ff30c0db219e8ceb35aaca0e37d37ae"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"be5ad68b09fc9911edcc7d8c35a33c267bd59386","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class EswitchUtils(object):"},{"line_number":30,"context_line":"    def __init__(self, daemon_endpoint, timeout):"},{"line_number":31,"context_line":"        if not zmq:"},{"line_number":32,"context_line":"            LOG.exception(_(\"Failed to import eventlet.green.zmq. \""},{"line_number":33,"context_line":"                            \"Won\u0027t connect to eSwitchD - exiting...\"))"},{"line_number":34,"context_line":"            raise SystemExit(1)"},{"line_number":35,"context_line":"        self.__conn \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FJEg%3D","line":32,"in_reply_to":"AAAAUX%2F%2FJF0%3D","updated":"2014-02-16 08:07:09.000000000","message":"Done","commit_id":"1b1364838ff30c0db219e8ceb35aaca0e37d37ae"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"4f30fa84fb21d2f5d1d1ba32617f994555dd2d96","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not zmq:"},{"line_number":32,"context_line":"            LOG.exception(_(\"Failed to import eventlet.green.zmq. \""},{"line_number":33,"context_line":"                            \"Won\u0027t connect to eSwitchD - exiting...\"))"},{"line_number":34,"context_line":"            raise SystemExit(1)"},{"line_number":35,"context_line":"        self.__conn \u003d None"},{"line_number":36,"context_line":"        self.daemon \u003d daemon_endpoint"},{"line_number":37,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FJF4%3D","line":34,"updated":"2014-02-16 07:46:23.000000000","message":"Better to use error message in SystemExit instead of just \"1\".","commit_id":"1b1364838ff30c0db219e8ceb35aaca0e37d37ae"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"be5ad68b09fc9911edcc7d8c35a33c267bd59386","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        if not zmq:"},{"line_number":32,"context_line":"            LOG.exception(_(\"Failed to import eventlet.green.zmq. \""},{"line_number":33,"context_line":"                            \"Won\u0027t connect to eSwitchD - exiting...\"))"},{"line_number":34,"context_line":"            raise SystemExit(1)"},{"line_number":35,"context_line":"        self.__conn \u003d None"},{"line_number":36,"context_line":"        self.daemon \u003d daemon_endpoint"},{"line_number":37,"context_line":"        self.timeout \u003d timeout"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAUX%2F%2FJEU%3D","line":34,"in_reply_to":"AAAAUX%2F%2FJF4%3D","updated":"2014-02-16 08:07:09.000000000","message":"Done","commit_id":"1b1364838ff30c0db219e8ceb35aaca0e37d37ae"}],"neutron/tests/unit/mlnx/test_mlnx_neutron_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d28c1dfb1c1ce26902b2f11933cc95cef5bcd645","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":16,"context_line":"# limitations under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import contextlib"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FTPk%3D","line":18,"updated":"2013-11-11 12:55:30.000000000","message":"Need a blank line here","commit_id":"20f277555060f38f25290dabdb614e80a7ce6abb"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7ab711c7b53f9465ebabdf6e2725e941c6b8838a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":16,"context_line":"# limitations under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import contextlib"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FQMM%3D","line":18,"in_reply_to":"AAAATn%2F%2FTPk%3D","updated":"2013-11-12 11:30:27.000000000","message":"Done","commit_id":"20f277555060f38f25290dabdb614e80a7ce6abb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d28c1dfb1c1ce26902b2f11933cc95cef5bcd645","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class TestEswitchAgent(base.BaseTestCase):"},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestEswitchAgent, self).setUp()"},{"line_number":29,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":30,"context_line":"        # Avoid rpc initialization for unit tests"},{"line_number":31,"context_line":"        cfg.CONF.set_override(\u0027rpc_backend\u0027,"},{"line_number":32,"context_line":"                              \u0027neutron.openstack.common.rpc.impl_fake\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FTOY%3D","line":29,"updated":"2013-11-11 12:55:30.000000000","message":"Nit: It is actually unnecessary.","commit_id":"20f277555060f38f25290dabdb614e80a7ce6abb"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"7ab711c7b53f9465ebabdf6e2725e941c6b8838a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class TestEswitchAgent(base.BaseTestCase):"},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(TestEswitchAgent, self).setUp()"},{"line_number":29,"context_line":"        self.addCleanup(cfg.CONF.reset)"},{"line_number":30,"context_line":"        # Avoid rpc initialization for unit tests"},{"line_number":31,"context_line":"        cfg.CONF.set_override(\u0027rpc_backend\u0027,"},{"line_number":32,"context_line":"                              \u0027neutron.openstack.common.rpc.impl_fake\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FQMI%3D","line":29,"in_reply_to":"AAAATn%2F%2FTOY%3D","updated":"2013-11-12 11:30:27.000000000","message":"Done","commit_id":"20f277555060f38f25290dabdb614e80a7ce6abb"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"f1d4e19ac1c50a73cb7a9a750854ff6da3fbba2d","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        mock.patch(\u0027neutron.openstack.common.loopingcall.\u0027"},{"line_number":42,"context_line":"                   \u0027FixedIntervalLoopingCall\u0027,"},{"line_number":43,"context_line":"                   new\u003dMockFixedIntervalLoopingCall)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.agent \u003d eswitch_neutron_agent.MlnxEswitchNeutronAgent({})"},{"line_number":46,"context_line":"        self.agent.plugin_rpc \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BPN8%3D","line":43,"updated":"2013-11-28 13:33:37.000000000","message":"I think you need to start the mock and add a cleanup action to stop it","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b995cc1875c00859ad543dcde5ef24827eb3f401","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        mock.patch(\u0027neutron.openstack.common.loopingcall.\u0027"},{"line_number":42,"context_line":"                   \u0027FixedIntervalLoopingCall\u0027,"},{"line_number":43,"context_line":"                   new\u003dMockFixedIntervalLoopingCall)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.agent \u003d eswitch_neutron_agent.MlnxEswitchNeutronAgent({})"},{"line_number":46,"context_line":"        self.agent.plugin_rpc \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BITo%3D","line":43,"in_reply_to":"AAAATn%2F%2BPN8%3D","updated":"2013-12-03 14:19:50.000000000","message":"Done","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"f1d4e19ac1c50a73cb7a9a750854ff6da3fbba2d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.assertEqual(port_release.called, not port_exists)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_treat_devices_removed_releases_port(self):"},{"line_number":108,"context_line":"        self._mock_treat_devices_removed(False)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_process_network_ports(self):"},{"line_number":111,"context_line":"        reply \u003d {\u0027current\u0027: set([\u002701:02:03:04:05:06\u0027]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BPOg%3D","line":108,"updated":"2013-11-28 13:33:37.000000000","message":"is another test with self._mock_treat_devices_remove(True) needed? or is it the method at line 93?\n\nIn the case maybe merge the method starting at line 98 with this.","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b995cc1875c00859ad543dcde5ef24827eb3f401","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.assertEqual(port_release.called, not port_exists)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_treat_devices_removed_releases_port(self):"},{"line_number":108,"context_line":"        self._mock_treat_devices_removed(False)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_process_network_ports(self):"},{"line_number":111,"context_line":"        reply \u003d {\u0027current\u0027: set([\u002701:02:03:04:05:06\u0027]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHXA%3D","line":108,"in_reply_to":"AAAATn%2F%2BPOg%3D","updated":"2013-12-03 14:19:50.000000000","message":"Done","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"f1d4e19ac1c50a73cb7a9a750854ff6da3fbba2d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                   return_value\u003dFalse) as device_removed:"},{"line_number":118,"context_line":"                self.assertFalse(self.agent.process_network_ports(reply))"},{"line_number":119,"context_line":"                self.assertTrue(device_added.called)"},{"line_number":120,"context_line":"                self.assertTrue(device_removed.called)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BPO4%3D","line":120,"updated":"2013-11-28 13:33:37.000000000","message":"I would suggest extending the assertion to the argument using\n\ndevice_{added|removed}.assert_called_once_with(arglist)","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b995cc1875c00859ad543dcde5ef24827eb3f401","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                   return_value\u003dFalse) as device_removed:"},{"line_number":118,"context_line":"                self.assertFalse(self.agent.process_network_ports(reply))"},{"line_number":119,"context_line":"                self.assertTrue(device_added.called)"},{"line_number":120,"context_line":"                self.assertTrue(device_removed.called)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BHaE%3D","line":120,"in_reply_to":"AAAATn%2F%2BPO4%3D","updated":"2013-12-03 14:19:50.000000000","message":"Done","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"924381e39e4298d7cf0363db27b9d4056d14cc87","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"            def start(self, interval\u003d0):"},{"line_number":42,"context_line":"                self.f()"},{"line_number":43,"context_line":"        with contextlib.nested("},{"line_number":44,"context_line":"            mock.patch(\u0027neutron.openstack.common.loopingcall.\u0027"},{"line_number":45,"context_line":"                       \u0027FixedIntervalLoopingCall\u0027,"},{"line_number":46,"context_line":"                       new\u003dMockFixedIntervalLoopingCall)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2FwdI%3D","line":43,"updated":"2014-01-02 09:25:24.000000000","message":"please insert empty line before L43.\n\nAlso, it looks like you don\u0027t need contextlib.nested here since you only patch one object.\n with mock.patch(...):","commit_id":"981dab4dd2085a0d6044a85be31d41394c4145b0"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"368c0c3f171d055a75a1dede9d604620ff391908","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"            def start(self, interval\u003d0):"},{"line_number":42,"context_line":"                self.f()"},{"line_number":43,"context_line":"        with contextlib.nested("},{"line_number":44,"context_line":"            mock.patch(\u0027neutron.openstack.common.loopingcall.\u0027"},{"line_number":45,"context_line":"                       \u0027FixedIntervalLoopingCall\u0027,"},{"line_number":46,"context_line":"                       new\u003dMockFixedIntervalLoopingCall)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2FwZ8%3D","line":43,"in_reply_to":"AAAAT3%2F%2FwdI%3D","updated":"2014-01-02 09:37:07.000000000","message":"Will try to remove it","commit_id":"981dab4dd2085a0d6044a85be31d41394c4145b0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"91bbcebb4becfbf46dd856bda6d73d44844aec4f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Mellanox Technologies, Ltd"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2FwNw%3D","line":3,"updated":"2014-01-08 21:43:14.000000000","message":"nit: 2104?","commit_id":"00adb1994498f691f3eed76125d30847951a9783"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"31c9690b5e6a241d7e71d49b4b40b2468f9c0b97","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Mellanox Technologies, Ltd"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2FuiA%3D","line":3,"in_reply_to":"AAAAUH%2F%2FwNw%3D","updated":"2014-01-09 06:00:04.000000000","message":"You probably mean 2014?\nDone","commit_id":"00adb1994498f691f3eed76125d30847951a9783"}],"test-requirements.txt":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"f1d4e19ac1c50a73cb7a9a750854ff6da3fbba2d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"testrepository\u003e\u003d0.0.17"},{"line_number":12,"context_line":"testtools\u003e\u003d0.9.32"},{"line_number":13,"context_line":"WebTest\u003e\u003d2.0"},{"line_number":14,"context_line":"pyzmq\u003d\u003d2.2.0.1"},{"line_number":15,"context_line":"# Packages for the Cisco Plugin"},{"line_number":16,"context_line":"###############################"},{"line_number":17,"context_line":"configobj"}],"source_content_type":"text/plain","patch_set":4,"id":"AAAATn%2F%2BPNo%3D","line":14,"updated":"2013-11-28 13:33:37.000000000","message":"why?","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b995cc1875c00859ad543dcde5ef24827eb3f401","unresolved":false,"context_lines":[{"line_number":11,"context_line":"testrepository\u003e\u003d0.0.17"},{"line_number":12,"context_line":"testtools\u003e\u003d0.9.32"},{"line_number":13,"context_line":"WebTest\u003e\u003d2.0"},{"line_number":14,"context_line":"pyzmq\u003d\u003d2.2.0.1"},{"line_number":15,"context_line":"# Packages for the Cisco Plugin"},{"line_number":16,"context_line":"###############################"},{"line_number":17,"context_line":"configobj"}],"source_content_type":"text/plain","patch_set":4,"id":"AAAATn%2F%2BHU8%3D","line":14,"in_reply_to":"AAAATn%2F%2BPNo%3D","updated":"2013-12-03 14:19:50.000000000","message":"removed it, since following Mark\u0027s suggestion to use importutils.try_import(\u0027eventlet.green.zmq\u0027) solved the tox error I had running the tests","commit_id":"1c45609cd727842add4251abd182f1a6bf40d87f"}]}
