)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d0b32205871491e37680d97a22feab7980877862","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Port OVO filtering based on security groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Filtring of port OVO based on ids of security groups which"},{"line_number":10,"context_line":"are used by ports is now available."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1744447"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_7a9de464","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"updated":"2018-01-22 14:24:28.000000000","message":"Filtering","commit_id":"7ab5a581d8d2d06f1272d9e7a6edb9627b17f35a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"431896c90e6b4169c360fc550555ebf0e3fa5e13","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Port OVO filtering based on security groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Filtring of port OVO based on ids of security groups which"},{"line_number":10,"context_line":"are used by ports is now available."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1744447"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_8d69988c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":8},"in_reply_to":"7f96bb07_7a9de464","updated":"2018-01-22 14:46:55.000000000","message":"Done","commit_id":"7ab5a581d8d2d06f1272d9e7a6edb9627b17f35a"}],"neutron/objects/ports.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"95a7f830915dd447d52b550e4a42c661a128d26e","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    @classmethod"},{"line_number":388,"context_line":"    def get_objects(cls, context, _pager\u003dNone, validate_filters\u003dTrue,"},{"line_number":389,"context_line":"                    **kwargs):"},{"line_number":390,"context_line":"        security_group_ids \u003d kwargs.pop(\"security_group_ids\", None)"},{"line_number":391,"context_line":"        if security_group_ids:"},{"line_number":392,"context_line":"            ports_with_sg \u003d cls.get_ports_by_security_group("},{"line_number":393,"context_line":"                context, security_group_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_4a305908","line":390,"range":{"start_line":390,"start_character":29,"end_line":390,"end_character":67},"updated":"2018-01-22 12:57:08.000000000","message":"Consider making security_group_ids part of method declaration.\n\n def get_objects(..., security_group_ids\u003dNone)","commit_id":"1e701d8d21e8e13c754b6d5fb781030e702dd778"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"efd28860243c04d9063ea3d177a52edc2709d16b","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    @classmethod"},{"line_number":388,"context_line":"    def get_objects(cls, context, _pager\u003dNone, validate_filters\u003dTrue,"},{"line_number":389,"context_line":"                    **kwargs):"},{"line_number":390,"context_line":"        security_group_ids \u003d kwargs.pop(\"security_group_ids\", None)"},{"line_number":391,"context_line":"        if security_group_ids:"},{"line_number":392,"context_line":"            ports_with_sg \u003d cls.get_ports_by_security_group("},{"line_number":393,"context_line":"                context, security_group_ids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_17bcb967","line":390,"range":{"start_line":390,"start_character":29,"end_line":390,"end_character":67},"in_reply_to":"7f96bb07_4a305908","updated":"2018-01-22 14:07:05.000000000","message":"Done","commit_id":"1e701d8d21e8e13c754b6d5fb781030e702dd778"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"95a7f830915dd447d52b550e4a42c661a128d26e","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    **kwargs):"},{"line_number":390,"context_line":"        security_group_ids \u003d kwargs.pop(\"security_group_ids\", None)"},{"line_number":391,"context_line":"        if security_group_ids:"},{"line_number":392,"context_line":"            ports_with_sg \u003d cls.get_ports_by_security_group("},{"line_number":393,"context_line":"                context, security_group_ids)"},{"line_number":394,"context_line":"            port_ids \u003d kwargs.get(\"id\", [])"},{"line_number":395,"context_line":"            if port_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_2a3f0dd7","line":392,"range":{"start_line":392,"start_character":32,"end_line":392,"end_character":59},"updated":"2018-01-22 12:57:08.000000000","message":"Suggestion: get_ports_by_security_groups","commit_id":"1e701d8d21e8e13c754b6d5fb781030e702dd778"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"efd28860243c04d9063ea3d177a52edc2709d16b","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                    **kwargs):"},{"line_number":390,"context_line":"        security_group_ids \u003d kwargs.pop(\"security_group_ids\", None)"},{"line_number":391,"context_line":"        if security_group_ids:"},{"line_number":392,"context_line":"            ports_with_sg \u003d cls.get_ports_by_security_group("},{"line_number":393,"context_line":"                context, security_group_ids)"},{"line_number":394,"context_line":"            port_ids \u003d kwargs.get(\"id\", [])"},{"line_number":395,"context_line":"            if port_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_b7b0658d","line":392,"range":{"start_line":392,"start_character":32,"end_line":392,"end_character":59},"in_reply_to":"7f96bb07_2a3f0dd7","updated":"2018-01-22 14:07:05.000000000","message":"Done","commit_id":"1e701d8d21e8e13c754b6d5fb781030e702dd778"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d0b32205871491e37680d97a22feab7980877862","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        return [cls._load_object(context, db_obj) for db_obj in ports.all()]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @classmethod"},{"line_number":463,"context_line":"    def get_ports_by_security_groups(cls, context, security_group_ids):"},{"line_number":464,"context_line":"        query \u003d context.session.query(sg_models.SecurityGroupPortBinding)"},{"line_number":465,"context_line":"        query \u003d query.filter("},{"line_number":466,"context_line":"            sg_models.SecurityGroupPortBinding.security_group_id.in_("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_dac75845","line":463,"range":{"start_line":463,"start_character":8,"end_line":463,"end_character":36},"updated":"2018-01-22 14:24:28.000000000","message":"i think that you need to specify that this returns port ids and not ports. It was confusing for a while","commit_id":"7ab5a581d8d2d06f1272d9e7a6edb9627b17f35a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"431896c90e6b4169c360fc550555ebf0e3fa5e13","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        return [cls._load_object(context, db_obj) for db_obj in ports.all()]"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    @classmethod"},{"line_number":463,"context_line":"    def get_ports_by_security_groups(cls, context, security_group_ids):"},{"line_number":464,"context_line":"        query \u003d context.session.query(sg_models.SecurityGroupPortBinding)"},{"line_number":465,"context_line":"        query \u003d query.filter("},{"line_number":466,"context_line":"            sg_models.SecurityGroupPortBinding.security_group_id.in_("}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_cdc1e082","line":463,"range":{"start_line":463,"start_character":8,"end_line":463,"end_character":36},"in_reply_to":"7f96bb07_dac75845","updated":"2018-01-22 14:46:55.000000000","message":"Done","commit_id":"7ab5a581d8d2d06f1272d9e7a6edb9627b17f35a"}]}